Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146810442
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146804206
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends
Github user DonnyZone commented on the issue:
https://github.com/apache/spark/pull/19559
@gatorsmile Thank for your advice, I will work on it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user rberenguel commented on the issue:
https://github.com/apache/spark/pull/17100
Thanks @gatorsmile @holdenk @viirya @wzhfy for all the help
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19553
Ping @Whoosh
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19565#discussion_r146799989
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -497,40 +495,38 @@ final class OnlineLDAOptimizer extends
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146796399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19557
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19557
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83038/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19557
**[Test build #83038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83038/testReport)**
for PR 19557 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19550
@felixcheung, are we okay to merge this alone in branch-2.0?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146783934
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2127,4 +2127,18 @@ class SQLQuerySuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146783308
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -252,6 +253,13 @@ private[orc] class OrcOutputWriter(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146784952
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -58,10 +58,7 @@ class OrcFileFormat extends FileFormat with
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19571#discussion_r146783595
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -73,6 +70,10 @@ class OrcFileFormat extends FileFormat with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19573
**[Test build #83039 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83039/testReport)**
for PR 19573 at commit
GitHub user jinxing64 opened a pull request:
https://github.com/apache/spark/pull/19573
[SPARK-22350][SQL] select grouping__id from subquery
## What changes were proposed in this pull request?
Currently, sql below will fail:
```
SELECT cnt, k2, k3, grouping__id
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19557
**[Test build #83038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83038/testReport)**
for PR 19557 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19480
@kiszk Thanks!
@mgaido91 I have not reviewed it carefully. Will do another pass in the
next few days. Thanks for your fix!
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146775448
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -801,10 +834,46 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146775221
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -801,10 +834,46 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146774741
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -801,10 +834,46 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146773769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -277,13 +292,25 @@ class
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19557
well, this change avoided the warning but disabled help too (which is
probably why it's working)
```
> showMethods("attach")
Function: attach (package base)
what="ANY"
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19480#discussion_r146773177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -78,6 +79,20 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19559
@DonnyZone Analyzer is the best place to fix the issue.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19557#discussion_r146772862
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3249,9 +3249,12 @@ setMethod("as.data.frame",
#' @note attach since 1.6.0
setMethod("attach",
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19572
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19556
**[Test build #83037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83037/testReport)**
for PR 19556 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146771631
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19572
**[Test build #83036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83036/testReport)**
for PR 19572 at commit
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19572
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19572
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19458
**[Test build #83034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83034/testReport)**
for PR 19458 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19458
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83034/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19572
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83035/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19572
**[Test build #83035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83035/testReport)**
for PR 19572 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146769438
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user wuciawe commented on the issue:
https://github.com/apache/spark/pull/17190
@GaalDornick hi, I think
```
def quote(colName: String): String = {
s$colName
}
```
should be
```
def quote(colName: String): String = {
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/19572
cc @sameeragarwal @ericl
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19572
**[Test build #83035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83035/testReport)**
for PR 19572 at commit
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/19572
[SPARK-22349]In on-heap mode, when allocating memory from pool,we should
fill memory with `MEMORY_DEBUG_FILL_CLEAN_VALUE`
## What changes were proposed in this pull request?
In on-heap mode,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19571
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83030/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19571
**[Test build #83030 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83030/testReport)**
for PR 19571 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19569
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19569
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83032/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19569
**[Test build #83032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83032/testReport)**
for PR 19569 at commit
Github user nivox commented on the issue:
https://github.com/apache/spark/pull/19217
@vanzin @ash211 I just modified the title of the PR as per your suggestion
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19569
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19569
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83031/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19569
**[Test build #83031 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83031/testReport)**
for PR 19569 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19458
There's a UT failure
(https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83014/testReport/junit/org.apache.spark.storage/BlockIdSuite/test_bad_deserialization/).
@superbobry
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19458
**[Test build #83034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83034/testReport)**
for PR 19458 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r146763856
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelationSuite.scala
---
@@ -30,6 +30,7 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19556#discussion_r146763677
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -91,6 +91,50 @@ private[spark] object ClosureCleaner extends Logging {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19458
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r146763654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala
---
@@ -0,0 +1,111 @@
+/*
+ *
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r146763571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala
---
@@ -0,0 +1,111 @@
+/*
+ *
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17100
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r146761735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -922,6 +922,17 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19451#discussion_r146761684
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1200,6 +1211,8 @@ class SQLConf extends Serializable with
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18527
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17100
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18527
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18527
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
401 - 467 of 467 matches
Mail list logo
