[GitHub] spark issue #18029: [SPARK-20168] [DStream] Add changes to use kinesis fetch...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18029 **[Test build #83144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83144/testReport)** for PR 18029 at commit [`2c2a56a`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #18029: [SPARK-20168] [DStream] Add changes to use kinesis fetch...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18029 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83144/ Test PASSed. ---

[GitHub] spark pull request #19588: [SPARK-12375][ML] VectorIndexerModel support hand...

2017-10-27 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/19588#discussion_r147542224 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala --- @@ -311,22 +342,39 @@ class VectorIndexerModel private[ml] (

[GitHub] spark pull request #19567: [SPARK-22291][SQL] Postgresql UUID[] to Cassandra...

2017-10-27 Thread jmchung
Github user jmchung commented on a diff in the pull request: https://github.com/apache/spark/pull/19567#discussion_r147542014 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala --- @@ -134,11 +149,28 @@ class Postgre

[GitHub] spark issue #19567: [SPARK-22291][SQL] Postgresql UUID[] to Cassandra: Conve...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19567 **[Test build #83145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83145/testReport)** for PR 19567 at commit [`edc5f6f`](https://github.com/apache/spark/commit/ed

[GitHub] spark issue #17581: [SPARK-20248][ SQL]Spark SQL add limit parameter to enha...

2017-10-27 Thread shaolinliu
Github user shaolinliu commented on the issue: https://github.com/apache/spark/pull/17581 ok. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apa

[GitHub] spark issue #18029: [SPARK-20168] [DStream] Add changes to use kinesis fetch...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18029 **[Test build #83144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83144/testReport)** for PR 18029 at commit [`2c2a56a`](https://github.com/apache/spark/commit/2c

[GitHub] spark issue #19122: [SPARK-21911][ML][PySpark] Parallel Model Evaluation for...

2017-10-27 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19122 @jkbradley Sure I will! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19451: [SPARK-22181][SQL]Adds ReplaceExceptWithFilter rule

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19451 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19451: [SPARK-22181][SQL]Adds ReplaceExceptWithFilter rule

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19451 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83135/ Test PASSed. ---

[GitHub] spark issue #19451: [SPARK-22181][SQL]Adds ReplaceExceptWithFilter rule

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19451 **[Test build #83135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83135/testReport)** for PR 19451 at commit [`40d8797`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #18687: [SPARK-21484][SQL] Fix inconsistent query plans of Datas...

2017-10-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18687 @gatorsmile Any suggestion for this issue? Leave it as it for now? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.

[GitHub] spark issue #19593: [WIP][SPARK-22374][SQL][2.2] closeAllForUGI is required ...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19593 **[Test build #83142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83142/testReport)** for PR 19593 at commit [`ea3943e`](https://github.com/apache/spark/commit/ea

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147540587 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as sta

[GitHub] spark issue #19570: [SPARK-22335][SQL] Clarify union behavior on Dataset of ...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19570 **[Test build #83143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83143/testReport)** for PR 19570 at commit [`977c78e`](https://github.com/apache/spark/commit/97

[GitHub] spark pull request #19593: [WIP][SPARK-22374][SQL][2.2] closeAllForUGI is re...

2017-10-27 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/19593 [WIP][SPARK-22374][SQL][2.2] closeAllForUGI is required after using loginUserFromKeytab ## What changes were proposed in this pull request? In a secure cluster, FileSystem.Cache grow

[GitHub] spark issue #13206: [SPARK-15420] [SQL] Add repartition and sort to prepare ...

2017-10-27 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/13206 We still maintain a version of this for our Spark builds to avoid an extra sort in Hive. If someone is willing to review it, I can probably find the time to rebase it on master. I think the year this

[GitHub] spark pull request #19570: [SPARK-22335][SQL] Clarify union behavior on Data...

2017-10-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19570#discussion_r147540274 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -1753,6 +1753,27 @@ class Dataset[T] private[sql]( * * Also as sta

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19592 **[Test build #83141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83141/testReport)** for PR 19592 at commit [`9744e77`](https://github.com/apache/spark/commit/97

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19592 cc @HyukjinKwon @ueshin @BryanCutler @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API

2017-10-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19442 Before the discussion of attribute API is finalized, I think the review won't be started. Close this for now and maybe re-open in the future. --- ---

[GitHub] spark pull request #19442: [SPARK-8515][ML][WIP] Improve ML Attribute API

2017-10-27 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/19442 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18687: [SPARK-21484][SQL] Fix inconsistent query plans o...

2017-10-27 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/18687 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18687: [SPARK-21484][SQL] Fix inconsistent query plans of Datas...

2017-10-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18687 Sure. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apach

[GitHub] spark issue #17973: [SPARK-20731][SQL] Add ability to change or omit .csv fi...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17973 @mikkokupsu We do not plan to support this after an offline discussion with the other Committers. Thanks for your contribution. Could you close this PR please? ---

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19592 **[Test build #83140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83140/testReport)** for PR 19592 at commit [`1c523d1`](https://github.com/apache/spark/commit/1c

[GitHub] spark pull request #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be ...

2017-10-27 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/18841 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #13206: [SPARK-15420] [SQL] Add repartition and sort to prepare ...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13206 @rdblue What is the latest status of this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #15049: [SPARK-17310][SQL] Add an option to disable record-level...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15049 cc @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #17581: [SPARK-20248][ SQL]Spark SQL add limit parameter to enha...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17581 @shaolinliu The new behavior introduced in this PR is not clean in the long term. We might not want to introduce such a change. You can keep it in your internal fork. Could you close this PR? -

[GitHub] spark issue #18687: [SPARK-21484][SQL] Fix inconsistent query plans of Datas...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18687 @viirya Could you close this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19592 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19592 **[Test build #83139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83139/testReport)** for PR 19592 at commit [`0515435`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19592 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83139/ Test FAILed. ---

[GitHub] spark issue #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be null

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18841 Different DB systems have different behaviors. We might not accept this behavior change now, until we support the profiles. Could you close this PR? ---

[GitHub] spark issue #19592: [SPARK-22347][SQL][PySpark] Support optionally running P...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19592 **[Test build #83139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83139/testReport)** for PR 19592 at commit [`0515435`](https://github.com/apache/spark/commit/05

[GitHub] spark issue #18828: [SPARK-21619][SQL] Fail the execution of canonicalized p...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18828 ping @rxin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark pull request #19592: [SPARK-22347][SQL][PySpark] Support optionally ru...

2017-10-27 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/19592 [SPARK-22347][SQL][PySpark] Support optionally running PythonUDFs in conditional expressions ## What changes were proposed in this pull request? Under the current execution mode of Python U

[GitHub] spark issue #17174: [SPARK-19145][SQL] Timestamp to String casting is slowin...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17174 ping @tanejagagan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #18106: [SPARK-20754][SQL] Support TRUNC (number)

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18106 This is close to merge. Could you resolve the conflicts? Then, I will review it. Thanks! --- - To unsubscribe, e-mail: review

[GitHub] spark pull request #19426: [SPARK-22190][CORE] Add Spark executor task metri...

2017-10-27 Thread umehrot2
Github user umehrot2 commented on a diff in the pull request: https://github.com/apache/spark/pull/19426#discussion_r147537143 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -406,6 +406,41 @@ private[spark] class Executor( task.metrics.set

[GitHub] spark issue #18812: [SPARK-21606][SQL]HiveThriftServer2 catches OOMs on requ...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18812 cc @liufengdb Is this PR in the right track? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18766: [SPARK-8288][SQL] ScalaReflection can use companion obje...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18766 cc @liancheng Should we still support this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17819: [SPARK-20542][ML][SQL] Add an API to Bucketizer that can...

2017-10-27 Thread huaxingao
Github user huaxingao commented on the issue: https://github.com/apache/spark/pull/17819 @AFractalThought @viirya I have made changes for QuantileDiscretizer based on this PR. Once this PR is merged, I will open a jira to submit the PR for QuantileDiscretizer. ---

[GitHub] spark issue #18377: [SPARK-18016][SQL][CATALYST][BRANCH-2.2] Code Generation...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18377 @bdrillard Sorry, we do not plan to backport this PR to the maintenance branch 2.2. Could you please close this PR? Thanks! --- -

[GitHub] spark issue #17953: [SPARK-20680][SQL] Spark-sql do not support for void col...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17953 @LantaoJin Maybe close it now? You can reopen it when the comment is resolved? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #19559: [SPARK-22333][SQL]timeFunctionCall(CURRENT_DATE, CURRENT...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19559 **[Test build #83138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83138/testReport)** for PR 19559 at commit [`a57fb81`](https://github.com/apache/spark/commit/a5

[GitHub] spark issue #13706: [SPARK-15988] [SQL] Implement DDL commands: Create/Drop ...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13706 @lianhuiwang Could you restart the work? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additi

[GitHub] spark issue #18581: [SPARK-21289][SQL][ML] Supports custom line separator fo...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18581 @HyukjinKwon Could you address the conflicts? Then, I will review it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.

[GitHub] spark issue #18642: [MINOR][REFACTORING] KeyValueGroupedDataset.mapGroupsWit...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18642 Since the fix is not right, @jaceklaskowski Could you close this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.a

[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19587 Could you add a comment in `abstract class QueryPlan`'s conf? Hopefully, the others will read the comment before using it. --- -

[GitHub] spark issue #18610: [SPARK-21386] ML LinearRegression supports warm start fr...

2017-10-27 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/18610 A couple questions: 1. do we actually *need* to save the initialModel when we persist the current model? I'm not sure it's necessary and it adds complexity. Also, we could add it in the futu

[GitHub] spark pull request #18610: [SPARK-21386] ML LinearRegression supports warm s...

2017-10-27 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/18610#discussion_r147532256 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -226,6 +246,12 @@ class LinearRegression @Since("1.3.0") (@Since

[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19587 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache

[GitHub] spark issue #19591: [SPARK-11035][core] Add in-process Spark app launcher.

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19591 **[Test build #83137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83137/testReport)** for PR 19591 at commit [`928a052`](https://github.com/apache/spark/commit/92

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-10-27 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/19591 [SPARK-11035][core] Add in-process Spark app launcher. This change adds a new launcher that allows applications to be run in a separate thread in the same process as the calling code. To achi

[GitHub] spark pull request #19567: [SPARK-22291][SQL] Postgresql UUID[] to Cassandra...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19567#discussion_r147531601 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala --- @@ -134,11 +149,28 @@ class Post

[GitHub] spark issue #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push epoch u...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19583 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push epoch u...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19583 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83136/ Test FAILed. ---

[GitHub] spark issue #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push epoch u...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19583 **[Test build #83136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83136/testReport)** for PR 19583 at commit [`7f538df`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #19531: [SPARK-22310] [SQL] Refactor join estimation to i...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19531#discussion_r147530024 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala --- @@ -157,64 +154,100 @@ case c

[GitHub] spark pull request #19531: [SPARK-22310] [SQL] Refactor join estimation to i...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19531#discussion_r147529424 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala --- @@ -157,64 +154,100 @@ case c

[GitHub] spark pull request #19531: [SPARK-22310] [SQL] Refactor join estimation to i...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19531#discussion_r147529228 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala --- @@ -28,45 +28,43 @@ import o

[GitHub] spark issue #19122: [SPARK-21911][ML][PySpark] Parallel Model Evaluation for...

2017-10-27 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19122 Whoops, could you please send a follow-up PR to do 1 doc update? * Update https://github.com/apache/spark/blob/master/docs/ml-tuning.md to say this is supported in Python. (Search for "NOTE: t

[GitHub] spark issue #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push epoch u...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19583 **[Test build #83136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83136/testReport)** for PR 19583 at commit [`7f538df`](https://github.com/apache/spark/commit/7f

[GitHub] spark pull request #19122: [SPARK-21911][ML][PySpark] Parallel Model Evaluat...

2017-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19122 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push ...

2017-10-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19583#discussion_r147522958 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -51,7 +51,26 @@ private case class ExecutorRegistered(executorId: String)

[GitHub] spark pull request #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push ...

2017-10-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19583#discussion_r147526776 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -51,7 +51,26 @@ private case class ExecutorRegistered(executorId: String)

[GitHub] spark issue #19122: [SPARK-21911][ML][PySpark] Parallel Model Evaluation for...

2017-10-27 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19122 LGTM Merging with master Thanks @WeichenXu123 , @BryanCutler and @viirya ! --- - To unsubscribe, e-mail: reviews-unsubs

[GitHub] spark pull request #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push ...

2017-10-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19583#discussion_r147525074 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -241,6 +243,21 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark issue #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push epoch u...

2017-10-27 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19583 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark pull request #19583: [WIP][SPARK-22339] [CORE] [NETWORK-SHUFFLE] Push ...

2017-10-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19583#discussion_r147526524 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -225,6 +270,7 @@ class HeartbeatReceiverSuite Matchers.eq(Arr

[GitHub] spark issue #19590: [WIP][SPARK-22148][CORE] TaskSetManager.abortIfCompletel...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19590 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19590: [WIP][SPARK-22148][CORE] TaskSetManager.abortIfCo...

2017-10-27 Thread juanrh
GitHub user juanrh opened a pull request: https://github.com/apache/spark/pull/19590 [WIP][SPARK-22148][CORE] TaskSetManager.abortIfCompletelyBlacklisted should not abort when all current executors are blacklisted but dynamic allocation is enabled ## What changes were proposed in t

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18544 The failures are related to the changes you made here. Could you fix them? Thanks! --- - To unsubscribe, e-mail: reviews-unsu

[GitHub] spark issue #19451: [SPARK-22181][SQL]Adds ReplaceExceptWithFilter rule

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19451 **[Test build #83135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83135/testReport)** for PR 19451 at commit [`40d8797`](https://github.com/apache/spark/commit/40

[GitHub] spark pull request #19585: [TRIVIAL] [SQL] Code cleaning in ResolveReference...

2017-10-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19585#discussion_r147520400 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -841,15 +852,7 @@ class Analyzer( cas

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread sathiyapk
Github user sathiyapk commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147518995 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * License

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread sathiyapk
Github user sathiyapk commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147518757 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * License

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19587: [SPARK-22370][SQL][PYSPARK] Config values should be capt...

2017-10-27 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/19587 LGTM, good catch! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83134/ Test FAILed. ---

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18544 **[Test build #83134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83134/testReport)** for PR 18544 at commit [`c41475e`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #19480: [SPARK-22226][SQL] splitExpression can create too...

2017-10-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19480 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19480: [SPARK-22226][SQL] splitExpression can create too many m...

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19480 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19451 Please change the title to `[SPARK-22181][SQL]Adds ReplaceExceptWithNotFilter rule` --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark issue #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19451 LGMT except a few minor comments. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147510054 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceOperatorSuite.scala --- @@ -50,6 +52,108 @@ class ReplaceOperatorSu

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147508919 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * Licens

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147508867 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * Licens

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147507850 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * Licens

[GitHub] spark issue #19439: [SPARK-21866][ML][PySpark] Adding spark image reader

2017-10-27 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/19439 @WeichenXu123 @viirya @srowen @MrBago @holdenk @HyukjinKwon @dakirsa @hhbyyh @drdarshan Thank you for taking a look at the PR merging the "spark-images" spark package into spark and your great

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147507755 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * Licens

[GitHub] spark pull request #19451: SPARK-22181 Adds ReplaceExceptWithNotFilter rule

2017-10-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19451#discussion_r147507461 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceExceptWithFilter.scala --- @@ -0,0 +1,104 @@ +/* + * Licens

[GitHub] spark issue #19578: [SPARK-21983][SQL] Fix Antlr 4.7 deprecation warnings

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19578 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19578: [SPARK-21983][SQL] Fix Antlr 4.7 deprecation warnings

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19578 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83133/ Test PASSed. ---

[GitHub] spark issue #19578: [SPARK-21983][SQL] Fix Antlr 4.7 deprecation warnings

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19578 **[Test build #83133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83133/testReport)** for PR 19578 at commit [`c572154`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #19573: [SPARK-22350][SQL] select grouping__id from subquery

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19573 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19573: [SPARK-22350][SQL] select grouping__id from subquery

2017-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19573 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83131/ Test PASSed. ---

[GitHub] spark issue #19573: [SPARK-22350][SQL] select grouping__id from subquery

2017-10-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19573 **[Test build #83131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83131/testReport)** for PR 19573 at commit [`c0ecbee`](https://github.com/apache/spark/commit/c

<    1   2   3   4   >