[GitHub] spark issue #19839: SPARK-22373 Bump Janino dependency version to fix thread...

2017-11-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19839 No, it is unreleased. Yes, sure, we can also update it now and later too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spar

[GitHub] spark issue #19839: SPARK-22373 Bump Janino dependency version to fix thread...

2017-11-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19839 You'll need to run `./dev/test-dependencies.sh --replace-manifest` --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-11-29 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/19715 @huaxingao for posterity and recording purposes, could you post the performance comparison between the approach used here (of merging together all the probabilities into one array for `approxQuantile

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153774332 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -50,10 +50,26 @@ private[feature] trait QuantileDiscretizerBase e

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153776672 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -129,34 +152,119 @@ final class QuantileDiscretizer @Since("1.6.0

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153786414 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala --- @@ -146,4 +146,166 @@ class QuantileDiscretizerSuite

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153774170 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -50,10 +50,26 @@ private[feature] trait QuantileDiscretizerBase e

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153775090 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -86,6 +104,10 @@ private[feature] trait QuantileDiscretizerBase e

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153785692 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -129,34 +152,119 @@ final class QuantileDiscretizer @Since("1.6.0

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153772861 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -129,34 +152,119 @@ final class QuantileDiscretizer @Since("1.6.0

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153775451 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -50,10 +50,26 @@ private[feature] trait QuantileDiscretizerBase e

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-11-29 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r153772930 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -129,34 +152,119 @@ final class QuantileDiscretizer @Since("1.6.0

[GitHub] spark issue #19839: SPARK-22373 Bump Janino dependency version to fix thread...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19839 **[Test build #3997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3997/testReport)** for PR 19839 at commit [`5f54a89`](https://github.com/apache/spark/commit/

[GitHub] spark issue #19845: [SPARK-22651][PYTHON][ML] Prevent initiating multiple Hi...

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19845 cc @jiangxb1987, @viirya who I am seeing touched and reviewed similar codes, and @imatiach-msft who's the primary author of this codes. ---

[GitHub] spark issue #19845: [SPARK-22651][PYTHON][ML] Prevent initiating multiple Hi...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19845 **[Test build #84297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84297/testReport)** for PR 19845 at commit [`c0c3c48`](https://github.com/apache/spark/commit/c0

[GitHub] spark issue #19839: SPARK-22373 Bump Janino dependency version to fix thread...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19839 **[Test build #3997 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3997/testReport)** for PR 19839 at commit [`5f54a89`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #19839: SPARK-22373 Bump Janino dependency version to fix thread...

2017-11-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19839 Which version? if it's unreleased, I don't see a harm in updating this now and later too. If it's released, we can just update it here. --- -

[GitHub] spark issue #19845: [SPARK-22651][PYTHON][ML] Prevent initiating multiple Hi...

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19845 I could fold this change into `https://github.com/apache/spark/pull/19835`. I only opened a separate PR here as it was easy to describe this issue separately and seems another issue although the

[GitHub] spark pull request #19845: [SPARK-22651][PYTHON][ML] Prevent initiating mult...

2017-11-29 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/19845 [SPARK-22651][PYTHON][ML] Prevent initiating multiple Hive clients for ImageSchema.readImages ## What changes were proposed in this pull request? Calling `ImageSchema.readImages` multi

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19842 LGTM - pending benchmarks :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19842 @cloud-fan TPCDS does not have nested data or arrays. So I think we have to redo the benchmarks. A simple micro benchmark that touches a few elements in the array should probably do it. --- --

[GitHub] spark issue #19841: [SPARK-22642][SQL] the createdTempDir will not be delete...

2017-11-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19841 It's a very long method, and a try-finally around it is hard to follow. Can this wrapper live in the caller? is there another place to ensure something's cleaned up? --- --

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19842 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19821 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84293/ Test PASSed. ---

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19842 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84294/ Test PASSed. ---

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19842 **[Test build #84294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84294/testReport)** for PR 19842 at commit [`aaa33dd`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84293/testReport)** for PR 19821 at commit [`5332f12`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84290/ Test PASSed. ---

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84290/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19834: [SPARK-22585][Core] Path in addJar is not url encoded

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19834 **[Test build #84295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84295/testReport)** for PR 19834 at commit [`bd667d9`](https://github.com/apache/spark/commit/bd

[GitHub] spark issue #19828: [SPARK-22614] Dataset API: repartitionByRange(...)

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19828 **[Test build #84296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84296/testReport)** for PR 19828 at commit [`012d617`](https://github.com/apache/spark/commit/01

[GitHub] spark issue #19834: [SPARK-22585][Core] Path in addJar is not url encoded

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19834 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19714 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84291/ Test PASSed. ---

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19714 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19714 **[Test build #84291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84291/testReport)** for PR 19714 at commit [`a2cf0ce`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #19717: [SPARK-18278] [Submission] Spark on Kubernetes - basic s...

2017-11-29 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/19717 @liyinan926, please change PR title to match sub-task: https://issues.apache.org/jira/browse/SPARK-22646 --- - To unsubscribe, e-

[GitHub] spark pull request #19714: [SPARK-22489][SQL] Shouldn't change broadcast joi...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19714#discussion_r153771297 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -223,4 +223,69 @@ class BroadcastJoinSuite extends

[GitHub] spark pull request #19714: [SPARK-22489][SQL] Shouldn't change broadcast joi...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19714#discussion_r153770711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -149,10 +147,43 @@ abstract class SparkStrategies extends Q

[GitHub] spark pull request #19714: [SPARK-22489][SQL] Shouldn't change broadcast joi...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19714#discussion_r153770517 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -149,10 +147,43 @@ abstract class SparkStrategies extends Q

[GitHub] spark pull request #19844: [SPARK-22635][SQL][ORC] FileNotFoundException whi...

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19844#discussion_r153769263 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala --- @@ -59,8 +59,9 @@ class OrcFileFormat extends FileFormat with D

[GitHub] spark issue #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint to Dat...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19805 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint to Dat...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19805 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84289/ Test PASSed. ---

[GitHub] spark issue #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint to Dat...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19805 **[Test build #84289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84289/testReport)** for PR 19805 at commit [`c5f1b2c`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #19844: [SPARK-22635][SQL][ORC] FileNotFoundException whi...

2017-11-29 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19844#discussion_r153766590 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala --- @@ -59,8 +59,9 @@ class OrcFileFormat extends FileFormat with Data

[GitHub] spark issue #19834: [SPARK-22585][Core] Path in addJar is not url encoded

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19834 Another LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #19844: [SPARK-22635][SQL][ORC] FileNotFoundException while read...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19844 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19844: [SPARK-22635][SQL][ORC] FileNotFoundException while read...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19844 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84292/ Test PASSed. ---

[GitHub] spark issue #19844: [SPARK-22635][SQL][ORC] FileNotFoundException while read...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19844 **[Test build #84292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84292/testReport)** for PR 19844 at commit [`c7e817f`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #19844: [SPARK-22635][SQL][ORC] FileNotFoundException whi...

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19844#discussion_r153763011 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala --- @@ -59,8 +59,9 @@ class OrcFileFormat extends FileFormat with D

[GitHub] spark issue #19764: [SPARK-22539][SQL] Add second order for rangepartitioner...

2017-11-29 Thread caneGuy
Github user caneGuy commented on the issue: https://github.com/apache/spark/pull/19764 @gczsjdy Ok,i will post later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19821 LGTM, can you remove `WIP` in PR title? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #19821: [WIP][SPARK-22608][SQL] add new API to CodeGenera...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19821#discussion_r153763387 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -788,11 +788,31 @@ class CodegenContex

[GitHub] spark pull request #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint...

2017-11-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19805#discussion_r153761498 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -537,9 +536,55 @@ class Dataset[T] private[sql]( */ @Experimen

[GitHub] spark pull request #19833: [SPARK-22605][SQL] SQL write job should also set ...

2017-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19833 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19833: [SPARK-22605][SQL] SQL write job should also set Spark t...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19833 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19833: [SPARK-22605][SQL] SQL write job should also set ...

2017-11-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19833#discussion_r153758037 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala --- @@ -106,6 +105,13 @@ class BasicWriteTaskSt

[GitHub] spark pull request #19812: [SPARK-22598][CORE] ExecutorAllocationManager doe...

2017-11-29 Thread liutang123
Github user liutang123 closed the pull request at: https://github.com/apache/spark/pull/19812 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19812: [SPARK-22598][CORE] ExecutorAllocationManager does not r...

2017-11-29 Thread liutang123
Github user liutang123 commented on the issue: https://github.com/apache/spark/pull/19812 Sorry, I can not reproduce it now. But, sometimes, `ExecutorAllocationManager ` did not request new executors and `YarnSchedulerBackend.requestedTotalExecutors` is 0. I will close this PR now an

[GitHub] spark pull request #19828: [SPARK-22614] Dataset API: repartitionByRange(......

2017-11-29 Thread adrian-ionescu
Github user adrian-ionescu commented on a diff in the pull request: https://github.com/apache/spark/pull/19828#discussion_r153755261 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -838,6 +839,30 @@ case class Re

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19825 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84288/ Test PASSed. ---

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19825 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19825 **[Test build #84288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84288/testReport)** for PR 19825 at commit [`189d590`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19842 **[Test build #84294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84294/testReport)** for PR 19842 at commit [`aaa33dd`](https://github.com/apache/spark/commit/aa

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19842 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint...

2017-11-29 Thread ferdonline
Github user ferdonline commented on a diff in the pull request: https://github.com/apache/spark/pull/19805#discussion_r153746129 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -537,9 +536,55 @@ class Dataset[T] private[sql]( */ @Experiment

[GitHub] spark issue #19821: [WIP][SPARK-22608][SQL] add new API to CodeGeneration.sp...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19821 **[Test build #84293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84293/testReport)** for PR 19821 at commit [`5332f12`](https://github.com/apache/spark/commit/53

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19843 @MrBago @jkbradley --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #19844: [SPARK-22635][SQL][ORC] FileNotFoundException while read...

2017-11-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19844 @dongjoon-hyun @gatorsmile you helped reviewing SPARK-22146. Might you please help reviewing this too? Sorry for pinging you directly. ---

[GitHub] spark pull request #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint...

2017-11-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19805#discussion_r153739562 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -537,9 +536,55 @@ class Dataset[T] private[sql]( */ @Experimental

[GitHub] spark issue #19844: [SPARK-22635][SQL][ORC] FileNotFoundException while read...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19844 **[Test build #84292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84292/testReport)** for PR 19844 at commit [`c7e817f`](https://github.com/apache/spark/commit/c7

[GitHub] spark pull request #19844: [SPARK-22635][SQL][ORC] FileNotFoundException whi...

2017-11-29 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/19844 [SPARK-22635][SQL][ORC] FileNotFoundException while reading ORC files containing special characters ## What changes were proposed in this pull request? SPARK-22146 fix the FileNotFoundExc

[GitHub] spark pull request #19714: [SPARK-22489][SQL] Shouldn't change broadcast joi...

2017-11-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/19714#discussion_r153736381 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -153,6 +151,27 @@ abstract class SparkStrategies extends Quer

[GitHub] spark issue #19714: [SPARK-22489][SQL] Shouldn't change broadcast join build...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19714 **[Test build #84291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84291/testReport)** for PR 19714 at commit [`a2cf0ce`](https://github.com/apache/spark/commit/a2

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84290/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/08

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19843 Jenkins retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #19805: [SPARK-22649][PYTHON][SQL] Adding localCheckpoint to Dat...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19805 **[Test build #84289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84289/testReport)** for PR 19805 at commit [`c5f1b2c`](https://github.com/apache/spark/commit/c5

[GitHub] spark pull request #19805: [PYTHON][SQL] Adding localCheckpoint to Dataset A...

2017-11-29 Thread ferdonline
Github user ferdonline commented on a diff in the pull request: https://github.com/apache/spark/pull/19805#discussion_r153722443 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -537,9 +536,55 @@ class Dataset[T] private[sql]( */ @Experiment

[GitHub] spark issue #19468: [SPARK-18278] [Scheduler] Spark on Kubernetes - Basic Sc...

2017-11-29 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/19468 Done, created subtasks. Thanks everyone for helping review this PR! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19842 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84285/ Test FAILed. ---

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84286/testReport)** for PR 19843 at commit [`072f4b9`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84286/ Test FAILed. ---

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19825 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84284/ Test FAILed. ---

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19842 **[Test build #84285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84285/testReport)** for PR 19842 at commit [`aaa33dd`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19825 **[Test build #84284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84284/testReport)** for PR 19825 at commit [`c359fe3`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19825 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19843 **[Test build #84287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84287/testReport)** for PR 19843 at commit [`08954fe`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84287/ Test FAILed. ---

[GitHub] spark issue #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite support S...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19843 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19842: [SPARK-22643][SQL] ColumnarArray should be an immutable ...

2017-11-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19842 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/19825 Hi @gatorsmile , I have just fixed full outer join and add more test cases. It is ready for review. --- - To unsubscrib

[GitHub] spark issue #19825: [SPARK-22615][SQL] Handle more cases in PropagateEmptyRe...

2017-11-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19825 **[Test build #84288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84288/testReport)** for PR 19825 at commit [`189d590`](https://github.com/apache/spark/commit/18

<    1   2   3   4