Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19910
@cloud-fan the UT failures are caused by this PR. Therefore I think @viirya
is right and also for `CreateArray` we shouldn't reuse the object to avoid bad
results. Likely this happens only in some
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19836#discussion_r155267282
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -159,11 +160,16 @@ class BlockManagerMasterEndpoint(
Github user mgaido91 closed the pull request at:
https://github.com/apache/spark/pull/19909
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19909
Unfortunately all the solution require using another row. Since this might
not be as performant as the current code I am closing this.
---
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19836#discussion_r155265124
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -159,11 +160,16 @@ class BlockManagerMasterEndpoint(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155259103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamed
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155257951
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamedStru
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19836
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user brad-kaiser commented on a diff in the pull request:
https://github.com/apache/spark/pull/19836#discussion_r155255972
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -159,11 +160,18 @@ class BlockManagerMasterEndpoint(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19836
**[Test build #84562 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84562/testReport)**
for PR 19836 at commit
[`e2ad8c3`](https://github.com/apache/spark/commit/e2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19901
**[Test build #84561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84561/testReport)**
for PR 19901 at commit
[`740f1a0`](https://github.com/apache/spark/commit/74
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19906
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84549/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19906
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19906
**[Test build #84549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84549/testReport)**
for PR 19906 at commit
[`8bc6a9c`](https://github.com/apache/spark/commit/8
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155249354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155249230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamed
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19896
thank you all, please wait for #19910 because if it is not feasible to
reuse the array object as @viirya
says, I will add back here the change to avoid that global variable.
Thanks.
---
--
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19899
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155246637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -237,37 +237,40 @@ case class In(value: Expression, l
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19901
LGTM except some minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19896
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155246230
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -276,14 +279,15 @@ case class In(value: Expressio
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19911
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155245909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -237,37 +237,40 @@ case class In(value: Expressio
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84558/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19792
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84558 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84558/testReport)**
for PR 19792 at commit
[`5131db2`](https://github.com/apache/spark/commit/5
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155245675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -237,37 +237,40 @@ case class In(value: Expressio
GitHub user danielvdende opened a pull request:
https://github.com/apache/spark/pull/19911
[SPARK-21098] Correct cascade default for postgres
The PostgresDialect indicates that cascade is true by default for Postgres.
This is not the case. This patch fixes this.
## What
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
Here is a list but it definitely contains false positives.
[SPARK-16139.txt](https://github.com/apache/spark/files/1535397/SPARK-16139.txt)
---
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19899
**[Test build #84560 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84560/testReport)**
for PR 19899 at commit
[`e1ed6c1`](https://github.com/apache/spark/commit/e1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19910
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155243262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -212,59 +213,63 @@ case class CaseWhe
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19910
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84554/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19910
**[Test build #84554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84554/testReport)**
for PR 19910 at commit
[`e995a0e`](https://github.com/apache/spark/commit/e
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19621
I think I understand what you are saying but the latest test failure I see
it from spark.mlp instead and be results are different from the existing ones.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155242774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -180,13 +180,15 @@ case class CaseWhe
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
On the other side globalEventExecutor.* and dag-scheduler-event-loop was an
issue in the tests what I've taken a look at.
---
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155241754
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamedS
Github user gaborgsomogyi commented on the issue:
https://github.com/apache/spark/pull/19893
I've just started to take a look at it deeper and found some patterns.
Namely we can exclude all netty.* threads + ForkJoinPool.* is most of the time
but not always created inside scala by the
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19900
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19900
**[Test build #84559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84559/testReport)**
for PR 19900 at commit
[`f188d55`](https://github.com/apache/spark/commit/f1
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155240522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155239933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamed
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155239813
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamedS
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19900#discussion_r155239094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -982,35 +982,29 @@ case class ScalaUDF(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84556/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19899
**[Test build #84556 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84556/testReport)**
for PR 19899 at commit
[`e5aa90e`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19792
**[Test build #84558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84558/testReport)**
for PR 19792 at commit
[`5131db2`](https://github.com/apache/spark/commit/51
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19900#discussion_r155238814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -982,35 +982,29 @@ case class ScalaUDF(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19899
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19901
**[Test build #84557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84557/testReport)**
for PR 19901 at commit
[`6a14e16`](https://github.com/apache/spark/commit/6a
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r155238727
--- Diff: python/pyspark/sql/session.py ---
@@ -405,7 +401,7 @@ def _createFromLocal(self, data, schema):
data = list(data)
Github user gberger commented on a diff in the pull request:
https://github.com/apache/spark/pull/19792#discussion_r155238617
--- Diff: python/pyspark/sql/session.py ---
@@ -405,7 +401,7 @@ def _createFromLocal(self, data, schema):
data = list(data)
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19910#discussion_r155238576
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -356,25 +356,24 @@ case class CreateNamedStr
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19900#discussion_r155238140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -982,35 +982,29 @@ case class ScalaUDF(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19899
**[Test build #84556 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84556/testReport)**
for PR 19899 at commit
[`e5aa90e`](https://github.com/apache/spark/commit/e5
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19900#discussion_r155237198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -982,35 +982,29 @@ case class ScalaUDF(
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19896
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19900
**[Test build #84555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84555/testReport)**
for PR 19900 at commit
[`eef8036`](https://github.com/apache/spark/commit/ee
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155234845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -237,37 +237,39 @@ case class In(value: Expressio
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19910
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19910
**[Test build #84554 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84554/testReport)**
for PR 19910 at commit
[`e995a0e`](https://github.com/apache/spark/commit/e9
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19910
[SPARK-22715][SQL] Reuse the same array in CreateNamedStruct
## What changes were proposed in this pull request?
The PR reuses the same object in CreateNamedStruct instead of instantiating
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155233875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155233734
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155233351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84550/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19909
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19909
**[Test build #84550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84550/testReport)**
for PR 19909 at commit
[`d3bebce`](https://github.com/apache/spark/commit/d
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155233099
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155232397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19901#discussion_r155231783
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -237,37 +237,39 @@ case class In(value: Expression, l
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231792
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231547
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231523
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231340
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r155231264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
---
@@ -114,4 +114,171 @@ object
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19890
It would only cause a problem if somehow and older Janino was on the
classpath, which does not have the new exception type. I don't think there's a
reason to believe that happens in practice (i.e. no
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19882#discussion_r155230769
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Soft
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19836
**[Test build #84553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84553/testReport)**
for PR 19836 at commit
[`fbd2497`](https://github.com/apache/spark/commit/fb
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19836
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19836#discussion_r155230290
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
@@ -159,11 +160,18 @@ class BlockManagerMasterEndpoint(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19882#discussion_r155228866
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -225,57 +162,39 @@ abstract class OrcSuite
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19882#discussion_r155229015
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
---
@@ -15,20 +15,51 @@
* limitations under the Li
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19882#discussion_r155227254
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
---
@@ -614,27 +523,88 @@ class OrcQuerySuite exte
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19896
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19890
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84545/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19890
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19908
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84548/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19890
**[Test build #84545 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84545/testReport)**
for PR 19890 at commit
[`663803b`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19908
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19896
**[Test build #84552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84552/testReport)**
for PR 19896 at commit
[`b5bd951`](https://github.com/apache/spark/commit/b5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19908
**[Test build #84548 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84548/testReport)**
for PR 19908 at commit
[`a33bd99`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84547/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19899
**[Test build #84547 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84547/testReport)**
for PR 19899 at commit
[`47fcdc2`](https://github.com/apache/spark/commit/4
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19893
Do any of those leaked threads look like they might be real issues to fix?
you could paste the results here, minus anything you know isn't a problem.
---
---
401 - 500 of 684 matches
Mail list logo
