[GitHub] spark pull request #19992: [SPARK-22805][CORE] Use StorageLevel aliases in e...

2018-01-01 Thread superbobry
Github user superbobry commented on a diff in the pull request: https://github.com/apache/spark/pull/19992#discussion_r159153806 --- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala --- @@ -2022,12 +1947,7 @@ private[spark] object JsonProtocolSuite extends

[GitHub] spark pull request #20070: SPARK-22896 Improvement in String interpolation

2018-01-01 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20070#discussion_r159152519 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/LatentDirichletAllocationExample.scala --- @@ -46,7 +46,10 @@ object

[GitHub] spark issue #20078: [SPARK-22900] [Spark-Streaming] Remove unnecessary restr...

2018-01-01 Thread sharkdtu
Github user sharkdtu commented on the issue: https://github.com/apache/spark/pull/20078 @felixcheung At the beginning, if numReceivers > totleExecutorCores, there is not cpu cores for batch processing, and `ExecutorAllocationManager` can't listen metrics of any batches. As a

[GitHub] spark issue #20129: [SPARK-22933][SPARKR] R Structured Streaming API for wit...

2018-01-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20129 **[Test build #85577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85577/testReport)** for PR 20129 at commit

[GitHub] spark issue #20133: [SPARK-22934] [SQL] Make optional clauses order insensit...

2018-01-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20133 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20133: [SPARK-22934] [SQL] Make optional clauses order insensit...

2018-01-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20133 **[Test build #85576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85576/testReport)** for PR 20133 at commit

[GitHub] spark issue #20133: [SPARK-22934] [SQL] Make optional clauses order insensit...

2018-01-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20133 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85576/ Test FAILed. ---

[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...

2018-01-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20132 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20132: [SPARK-13030][ML] Follow-up cleanups for OneHotEncoderEs...

2018-01-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20132 The simplified logic for encoder looks good to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20127: [SPARK-22932] [SQL] Refactor AnalysisContext

2018-01-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20127#discussion_r159150900 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -95,6 +98,17 @@ class Analyzer( this(catalog,

[GitHub] spark pull request #20127: [SPARK-22932] [SQL] Refactor AnalysisContext

2018-01-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20127#discussion_r159150948 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -70,6 +71,8 @@ object AnalysisContext { }

[GitHub] spark issue #20124: [WIP][SPARK-22126][ML] Fix model-specific optimization s...

2018-01-01 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20124 (Happy new year!) Just commented on the JIRA; let me know what you think. --- - To unsubscribe, e-mail:

<    1   2