[GitHub] spark pull request #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, as...

2018-04-04 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/20962#discussion_r179292870 --- Diff: python/pyspark/sql/functions.py --- @@ -87,7 +87,15 @@ def _(): 'col': 'Returns a :class:`Column` based on the given column name.',

[GitHub] spark issue #20937: [SPARK-23094][SPARK-23723][SPARK-23724][SQL] Support cus...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20937 **[Test build #88907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88907/testReport)** for PR 20937 at commit [`7e20891`](https://github.com/apache/spark/commit/7e

[GitHub] spark pull request #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff te...

2018-04-04 Thread yogeshg
Github user yogeshg commented on a diff in the pull request: https://github.com/apache/spark/pull/20904#discussion_r179278641 --- Diff: python/pyspark/ml/stat.py --- @@ -134,6 +134,63 @@ def corr(dataset, column, method="pearson"): return _java2py(sc, javaCorrObj.corr(*

[GitHub] spark pull request #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff te...

2018-04-04 Thread yogeshg
Github user yogeshg commented on a diff in the pull request: https://github.com/apache/spark/pull/20904#discussion_r179283700 --- Diff: python/pyspark/ml/stat.py --- @@ -134,6 +134,63 @@ def corr(dataset, column, method="pearson"): return _java2py(sc, javaCorrObj.corr(*

[GitHub] spark pull request #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff te...

2018-04-04 Thread yogeshg
Github user yogeshg commented on a diff in the pull request: https://github.com/apache/spark/pull/20904#discussion_r179267921 --- Diff: python/pyspark/ml/stat.py --- @@ -134,6 +134,63 @@ def corr(dataset, column, method="pearson"): return _java2py(sc, javaCorrObj.corr(*

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88898/ Test PASSed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #88898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88898/testReport)** for PR 19222 at commit [`94c9648`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179265065 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala --- @@ -0,0 +1,166 @@ +/* + * License

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179267979 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala --- @@ -0,0 +1,135 @@ +/

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179266001 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkPod.scala --- @@ -14,17 +14,16 @@ * See the License for

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179273021 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KubernetesFeatureConfigStep.scala --- @@ -0,0 +1,29 @@

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179269454 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -14,104 +14,66 @@

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179270994 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -175,49 +138,41 @@

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread kimoonkim
Github user kimoonkim commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179266562 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala --- @@ -0,0 +1,135 @@ +/

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19041 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19041 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88899/ Test FAILed. ---

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19041 **[Test build #88899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88899/testReport)** for PR 19041 at commit [`03ed8a2`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2018-04-04 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19041 thanks for the updates @brad-kaiser. I think I understand and don't have any major concerns. It doesn't seem easy to use the LRU from MemoryStore, so can set that aside for now btw as you

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179266769 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -252,6 +257,44 @@ class BlockManagerMasterEndpoint(

[GitHub] spark issue #20871: [WIP][SPARK-23762][SQL] UTF8StringBuffer uses MemoryBloc...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88894/ Test PASSed. ---

[GitHub] spark issue #20871: [WIP][SPARK-23762][SQL] UTF8StringBuffer uses MemoryBloc...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20871: [WIP][SPARK-23762][SQL] UTF8StringBuffer uses MemoryBloc...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20871 **[Test build #88894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88894/testReport)** for PR 20871 at commit [`0d0f271`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1974/ Tes

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20890 **[Test build #88906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88906/testReport)** for PR 20890 at commit [`9abcf09`](https://github.com/apache/spark/commit/9a

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88893/ Test FAILed. ---

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20890 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20890 **[Test build #88893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88893/testReport)** for PR 20890 at commit [`9abcf09`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20753 **[Test build #88905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88905/testReport)** for PR 20753 at commit [`984cee7`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88905/ Test FAILed. ---

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1973/ Tes

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20753 **[Test build #88905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88905/testReport)** for PR 20753 at commit [`984cee7`](https://github.com/apache/spark/commit/98

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1972/ Tes

[GitHub] spark issue #20874: [WIP][SPARK-23763][SQL] OffHeapColumnVector uses MemoryB...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20874: [WIP][SPARK-23763][SQL] OffHeapColumnVector uses MemoryB...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1971/ Tes

[GitHub] spark pull request #20811: [SPARK-23668][K8S] Add config option for passing ...

2018-04-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20811 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1937/ ---

[GitHub] spark issue #20874: [WIP][SPARK-23763][SQL] OffHeapColumnVector uses MemoryB...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20874 **[Test build #88904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88904/testReport)** for PR 20874 at commit [`7f410ae`](https://github.com/apache/spark/commit/7f

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20976 **[Test build #88903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88903/testReport)** for PR 20976 at commit [`b3e70e9`](https://github.com/apache/spark/commit/b3

[GitHub] spark pull request #20963: [SPARK-23849][SQL] Tests for the samplingRatio op...

2018-04-04 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20963#discussion_r179257489 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2127,4 +2127,39 @@ class JsonSuite extends QueryT

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20976 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20811 LGTM. Merging to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88902/ Test PASSed. ---

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 **[Test build #88902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88902/testReport)** for PR 20811 at commit [`0291f0f`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1970/ Tes

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1937/ --- --

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame bou...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20978 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88895/ Test PASSed. ---

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame bou...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20978 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame bou...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20978 **[Test build #88895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88895/testReport)** for PR 20978 at commit [`0b6f5fc`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20811 @mccheah - heads up, this will likely lead to a rebase on https://github.com/apache/spark/pull/20910. --- - To unsubscribe, e-mai

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1935/ ---

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 **[Test build #88902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88902/testReport)** for PR 20811 at commit [`0291f0f`](https://github.com/apache/spark/commit/02

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1969/ Tes

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20811 @andrusha, no worries. I think this is going to be rather important for folks with private registries. Thanks for following up on it! --- ---

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1935/ --- --

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20811 Jenkins, test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1968/ Tes

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88901/ Test FAILed. ---

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20753 **[Test build #88901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88901/testReport)** for PR 20753 at commit [`0c61e60`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20753 **[Test build #88901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88901/testReport)** for PR 20753 at commit [`0c61e60`](https://github.com/apache/spark/commit/0c

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread andrusha
Github user andrusha commented on the issue: https://github.com/apache/spark/pull/20811 Sorry for all the merging troubles > On 4 Apr 2018, at 20:45, Apache Spark QA wrote: > > Test build #88900 has finished

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1934/ ---

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1934/ --- --

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1967/ Tes

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 **[Test build #88900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88900/testReport)** for PR 20811 at commit [`c8fb9fa`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20811 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88900/ Test FAILed. ---

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179242084 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -14,104 +14,66 @@

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179241834 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -14,104 +14,66 @@

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179239601 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesSpec.scala --- @@ -14,25 +14,18 @@ * See the Lice

[GitHub] spark pull request #20910: [SPARK-22839] [K8s] Refactor to unify driver and ...

2018-04-04 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/20910#discussion_r179239212 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala --- @@ -0,0 +1,166 @@ +/* + * Licens

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20811 **[Test build #88900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88900/testReport)** for PR 20811 at commit [`c8fb9fa`](https://github.com/apache/spark/commit/c8

[GitHub] spark issue #20811: [SPARK-23668][K8S] Add config option for passing through...

2018-04-04 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20811 Jenkins, test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20933 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88897/ Test FAILed. ---

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20933 **[Test build #88897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88897/testReport)** for PR 20933 at commit [`35b74c0`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-04-04 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r179238708 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame bou...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20978 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame bou...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20978 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88896/ Test FAILed. ---

[GitHub] spark issue #20978: [SPARK-23861][SQL][Doc] Clarify default window frame bou...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20978 **[Test build #88896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88896/testReport)** for PR 20978 at commit [`f96eaea`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88892/ Test FAILed. ---

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20976 **[Test build #88892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88892/testReport)** for PR 20976 at commit [`b3e70e9`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #20945: [SPARK-23790][Mesos] fix metastore connection issue

2018-04-04 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/20945 @susanxhuynh the doAs call from hadoop libs on the proxy user in SparkSubmit is using java.security.AccessController.doPrivileged at the java security level, what if I use a security manager policy

[GitHub] spark issue #20945: [SPARK-23790][Mesos] fix metastore connection issue

2018-04-04 Thread susanxhuynh
Github user susanxhuynh commented on the issue: https://github.com/apache/spark/pull/20945 (1) seems the most secure. How do we handle keytabs today in cluster mode in pure Mesos? Is it the same situation -- the keytab gets sent over a HTTP connection to the Dispatcher? (3) Y

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179201817 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179200666 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179206819 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179206187 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundati

<    1   2   3   4   5   6   >