[GitHub] spark issue #19675: [SPARK-14540][BUILD] Support Scala 2.12 closures and Jav...

2018-04-05 Thread jvican
Github user jvican commented on the issue: https://github.com/apache/spark/pull/19675 I would be very happy to accept feedback on the latest spores implementation https://github.com/scalacenter/spores/ and make them production ready, possibly adding them into the language after a pote

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88937/ Test PASSed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #88937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88937/testReport)** for PR 19222 at commit [`3d03f92`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20978#discussion_r179467893 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala --- @@ -33,6 +33,10 @@ import org.apache.spark.sql.catalyst.expressions._

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20756 Yes that would effectively be the same. Do you think we should always call setters for reference types? --- - To unsu

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20756 We don't invoke the setter if the input is null, sounds like we simply skip calling the setter if the input is null? --- - To uns

[GitHub] spark pull request #20778: [SPARK-23584][SQL] NewInstance should support int...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20778#discussion_r179464207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -392,8 +392,44 @@ case class NewInstance(

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20756 I think the semantic should be that we do not invoke the setter if the input is null. --- - To unsubscribe, e-mail: reviews-u

[GitHub] spark issue #20933: [SPARK-23817][SQL]Migrate ORC file format read path to d...

2018-04-05 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/20933 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #19675: [SPARK-14540][BUILD] Support Scala 2.12 closures and Jav...

2018-04-05 Thread ekrich
Github user ekrich commented on the issue: https://github.com/apache/spark/pull/19675 Interestingly, when searching for spores I ran across this post - https://www.reddit.com/r/scala/comments/702lct/what_ever_happened_to_sip21_aka_scala_spores/ --- --

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20756 @hvanhovell Looks like we have tests using null as value for setters. So the added null check fails. --- - To unsubscribe, e-mail

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-05 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r179447746 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec(

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-05 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r179448442 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -266,28 +342,53 @@ case class HashAggregateExec(

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-05 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r179448598 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec(

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20979 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20979 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88935/ Test PASSed. ---

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20979 **[Test build #88935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88935/testReport)** for PR 20979 at commit [`352777b`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88933/ Test PASSed. ---

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20890 **[Test build #88933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88933/testReport)** for PR 20890 at commit [`6ef1ea3`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88939/ Test PASSed. ---

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20904 **[Test build #88939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88939/testReport)** for PR 20904 at commit [`02a1409`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20753: [SPARK-23582][SQL] StaticInvoke should support in...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20753 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20756 @viirya I thought it passed tests, but your last change is causing errors. I am going to revert this for now. Can you reopen? Sorry about this. --- -

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2004/ Tes

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20976 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20976 **[Test build #88940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88940/testReport)** for PR 20976 at commit [`b78ff6c`](https://github.com/apache/spark/commit/b7

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20913 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20913 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88934/ Test PASSed. ---

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88936/ Test FAILed. ---

[GitHub] spark pull request #20756: [SPARK-23593][SQL] Add interpreted execution for ...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20756 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20982 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88938/ Test PASSed. ---

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20913 **[Test build #88934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88934/testReport)** for PR 20913 at commit [`984faf5`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20982 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20756 **[Test build #88936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88936/testReport)** for PR 20756 at commit [`573db59`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20982 **[Test build #88938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88938/testReport)** for PR 20982 at commit [`f05bcdf`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #20979: [SPARK-23588][SQL] CatalystToExternalMap should s...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20979#discussion_r179430079 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -988,8 +988,20 @@ case class CatalystToExte

[GitHub] spark issue #20975: [SPARK-23863] [SQL] Wholetext mode should not add line b...

2018-04-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20975 I am sorry, the unit test uses many private classes, and I think I am not getting the point of this change. Do you mind if I ask some code snippets? I think `wholetext` is not related i

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88930/ Test PASSed. ---

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20981 **[Test build #88930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88930/testReport)** for PR 20981 at commit [`35539be`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2003/ Tes

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20945: [SPARK-23790][Mesos] fix metastore connection issue

2018-04-05 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/20945 @vanzin Sure we will try to comply the thing is pure mesos does not have an api for secrets only DC/OS has one and we cannot bring that api in the Spark project, otherwise I would just implement opti

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20904 **[Test build #88939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88939/testReport)** for PR 20904 at commit [`02a1409`](https://github.com/apache/spark/commit/02

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88932/ Test FAILed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #88932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88932/testReport)** for PR 19222 at commit [`e4a7016`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #20981: [SPARK-23873][SQL] Use accessors in interpreted L...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20981#discussion_r179420439 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala --- @@ -277,4 +278,31 @@ class ObjectExpres

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20981 A few minor comments. Looks good otherwise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20982 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2002/ Tes

[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20982 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20982: [SPARK-23859][ML] Initial PR for Instrumentation improve...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20982 **[Test build #88938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88938/testReport)** for PR 20982 at commit [`f05bcdf`](https://github.com/apache/spark/commit/f0

[GitHub] spark pull request #20982: [SPARK-23859][ML] Initial PR for Instrumentation ...

2018-04-05 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/20982 [SPARK-23859][ML] Initial PR for Instrumentation improvements: UUID and logging levels ## What changes were proposed in this pull request? Initial PR for Instrumentation improvements:

[GitHub] spark pull request #20981: [SPARK-23873][SQL] Use accessors in interpreted L...

2018-04-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20981#discussion_r179418102 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -550,11 +550,33 @@ case class LambdaVariabl

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #88937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88937/testReport)** for PR 19222 at commit [`3d03f92`](https://github.com/apache/spark/commit/3d

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2001/ Tes

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179402310 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -45,38 +45,164 @@ */ public static final int FREED

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179397907 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -45,38 +45,164 @@ */ public static final int FREE

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2000/ Tes

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20756 **[Test build #88936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88936/testReport)** for PR 20756 at commit [`573db59`](https://github.com/apache/spark/commit/57

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20756 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2018-04-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20043 This pr will be merge soon? I'd like to use this in my pr: https://github.com/apache/spark/pull/20965 --- - To unsubscribe, e-mai

[GitHub] spark pull request #19082: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-05 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19082#discussion_r179391181 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -257,6 +259,78 @@ case class HashAggregateExec(

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179391228 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -45,38 +45,164 @@ */ public static final int FREED

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20979 **[Test build #88935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88935/testReport)** for PR 20979 at commit [`352777b`](https://github.com/apache/spark/commit/35

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20979 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1999/ Tes

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20979 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20979 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-04-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r179385907 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java --- @@ -45,38 +45,164 @@ */ public static final int F

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20913 **[Test build #88934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88934/testReport)** for PR 20913 at commit [`984faf5`](https://github.com/apache/spark/commit/98

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88931/ Test FAILed. ---

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20756 **[Test build #88931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88931/testReport)** for PR 20756 at commit [`573db59`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1998/ Tes

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20890 **[Test build #88933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88933/testReport)** for PR 20890 at commit [`6ef1ea3`](https://github.com/apache/spark/commit/6e

[GitHub] spark issue #20890: [WIP][SPARK-23779][SQL] TaskMemoryManager and UnsafeSort...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20890 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20975: [SPARK-23863] [SQL] Wholetext mode should not add line b...

2018-04-05 Thread barrenlake
Github user barrenlake commented on the issue: https://github.com/apache/spark/pull/20975 @HyukjinKwon Hello, the unit test describes the scene where this problem occurred. You can run the unit test in the original system. Spark2.3 introduced `wholetext` ( default `false`): If true,

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1997/ Tes

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1996/ Tes

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #88932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88932/testReport)** for PR 19222 at commit [`e4a7016`](https://github.com/apache/spark/commit/e4

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20981 **[Test build #88930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88930/testReport)** for PR 20981 at commit [`35539be`](https://github.com/apache/spark/commit/35

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20756 **[Test build #88931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88931/testReport)** for PR 20756 at commit [`573db59`](https://github.com/apache/spark/commit/57

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1995/ Tes

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19222 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark pull request #19082: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-05 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/19082#discussion_r179367236 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -257,6 +259,78 @@ case class HashAggregateExe

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20756 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20981 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20756: [SPARK-23593][SQL] Add interpreted execution for Initial...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20756 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88926/ Test FAILed. ---

<    1   2   3   4   5   >