[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21029 **[Test build #89490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89490/testReport)** for PR 21029 at commit [`18e391a`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #21034: [SPARK-23926][SQL] Extending reverse function to ...

2018-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21034 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21034: [SPARK-23926][SQL] Extending reverse function to support...

2018-04-18 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/21034 Thanks everybody for code reviews! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #21034: [SPARK-23926][SQL] Extending reverse function to support...

2018-04-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21034 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #17086: [SPARK-18693][ML][MLLIB] ML Evaluators should use...

2018-04-18 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17086#discussion_r182367186 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala --- @@ -27,10 +27,11 @@ import org.apache.spark.sql.DataFrame

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20894 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20894 **[Test build #89496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89496/testReport)** for PR 20894 at commit [`a5f2916`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20894 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89496/ Test FAILed. ---

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20894 **[Test build #89496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89496/testReport)** for PR 20894 at commit [`a5f2916`](https://github.com/apache/spark/commit/a5

[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

2018-04-18 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21089 The PR was closed because the equals and hashCode method were explicitly deleted in the commit: https://github.com/apache/spark/commit/3e4e868c850e6b6da2c0d005167316e1abdc7460 --- ---

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20858 **[Test build #89495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89495/testReport)** for PR 20858 at commit [`8a125d9`](https://github.com/apache/spark/commit/8a

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182362454 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains(_

[GitHub] spark issue #21091: [SPARK-22676][FOLLOW-UP] fix code style for test.

2018-04-18 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21091 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-18 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182357725 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class ArrayMax(c

[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

2018-04-18 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21089 @HyukjinKwon I cannot find tests for not-root map types in JsonFunctionsSuite and JsonExpressionsSuite. I am going to propose a PR for supporting the map type as root type in from_json. The tests fo

[GitHub] spark issue #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet produc...

2018-04-18 Thread mshtelma
Github user mshtelma commented on the issue: https://github.com/apache/spark/pull/21052 @wzhfy @maropu Hi guys, is there anything else I should add/change to the PR ? --- - To unsubscribe, e-mail: reviews-unsubscr.

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20858 LGTM except for nits. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182350135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class ArrayMax(chi

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182349064 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class ArrayMax(chi

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21061 **[Test build #89493 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89493/testReport)** for PR 21061 at commit [`bbbc865`](https://github.com/apache/spark/commit/bb

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #89494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89494/testReport)** for PR 20636 at commit [`21b3708`](https://github.com/apache/spark/commit/21

[GitHub] spark issue #21089: [SPARK-24004] Test of from_json for non-root MapType

2018-04-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21089 @MaxGekk, mind taking an action to the JIRA too? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addit

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2425/ Tes

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2426/ Tes

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182350430 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains(_t

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21061 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20636 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16578 I only looked at the PR description, here are my 2 cents: Currently column pruning is done with 2 steps in Spark: 1) optimizer generates extra `Project` to prune unnecessary columns as bot

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89492/testReport)** for PR 20938 at commit [`10849d7`](https://github.com/apache/spark/commit/10

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20938 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21094 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21094 **[Test build #89491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89491/testReport)** for PR 21094 at commit [`ad74513`](https://github.com/apache/spark/commit/ad

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2424/ Tes

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21094 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark pull request #20930: [SPARK-23811][Core] FetchFailed comes before Succ...

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20930#discussion_r182340309 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1266,6 +1266,9 @@ class DAGScheduler( }

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21094 **[Test build #89488 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89488/testReport)** for PR 21094 at commit [`ad74513`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89488/ Test FAILed. ---

[GitHub] spark pull request #21011: [SPARK-23916][SQL] Add array_join function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21011#discussion_r182333814 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,27 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains(_

[GitHub] spark pull request #20930: [SPARK-23811][Core] FetchFailed comes before Succ...

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20930#discussion_r182338127 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1266,6 +1266,9 @@ class DAGScheduler( }

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2423/ Tes

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21093 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2422/ Tes

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21093 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20930: [SPARK-23811][Core] FetchFailed comes before Succ...

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20930#discussion_r182336811 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -1266,6 +1266,9 @@ class DAGScheduler( }

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21029 **[Test build #89490 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89490/testReport)** for PR 21029 at commit [`18e391a`](https://github.com/apache/spark/commit/18

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21093 **[Test build #89489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89489/testReport)** for PR 21093 at commit [`fc5d976`](https://github.com/apache/spark/commit/fc

[GitHub] spark pull request #21089: [SPARK-24004] Test of from_json for non-root MapT...

2018-04-18 Thread MaxGekk
Github user MaxGekk closed the pull request at: https://github.com/apache/spark/pull/21089 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21093 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21029 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #21095: [SPARK-23529][K8s] Support mounting hostPath volumes

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21095 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21095: [SPARK-23529][K8s] Support mounting hostPath volumes

2018-04-18 Thread madanadit
Github user madanadit commented on the issue: https://github.com/apache/spark/pull/21095 @liyinan926 @foxish Please take a look --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comman

[GitHub] spark pull request #21095: [SPARK-23529][K8s] Support mounting hostPath volu...

2018-04-18 Thread madanadit
GitHub user madanadit opened a pull request: https://github.com/apache/spark/pull/21095 [SPARK-23529][K8s] Support mounting hostPath volumes ## What changes were proposed in this pull request? This PR introduces a new config `spark.kubernetes.driver/executor.volumes` taking

[GitHub] spark issue #21095: [SPARK-23529][K8s] Support mounting hostPath volumes

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21095 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182325781 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +417,106 @@ case class ArrayMax(chi

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182327230 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -417,3 +417,106 @@ case class ArrayMax(chi

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182323290 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains(_

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r182326476 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,28 @@ def array_contains(col, value): return Column(sc._jvm.functions.array_contains(_

[GitHub] spark issue #21084: [SPARK-23998][Core]It may be better to add @transient to...

2018-04-18 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/21084 @jerryshao , There is not any issue without transient, but I think it is better to keep same to other fields, and make it clearly which fields do not need to be serialized. --- -

[GitHub] spark issue #19222: [SPARK-10399][SPARK-23879][CORE][SQL] Introduce multiple...

2018-04-18 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/19222 Sorry this thread is too long for me to follow. I might be bringing up a point that has been brought up before. @kiszk did your perf tests take into account megamorphic callsites? It seems to

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2421/ Tes

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21094 **[Test build #89488 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89488/testReport)** for PR 21094 at commit [`ad74513`](https://github.com/apache/spark/commit/ad

[GitHub] spark issue #21084: [SPARK-23998][Core]It may be better to add @transient to...

2018-04-18 Thread eatoncys
Github user eatoncys commented on the issue: https://github.com/apache/spark/pull/21084 @jiangxb1987 It does not take significant time to serialize the taskMemoryManager, because the value is null in driver side, but I think it is better to keep same to other fields in the Task class

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21094 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: r

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89482/ Test FAILed. ---

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21094 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89486/ Test FAILed. ---

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21093 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89487/ Test FAILed. ---

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89485/ Test FAILed. ---

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21093 **[Test build #89484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89484/testReport)** for PR 21093 at commit [`fc5d976`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20636 **[Test build #89485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89485/testReport)** for PR 20636 at commit [`21b3708`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #21093: [SPARK-23340][SQL][BRANCH-2.3] Upgrade Apache ORC to 1.4...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21093 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89484/ Test FAILed. ---

[GitHub] spark issue #20636: [SPARK-23415][SQL][TEST] Make behavior of BufferHolderSp...

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20636 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21061 **[Test build #89487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89487/testReport)** for PR 21061 at commit [`bbbc865`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21094 **[Test build #89486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89486/testReport)** for PR 21094 at commit [`ad74513`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21029 **[Test build #89482 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89482/testReport)** for PR 21029 at commit [`18e391a`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #21094: [SPARK-24007][SQL] EqualNullSafe for FloatType and Doubl...

2018-04-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21094 good catch! LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

<    1   2   3   4   5   6