[GitHub] spark issue #21410: [SPARK-24366][SQL] Improving of error messages for type ...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21410 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #21408: [SPARK-24364][SS] Prevent InMemoryFileIndex from ...

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21408#discussion_r190262119 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala --- @@ -311,14 +314,27 @@ object InMemoryFileIndex e

[GitHub] spark issue #21410: [SPARK-24366][SQL] Improving of error messages for type ...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21410 **[Test build #91034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91034/testReport)** for PR 21410 at commit [`26cc2f8`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91031/ Test PASSed. ---

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #91031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91031/testReport)** for PR 21405 at commit [`2d77332`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91033/ Test FAILed. ---

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21409 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21409 **[Test build #91033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91033/testReport)** for PR 21409 at commit [`0f0908e`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #21411: [SPARK-24367][SQL]Parquet: use JOB_SUMMARY_LEVEL instead...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21411 **[Test build #91042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91042/testReport)** for PR 21411 at commit [`6fa1949`](https://github.com/apache/spark/commit/6f

[GitHub] spark pull request #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21409#discussion_r190260242 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + * Li

[GitHub] spark issue #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP PARTITIO...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19691 @DazhuangSu why can't we enforce it in the parser? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-05-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21405 @mgaido91 Yes, as @rednaxelafx said in previous RP, #19813 will be the first use case. I'd like to use this API to transform statement-based expressions in code blocks. For example, `code` c

[GitHub] spark pull request #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21409#discussion_r190259448 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + * Li

[GitHub] spark issue #21411: [SPARK-24367][SQL]Parquet: use JOB_SUMMARY_LEVEL instead...

2018-05-23 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/21411 @rdblue @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #21411: [SPARK-24367][SQL]Parquet: use JOB_SUMMARY_LEVEL ...

2018-05-23 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/21411 [SPARK-24367][SQL]Parquet: use JOB_SUMMARY_LEVEL instead of deprecated flag ENABLE_JOB_SUMMARY ## What changes were proposed in this pull request? In current parquet version,the conf

[GitHub] spark issue #21311: [SPARK-24257][SQL]LongToUnsafeRowMap calculate the new s...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21311 **[Test build #91041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91041/testReport)** for PR 21311 at commit [`b8b6324`](https://github.com/apache/spark/commit/b8

[GitHub] spark pull request #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21409#discussion_r190258642 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + * Li

[GitHub] spark pull request #21311: [SPARK-24257][SQL]LongToUnsafeRowMap calculate th...

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21311#discussion_r190256996 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/HashedRelationSuite.scala --- @@ -254,6 +254,30 @@ class HashedRelationSuite exten

[GitHub] spark issue #21311: [SPARK-24257][SQL]LongToUnsafeRowMap calculate the new s...

2018-05-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21311 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #21246: [SPARK-23901][SQL] Add masking functions

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21246 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21246: [SPARK-23901][SQL] Add masking functions

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3510/ Tes

[GitHub] spark issue #21408: [SPARK-24364][SS] Prevent InMemoryFileIndex from failing...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21408 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91029/ Test PASSed. ---

[GitHub] spark issue #21408: [SPARK-24364][SS] Prevent InMemoryFileIndex from failing...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21408 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP PARTITIO...

2018-05-23 Thread DazhuangSu
Github user DazhuangSu commented on the issue: https://github.com/apache/spark/pull/19691 @mgaido91 Will it be ok to support Literal only on the right-side like this? https://github.com/apache/spark/pull/19691/files#diff-9847f5cef7cf7fbc5830fbc6b779ee10R295 --- -

[GitHub] spark issue #21408: [SPARK-24364][SS] Prevent InMemoryFileIndex from failing...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21408 **[Test build #91029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91029/testReport)** for PR 21408 at commit [`c52d972`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21372 since it has a bug fix, shall we backport it to Spark 2.3? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org F

[GitHub] spark issue #21246: [SPARK-23901][SQL] Add masking functions

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21246 **[Test build #91040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91040/testReport)** for PR 21246 at commit [`fca3af8`](https://github.com/apache/spark/commit/fc

[GitHub] spark pull request #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21372#discussion_r190253937 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -169,6 +170,14 @@ abstract class OrcSuite ex

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-23 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @holdenk as we discussed in Strata, it would be great if you could give me your opinion on the approach taken in this PR. --- - To

[GitHub] spark pull request #21295: [SPARK-24230][SQL] Fix SpecificParquetRecordReade...

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21295#discussion_r190252764 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java --- @@ -225,7 +226,8 @@ protecte

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-05-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21405 @viirya sorry do you already have some use-cases, goals in mind for this API? May you please share them? Thanks. --- - To unsub

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

2018-05-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r190251443 --- Diff: python/pyspark/sql/dataframe.py --- @@ -347,13 +347,30 @@ def show(self, n=20, truncate=True, vertical=False): name | Bob

[GitHub] spark pull request #21295: [SPARK-24230][SQL] Fix SpecificParquetRecordReade...

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21295#discussion_r190251186 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala --- @@ -879,6 +879,18 @@ class ParquetQueryS

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python] Enable grouped aggregate pand...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21082 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python] Enable grouped aggregate pand...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21082 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3509/ Tes

[GitHub] spark issue #21370: [SPARK-24215][PySpark] Implement _repr_html_ for datafra...

2018-05-23 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/21370 ``` Can we also do something a bit more generic that works for non-Jupyter notebooks as well? ``` Can we accept `spark.sql.repl.eagerEval.enabled` to control both \_\_repr\_\_ and \

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3508/ Tes

[GitHub] spark issue #21407: [SPARK-24313][SQL][BACKPORT-2.3] Fix collection operatio...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21407 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21407: [SPARK-24313][SQL][BACKPORT-2.3] Fix collection operatio...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21407 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91026/ Test PASSed. ---

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21342 **[Test build #91039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91039/testReport)** for PR 21342 at commit [`f5a5a81`](https://github.com/apache/spark/commit/f5

[GitHub] spark issue #21407: [SPARK-24313][SQL][BACKPORT-2.3] Fix collection operatio...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21407 **[Test build #91026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91026/testReport)** for PR 21407 at commit [`dfaad1b`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-05-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r190244637 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -120,11 +120,11 @@ class CodeBlockSuite

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-23 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21342 Thanks a gain for comments ! I updated this pr and added small defensive logic in SparkUncaughtExceptionHandler.scala. Please take another look ~ ---

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

2018-05-23 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r190244648 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -358,6 +357,43 @@ class Dataset[T] private[sql]( sb.toString()

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21409 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91030/ Test FAILed. ---

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3507/ Tes

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python] Enable grouped aggregate pand...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21082 **[Test build #91038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91038/testReport)** for PR 21082 at commit [`1c6b5d5`](https://github.com/apache/spark/commit/1c

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21409 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21406 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21409 **[Test build #91030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91030/testReport)** for PR 21409 at commit [`11d612a`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #21082: [SPARK-22239][SQL][Python] Enable grouped aggrega...

2018-05-23 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/21082#discussion_r190242582 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1869,6 +1870,8 @@ class Analyzer( cas

[GitHub] spark pull request #21317: [SPARK-24232][k8s] Add support for secret env var...

2018-05-23 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21317#discussion_r190242317 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStepSuite.scala --- @@ -0,0 +1,59 @@ +/

[GitHub] spark pull request #21317: [SPARK-24232][k8s] Add support for secret env var...

2018-05-23 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21317#discussion_r190242189 --- Diff: docs/running-on-kubernetes.md --- @@ -140,6 +140,13 @@ namespace as that of the driver and executor pods. For example, to mount a secre --conf

[GitHub] spark pull request #21317: [SPARK-24232][k8s] Add support for secret env var...

2018-05-23 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21317#discussion_r190242231 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala --- @@ -0,0 +1,57 @@ +/*

[GitHub] spark pull request #21317: [SPARK-24232][k8s] Add support for secret env var...

2018-05-23 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21317#discussion_r190242098 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala --- @@ -0,0 +1,57 @@ +/*

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21406 **[Test build #91037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91037/testReport)** for PR 21406 at commit [`567a7ff`](https://github.com/apache/spark/commit/56

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21406 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #21394: [SPARK-24329][SQL] Test for skipping multi-space lines

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21394 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91032/ Test FAILed. ---

[GitHub] spark issue #21394: [SPARK-24329][SQL] Test for skipping multi-space lines

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21394 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21394: [SPARK-24329][SQL] Test for skipping multi-space lines

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21394 **[Test build #91032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91032/testReport)** for PR 21394 at commit [`470980f`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #21342: [SPARK-24294] Throw SparkException when OOM in Br...

2018-05-23 Thread jinxing64
Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/21342#discussion_r190237452 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala --- @@ -111,12 +112,18 @@ case class BroadcastExcha

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21389 **[Test build #91035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91035/testReport)** for PR 21389 at commit [`e4ebac2`](https://github.com/apache/spark/commit/e4

[GitHub] spark issue #21266: [SPARK-24206][SQL] Improve DataSource read benchmark cod...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21266 **[Test build #91036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91036/testReport)** for PR 21266 at commit [`5eab1a5`](https://github.com/apache/spark/commit/5e

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21389 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3505/ Tes

[GitHub] spark issue #21266: [SPARK-24206][SQL] Improve DataSource read benchmark cod...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21266 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3506/ Tes

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21389 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21266: [SPARK-24206][SQL] Improve DataSource read benchmark cod...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21266 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21389: [SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFi...

2018-05-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21389 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark issue #21266: [SPARK-24206][SQL] Improve DataSource read benchmark cod...

2018-05-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21266 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

[GitHub] spark pull request #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21409#discussion_r190231900 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala --- @@ -0,0 +1,132 @@ +/* + * Licens

[GitHub] spark issue #21410: [SPARK-24366][SQL] Improving of error messages for type ...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21410 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-05-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r190228283 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -120,11 +120,11 @@ class CodeBlockSuite e

[GitHub] spark issue #21410: [SPARK-24366][SQL] Improving of error messages for type ...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21410 **[Test build #91034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91034/testReport)** for PR 21410 at commit [`26cc2f8`](https://github.com/apache/spark/commit/26

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91024/ Test FAILed. ---

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #21410: [SPARK-24366][SQL] Improving of error messages fo...

2018-05-23 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/21410 [SPARK-24366][SQL] Improving of error messages for type converting ## What changes were proposed in this pull request? Currently, users are getting the following error messages on type con

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21372 **[Test build #91024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91024/testReport)** for PR 21372 at commit [`954d1d9`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP P...

2018-05-23 Thread DazhuangSu
Github user DazhuangSu commented on a diff in the pull request: https://github.com/apache/spark/pull/19691#discussion_r190221738 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -495,6 +496,150 @@ class HiveDDLSuite }

[GitHub] spark pull request #21403: [SPARK-24341][WIP][SQL] Support IN subqueries wit...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21403#discussion_r190217120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -45,6 +46,10 @@ object RewritePredicateSubquery extend

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21406 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21406 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91023/ Test FAILed. ---

[GitHub] spark issue #21406: [Minor][Core] Cleanup unused vals in `DAGScheduler.handl...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21406 **[Test build #91023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91023/testReport)** for PR 21406 at commit [`567a7ff`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21403: [SPARK-24341][WIP][SQL] Support IN subqueries with struc...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21403 thanks @hvanhovell, sorry for the error. I changed to the right one. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apa

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-05-23 Thread wajda
Github user wajda commented on the issue: https://github.com/apache/spark/pull/21155 Any other comments on this one? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21409 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21409 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3504/ Tes

[GitHub] spark issue #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21409 **[Test build #91033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91033/testReport)** for PR 21409 at commit [`0f0908e`](https://github.com/apache/spark/commit/0f

[GitHub] spark pull request #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21409#discussion_r190207779 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala --- @@ -0,0 +1,128 @@ +/* + * Li

[GitHub] spark pull request #21409: [SPARK-24365][SQL] Add Parquet write benchmark

2018-05-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21409#discussion_r190207562 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteBenchmark.scala --- @@ -0,0 +1,128 @@ +/* + * Li

[GitHub] spark issue #21393: [SPARK-20114][ML][FOLLOW-UP] spark.ml parity for sequent...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21393 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91028/ Test PASSed. ---

[GitHub] spark issue #21393: [SPARK-20114][ML][FOLLOW-UP] spark.ml parity for sequent...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21393 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91027/ Test PASSed. ---

[GitHub] spark issue #21393: [SPARK-20114][ML][FOLLOW-UP] spark.ml parity for sequent...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21393 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21393: [SPARK-20114][ML][FOLLOW-UP] spark.ml parity for sequent...

2018-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21393 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21393: [SPARK-20114][ML][FOLLOW-UP] spark.ml parity for sequent...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21393 **[Test build #91028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91028/testReport)** for PR 21393 at commit [`6e0c59f`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #21393: [SPARK-20114][ML][FOLLOW-UP] spark.ml parity for sequent...

2018-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21393 **[Test build #91027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91027/testReport)** for PR 21393 at commit [`90d71e8`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP PARTITIO...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19691 @DazhuangSu may you also please address https://github.com/apache/spark/pull/19691/files#r179944192? Thanks. --- - To unsubscri

[GitHub] spark pull request #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP P...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19691#discussion_r190204871 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -495,6 +496,150 @@ class HiveDDLSuite } }

[GitHub] spark pull request #19691: [SPARK-14922][SPARK-17732][SQL]ALTER TABLE DROP P...

2018-05-23 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19691#discussion_r190205589 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -128,7 +128,7 @@ case class In

<    1   2   3   4   5   6   7   8   >