Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22826
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22852
the intention is not a we told you so, its meant to grab their attention
and to get people to think about it because in the end it is their
responsibility in my opinion.
I'm fine if you
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22826
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22815#discussion_r228554831
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -54,6 +54,7 @@ import org.apache.spark.sql.util.ExecutionListenerManager
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22848#discussion_r228553964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -89,12 +89,12 @@ private class LongLongTupleConverter extends
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22764
as @WeichenXu123 mentioned in
https://github.com/apache/spark/pull/22764#discussion_r228527916, I don't see
other problems with the current PR. The only thing is: do we want to target it
for 2.4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98091/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22852
**[Test build #98091 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98091/testReport)**
for PR 22852 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22852
I get it, the "it's your responsibility" stance, and it is. For any risk
there's a sentence in this doc we could point to and say, "see, told you". If
we're going to make a change here, adding
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22852
**[Test build #98091 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98091/testReport)**
for PR 22852 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/22852#discussion_r228544730
--- Diff: docs/security.md ---
@@ -6,7 +6,20 @@ title: Security
* This will become a table of contents (this text will be scraped).
{:toc}
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22775
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22775
Sure!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22775
thanks, merging to master! can you send a new PR for 2.4? it conflicts
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22723
Kind of. As you say it lets a particular `InputFormat` decide this. But it
still uses the minPartitions as input. See again
https://issues.apache.org/jira/browse/SPARK-22357 for some subtlety, and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98090/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user laskfla commented on the issue:
https://github.com/apache/spark/pull/22850
@HyukjinKwon ï¼I checked the file and looks like the others looks good.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22852
**[Test build #98090 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98090/testReport)**
for PR 22852 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22838
I merged to master/2.4 . The key parts here already passed individually.
---
-
To unsubscribe, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22852#discussion_r228536180
--- Diff: docs/security.md ---
@@ -6,7 +6,20 @@ title: Security
* This will become a table of contents (this text will be scraped).
{:toc}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22852#discussion_r228536280
--- Diff: docs/security.md ---
@@ -6,7 +6,20 @@ title: Security
* This will become a table of contents (this text will be scraped).
{:toc}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22852#discussion_r228535892
--- Diff: docs/security.md ---
@@ -6,7 +6,20 @@ title: Security
* This will become a table of contents (this text will be scraped).
{:toc}
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22838
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22852
**[Test build #98090 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98090/testReport)**
for PR 22852 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22852
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22852
@vanzin @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user tgravescs opened a pull request:
https://github.com/apache/spark/pull/22852
[SPARK-25023] Clarify Spark security documentation
## What changes were proposed in this pull request?
Clarify documentation about security.
## How was this patch tested?
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22830
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22830
**[Test build #98088 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98088/testReport)**
for PR 22830 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22029
**[Test build #98089 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98089/testReport)**
for PR 22029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22830
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22764#discussion_r228527916
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -225,13 +227,14 @@ object BisectingKMeansModel
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98083/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #98083 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98083/testReport)**
for PR 22771 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22850
**[Test build #98087 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98087/testReport)**
for PR 22850 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22850
Yea, I was aware of it. I think there are some more old comments in this
file if I remember this correctly. Can you double check and fix them while we
are here?
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22850
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r228520891
--- Diff: python/pyspark/sql/functions.py ---
@@ -2365,30 +2365,32 @@ def to_json(col, options={}):
@ignore_unicode_prefix
@since(2.4)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98084/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22830
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22029
**[Test build #98084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98084/testReport)**
for PR 22029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22830
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98082/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22830
**[Test build #98082 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98082/testReport)**
for PR 22830 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r228504453
--- Diff: python/pyspark/sql/functions.py ---
@@ -2365,30 +2365,32 @@ def to_json(col, options={}):
@ignore_unicode_prefix
@since(2.4)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22848
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22848
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98081/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22848
**[Test build #98081 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98081/testReport)**
for PR 22848 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22851
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98086/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22851
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22851
**[Test build #98086 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98086/testReport)**
for PR 22851 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22775#discussion_r228499222
--- Diff: python/pyspark/sql/functions.py ---
@@ -2365,30 +2365,32 @@ def to_json(col, options={}):
@ignore_unicode_prefix
@since(2.4)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22838
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22838
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4532/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22838
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22846
@cloud-fan PR for 2.3 is submitted. Please see #22851.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22847
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98080/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22838
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4532/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22847
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22851
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22847
**[Test build #98080 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98080/testReport)**
for PR 22847 at commit
GitHub user seancxmao opened a pull request:
https://github.com/apache/spark/pull/22851
[SPARK-25797][SQL][DOCS][BACKPORT-2.3] Add migration doc for solving issues
caused by view canonicalization approach change
## What changes were proposed in this pull request?
Since Spark
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22851
**[Test build #98086 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98086/testReport)**
for PR 22851 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22851
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22838
**[Test build #98085 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98085/testReport)**
for PR 22838 at commit
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22838#discussion_r228494668
--- Diff:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
---
@@ -103,4 +104,4 @@ then
properties=( ${properties[@]}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22666
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22850
cc @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22666
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98079/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22850
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22666
**[Test build #98079 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98079/testReport)**
for PR 22666 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98078/
Test PASSed.
---
GitHub user laskfla opened a pull request:
https://github.com/apache/spark/pull/22850
[MINOR][DOC] Fix comment error of HiveUtils
## What changes were proposed in this pull request?
Change the version number in comment of `HiveUtils.newClientForExecution`
from `13` to `1.2.1` .
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22775
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22775
**[Test build #98078 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98078/testReport)**
for PR 22775 at commit
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22846
@cloud-fan Sure, I will send a new PR for 2.3. Thanks you for review this.
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22846
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22846
LGTM, merging to master/2.4!
it conflicts with 2.3, can you send a new PR? thanks!
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22029#discussion_r228485894
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -212,27 +212,27 @@ object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22029
**[Test build #98084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98084/testReport)**
for PR 22029 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22847#discussion_r228483780
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -812,6 +812,17 @@ object SQLConf {
.intConf
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22029#discussion_r228483295
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -212,27 +212,27 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22029#discussion_r228482085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -212,27 +212,27 @@ object
Github user sandeep-katta commented on the issue:
https://github.com/apache/spark/pull/22824
cc @zsxwing @jose-torres @brkyvz
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r228470066
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/Utils.scala
---
@@ -27,4 +27,36 @@
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r228470004
--- Diff:
resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh
---
@@ -71,19 +71,36 @@ if [[ $IMAGE_TAG == "N/A" ]];
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r228469510
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/Utils.scala
---
@@ -27,4 +27,36 @@
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r228467937
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/IntegrationTestBackend.scala
---
301 - 400 of 485 matches
Mail list logo
