[GitHub] spark pull request #23031: [SPARK-26060][SQL] Track SparkConf entries and ma...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23031#discussion_r233986989 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala --- @@ -154,5 +154,9 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98879/ Test FAILed. ---

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23049 **[Test build #98879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98879/testReport)** for PR 23049 at commit

[GitHub] spark issue #23050: [SPARK-26079][sql] Ensure listener event delivery in Str...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23050 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23050: [SPARK-26079][sql] Ensure listener event delivery in Str...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23050 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23050: [SPARK-26079][sql] Ensure listener event delivery in Str...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23050 **[Test build #98886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98886/testReport)** for PR 23050 at commit

[GitHub] spark pull request #23050: [SPARK-26079][sql] Ensure listener event delivery...

2018-11-15 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/23050 [SPARK-26079][sql] Ensure listener event delivery in StreamingQueryListenersConfSuite. Events are dispatched on a separate thread, so need to wait for them to be actually delivered before

[GitHub] spark pull request #23042: [SPARK-26070][SQL] add rule for implicit type coe...

2018-11-15 Thread uzadude
Github user uzadude commented on a diff in the pull request: https://github.com/apache/spark/pull/23042#discussion_r233972629 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -138,6 +138,11 @@ object TypeCoercion {

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98874/ Test PASSed. ---

[GitHub] spark issue #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegrationSuite....

2018-11-15 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/23041 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98874/testReport)** for PR 22875 at commit

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98875/ Test PASSed. ---

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23044 **[Test build #98875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98875/testReport)** for PR 23044 at commit

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22911 **[Test build #98885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98885/testReport)** for PR 22911 at commit

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-11-15 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/22911 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22911 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98883/ Test PASSed. ---

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22911 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23026 **[Test build #98883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98883/testReport)** for PR 23026 at commit

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegrationSuite....

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23041 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegrationSuite....

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23041 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegrationSuite....

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23041 **[Test build #98884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98884/testReport)** for PR 23041 at commit

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22598 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98873/ Test PASSed. ---

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22598 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23041: [SPARK-26069][TESTS]Fix flaky test: RpcIntegrationSuite....

2018-11-15 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/23041 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22598 **[Test build #98873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98873/testReport)** for PR 22598 at commit

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23026 **[Test build #98883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98883/testReport)** for PR 23026 at commit

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23017 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98872/ Test PASSed. ---

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23017 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23026 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23026 LGTM. Will leave it up for a while in case anyone wants to comment. Also will re-trigger tests... not sure why integration tests didn't run. ---

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23017 **[Test build #98872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98872/testReport)** for PR 23017 at commit

[GitHub] spark pull request #23013: [SPARK-25023] More detailed security guidance for...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23013#discussion_r233960723 --- Diff: docs/running-on-kubernetes.md --- @@ -15,7 +15,19 @@ container images and entrypoints.** # Security Security in Spark is OFF by

[GitHub] spark pull request #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spa...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23017#discussion_r233960280 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23017 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spa...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23017#discussion_r233959468 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -53,5 +54,9 @@ COPY data /opt/spark/data ENV SPARK_HOME

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23043 @kiszk This spun out of https://issues.apache.org/jira/browse/SPARK-24834 and https://github.com/apache/spark/pull/21794 ; is that what you may be thinking of? I'm not aware of others. ---

[GitHub] spark pull request #23043: [SPARK-26021][SQL] replace minus zero with zero i...

2018-11-15 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23043#discussion_r233951725 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -56,17 +56,32 @@ case class

[GitHub] spark pull request #23043: [SPARK-26021][SQL] replace minus zero with zero i...

2018-11-15 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23043#discussion_r233951670 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala --- @@ -56,17 +56,32 @@ case class

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r233948762 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -598,13 +598,24 @@ private[yarn] class

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r233948023 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -598,13 +598,24 @@ private[yarn] class

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r233946890 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -598,13 +598,24 @@ private[yarn] class

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/23043 IIUC, we discussed handling `+0.0` and `-0.0` before in another PR. @srowen do you remember the previous discussion? --- - To

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/23044 LGTM, pending Jenkins --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98871/ Test PASSed. ---

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23013: [SPARK-25023] More detailed security guidance for K8S

2018-11-15 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/23013 @srowen I'm happy with it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23034 **[Test build #98871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98871/testReport)** for PR 23034 at commit

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98881/ Test PASSed. ---

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23026 **[Test build #98881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98881/testReport)** for PR 23026 at commit

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233934316 --- Diff: core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed to the

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23026 **[Test build #98881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98881/testReport)** for PR 23026 at commit

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233931731 --- Diff: core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #23026: [SPARK-25960][k8s] Support subpath mounting with Kuberne...

2018-11-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/23026 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22911 **[Test build #98880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98880/testReport)** for PR 22911 at commit

[GitHub] spark issue #22911: [SPARK-25815][k8s] Support kerberos in client mode, keyt...

2018-11-15 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22911 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23009: [SPARK-26011][SPARK-SUBMIT] Yarn mode pyspark app...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23009 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23024: [SPARK-26044][WEBUI]Aggregated Metrics table sort...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23024 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23009: [SPARK-26011][SPARK-SUBMIT] Yarn mode pyspark app withou...

2018-11-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23009 Merged to master/2.4/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23013: [SPARK-25023] More detailed security guidance for K8S

2018-11-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23013 @tgravescs @mccheah @rvesse is this pretty much OK with all of you? --- - To unsubscribe, e-mail:

[GitHub] spark issue #23024: [SPARK-26044][WEBUI]Aggregated Metrics table sort based ...

2018-11-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23024 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23049 **[Test build #98879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98879/testReport)** for PR 23049 at commit

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23049: [SPARK-26076][Build][Minor] Revise ambiguous error messa...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98877/ Test PASSed. ---

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23030 **[Test build #98877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98877/testReport)** for PR 23030 at commit

[GitHub] spark issue #23040: [SPARK-26068][Core]ChunkedByteBufferInputStream should h...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23040 **[Test build #98878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98878/testReport)** for PR 23040 at commit

[GitHub] spark issue #23040: [SPARK-26068][Core]ChunkedByteBufferInputStream should h...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23040 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23049: [SPARK-26076][Build][Minor] Revise ambiguous erro...

2018-11-15 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/23049#discussion_r233902416 --- Diff: bin/load-spark-env.sh --- @@ -47,8 +47,8 @@ if [ -z "$SPARK_SCALA_VERSION" ]; then

[GitHub] spark pull request #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatr...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16732#discussion_r233901615 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -275,22 +275,33 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r233901330 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -598,13 +598,24 @@ private[yarn] class

[GitHub] spark pull request #23049: [SPARK-26076][Build] Revise ambiguous error messa...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23049#discussion_r233900961 --- Diff: bin/load-spark-env.sh --- @@ -47,8 +47,8 @@ if [ -z "$SPARK_SCALA_VERSION" ]; then ASSEMBLY_DIR1="${SPARK_HOME}/assembly/target/scala-2.12"

[GitHub] spark issue #23049: [SPARK-26076][Build] Revise ambiguous error message from...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23049: [SPARK-26076][Build] Revise ambiguous error message from...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23049 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23030 **[Test build #98877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98877/testReport)** for PR 23030 at commit

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23030: [MINOR][YARN] Make memLimitExceededLogMessage more clean

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23030 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23049: [SPARK-26076][Build] Revise ambiguous error message from...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23049 **[Test build #98876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98876/testReport)** for PR 23049 at commit

[GitHub] spark issue #23049: [SPARK-26076][Build] Revise ambiguous error message from...

2018-11-15 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/23049 @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23049: [SPARK-26076][Build] Revise ambiguous error messa...

2018-11-15 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/23049 [SPARK-26076][Build] Revise ambiguous error message from load-spark-env.sh ## What changes were proposed in this pull request? When I try to run scripts (e.g.

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233898001 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23044 **[Test build #98875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98875/testReport)** for PR 23044 at commit

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233888412 --- Diff: core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed to the

[GitHub] spark pull request #22974: [SPARK-22450][WIP][Core][MLLib][FollowUp] Safely ...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22974 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23030: [MINOR][YARN] Make memLimitExceededLogMessage mor...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23030#discussion_r233887452 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala --- @@ -378,14 +380,16 @@ class YarnAllocatorSuite

[GitHub] spark issue #22974: [SPARK-22450][WIP][Core][MLLib][FollowUp] Safely registe...

2018-11-15 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22974 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatr...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16732#discussion_r233879857 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -275,22 +275,33 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark pull request #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatr...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16732#discussion_r233879830 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -275,22 +275,33 @@ class BlockMatrix @Since("1.3.0") (

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23046 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98867/ Test PASSed. ---

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23046 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23046 **[Test build #98867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98867/testReport)** for PR 23046 at commit

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23045#discussion_r233873941 --- Diff: docs/sql-migration-guide-upgrade.md --- @@ -17,6 +17,8 @@ displayTitle: Spark SQL Upgrading Guide - The `ADD JAR` command previously

<    1   2   3   4   5   >