[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #98874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98874/testReport)** for PR 22875 at commit [`6e2d501`](https://github.com/apache/spark/commit/6e

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233871529 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Softw

[GitHub] spark pull request #22947: [SPARK-24913][SQL] Make AssertNotNull and AssertT...

2018-11-15 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22947#discussion_r233871089 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -66,6 +66,8 @@ case class AssertTrue(child: Expression)

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233870838 --- Diff: core/pom.xml --- @@ -408,6 +408,19 @@ provided +

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233870430 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to th

[GitHub] spark issue #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatrix() op...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16732 **[Test build #4426 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4426/testReport)** for PR 16732 at commit [`5531806`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #23048: transform DenseVector x DenseVector sqdist from i...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23048#discussion_r233866690 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala --- @@ -370,14 +370,19 @@ object Vectors { case (v1: DenseVector, v2

[GitHub] spark issue #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatrix() op...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16732 **[Test build #4426 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4426/testReport)** for PR 16732 at commit [`5531806`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #23048: transform DenseVector x DenseVector sqdist from imperati...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23048 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23048: transform DenseVector x DenseVector sqdist from imperati...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23048 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/23046 I searched the code and didn't find similar issues, so this is the only one shall be fixed. --- - To unsubscribe, e-mail: re

[GitHub] spark issue #22598: [SPARK-25501][SS] Add kafka delegation token support.

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22598 **[Test build #98873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98873/testReport)** for PR 22598 at commit [`b4541cd`](https://github.com/apache/spark/commit/b4

[GitHub] spark issue #23048: transform DenseVector x DenseVector sqdist from imperati...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23048 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23048: transform DenseVector x DenseVector sqdist from i...

2018-11-15 Thread beckgael
GitHub user beckgael opened a pull request: https://github.com/apache/spark/pull/23048 transform DenseVector x DenseVector sqdist from imperativ to function… …al tailrec style which improves performance well on low and medium dim vectors ## What changes were proposed in

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/23017 > noted test issue. let's kick off test though @felixcheung This is now resolved, please kick off a retest when you get chance --- -

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/23017 Resolved the issue with the client mode test. The test itself was actually badly written in that it used the Spark images but overrode the entry point which avoided the logic that sets up the `/etc/

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233858832 --- Diff: core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233858781 --- Diff: core/src/test/scala/org/apache/spark/deploy/security/KafkaTokenUtilSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233858643 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Softw

[GitHub] spark issue #23017: [WIP][SPARK-26015][K8S] Set a default UID for Spark on K...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23017 **[Test build #98872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98872/testReport)** for PR 23017 at commit [`a9e59b3`](https://github.com/apache/spark/commit/a9

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233858735 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Softw

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233858687 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Softw

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233858574 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to th

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-15 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r233857377 --- Diff: core/pom.xml --- @@ -408,6 +408,19 @@ provided +

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23045 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23045 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98866/ Test FAILed. ---

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23045 **[Test build #98866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98866/testReport)** for PR 23045 at commit [`3ff0cd5`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98868/ Test FAILed. ---

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23044 **[Test build #98868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98868/testReport)** for PR 23044 at commit [`786cd4d`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatrix() op...

2018-11-15 Thread akaltsikis
Github user akaltsikis commented on the issue: https://github.com/apache/spark/pull/16732 > After running some more experiments I was able to reduce the runtime by another 1.5x factor. So currently the "toCoordinateMatrix().toIndexedRowMatrix()" is better by a bit only in the extreme

[GitHub] spark pull request #22989: [SPARK-25986][Build] Add rules to ban throw Error...

2018-11-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22989#discussion_r233842829 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -39,7 +39,9 @@ public static int getSize(Object object, long of

[GitHub] spark issue #23047: [BACKPORT][SPARK-25883][SQL][MINOR] Override method `pre...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23047 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23047: [BACKPORT][SPARK-25883][SQL][MINOR] Override method `pre...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23047 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98870/ Test PASSed. ---

[GitHub] spark issue #23047: [BACKPORT][SPARK-25883][SQL][MINOR] Override method `pre...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23047 **[Test build #98870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98870/testReport)** for PR 23047 at commit [`3323fdb`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5053/

[GitHub] spark issue #23047: [BACKPORT][SPARK-25883][SQL][MINOR] Override method `pre...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23047 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23047: [BACKPORT][SPARK-25883][SQL][MINOR] Override method `pre...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23047 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5052/

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98865/ Test PASSed. ---

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23034 **[Test build #98865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98865/testReport)** for PR 23034 at commit [`c542b8d`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23034 **[Test build #98871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98871/testReport)** for PR 23034 at commit [`8c539a4`](https://github.com/apache/spark/commit/8c

[GitHub] spark issue #23047: [SPARK-25883][SQL][MINOR] Override method `prettyName` i...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23047 **[Test build #98870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98870/testReport)** for PR 23047 at commit [`3323fdb`](https://github.com/apache/spark/commit/33

[GitHub] spark pull request #23047: [SPARK-25883][SQL][MINOR] Override method `pretty...

2018-11-15 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/23047 [SPARK-25883][SQL][MINOR] Override method `prettyName` in `from_avro`/`to_avro` ## What changes were proposed in this pull request? Previously in from_avro/to_avro, we override the m

[GitHub] spark issue #22890: [SPARK-25883][SQL][Minor] Override method `prettyName` i...

2018-11-15 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22890 This PR turn out to be a bug fix for this issue: https://issues.apache.org/jira/browse/SPARK-26063 Back port this to branch-2.4. ---

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98869/ Test FAILed. ---

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23034 **[Test build #98869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98869/testReport)** for PR 23034 at commit [`86faf79`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23034 **[Test build #98869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98869/testReport)** for PR 23034 at commit [`86faf79`](https://github.com/apache/spark/commit/86

[GitHub] spark issue #23034: [SPARK-26035][PYTHON] Break large streaming/tests.py fil...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5051/

[GitHub] spark pull request #23034: [SPARK-26035][PYTHON] Break large streaming/tests...

2018-11-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23034#discussion_r233829511 --- Diff: python/pyspark/testing/streamingutils.py --- @@ -0,0 +1,189 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] spark issue #23034: [WIP][SPARK-26035][PYTHON] Break large streaming/tests.p...

2018-11-15 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23034 Will go and merge this tomorrow if there's no outstanding issues. cc @zsxwing and @tdas. --- - To unsubscribe, e-ma

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23044#discussion_r233827093 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -76,8 +76,6 @@ object GenerateOrdering

[GitHub] spark issue #23000: [SPARK-26002][SQL] Fix day of year calculation for Julia...

2018-11-15 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/23000 ping @10110346 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #23038: [SPARK-25451][CORE][WEBUI]Aggregated metrics table doesn...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22974: [SPARK-22450][WIP][Core][MLLib][FollowUp] Safely registe...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22974 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23038: [SPARK-25451][CORE][WEBUI]Aggregated metrics table doesn...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98863/ Test PASSed. ---

[GitHub] spark issue #22974: [SPARK-22450][WIP][Core][MLLib][FollowUp] Safely registe...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22974 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98864/ Test PASSed. ---

[GitHub] spark issue #23038: [SPARK-25451][CORE][WEBUI]Aggregated metrics table doesn...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23038 **[Test build #98863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98863/testReport)** for PR 23038 at commit [`c53ca48`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #22974: [SPARK-22450][WIP][Core][MLLib][FollowUp] Safely registe...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22974 **[Test build #98864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98864/testReport)** for PR 22974 at commit [`ec9b83f`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #23029: [SPARK-26055][CORE] InterfaceStability annotation...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23029 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23029: [SPARK-26055][CORE] InterfaceStability annotations shoul...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23029 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22989: [SPARK-25986][Build] Add rules to ban throw Error...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22989#discussion_r233821654 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/UnsafeAlignedOffset.java --- @@ -39,7 +39,9 @@ public static int getSize(Object object, long

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 This only works for attribute, not literal or intermedia result. Is there a better place to fix it? --- - To unsubscribe, e-ma

[GitHub] spark issue #23040: [SPARK-26068][Core]ChunkedByteBufferInputStream should h...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23040 It's good to fix a potential bug, can you add a unit test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org F

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23044 **[Test build #98868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98868/testReport)** for PR 23044 at commit [`786cd4d`](https://github.com/apache/spark/commit/78

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23044 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23044 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spa

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23044#discussion_r233819066 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -76,8 +76,6 @@ object GenerateOrder

[GitHub] spark pull request #23035: [SPARK-26057][SQL] Transform also analyzed plans ...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23035 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23046 good catch! LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #23035: [SPARK-26057][SQL] Transform also analyzed plans when de...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23035 thanks, merging to master/2.4! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark pull request #23042: [SPARK-26070][SQL] add rule for implicit type coe...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23042#discussion_r233816966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -138,6 +138,11 @@ object TypeCoercion { c

[GitHub] spark issue #23031: [SPARK-26060][SQL] Track SparkConf entries and make SET ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23031 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23031: [SPARK-26060][SQL] Track SparkConf entries and make SET ...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23031 **[Test build #98862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98862/testReport)** for PR 23031 at commit [`37ebae4`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #23031: [SPARK-26060][SQL] Track SparkConf entries and make SET ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98862/ Test PASSed. ---

[GitHub] spark issue #23035: [SPARK-26057][SQL] Transform also analyzed plans when de...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23035 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98861/ Test PASSed. ---

[GitHub] spark issue #23035: [SPARK-26057][SQL] Transform also analyzed plans when de...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23035 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23046 **[Test build #98867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98867/testReport)** for PR 23046 at commit [`d8db5f3`](https://github.com/apache/spark/commit/d8

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23046 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5050/

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23046 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRad...

2018-11-15 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/23046 cc @jiangxb1987 @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark pull request #23046: [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.en...

2018-11-15 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/23046 [SPARK-23207][SQL][FOLLOW-UP] Use `SQLConf.get.enableRadixSort` instead of `SparkEnv.get.conf.get(SQLConf.RADIX_SORT_ENABLED)`. ## What changes were proposed in this pull request? This is a

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5049/

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23045 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23045 **[Test build #98866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98866/testReport)** for PR 23045 at commit [`3ff0cd5`](https://github.com/apache/spark/commit/3f

[GitHub] spark issue #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23045 cc @gatorsmile @dongjoon-hyun @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comman

[GitHub] spark pull request #23045: [SPARK-26071][SQL] disallow map as map key

2018-11-15 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/23045 [SPARK-26071][SQL] disallow map as map key ## What changes were proposed in this pull request? Due to implementation limitation, currently Spark can't compare or do equality check betwee

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23044 cc @cloud-fan, @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23044 [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as we don't use it anymore ## What changes were proposed in this pull request? remove invalid comment as we don't use it anymore

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23044 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22976: [SPARK-25974][SQL]Optimizes Generates bytecode for order...

2018-11-15 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22976 thanks, All @cloud-fan, @rednaxelafx, @viirya, @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org F

[GitHub] spark issue #23040: [SPARK-26068][Core]ChunkedByteBufferInputStream should h...

2018-11-15 Thread LinhongLiu
Github user LinhongLiu commented on the issue: https://github.com/apache/spark/pull/23040 Problem: ChunkedByteBuffer has signature `ChunkedByteBuffer(var chunks: Array[ByteBuffer])`. This means user is allowed to pass any kind of `chunks` to it. Then we will face the problem descr

[GitHub] spark pull request #22976: [SPARK-25974][SQL]Optimizes Generates bytecode fo...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22976 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22976: [SPARK-25974][SQL]Optimizes Generates bytecode fo...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22976#discussion_r233787377 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -133,30 +126,26 @@ object GenerateO

[GitHub] spark issue #22976: [SPARK-25974][SQL]Optimizes Generates bytecode for order...

2018-11-15 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22976 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

<    1   2   3   4   5   >