[GitHub] spark issue #23088: [SPARK-26119][CORE][WEBUI]Task summary table should cont...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23088 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23088: [SPARK-26119][CORE][WEBUI]Task summary table shou...

2018-11-21 Thread shahidki31
GitHub user shahidki31 reopened a pull request: https://github.com/apache/spark/pull/23088 [SPARK-26119][CORE][WEBUI]Task summary table should contain only successful tasks' metrics ## What changes were proposed in this pull request? Task summary table in the stage page

[GitHub] spark issue #23053: [SPARK-25957][K8S] Make building alternate language bind...

2018-11-21 Thread ramaddepally
Github user ramaddepally commented on the issue: https://github.com/apache/spark/pull/23053 > > Probably also want to update `docs/running-on-kubernetes.md` to make it clear that you now have to opt into building the additional language bindings > > @rvesse ... Actually, the

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99128/ Test FAILed. ---

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23105 **[Test build #99128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99128/testReport)** for PR 23105 at commit

[GitHub] spark issue #23053: [SPARK-25957][K8S] Make building alternate language bind...

2018-11-21 Thread ramaddepally
Github user ramaddepally commented on the issue: https://github.com/apache/spark/pull/23053 > Probably also want to update `docs/running-on-kubernetes.md` to make it clear that you now have to opt into building the additional language bindings @rvesse ... Actually, the usage

[GitHub] spark issue #21465: [SPARK-24333][ML][PYTHON]Add fit with validation set to ...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21465 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21465: [SPARK-24333][ML][PYTHON]Add fit with validation set to ...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21465 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99136/ Test PASSed. ---

[GitHub] spark issue #21465: [SPARK-24333][ML][PYTHON]Add fit with validation set to ...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21465 **[Test build #99136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99136/testReport)** for PR 21465 at commit

[GitHub] spark issue #21465: [SPARK-24333][ML][PYTHON]Add fit with validation set to ...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21465 **[Test build #99136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99136/testReport)** for PR 21465 at commit

[GitHub] spark issue #21465: [SPARK-24333][ML][PYTHON]Add fit with validation set to ...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21465 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21465: [SPARK-24333][ML][PYTHON]Add fit with validation set to ...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21465 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21465: [SPARK-24333][ML][PYTHON]Add fit with validation ...

2018-11-21 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21465#discussion_r235488017 --- Diff: python/pyspark/ml/classification.py --- @@ -1176,8 +1176,8 @@ def trees(self): @inherit_doc class GBTClassifier(JavaEstimator,

[GitHub] spark issue #23103: [SPARK-26121] [Structured Streaming] Allow users to defi...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23103 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99134/ Test PASSed. ---

[GitHub] spark issue #23103: [SPARK-26121] [Structured Streaming] Allow users to defi...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23103 **[Test build #99134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99134/testReport)** for PR 23103 at commit

[GitHub] spark issue #23103: [SPARK-26121] [Structured Streaming] Allow users to defi...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23103 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99127/ Test FAILed. ---

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21688 **[Test build #99127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99127/testReport)** for PR 21688 at commit

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

2018-11-21 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/23081 Thank you @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...

2018-11-21 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23103#discussion_r235480695 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -538,6 +538,17 @@ private[kafka010]

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22938 LGTM except the migration guide. JSON data source can't produce null rows, but skip it even with permisive mode. --- - To

[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...

2018-11-21 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23103#discussion_r235479872 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -538,6 +538,17 @@ private[kafka010]

[GitHub] spark issue #23103: [SPARK-26121] [Structured Streaming] Allow users to defi...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23103 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23086: [SPARK-25528][SQL] data source v2 API refactor (batch re...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23086 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23103: [SPARK-26121] [Structured Streaming] Allow users to defi...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23103 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23086: [SPARK-25528][SQL] data source v2 API refactor (batch re...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23086 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23054: [SPARK-26085][SQL] Key attribute of non-struct type unde...

2018-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23054 hmmm it conflicts again... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...

2018-11-21 Thread zouzias
Github user zouzias commented on a diff in the pull request: https://github.com/apache/spark/pull/23103#discussion_r235478266 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -538,6 +538,17 @@ private[kafka010] object

[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...

2018-11-21 Thread zouzias
Github user zouzias commented on a diff in the pull request: https://github.com/apache/spark/pull/23103#discussion_r235478048 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -538,6 +538,17 @@ private[kafka010] object

[GitHub] spark issue #23086: [SPARK-25528][SQL] data source v2 API refactor (batch re...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23086 **[Test build #99135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99135/testReport)** for PR 23086 at commit

[GitHub] spark issue #23103: [SPARK-26121] [Structured Streaming] Allow users to defi...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23103 **[Test build #99134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99134/testReport)** for PR 23103 at commit

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #23095: [SPARK-23886][SS] Update query status for Continu...

2018-11-21 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/23095#discussion_r235473858 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala --- @@ -117,6 +117,7 @@ class

[GitHub] spark issue #23099: [SPARK-25954][SS] Upgrade to Kafka 2.1.0

2018-11-21 Thread ijuma
Github user ijuma commented on the issue: https://github.com/apache/spark/pull/23099 Amazingly fast update, nice one. :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #23086: [SPARK-25528][SQL] data source v2 API refactor (b...

2018-11-21 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/23086#discussion_r235470285 --- Diff: project/MimaExcludes.scala --- @@ -149,7 +149,8 @@ object MimaExcludes {

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #99133 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99133/testReport)** for PR 22875 at commit

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99132/testReport)** for PR 23043 at commit

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22875 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/23043 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23039 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23039 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99121/ Test PASSed. ---

[GitHub] spark issue #23039: [SPARK-26066][SQL] Move truncatedString to sql/catalyst ...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23039 **[Test build #99121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99121/testReport)** for PR 23039 at commit

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99123/ Test FAILed. ---

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22875: [SPARK-25867][ML] Remove KMeans computeCost

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22875 **[Test build #99123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99123/testReport)** for PR 22875 at commit

[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...

2018-11-21 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23103#discussion_r235462394 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -538,6 +538,17 @@ private[kafka010]

[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...

2018-11-21 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23103#discussion_r235461374 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -538,6 +538,17 @@ private[kafka010]

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pyspark.me...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99120/ Test PASSed. ---

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pyspark.me...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23055 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pyspark.me...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23055 **[Test build #99120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99120/testReport)** for PR 23055 at commit

[GitHub] spark issue #23106: [SPARK-26141] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23106 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99130/ Test FAILed. ---

[GitHub] spark issue #23106: [SPARK-26141] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23106 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23106: [SPARK-26141] Enable custom metrics implementation in sh...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23106 **[Test build #99130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99130/testReport)** for PR 23106 at commit

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasou...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23080 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasou...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99122/ Test PASSed. ---

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23105 **[Test build #99131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99131/testReport)** for PR 23105 at commit

[GitHub] spark issue #23106: [SPARK-26141] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23106 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23106: [SPARK-26141] Enable custom metrics implementation in sh...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23106 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23106: [SPARK-26141] Enable custom metrics implementation in sh...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23106 **[Test build #99130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99130/testReport)** for PR 23106 at commit

[GitHub] spark issue #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasou...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23080 **[Test build #99122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99122/testReport)** for PR 23080 at commit

[GitHub] spark pull request #23106: [SPARK-26141] Enable custom shuffle metrics imple...

2018-11-21 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/23106 [SPARK-26141] Enable custom shuffle metrics implementation in shuffle write ## What changes were proposed in this pull request? This is the write side counterpart to

[GitHub] spark issue #23105: [SPARK-26140] Enable custom metrics implementation in sh...

2018-11-21 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/23105 cc @jiangxb1987 @squito --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21308: [SPARK-24253][SQL] Add DeleteSupport mix-in for DataSour...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21308 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21308: [SPARK-24253][SQL] Add DeleteSupport mix-in for DataSour...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21308 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23096 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23062: [SPARK-8288][SQL] ScalaReflection can use compani...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23062 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23096: [SPARK-26129][SQL] Instrumentation for per-query plannin...

2018-11-21 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/23096 Merging this. Feel free to leave more comments. I'm hoping we can wire this into the UI eventually. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23062: [SPARK-8288][SQL] ScalaReflection can use companion obje...

2018-11-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23062 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23081: [SPARK-26109][WebUI]Duration in the task summary ...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23081 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #23088: [SPARK-26119][CORE][WEBUI]Task summary table should cont...

2018-11-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23088 When evaluating these things I use git blame (or visual tools here and in an IDE) to figure out if there was a previous change that explicitly tried to change the behavior, and whether it was on

[GitHub] spark issue #23081: [SPARK-26109][WebUI]Duration in the task summary metrics...

2018-11-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23081 Merged to master/2.4/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22822: [SPARK-25678] Requesting feedback regarding a prototype ...

2018-11-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22822 Yeah, I can't imagine merging support for any other resource manager I know of now; it's just way too much to maintain. I have not heard of this one myself. It should be implemented outside Spark.

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23096: [SPARK-26129][SQL] Instrumentation for per-query plannin...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23096 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23043 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99119/ Test FAILed. ---

[GitHub] spark issue #23096: [SPARK-26129][SQL] Instrumentation for per-query plannin...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23096 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99118/ Test PASSed. ---

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23043 **[Test build #99119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99119/testReport)** for PR 23043 at commit

[GitHub] spark issue #23096: [SPARK-26129][SQL] Instrumentation for per-query plannin...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23096 **[Test build #99118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99118/testReport)** for PR 23096 at commit

[GitHub] spark issue #23105: [SPARK-26140] Enable passing in a custom shuffle metrics...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23105 **[Test build #99129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99129/testReport)** for PR 23105 at commit

[GitHub] spark issue #23105: [SPARK-26140] Enable passing in a custom shuffle metrics...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23105: [SPARK-26140] Enable passing in a custom shuffle metrics...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasou...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99117/ Test PASSed. ---

[GitHub] spark issue #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasou...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23080 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23105: [SPARK-26140] Enable passing in a custom shuffle metrics...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23080: [SPARK-26108][SQL] Support custom lineSep in CSV datasou...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23080 **[Test build #99117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99117/testReport)** for PR 23080 at commit

[GitHub] spark issue #23105: [SPARK-26140] Enable passing in a custom shuffle metrics...

2018-11-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23105 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23105: [SPARK-26140] Enable passing in a custom shuffle metrics...

2018-11-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23105 **[Test build #99128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99128/testReport)** for PR 23105 at commit

[GitHub] spark pull request #23105: [SPARK-26140] Enable passing in a custom shuffle ...

2018-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r235420647 --- Diff: core/src/main/scala/org/apache/spark/executor/ShuffleReadMetrics.scala --- @@ -122,34 +123,3 @@ class ShuffleReadMetrics private[spark] () extends

[GitHub] spark pull request #23105: [SPARK-26140] Pull TempShuffleReadMetrics creatio...

2018-11-21 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/23105 [SPARK-26140] Pull TempShuffleReadMetrics creation out of shuffle reader ## What changes were proposed in this pull request? This patch defines an internal Spark interface for reporting shuffle

[GitHub] spark pull request #23098: [WIP][SPARK-26132][BUILD][CORE] Remove support fo...

2018-11-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23098#discussion_r235418193 --- Diff: bin/load-spark-env.cmd --- @@ -21,37 +21,42 @@ rem This script loads spark-env.cmd if it exists, and ensures it is only loaded rem

[GitHub] spark pull request #22305: [SPARK-24561][SQL][Python] User-defined window ag...

2018-11-21 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/22305#discussion_r235417425 --- Diff: python/pyspark/worker.py --- @@ -154,6 +154,47 @@ def wrapped(*series): return lambda *a: (wrapped(*a), arrow_return_type)

[GitHub] spark issue #23052: [SPARK-26081][SQL] Prevent empty files for empty partiti...

2018-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23052 Also, it's not always for Parquet to write empty files. That does not write empty files when data frames are created from emptyRDD (the one pointed out in the PR link I gave). We should match

[GitHub] spark issue #23101: [SPARK-26134][CORE] Upgrading Hadoop to 2.7.4 to fix jav...

2018-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23101 LGTM2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

<    1   2   3   4   5   6   7   >