[GitHub] mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT

2019-02-15 Thread GitBox
mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT URL: https://github.com/apache/spark/pull/23773#discussion_r257304015 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#issuecomment-464112939 Can one of the admins verify this patch?

[GitHub] AmplabJenkins commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#issuecomment-464113113 Can one of the admins verify this patch?

[GitHub] peter-toth commented on a change in pull request #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
peter-toth commented on a change in pull request #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#discussion_r257303536 ## File path:

[GitHub] attilapiros commented on a change in pull request #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
attilapiros commented on a change in pull request #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799#discussion_r257304118 ## File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala

[GitHub] AmplabJenkins commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#issuecomment-464112939 Can one of the admins verify this patch?

[GitHub] peter-toth commented on a change in pull request #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
peter-toth commented on a change in pull request #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#discussion_r257303536 ## File path:

[GitHub] SparkQA commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
SparkQA commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464111511 **[Test build #102397 has

[GitHub] AmplabJenkins commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#issuecomment-464111400 Can one of the admins verify this patch?

[GitHub] peter-toth commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
peter-toth commented on issue #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802#issuecomment-464111482 cc. @mgaido91 @cloud-fan as you worked on https://github.com/apache/spark/pull/22518

[GitHub] AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464110853 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464110859 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] peter-toth opened a new pull request #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source

2019-02-15 Thread GitBox
peter-toth opened a new pull request #23802: [SPARK-26893][SQL] Allow pushdown of partition pruning subquery filters to file source URL: https://github.com/apache/spark/pull/23802 ## What changes were proposed in this pull request? This PR introduces leveraging of subquery filters

[GitHub] AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464110859 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464110853 Merged build finished. Test PASSed.

[GitHub] srowen commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT

2019-02-15 Thread GitBox
srowen commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT URL: https://github.com/apache/spark/pull/23773#discussion_r257298566 ## File path:

[GitHub] SparkQA commented on issue #23778: [SPARK-24935][SQL] : Problem with Executing Hive UDF's from Spark 2.2 Onwards

2019-02-15 Thread GitBox
SparkQA commented on issue #23778: [SPARK-24935][SQL] : Problem with Executing Hive UDF's from Spark 2.2 Onwards URL: https://github.com/apache/spark/pull/23778#issuecomment-464099508 **[Test build #102396 has

[GitHub] AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464093655 Can one of the admins verify this patch?

[GitHub] AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464098820 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464098824 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464098824 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] SparkQA removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
SparkQA removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464092239 **[Test build #102395 has

[GitHub] AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464098820 Merged build finished. Test PASSed. This is

[GitHub] SparkQA commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
SparkQA commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464098729 **[Test build #102395 has

[GitHub] AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464093896 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464093902 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464093896 Merged build finished. Test PASSed. This is

[GitHub] AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464093902 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464093655 Can one of the admins verify this patch? This

[GitHub] SparkQA commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
SparkQA commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464092239 **[Test build #102395 has

[GitHub] attilapiros opened a new pull request #23801: [SPARK-26891][YARN] Fixing flaky test YarnSchedulerBackendSuite

2019-02-15 Thread GitBox
attilapiros opened a new pull request #23801: [SPARK-26891][YARN] Fixing flaky test YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801 ## What changes were proposed in this pull request? The test "RequestExecutors reflects node blacklist and is serializable"

[GitHub] mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT

2019-02-15 Thread GitBox
mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT URL: https://github.com/apache/spark/pull/23773#discussion_r257274678 ## File path:

[GitHub] mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT

2019-02-15 Thread GitBox
mgaido91 commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT URL: https://github.com/apache/spark/pull/23773#discussion_r257274678 ## File path:

[GitHub] IvanVergiliev commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
IvanVergiliev commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464086652 The test failures appear relevant; I’ll take a look in a bit.

[GitHub] cloud-fan commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
cloud-fan commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464085317 LGTM This is an automated

[GitHub] AmplabJenkins removed a comment on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464084174 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] AmplabJenkins removed a comment on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464084163 Merged build finished. Test PASSed.

[GitHub] cloud-fan commented on a change in pull request #23304: [SPARK-26353][SQL]Add typed aggregate functions(max/min) to the example module.

2019-02-15 Thread GitBox
cloud-fan commented on a change in pull request #23304: [SPARK-26353][SQL]Add typed aggregate functions(max/min) to the example module. URL: https://github.com/apache/spark/pull/23304#discussion_r257271503 ## File path:

[GitHub] SparkQA commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
SparkQA commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464084848 **[Test build #102394 has

[GitHub] AmplabJenkins commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464084163 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464084174 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] gengliangwang commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
gengliangwang commented on issue #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800#issuecomment-464083240 @cloud-fan This is

[GitHub] gengliangwang opened a new pull request #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory

2019-02-15 Thread GitBox
gengliangwang opened a new pull request #23800: [SPARK-26673][SQL] File source V2: remove duplicated broadcast object in FileWriterFactory URL: https://github.com/apache/spark/pull/23800 ## What changes were proposed in this pull request? This is a followup PR to fix two issues in

[GitHub] viirya commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT

2019-02-15 Thread GitBox
viirya commented on a change in pull request #23773: [SPARK-26721][ML] Avoid per-tree normalization in featureImportance for GBT URL: https://github.com/apache/spark/pull/23773#discussion_r257269300 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable URL: https://github.com/apache/spark/pull/23670#issuecomment-464082346 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable URL: https://github.com/apache/spark/pull/23670#issuecomment-464082357 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable URL: https://github.com/apache/spark/pull/23670#issuecomment-464082346 Merged build finished. Test PASSed. This is

[GitHub] AmplabJenkins commented on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable URL: https://github.com/apache/spark/pull/23670#issuecomment-464082357 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] SparkQA removed a comment on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable

2019-02-15 Thread GitBox
SparkQA removed a comment on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable URL: https://github.com/apache/spark/pull/23670#issuecomment-463996394 **[Test build #102387 has

[GitHub] SparkQA commented on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable

2019-02-15 Thread GitBox
SparkQA commented on issue #23670: [SPARK-26601][SQL] Make broadcast-exchange thread pool configurable URL: https://github.com/apache/spark/pull/23670#issuecomment-464081628 **[Test build #102387 has

[GitHub] cloud-fan commented on a change in pull request #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
cloud-fan commented on a change in pull request #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#discussion_r257267867 ## File path: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala

[GitHub] AmplabJenkins removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464076992 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464076987 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464076992 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464076987 Merged build finished. Test FAILed.

[GitHub] SparkQA removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
SparkQA removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464015769 **[Test build #102389 has

[GitHub] SparkQA commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
SparkQA commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464076665 **[Test build #102389 has

[GitHub] cloud-fan removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
cloud-fan removed a comment on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464075777 LGTM except one comment: https://github.com/apache/spark/pull/23766/files#r256712722

[GitHub] cloud-fan commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
cloud-fan commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464075777 LGTM except one comment: https://github.com/apache/spark/pull/23766/files#r256712722

[GitHub] SparkQA commented on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
SparkQA commented on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#issuecomment-464066276 **[Test build #102393 has

[GitHub] cloud-fan commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer

2019-02-15 Thread GitBox
cloud-fan commented on issue #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#issuecomment-464074842 LGTM except one comment: https://github.com/apache/spark/pull/23766/files#r256712722

[GitHub] liupc edited a comment on issue #23794: [SPARK-26884][CORE] Let task acquire memory accurately when using spilled memory

2019-02-15 Thread GitBox
liupc edited a comment on issue #23794: [SPARK-26884][CORE] Let task acquire memory accurately when using spilled memory URL: https://github.com/apache/spark/pull/23794#issuecomment-464073358 I think we acquire the amount of memory it needed no matter whether can be satisfied is what we

[GitHub] liupc commented on issue #23794: [SPARK-26884][CORE] Let task acquire memory accurately when using spilled memory

2019-02-15 Thread GitBox
liupc commented on issue #23794: [SPARK-26884][CORE] Let task acquire memory accurately when using spilled memory URL: https://github.com/apache/spark/pull/23794#issuecomment-464073358 I think we acquire the amount of memory it needed no mater whether can be satisfied is what we need

[GitHub] AmplabJenkins commented on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#issuecomment-464065684 Merged build finished. Test PASSed.

[GitHub] cloud-fan commented on a change in pull request #21149: [SPARK-24076][SQL] Use different seed in HashAggregate to avoid hash conflict

2019-02-15 Thread GitBox
cloud-fan commented on a change in pull request #21149: [SPARK-24076][SQL] Use different seed in HashAggregate to avoid hash conflict URL: https://github.com/apache/spark/pull/21149#discussion_r257259176 ## File path:

[GitHub] liupc commented on a change in pull request #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
liupc commented on a change in pull request #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#discussion_r257248456 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#issuecomment-464065684 Merged build finished. Test PASSed.

[GitHub] liupc commented on a change in pull request #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
liupc commented on a change in pull request #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#discussion_r257249731 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#issuecomment-464065693 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23602: [SPARK-26674][CORE]Consolidate CompositeByteBuf when reading large frame URL: https://github.com/apache/spark/pull/23602#issuecomment-464065693 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] mgaido91 commented on issue #23785: [SPARK-26860][PySpark] Fix for RangeBetween docs appear to be wrong

2019-02-15 Thread GitBox
mgaido91 commented on issue #23785: [SPARK-26860][PySpark] Fix for RangeBetween docs appear to be wrong URL: https://github.com/apache/spark/pull/23785#issuecomment-464060410 I see now, I actually initially said to fill the "JIRA description" but I meant "PR description", I noticed my

[GitHub] AmplabJenkins removed a comment on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799#issuecomment-464058101 Can one of the admins verify this patch?

[GitHub] AmplabJenkins removed a comment on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799#issuecomment-464059341 Can one of the admins verify this patch?

[GitHub] AmplabJenkins commented on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799#issuecomment-464059492 Can one of the admins verify this patch?

[GitHub] AmplabJenkins commented on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799#issuecomment-464059341 Can one of the admins verify this patch?

[GitHub] srowen commented on issue #23785: [SPARK-26860][PySpark] Fix for RangeBetween docs appear to be wrong

2019-02-15 Thread GitBox
srowen commented on issue #23785: [SPARK-26860][PySpark] Fix for RangeBetween docs appear to be wrong URL: https://github.com/apache/spark/pull/23785#issuecomment-464058367 I think that's my fault; I read your comment as suggesting the JIRA but I don't see that on re-reading it. Disregard

[GitHub] AmplabJenkins commented on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799#issuecomment-464058101 Can one of the admins verify this patch?

[GitHub] liupc opened a new pull request #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present

2019-02-15 Thread GitBox
liupc opened a new pull request #23799: [SPARK-26892]Fix saveAsTextFile throws NullPointerException when null row present URL: https://github.com/apache/spark/pull/23799 ## What changes were proposed in this pull request? Currently, RDD.saveAsTextFile may throw NullPointerException

[GitHub] attilapiros commented on issue #23793: [SPARK-24736][k8s] Let spark-submit handle dependency resolution.

2019-02-15 Thread GitBox
attilapiros commented on issue #23793: [SPARK-24736][k8s] Let spark-submit handle dependency resolution. URL: https://github.com/apache/spark/pull/23793#issuecomment-464054993 For the flaky test (YarnSchedulerBackendSuite#"RequestExecutors reflects node blacklist and is serializable") I

[GitHub] AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464052968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464052968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464052962 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464052962 Merged build finished. Test PASSed.

[GitHub] SparkQA removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
SparkQA removed a comment on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-463967515 **[Test build #102384 has

[GitHub] SparkQA commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly

2019-02-15 Thread GitBox
SparkQA commented on issue #23789: [SPARK-26878] QueryTest.compare() does not handle maps with array keys correctly URL: https://github.com/apache/spark/pull/23789#issuecomment-464052402 **[Test build #102384 has

[GitHub] liupc edited a comment on issue #23786: [SPARK-26877]Support user-level app staging directory in yarn mode when spark.yarn…

2019-02-15 Thread GitBox
liupc edited a comment on issue #23786: [SPARK-26877]Support user-level app staging directory in yarn mode when spark.yarn… URL: https://github.com/apache/spark/pull/23786#issuecomment-464051617 @vanzin I test the config you provide, but it seems only get the current username on the

[GitHub] liupc commented on issue #23786: [SPARK-26877]Support user-level app staging directory in yarn mode when spark.yarn…

2019-02-15 Thread GitBox
liupc commented on issue #23786: [SPARK-26877]Support user-level app staging directory in yarn mode when spark.yarn… URL: https://github.com/apache/spark/pull/23786#issuecomment-464051617 @vanzin I test the config you provide, but it seems only get the current username on the OS, but

[GitHub] AmplabJenkins removed a comment on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#issuecomment-464050150 Can one of the admins

[GitHub] AmplabJenkins commented on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#issuecomment-464050668 Can one of the admins verify this

[GitHub] AmplabJenkins commented on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#issuecomment-464050150 Can one of the admins verify this

[GitHub] AmplabJenkins commented on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#issuecomment-464050014 Can one of the admins verify this

[GitHub] AmplabJenkins removed a comment on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#issuecomment-464050014 Can one of the admins

[GitHub] LucaCanali opened a new pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation

2019-02-15 Thread GitBox
LucaCanali opened a new pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798 ## What changes were proposed in this pull request?

[GitHub] AmplabJenkins removed a comment on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs URL: https://github.com/apache/spark/pull/23797#issuecomment-464047844 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs URL: https://github.com/apache/spark/pull/23797#issuecomment-464047839 Merged build finished. Test FAILed. This is

[GitHub] SparkQA removed a comment on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs

2019-02-15 Thread GitBox
SparkQA removed a comment on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs URL: https://github.com/apache/spark/pull/23797#issuecomment-464041259 **[Test build #102392 has

[GitHub] AmplabJenkins commented on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs

2019-02-15 Thread GitBox
AmplabJenkins commented on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs URL: https://github.com/apache/spark/pull/23797#issuecomment-464047844 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs URL: https://github.com/apache/spark/pull/23797#issuecomment-464047839 Merged build finished. Test FAILed.

[GitHub] SparkQA commented on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs

2019-02-15 Thread GitBox
SparkQA commented on issue #23797: [SPARK-26856][PYSPARK] Python support for from_avro and to_avro APIs URL: https://github.com/apache/spark/pull/23797#issuecomment-464047640 **[Test build #102392 has

[GitHub] AmplabJenkins removed a comment on issue #23679: [SPARK-23516][CORE] Avoid repeated release/acquire on storage memory

2019-02-15 Thread GitBox
AmplabJenkins removed a comment on issue #23679: [SPARK-23516][CORE] Avoid repeated release/acquire on storage memory URL: https://github.com/apache/spark/pull/23679#issuecomment-464045545 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   >