[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL

dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#discussion_r302334959 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL

dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#discussion_r302335063 ## File path:

[GitHub] [spark] Tonix517 commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL

Tonix517 commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#discussion_r302334652 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510290016 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AmplabJenkins removed a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510290021 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #18986: [SPARK-21774][SQL] The rule PromoteStrings should cast a string to double type when compare with a int/long

AmplabJenkins removed a comment on issue #18986: [SPARK-21774][SQL] The rule PromoteStrings should cast a string to double type when compare with a int/long URL: https://github.com/apache/spark/pull/18986#issuecomment-499244590 Can one of the admins verify this patch?

[GitHub] [spark] SparkQA commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

SparkQA commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510290440 **[Test build #107496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107496/testReport)** for PR

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302332811 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #18986: [SPARK-21774][SQL] The rule PromoteStrings should cast a string to double type when compare with a int/long

AmplabJenkins commented on issue #18986: [SPARK-21774][SQL] The rule PromoteStrings should cast a string to double type when compare with a int/long URL: https://github.com/apache/spark/pull/18986#issuecomment-510290375 Can one of the admins verify this patch?

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL

dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#discussion_r302332704 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL

dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#discussion_r302332758 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302332789 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AmplabJenkins commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510290016 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AmplabJenkins commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510290021 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses

maropu commented on a change in pull request #25029: [SPARK-28228][SQL] Fix substitution order of nested WITH clauses URL: https://github.com/apache/spark/pull/25029#discussion_r302332468 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#discussion_r302332492 ## File path:

[GitHub] [spark] AngersZhuuuu edited a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AngersZh edited a comment on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510289811 > @AngersZh . The regression test is used to protect your patch. Without that, your contribution can be disabled

[GitHub] [spark] AngersZhuuuu commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AngersZh commented on issue #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#issuecomment-510289811 > @AngersZh . The regression test is used to protect your patch. Without that, your contribution can be disabled

[GitHub] [spark] HyukjinKwon edited a comment on issue #25065: [MINOR][SQL] Clean up ObjectProducerExec operators

HyukjinKwon edited a comment on issue #25065: [MINOR][SQL] Clean up ObjectProducerExec operators URL: https://github.com/apache/spark/pull/25065#issuecomment-510288905 I'm fine either way. I also prefer to have a JIRA in general for trackability, for instance, backporting stuff. I think

[GitHub] [spark] HyukjinKwon edited a comment on issue #25065: [MINOR][SQL] Clean up ObjectProducerExec operators

HyukjinKwon edited a comment on issue #25065: [MINOR][SQL] Clean up ObjectProducerExec operators URL: https://github.com/apache/spark/pull/25065#issuecomment-510288905 I'm fine either way. I also prefer to have a JIRA in general for trackability, for instance, backporting stuff. I think

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AngersZh commented on a change in pull request #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#discussion_r302331979 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala

[GitHub] [spark] cloud-fan commented on issue #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the yyyy and yyyy-[m]m formats

cloud-fan commented on issue #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the and -[m]m formats URL: https://github.com/apache/spark/pull/25097#issuecomment-510289326 A late LGTM This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.

AmplabJenkins removed a comment on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables. URL: https://github.com/apache/spark/pull/25040#issuecomment-510288902 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25071: [SPARK-28292][SQL] Enable inject user-defined Hint

AngersZh commented on a change in pull request #25071: [SPARK-28292][SQL] Enable inject user-defined Hint URL: https://github.com/apache/spark/pull/25071#discussion_r302331945 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala

[GitHub] [spark] maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql

maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r302331820 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -0,0 +1,1215 @@ +-- +--

[GitHub] [spark] AmplabJenkins removed a comment on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.

AmplabJenkins removed a comment on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables. URL: https://github.com/apache/spark/pull/25040#issuecomment-510288896 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.

AmplabJenkins commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables. URL: https://github.com/apache/spark/pull/25040#issuecomment-510288896 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.

AmplabJenkins commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables. URL: https://github.com/apache/spark/pull/25040#issuecomment-510288902 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on issue #25065: [MINOR][SQL] Clean up ObjectProducerExec operators

HyukjinKwon commented on issue #25065: [MINOR][SQL] Clean up ObjectProducerExec operators URL: https://github.com/apache/spark/pull/25065#issuecomment-510288905 I'm fine either way. I also prefer to have a JIRA in general for trackability, for instance, backporting stuff. I think this PR

[GitHub] [spark] cloud-fan closed pull request #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

cloud-fan closed pull request #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102 This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql

maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r302331512 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -1190,7 +1183,9 @@ SELECT *

[GitHub] [spark] SparkQA removed a comment on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.

SparkQA removed a comment on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables. URL: https://github.com/apache/spark/pull/25040#issuecomment-510260187 **[Test build #107490 has

[GitHub] [spark] SparkQA commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables.

SparkQA commented on issue #25040: [SPARK-28238][SQL] Implement DESCRIBE TABLE for Data Source V2 Tables. URL: https://github.com/apache/spark/pull/25040#issuecomment-510288769 **[Test build #107490 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-510288338 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-510288331 Merged build finished. Test PASSed.

[GitHub] [spark] maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql

maropu commented on a change in pull request #24860: [SPARK-28034][SQL][TEST] Port with.sql URL: https://github.com/apache/spark/pull/24860#discussion_r302331201 ## File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql ## @@ -1190,7 +1183,9 @@ SELECT *

[GitHub] [spark] AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-510288338 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

cloud-fan commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510288275 thanks, merging to master! This is an

[GitHub] [spark] AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-510288331 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

SparkQA removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-510247424 **[Test build #107487 has

[GitHub] [spark] SparkQA commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

SparkQA commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-510287970 **[Test build #107487 has

[GitHub] [spark] dongjoon-hyun commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

dongjoon-hyun commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510287567 Sure. I'll rerun and make a PR to you tonight.

[GitHub] [spark] cloud-fan closed pull request #24768: [SPARK-27919][SQL] Add v2 session catalog

cloud-fan closed pull request #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] dongjoon-hyun closed pull request #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the yyyy and yyyy-[m]m formats

dongjoon-hyun closed pull request #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the and -[m]m formats URL: https://github.com/apache/spark/pull/25097 This is an automated message from

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510287528 **[Test build #107495 has

[GitHub] [spark] HyukjinKwon closed pull request #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

HyukjinKwon closed pull request #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069 This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

AmplabJenkins removed a comment on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor. URL: https://github.com/apache/spark/pull/24804#issuecomment-510287130 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

AmplabJenkins removed a comment on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor. URL: https://github.com/apache/spark/pull/24804#issuecomment-510287134 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510287126 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510287126 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

AmplabJenkins commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor. URL: https://github.com/apache/spark/pull/24804#issuecomment-510287130 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510287122 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

AmplabJenkins commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor. URL: https://github.com/apache/spark/pull/24804#issuecomment-510287134 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510287122 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510286994 Merged to master. This

[GitHub] [spark] HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base

HyukjinKwon commented on issue #25069: [SPARK-28270][SQL][PYTHON] Convert and port 'pgSQL/aggregates_part1.sql' into UDF test base URL: https://github.com/apache/spark/pull/25069#issuecomment-510286949 I am going to merge this since I am anyway going to make a followup. We can proceed the

[GitHub] [spark] SparkQA removed a comment on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

SparkQA removed a comment on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor. URL: https://github.com/apache/spark/pull/24804#issuecomment-510256504 **[Test build #107489 has

[GitHub] [spark] brkyvz commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

brkyvz commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-510286728 After discussing with @cloud-fan offline, my thoughts are: - Getting rid of `spark.sql.catalog.session` - Use

[GitHub] [spark] SparkQA commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

SparkQA commented on issue #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor. URL: https://github.com/apache/spark/pull/24804#issuecomment-510286744 **[Test build #107489 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302329225 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

[GitHub] [spark] viirya commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

viirya commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510286138 @dongjoon-hyun oh, yes, the new config should be enabled. Let me add it. Would you like to re-submit a PR

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302329089 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL

dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302329029 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base URL: https://github.com/apache/spark/pull/25098#discussion_r302328542 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base URL: https://github.com/apache/spark/pull/25098#discussion_r302328906 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base URL: https://github.com/apache/spark/pull/25098#discussion_r302328827 ## File path:

[GitHub] [spark] dongjoon-hyun closed pull request #25000: [SPARK-28107][SQL] Support 'DAY TO (HOUR|MINUTE|SECOND)', 'HOUR TO (MINUTE|SECOND)' and 'MINUTE TO SECOND'

dongjoon-hyun closed pull request #25000: [SPARK-28107][SQL] Support 'DAY TO (HOUR|MINUTE|SECOND)', 'HOUR TO (MINUTE|SECOND)' and 'MINUTE TO SECOND' URL: https://github.com/apache/spark/pull/25000 This is an automated

[GitHub] [spark] HyukjinKwon closed pull request #25093: [SPARK-28281][SQL][PYTHON][TESTS]Convert and port 'having.sql' into UDF test base

HyukjinKwon closed pull request #25093: [SPARK-28281][SQL][PYTHON][TESTS]Convert and port 'having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25093 This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25096: [SPARK-28334][SQL][TEST] Port select.sql

dongjoon-hyun commented on a change in pull request #25096: [SPARK-28334][SQL][TEST] Port select.sql URL: https://github.com/apache/spark/pull/25096#discussion_r302327530 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -487,6

[GitHub] [spark] brkyvz commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

brkyvz commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-510284643 @cloud-fan I think it is necessary to be able to configure the session catalog. I'm just unsure on the naming of the configuration, as it may

[GitHub] [spark] cloud-fan commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog

cloud-fan commented on issue #24768: [SPARK-27919][SQL] Add v2 session catalog URL: https://github.com/apache/spark/pull/24768#issuecomment-510284607 I'm merging it and will send follow up PR according to https://github.com/rdblue/spark/pull/7 , since it's arguable if we want to make

[GitHub] [spark] HyukjinKwon commented on issue #25093: [SPARK-28281][SQL][PYTHON][TESTS]Convert and port 'having.sql' into UDF test base

HyukjinKwon commented on issue #25093: [SPARK-28281][SQL][PYTHON][TESTS]Convert and port 'having.sql' into UDF test base URL: https://github.com/apache/spark/pull/25093#issuecomment-510284183 Merged to master. This is an

[GitHub] [spark] dongjoon-hyun commented on issue #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base

dongjoon-hyun commented on issue #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base URL: https://github.com/apache/spark/pull/25086#issuecomment-510283955 Thank you, @HyukjinKwon ~

[GitHub] [spark] AmplabJenkins removed a comment on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations.

AmplabJenkins removed a comment on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations. URL: https://github.com/apache/spark/pull/24875#issuecomment-510283809 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

AmplabJenkins commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510283760 Merged build finished. Test PASSed.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base

dongjoon-hyun commented on a change in pull request #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base URL: https://github.com/apache/spark/pull/25086#discussion_r302327247 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

HyukjinKwon commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base URL: https://github.com/apache/spark/pull/25098#issuecomment-510283866 As a workaround, maybe we can also wrap the `udf(...)` with, for instance, `upper` -

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510283538 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510283531 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations.

SparkQA removed a comment on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations. URL: https://github.com/apache/spark/pull/24875#issuecomment-510256499 **[Test build #107488 has

[GitHub] [spark] AmplabJenkins commented on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations.

AmplabJenkins commented on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations. URL: https://github.com/apache/spark/pull/24875#issuecomment-510283809 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

AmplabJenkins removed a comment on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510283765 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

AmplabJenkins removed a comment on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510283760 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510283531 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

AmplabJenkins commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510283765 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] imback82 commented on a change in pull request #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

imback82 commented on a change in pull request #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#discussion_r302326966 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

AmplabJenkins removed a comment on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-510282713 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

AmplabJenkins removed a comment on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-510282716 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

SparkQA removed a comment on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510237070 **[Test build #107486 has

[GitHub] [spark] SparkQA commented on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations.

SparkQA commented on issue #24875: [SPARK-28055][SS][DSTREAMS] Add delegation token custom AdminClient configurations. URL: https://github.com/apache/spark/pull/24875#issuecomment-510283488 **[Test build #107488 has

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510283538 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

SparkQA removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510234655 **[Test build #107485 has

[GitHub] [spark] SparkQA commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name

SparkQA commented on issue #25102: [SPARK-28339][SQL] Rename Spark SQL adaptive execution configuration name URL: https://github.com/apache/spark/pull/25102#issuecomment-510283359 **[Test build #107486 has

[GitHub] [spark] HyukjinKwon commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base

HyukjinKwon commented on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] Convert and port 'group-by.sql' into UDF test base URL: https://github.com/apache/spark/pull/25098#issuecomment-510283330 Yes, there is the difference about that. I noted it here -

[GitHub] [spark] imback82 commented on a change in pull request #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base

imback82 commented on a change in pull request #25090: [SPARK-28278][SQL][PYTHON][TESTS] Convert and port 'except-all.sql' into UDF test base URL: https://github.com/apache/spark/pull/25090#discussion_r302326809 ## File path:

[GitHub] [spark] SparkQA commented on issue #24561: [SPARK-26130][UI] Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables

SparkQA commented on issue #24561: [SPARK-26130][UI] Change Event Timeline Display Functionality on the Stages Page to use either REST API or data from other tables URL: https://github.com/apache/spark/pull/24561#issuecomment-510283061 **[Test build #107494 has

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode

SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate in explode URL: https://github.com/apache/spark/pull/24637#issuecomment-510283183 **[Test build #107485 has

[GitHub] [spark] HyukjinKwon closed pull request #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base

HyukjinKwon closed pull request #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base URL: https://github.com/apache/spark/pull/25086 This is an automated message from

[GitHub] [spark] SparkQA commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

SparkQA commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-510283029 **[Test build #107493 has

[GitHub] [spark] AmplabJenkins commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base

AmplabJenkins commented on issue #25103: [SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base URL: https://github.com/apache/spark/pull/25103#issuecomment-510282716 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   8   9   10   >