[GitHub] [spark] AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513102087 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513102085 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513060496 **[Test build #107875 has

[GitHub] [spark] SparkQA commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-18 Thread GitBox
SparkQA commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513101671 **[Test build #107875 has

[GitHub] [spark] maropu commented on issue #25190: [SPARK-28429][SQL] Support implicit cast string type to interval type in PromoteStrings

2019-07-18 Thread GitBox
maropu commented on issue #25190: [SPARK-28429][SQL] Support implicit cast string type to interval type in PromoteStrings URL: https://github.com/apache/spark/pull/25190#issuecomment-513100522 In postgresql, is this handled as implicit casts? I checked a cast list in postgresql though, I

[GitHub] [spark] AmplabJenkins removed a comment on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base URL: https://github.com/apache/spark/pull/25127#issuecomment-513100162 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base URL: https://github.com/apache/spark/pull/25127#issuecomment-513100162 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base URL: https://github.com/apache/spark/pull/25127#issuecomment-513100165 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base URL: https://github.com/apache/spark/pull/25127#issuecomment-513100165 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base URL: https://github.com/apache/spark/pull/25127#issuecomment-513062238 **[Test build #107876 has

[GitHub] [spark] SparkQA commented on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base

2019-07-18 Thread GitBox
SparkQA commented on issue #25127: [SPARK-28284][SQL][PYTHON][TESTS] Convert and port 'join-empty-relation.sql' into UDF test base URL: https://github.com/apache/spark/pull/25127#issuecomment-513099787 **[Test build #107876 has

[GitHub] [spark] shivusondur commented on issue #25147: [SPARK-28333][SQL] NULLS FIRST for DESC and NULLS LAST for ASC

2019-07-18 Thread GitBox
shivusondur commented on issue #25147: [SPARK-28333][SQL] NULLS FIRST for DESC and NULLS LAST for ASC URL: https://github.com/apache/spark/pull/25147#issuecomment-513099183 > This is introduced at 2.1.0 via #14842 . And, we are followinging Hive's behavior. We cannot change this

[GitHub] [spark] shivusondur edited a comment on issue #25147: [SPARK-28333][SQL] NULLS FIRST for DESC and NULLS LAST for ASC

2019-07-18 Thread GitBox
shivusondur edited a comment on issue #25147: [SPARK-28333][SQL] NULLS FIRST for DESC and NULLS LAST for ASC URL: https://github.com/apache/spark/pull/25147#issuecomment-513099183 > This is introduced at 2.1.0 via #14842 . And, we are followinging Hive's behavior. We cannot change

[GitHub] [spark] AmplabJenkins removed a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513098799 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513098802 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513098799 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513098802 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513058974 **[Test build #107874 has

[GitHub] [spark] SparkQA commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
SparkQA commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513098326 **[Test build #107874 has

[GitHub] [spark] maropu commented on a change in pull request #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-18 Thread GitBox
maropu commented on a change in pull request #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#discussion_r305207441 ## File path: sql/core/src/test/resources/sql-tests/inputs/cast.sql ##

[GitHub] [spark] maropu commented on a change in pull request #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

2019-07-18 Thread GitBox
maropu commented on a change in pull request #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface URL: https://github.com/apache/spark/pull/25189#discussion_r305207265 ## File path:

[GitHub] [spark] HyukjinKwon closed pull request #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
HyukjinKwon closed pull request #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199 This is an automated message from the

[GitHub] [spark] SparkQA commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
SparkQA commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513096500 **[Test build #107885 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513096005 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513096013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513096013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513096005 Merged build finished. Test PASSed. This

[GitHub] [spark] HyukjinKwon commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513095796 Thanks, Max. Merged to master.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513094498 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513094504 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513094504 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513094498 Merged build finished. Test PASSed.

[GitHub] [spark] gatorsmile commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner

2019-07-18 Thread GitBox
gatorsmile commented on a change in pull request #25111: [SPARK-28346][SQL] clone the query plan between analyzer, optimizer and planner URL: https://github.com/apache/spark/pull/25111#discussion_r305204236 ## File path:

[GitHub] [spark] SparkQA commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
SparkQA commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513093463 **[Test build #107883 has

[GitHub] [spark] SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-18 Thread GitBox
SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-513093469 **[Test build #107884 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513064114 Can one of the admins verify this patch?

[GitHub] [spark] maropu commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType

2019-07-18 Thread GitBox
maropu commented on issue #25198: [SPARK-28443][SQL] Spark sql add exception when create field type NullType URL: https://github.com/apache/spark/pull/25198#issuecomment-513093263 ok to test This is an automated message from

[GitHub] [spark] cloud-fan commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64

2019-07-18 Thread GitBox
cloud-fan commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64 URL: https://github.com/apache/spark/pull/25186#issuecomment-513093151 agree with @srowen that we can just remove this assertion if it depends on hardware

[GitHub] [spark] maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-18 Thread GitBox
maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r305194409 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-18 Thread GitBox
maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r305194612 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-07-18 Thread GitBox
maropu commented on a change in pull request #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#discussion_r305194211 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-513091243 Merged build finished. Test PASSed.

[GitHub] [spark] maropu commented on a change in pull request #25186: [SPARK-28433][SQL]Special scala test case for aarch64

2019-07-18 Thread GitBox
maropu commented on a change in pull request #25186: [SPARK-28433][SQL]Special scala test case for aarch64 URL: https://github.com/apache/spark/pull/25186#discussion_r305202389 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@

[GitHub] [spark] AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-513091245 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-513091243 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-513091245 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-513051078 **[Test build #107871 has

[GitHub] [spark] SparkQA commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2

2019-07-18 Thread GitBox
SparkQA commented on issue #24798: [SPARK-27724][SQL] Implement REPLACE TABLE and REPLACE TABLE AS SELECT with V2 URL: https://github.com/apache/spark/pull/24798#issuecomment-513090931 **[Test build #107871 has

[GitHub] [spark] srowen commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64

2019-07-18 Thread GitBox
srowen commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64 URL: https://github.com/apache/spark/pull/25186#issuecomment-513090568 (Yes, this assertion fails on ARM, per the thread on dev@) This

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-513089756 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-513089751 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513089600 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513089596 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-513089756 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-513089751 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513089596 Merged build finished. Test FAILed. This

[GitHub] [spark] SparkQA removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-513048218 **[Test build #107870 has

[GitHub] [spark] SparkQA removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513057417 **[Test build #107872 has

[GitHub] [spark] AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513089600 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate

2019-07-18 Thread GitBox
SparkQA commented on issue #24637: [SPARK-27707][SQL] Prune unnecessary nested fields from Generate URL: https://github.com/apache/spark/pull/24637#issuecomment-513089383 **[Test build #107870 has

[GitHub] [spark] SparkQA commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-18 Thread GitBox
SparkQA commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513089436 **[Test build #107872 has

[GitHub] [spark] huaxingao commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
huaxingao commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513089380 Thanks for your help! @HyukjinKwon @viirya

[GitHub] [spark] kiszk commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64

2019-07-18 Thread GitBox
kiszk commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64 URL: https://github.com/apache/spark/pull/25186#issuecomment-513089164 Since I have no aarch64 machine, I am curious about the following statement. > seems these assertion is not related with spark

[GitHub] [spark] HyukjinKwon closed pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
HyukjinKwon closed pull request #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101 This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513088308 Merged to master. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513086196 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513086198 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513086198 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513086196 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513046877 **[Test build #107869 has

[GitHub] [spark] SparkQA commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base

2019-07-18 Thread GitBox
SparkQA commented on issue #25101: [SPARK-28277][SQL][PYTHON][TESTS] Convert and port 'except.sql' into UDF test base URL: https://github.com/apache/spark/pull/25101#issuecomment-513085715 **[Test build #107869 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513084688 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082862 **[Test build #107882 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513084693 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
SparkQA commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513084602 **[Test build #107882 has

[GitHub] [spark] AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513084693 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513084688 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513083905 @WeichenXu123, can we add a simple test case? Some characters

[GitHub] [spark] AmplabJenkins removed a comment on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#issuecomment-513083577 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#issuecomment-513083575 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#issuecomment-513083575 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#issuecomment-513083577 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-18 Thread GitBox
HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#discussion_r305196492 ## File path:

[GitHub] [spark] SparkQA commented on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base

2019-07-18 Thread GitBox
SparkQA commented on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#issuecomment-513083231 **[Test build #107867 has

[GitHub] [spark] SparkQA removed a comment on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base

2019-07-18 Thread GitBox
SparkQA removed a comment on issue #25196: [SPARK-28279][SQL][PYTHON][TESTS] Convert and port 'group-analytics.sql' into UDF test base URL: https://github.com/apache/spark/pull/25196#issuecomment-513035877 **[Test build #107867 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082532 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins removed a comment on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082530 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
SparkQA commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082862 **[Test build #107882 has

[GitHub] [spark] AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082532 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
AmplabJenkins commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082530 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199#issuecomment-513082020 cc @cloud-fan and @MaxGekk . No biggie but it just bugged me.

[GitHub] [spark] huangtianhua commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64

2019-07-18 Thread GitBox
huangtianhua commented on issue #25186: [SPARK-28433][SQL]Special scala test case for aarch64 URL: https://github.com/apache/spark/pull/25186#issuecomment-513081969 So maybe delete these assertion is a good choose? The binary representation depends on hardware and seems these assertion is

[GitHub] [spark] HyukjinKwon opened a new pull request #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide

2019-07-18 Thread GitBox
HyukjinKwon opened a new pull request #25199: [SPARK-28389][SQL][FOLLOW-UP] Use one example in 'add_months' behavior change at migration guide URL: https://github.com/apache/spark/pull/25199 ## What changes were proposed in this pull request? This PR proposes to add one example to

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513080850 Can you elaborate why and confirm if Scala UDF works or not as well? We should better match the test cases

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25153: [SPARK-28389][SQL] Use Java 8 API in add_months

2019-07-18 Thread GitBox
HyukjinKwon commented on a change in pull request #25153: [SPARK-28389][SQL] Use Java 8 API in add_months URL: https://github.com/apache/spark/pull/25153#discussion_r305193650 ## File path: docs/sql-migration-guide-upgrade.md ## @@ -151,6 +151,8 @@ license: | - Since

[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513079590 @HyukjinKwon The reason is that I specified "ORDER BY val"?: Before: `SELECT val, cate,

[GitHub] [spark] younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
younggyuchun edited a comment on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513079590 @HyukjinKwon The reason is that I specified the "ORDER BY val"?: Before: `SELECT val, cate,

[GitHub] [spark] younggyuchun commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into …

2019-07-18 Thread GitBox
younggyuchun commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into … URL: https://github.com/apache/spark/pull/25195#issuecomment-513079590 > @younggyuchun, do you know why it works with UDFs? > > ```diff > -- !query 19 > -SELECT val,

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25153: [SPARK-28389][SQL] Use Java 8 API in add_months

2019-07-18 Thread GitBox
HyukjinKwon commented on a change in pull request #25153: [SPARK-28389][SQL] Use Java 8 API in add_months URL: https://github.com/apache/spark/pull/25153#discussion_r305192591 ## File path: docs/sql-migration-guide-upgrade.md ## @@ -151,6 +151,8 @@ license: | - Since

[GitHub] [spark] maropu commented on issue #21668: [SPARK-24690][SQL] Add a new config to control plan stats computation in LogicalRelation

2019-07-18 Thread GitBox
maropu commented on issue #21668: [SPARK-24690][SQL] Add a new config to control plan stats computation in LogicalRelation URL: https://github.com/apache/spark/pull/21668#issuecomment-513079335 will fix in hours. This is an

  1   2   3   4   5   6   7   8   9   10   >