[GitHub] [spark] gatorsmile commented on issue #25146: [SPARK-28152][SQL] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-20 Thread GitBox
gatorsmile commented on issue #25146: [SPARK-28152][SQL] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25146#issuecomment-513525323 @dongjoon-hyun @shivsood This change requires an update in our migration guide section.

[GitHub] [spark] SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-20 Thread GitBox
SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-513524665 **[Test build #107957 has

[GitHub] [spark] gatorsmile commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'DAY TO (HOUR|MINUTE|SECOND)', 'HOUR TO (MINUTE|SECOND)' and 'MINUTE TO SECOND'

2019-07-20 Thread GitBox
gatorsmile commented on a change in pull request #25000: [SPARK-28107][SQL] Support 'DAY TO (HOUR|MINUTE|SECOND)', 'HOUR TO (MINUTE|SECOND)' and 'MINUTE TO SECOND' URL: https://github.com/apache/spark/pull/25000#discussion_r305601709 ## File path:

[GitHub] [spark] HyukjinKwon edited a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-07-20 Thread GitBox
HyukjinKwon edited a comment on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-513522547 And parser should recognises the DDL type string ideally (needs to check Hive) and R seeds

[GitHub] [spark] HyukjinKwon commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-513522547 And parser should recognises the DDL type string ideally (needs to check Hive) and R seeds should

[GitHub] [spark] AmplabJenkins commented on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option URL: https://github.com/apache/spark/pull/25219#issuecomment-513522321 Can one of the admins verify this patch? This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option URL: https://github.com/apache/spark/pull/25219#issuecomment-513522321 Can one of the admins verify this patch?

[GitHub] [spark] HyukjinKwon commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #25022: [SPARK-24695][SQL] Move `CalendarInterval` to org.apache.spark.sql.types package URL: https://github.com/apache/spark/pull/25022#issuecomment-513522325 Yea we gotta define the type in types.py too with some basic tests.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option URL: https://github.com/apache/spark/pull/25219#issuecomment-513521917 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option URL: https://github.com/apache/spark/pull/25219#issuecomment-513522360 Can one of the admins verify this patch? This

[GitHub] [spark] AngersZhuuuu commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AngersZh commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521947 @jerryshao @wangyum How about make HiveClientImple's sessionState to be ThreadLocal?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521713 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521918 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option URL: https://github.com/apache/spark/pull/25219#issuecomment-513521917 Can one of the admins verify this patch? This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513521763 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513521766 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#discussion_r305601076 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513521766 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521658 Can one of the admins verify this patch?

[GitHub] [spark] arunpandianp opened a new pull request #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option

2019-07-20 Thread GitBox
arunpandianp opened a new pull request #25219: [SPARK-28464][Doc][SS] Document Kafka source minPartitions option URL: https://github.com/apache/spark/pull/25219 ## What changes were proposed in this pull request? Adding doc for the kafka source minPartitions option to "Structured

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#discussion_r305601070 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513521763 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521713 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513521679 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
HyukjinKwon commented on a change in pull request #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#discussion_r305601060 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513521680 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
SparkQA commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513521649 **[Test build #107955 has

[GitHub] [spark] AmplabJenkins commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521658 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513521680 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513521679 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513519923 **[Test build #107955 has

[GitHub] [spark] AngersZhuuuu commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AngersZh commented on issue #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218#issuecomment-513521522 Gental ping @Deegue @xianyinxin @wangyum @jerryshao

[GitHub] [spark] AngersZhuuuu opened a new pull request #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile

2019-07-20 Thread GitBox
AngersZh opened a new pull request #25218: [SPARK-21067][SQL][FOLLOW-UP] fix sts FileSystem closed error when to call Hive.moveFile URL: https://github.com/apache/spark/pull/25218 ## What changes were proposed in this pull request? When we close a session of STS, if this session

[GitHub] [spark] SparkQA commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
SparkQA commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513521210 **[Test build #107956 has

[GitHub] [spark] SparkQA commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
SparkQA commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513519923 **[Test build #107955 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513519752 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513519748 Merged build finished. Test PASSed.

[GitHub] [spark] wangyum commented on a change in pull request #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
wangyum commented on a change in pull request #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#discussion_r305600807 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513519752 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217#issuecomment-513519748 Merged build finished. Test PASSed.

[GitHub] [spark] wangyum opened a new pull request #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal

2019-07-20 Thread GitBox
wangyum opened a new pull request #25217: [SPARK-28463][SQL][test-hadoop3.2] Thriftserver throws BigDecimal incompatible with HiveDecimal URL: https://github.com/apache/spark/pull/25217 ## What changes were proposed in this pull request? How to reproduce this issue: ```shell

[GitHub] [spark] SparkQA commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
SparkQA commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513518637 **[Test build #107954 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513518456 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513518459 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513518459 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513518456 Merged build finished. Test PASSed.

[GitHub] [spark] maropu commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
maropu commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513517999 retest this please

[GitHub] [spark] AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513517547 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513510299 **[Test build #107949 has

[GitHub] [spark] AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513517547 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513517545 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513517545 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
SparkQA commented on issue #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#issuecomment-513517468 **[Test build #107949 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513517349 Test FAILed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513517348 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513507923 **[Test build #107948 has

[GitHub] [spark] AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513517349 Test FAILed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513517348 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
SparkQA commented on issue #25213: [SPARK-28462][SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513517197 **[Test build #107948 has

[GitHub] [spark] beliefer commented on issue #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-20 Thread GitBox
beliefer commented on issue #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#issuecomment-513516946 > I'll take a look next week again. I'm rethinking about this PR. OK. we need a consistent opinion before I modify

[GitHub] [spark] SparkQA commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
SparkQA commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513516776 **[Test build #107953 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513516707 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513516709 Test PASSed. Refer to this link for build

[GitHub] [spark] AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513516707 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25184: [SPARK-28431][SQL] Fix CSV datasource throw com.univocity.parsers.common.TextParsingException with large size message URL: https://github.com/apache/spark/pull/25184#issuecomment-513516709 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] xueyumusic commented on issue #21985: [SPARK-24884][SQL] add regexp_extract_all support

2019-07-20 Thread GitBox
xueyumusic commented on issue #21985: [SPARK-24884][SQL] add regexp_extract_all support URL: https://github.com/apache/spark/pull/21985#issuecomment-513516631 Thanks for ping, @kiszk , I will update the code these days. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite URL: https://github.com/apache/spark/pull/25216#issuecomment-513516043 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite URL: https://github.com/apache/spark/pull/25216#issuecomment-513516043 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite URL: https://github.com/apache/spark/pull/25216#issuecomment-513516041 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite URL: https://github.com/apache/spark/pull/25216#issuecomment-513516041 Merged build finished. Test PASSed.

[GitHub] [spark] maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#discussion_r305600034 ## File path: docs/sql-migration-guide-upgrade.md ## @@ -23,6

[GitHub] [spark] SparkQA commented on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite

2019-07-20 Thread GitBox
SparkQA commented on issue #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite URL: https://github.com/apache/spark/pull/25216#issuecomment-513515832 **[Test build #107952 has

[GitHub] [spark] maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#discussion_r305599966 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#discussion_r305599958 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-513515759 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-513515756 Merged build finished. Test PASSed.

[GitHub] [spark] maropu opened a new pull request #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite

2019-07-20 Thread GitBox
maropu opened a new pull request #25216: [SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite URL: https://github.com/apache/spark/pull/25216 ## What changes were proposed in this pull request? This pr is to remove the unnecessary test in DataFrameSuite.

[GitHub] [spark] AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-513515756 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-513515759 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-07-20 Thread GitBox
SparkQA commented on issue #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215#issuecomment-513515521 **[Test build #107951 has

[GitHub] [spark] viirya opened a new pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression

2019-07-20 Thread GitBox
viirya opened a new pull request #25215: [SPARK-28445][SQL][Python] Fix error when PythonUDF is used in both group by and aggregate expression URL: https://github.com/apache/spark/pull/25215 ## What changes were proposed in this pull request? When PythonUDF is used in group by, and

[GitHub] [spark] gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-20 Thread GitBox
gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#discussion_r305599816 ## File path:

[GitHub] [spark] gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-20 Thread GitBox
gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#discussion_r305599805 ## File path:

[GitHub] [spark] gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-20 Thread GitBox
gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#discussion_r305599670 ## File path:

[GitHub] [spark] gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

2019-07-20 Thread GitBox
gatorsmile commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison URL: https://github.com/apache/spark/pull/25055#discussion_r305599586 ## File path:

[GitHub] [spark] Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-20 Thread GitBox
Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#discussion_r305599542 ## File path:

[GitHub] [spark] Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-20 Thread GitBox
Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#discussion_r305599471 ## File path:

[GitHub] [spark] Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks…

2019-07-20 Thread GitBox
Ngone51 commented on a change in pull request #23677: [SPARK-26755][SCHEDULER] : Optimize Spark Scheduler to dequeue speculative tasks… URL: https://github.com/apache/spark/pull/23677#discussion_r305599471 ## File path:

[GitHub] [spark] wangyum commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
wangyum commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#discussion_r305599336 ## File path:

[GitHub] [spark] SparkQA commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
SparkQA commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513513269 **[Test build #107950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107950/testReport)** for PR 25210 at

[GitHub] [spark] AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513513194 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513513196 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513513194 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513513196 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on issue #25213: [SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures

2019-07-20 Thread GitBox
maropu commented on issue #25213: [SQL][TEST] Add a prefix '*' to non-nullable attribute names in PlanTestBase.comparePlans failures URL: https://github.com/apache/spark/pull/25213#issuecomment-513512944 ok, will do. This

[GitHub] [spark] maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#discussion_r305598890 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25214: [SPARK-28461][SQL] Pad Decimal numbers with trailing zeros to the scale of the column URL: https://github.com/apache/spark/pull/25214#discussion_r305598890 ## File path:

[GitHub] [spark] MaxGekk commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
MaxGekk commented on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513512803 > BTW, I'm wondering if we need to add this function for all. I see. I will remove the function from Scala, Python, R API.

[GitHub] [spark] maropu commented on issue #21668: [SPARK-24690][SQL] Add a new config to control plan stats computation in LogicalRelation

2019-07-20 Thread GitBox
maropu commented on issue #21668: [SPARK-24690][SQL] Add a new config to control plan stats computation in LogicalRelation URL: https://github.com/apache/spark/pull/21668#issuecomment-513512192 This pr comes from https://github.com/apache/spark/pull/20345#issuecomment-400925890. Could you

[GitHub] [spark] AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] Add `make_date` function

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] Add `make_date` function URL: https://github.com/apache/spark/pull/25210#issuecomment-513511452 Test FAILed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   4   >