[GitHub] [spark] SparkQA commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
SparkQA commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514872275 **[Test build #108147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108147/testReport)** for PR 25251 at commit

[GitHub] [spark] AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871919 Merged build finished. Test PASSed. This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871920 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871919 Merged build finished. Test PASSed. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871920 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514866728 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [spark] HyukjinKwon removed a comment on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
HyukjinKwon removed a comment on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871649 add to whitelist This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
HyukjinKwon commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871649 add to whitelist This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] HyukjinKwon commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
HyukjinKwon commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514871696 ok to test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun closed pull request #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
dongjoon-hyun closed pull request #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248 This is an automated message from

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307093683 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307093581 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307093321 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307093160 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307092949 ## File path: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307092864 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307092843 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307092786 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307092625 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307092141 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT (

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307091967 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -328,16 +328,891 @@

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307091759 ## File path: python/pyspark/ml/image.py ## @@ -203,52 +205,16 @@ def

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307091599 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT (

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307091452 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -1,5 +1,5 @@ --

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307091452 ## File path: sql/core/src/test/resources/sql-tests/results/cte.sql.out ## @@ -1,5 +1,5 @@ --

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307091483 ## File path: python/pyspark/ml/image.py ## @@ -16,11 +16,11 @@ # """ -..

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307091121 ## File path: python/pyspark/ml/image.py ## @@ -16,11 +16,11 @@ # """

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307091258 ## File path: python/pyspark/ml/image.py ## @@ -16,11 +16,11 @@ # """

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307091258 ## File path: python/pyspark/ml/image.py ## @@ -16,11 +16,11 @@ # """

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307091121 ## File path: python/pyspark/ml/image.py ## @@ -16,11 +16,11 @@ # """

[GitHub] [spark] beliefer commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-24 Thread GitBox
beliefer commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r305786347 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307091036 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT (

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25242: [SPARK-28497][SQL] Disallow upcasting complex data types to string type

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25242: [SPARK-28497][SQL] Disallow upcasting complex data types to string type URL: https://github.com/apache/spark/pull/25242#discussion_r307090548 ## File path:

[GitHub] [spark] SparkQA commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
SparkQA commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514867350 **[Test build #108146 has

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25242: [SPARK-28497][SQL] Disallow upcasting complex data types to string type

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #25242: [SPARK-28497][SQL] Disallow upcasting complex data types to string type URL: https://github.com/apache/spark/pull/25242#discussion_r307090548 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307090403 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1873,6

[GitHub] [spark] AmplabJenkins removed a comment on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514866809 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514866809 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514866817 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#issuecomment-514866817 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514866598 Can one of the admins verify this patch? This is an automated message from the

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307090251 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT (

[GitHub] [spark] AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514866728 Can one of the admins verify this patch? This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514866598 Can one of the admins verify this patch? This is an automated message from the Apache

[GitHub] [spark] dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-24 Thread GitBox
dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#discussion_r307090135 ## File path:

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307090004 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT (

[GitHub] [spark] maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#discussion_r307089802 ## File path: sql/core/src/test/resources/sql-tests/inputs/cte.sql ## @@ -155,6 +155,419 @@ SELECT (

[GitHub] [spark] dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-24 Thread GitBox
dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#discussion_r307089669 ## File path:

[GitHub] [spark] SparkQA commented on issue #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
SparkQA commented on issue #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251#issuecomment-514865655 **[Test build #108145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108145/testReport)** for PR 25251 at commit

[GitHub] [spark] maropu commented on issue #23531: [SPARK-24497][SQL] Support recursive SQL query

2019-07-24 Thread GitBox
maropu commented on issue #23531: [SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-514865705 hi, @peter-toth, great work! just roughly looking over this pr though, my first impression was that this pr is a bit complicated for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-514865108 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-514865105 Merged build finished. Test PASSed.

[GitHub] [spark] dongjinleekr opened a new pull request #25251: [MINOR] Trivial cleanups

2019-07-24 Thread GitBox
dongjinleekr opened a new pull request #25251: [MINOR] Trivial cleanups URL: https://github.com/apache/spark/pull/25251 These are what I found during working on #22282. - Remove unused value: `UnsafeArraySuite#defaultTz` - Remove redundant new modifier to the case class,

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307088788 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-514865105 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-514865108 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
SparkQA commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-514864839 **[Test build #108132 has

[GitHub] [spark] SparkQA removed a comment on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect

2019-07-24 Thread GitBox
SparkQA removed a comment on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-514797544 **[Test build #108132 has

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307088788 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25237: [SPARK-28489][SS] Fix a bug that KafkaOffsetRangeCalculator.getRanges may drop offsets

2019-07-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25237: [SPARK-28489][SS] Fix a bug that KafkaOffsetRangeCalculator.getRanges may drop offsets URL: https://github.com/apache/spark/pull/25237#discussion_r307088330 ## File path:

[GitHub] [spark] mccheah commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2019-07-24 Thread GitBox
mccheah commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API URL: https://github.com/apache/spark/pull/25007#discussion_r307087721 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#issuecomment-514863350 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#issuecomment-514863355 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HeartSaVioR commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HeartSaVioR commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307087380 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#issuecomment-514863350 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#issuecomment-514863355 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HeartSaVioR commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HeartSaVioR commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307087380 ## File path:

[GitHub] [spark] WeichenXu123 commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
WeichenXu123 commented on a change in pull request #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#discussion_r307086995 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink

2019-07-24 Thread GitBox
HyukjinKwon commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514862670 Can we make the tests passed? Also, you can cc people who appears in Git blame. cc @jerryshao

[GitHub] [spark] SparkQA commented on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0

2019-07-24 Thread GitBox
SparkQA commented on issue #25245: [SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 URL: https://github.com/apache/spark/pull/25245#issuecomment-514862115 **[Test build #108144 has

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307086147 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307086147 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r307086147 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base

2019-07-24 Thread GitBox
HyukjinKwon commented on issue #25195: [SPARK-28288][SQL][PYTHON][TESTS] Convert and port 'window.sql' into UDF test base URL: https://github.com/apache/spark/pull/25195#issuecomment-514860931 Thanks, @younggyuchun. Do you mind updating PR description (the diff) too?

[GitHub] [spark] dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-24 Thread GitBox
dongjinleekr commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#discussion_r307084987 ## File path:

[GitHub] [spark] dilipbiswal commented on a change in pull request #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
dilipbiswal commented on a change in pull request #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#discussion_r307084134 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF URL: https://github.com/apache/spark/pull/25250#issuecomment-514857729 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF URL: https://github.com/apache/spark/pull/25250#issuecomment-514857733 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF URL: https://github.com/apache/spark/pull/25250#issuecomment-514857729 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF URL: https://github.com/apache/spark/pull/25250#issuecomment-514857733 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF

2019-07-24 Thread GitBox
SparkQA commented on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF URL: https://github.com/apache/spark/pull/25250#issuecomment-514857503 **[Test build #108141 has

[GitHub] [spark] SparkQA removed a comment on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF

2019-07-24 Thread GitBox
SparkQA removed a comment on issue #25250: [SPARK-21481][ML] Add indexOf method in ml.feature.HashingTF URL: https://github.com/apache/spark/pull/25250#issuecomment-514844432 **[Test build #108141 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514855661 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514855658 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514855661 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514855658 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
SparkQA commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514854663 **[Test build #108143 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514853434 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514853434 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
SparkQA removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514836031 **[Test build #108137 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514853431 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
SparkQA commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514853325 **[Test build #108137 has

[GitHub] [spark] AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor

2019-07-24 Thread GitBox
AmplabJenkins commented on issue #25249: [SPARK-28237][SQL] Enforce Idempotence for Once batches in RuleExecutor URL: https://github.com/apache/spark/pull/25249#issuecomment-514853431 Merged build finished. Test FAILed. This

[GitHub] [spark] HeartSaVioR commented on issue #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader

2019-07-24 Thread GitBox
HeartSaVioR commented on issue #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#issuecomment-514852868 @HyukjinKwon Could we revisit this? I guess it's just waiting for last call to merge.

[GitHub] [spark] HeartSaVioR commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink

2019-07-24 Thread GitBox
HeartSaVioR commented on issue #25232: [SPARK-28475][CORE] Add regex MetricFilter to GraphiteSink URL: https://github.com/apache/spark/pull/25232#issuecomment-514851622 I'm also one of contributors trying to help reviewing. :) @HyukjinKwon and @dongjoon-hyun are able to review and approve

[GitHub] [spark] HeartSaVioR commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-24 Thread GitBox
HeartSaVioR commented on a change in pull request #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#discussion_r307076383 ## File path:

[GitHub] [spark] HeartSaVioR edited a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-24 Thread GitBox
HeartSaVioR edited a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-514840592 Personally I would ask to rollback any irrelevant changes. Looks like the latest change contains

[GitHub] [spark] HeartSaVioR edited a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-07-24 Thread GitBox
HeartSaVioR edited a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-514840592 Personally I would ask to rollback any irrelevant changes. Looks like the latest change contains

[GitHub] [spark] AmplabJenkins removed a comment on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-514848536 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API

2019-07-24 Thread GitBox
AmplabJenkins removed a comment on issue #24560: [SPARK-27661][SQL] Add SupportsNamespaces API URL: https://github.com/apache/spark/pull/24560#issuecomment-514848540 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   8   9   10   >