[GitHub] [spark] cloud-fan commented on a change in pull request #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-06 Thread GitBox
cloud-fan commented on a change in pull request #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#discussion_r311378653 ## File path:

[GitHub] [spark] advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311376838 ## File path:

[GitHub] [spark] advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311375710 ## File path:

[GitHub] [spark] advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311375175 ## File path:

[GitHub] [spark] gatorsmile commented on a change in pull request #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-06 Thread GitBox
gatorsmile commented on a change in pull request #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#discussion_r311373968 ## File path:

[GitHub] [spark] gatorsmile commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-06 Thread GitBox
gatorsmile commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-518945763 cc @cloud-fan @gengliangwang This is an

[GitHub] [spark] gatorsmile removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-06 Thread GitBox
gatorsmile removed a comment on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-518945644 We do have the leaf nodes that can provide stats. Not sure why we are unable to test the PR? Anybody can

[GitHub] [spark] cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311373305 ## File path:

[GitHub] [spark] gatorsmile commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan

2019-08-06 Thread GitBox
gatorsmile commented on issue #24623: [SPARK-27739][SQL] df.persist should save stats from optimized plan URL: https://github.com/apache/spark/pull/24623#issuecomment-518945644 We do have the leaf nodes that can provide stats. Not sure why we are unable to test the PR? Anybody can dig it

[GitHub] [spark] AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518944806 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311371896 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
SparkQA removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518928357 **[Test build #108745 has

[GitHub] [spark] AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518944806 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518944800 Merged build finished. Test FAILed. This

[GitHub] [spark] cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311371896 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518944800 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
SparkQA commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518944719 **[Test build #108745 has

[GitHub] [spark] viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311371869 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311371869 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
cloud-fan commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311371896 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518943302 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518943308 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518943302 Merged build finished. Test PASSed.

[GitHub] [spark] jzhuge commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs

2019-08-06 Thread GitBox
jzhuge commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs URL: https://github.com/apache/spark/pull/25330#issuecomment-518943311 It'd better to group READ/SELECT and saveAsTable together because they both are affected by the change in

[GitHub] [spark] AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518943308 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311371102 ## File path:

[GitHub] [spark] viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
viirya commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311369535 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
SparkQA removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518918889 **[Test build #108742 has

[GitHub] [spark] SparkQA commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
SparkQA commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518942969 **[Test build #108742 has

[GitHub] [spark] viirya commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-06 Thread GitBox
viirya commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r311368156 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriterV2.scala ## @@ -0,0 +1,415 @@

[GitHub] [spark] viirya commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-06 Thread GitBox
viirya commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r311366921 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -3146,6 +3146,34 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518937807 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518937808 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518937808 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518937807 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
SparkQA removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518913142 **[Test build #108740 has

[GitHub] [spark] SparkQA commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
SparkQA commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518937442 **[Test build #108740 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518934209 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] SparkQA commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
SparkQA commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518934191 **[Test build #108746 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518934206 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
SparkQA removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518932067 **[Test build #108746 has

[GitHub] [spark] AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518934209 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518934206 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518933084 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518933078 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518933078 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518933084 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] brkyvz commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs

2019-08-06 Thread GitBox
brkyvz commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs URL: https://github.com/apache/spark/pull/25330#issuecomment-518932219 Or would you mind if those are added as a follow up in supporting INSERT INTO as well?

[GitHub] [spark] SparkQA commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
SparkQA commented on issue #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#issuecomment-518932067 **[Test build #108746 has

[GitHub] [spark] brkyvz commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs

2019-08-06 Thread GitBox
brkyvz commented on issue #25330: [SPARK-28565][SQL] DataFrameWriter saveAsTable support for V2 catalogs URL: https://github.com/apache/spark/pull/25330#issuecomment-518931990 Sounds good. I can separate the session catalog things. That's a valid point around requiring more tests around

[GitHub] [spark] brkyvz commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
brkyvz commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311361310 ## File path:

[GitHub] [spark] beliefer commented on issue #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-08-06 Thread GitBox
beliefer commented on issue #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#issuecomment-518931162 @jerryshao IMHO, Spark should reduce configuration parameters first. And then I think no

[GitHub] [spark] SparkQA commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
SparkQA commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518928357 **[Test build #108745 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518928016 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518928023 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518928016 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25328: [SPARK-28595][SQL] explain should not trigger partition listing URL: https://github.com/apache/spark/pull/25328#issuecomment-518928023 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
SparkQA commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518923276 **[Test build #108744 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518922937 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518922937 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518922934 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518922934 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-518922758 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-518922762 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-518922758 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-518922762 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-08-06 Thread GitBox
SparkQA removed a comment on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-518885405 **[Test build #108734 has

[GitHub] [spark] SparkQA commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-08-06 Thread GitBox
SparkQA commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-518922387 **[Test build #108734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/108734/testReport)**

[GitHub] [spark] xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r311353280 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518921599 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
SparkQA commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518921923 **[Test build #108743 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518921601 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r311353000 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518921599 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#issuecomment-518921601 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r311352767 ## File path:

[GitHub] [spark] advancedxy commented on issue #25002: [SPARK-28203][Core][Python] PythonRDD should respect SparkContext's hadoop configuration

2019-08-06 Thread GitBox
advancedxy commented on issue #25002: [SPARK-28203][Core][Python] PythonRDD should respect SparkContext's hadoop configuration URL: https://github.com/apache/spark/pull/25002#issuecomment-518921394 Gently ping @cloud-fan, @HyukjinKwon and @dongjoon-hyun.

[GitHub] [spark] xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r311352726 ## File path:

[GitHub] [spark] xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r311352702 ## File path:

[GitHub] [spark] xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder

2019-08-06 Thread GitBox
xianyinxin commented on a change in pull request #24983: [SPARK-27714][SQL][CBO] Support Genetic Algorithm based join reorder URL: https://github.com/apache/spark/pull/24983#discussion_r311352547 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518920002 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518919997 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518919997 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518920002 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-08-06 Thread GitBox
advancedxy commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r311351669 ## File path:

[GitHub] [spark] RussellSpitzer commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
RussellSpitzer commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311351159 ## File path:

[GitHub] [spark] RussellSpitzer commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
RussellSpitzer commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311351159 ## File path:

[GitHub] [spark] RussellSpitzer commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths

2019-08-06 Thread GitBox
RussellSpitzer commented on a change in pull request #25348: [RFC][SPARK-28554][SQL] Adds a v1 fallback writer implementation for v2 data source codepaths URL: https://github.com/apache/spark/pull/25348#discussion_r311351159 ## File path:

[GitHub] [spark] SparkQA commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3

2019-08-06 Thread GitBox
SparkQA commented on issue #25289: [SPARK-27889][INFRA] Make development scripts under dev/ support Python 3 URL: https://github.com/apache/spark/pull/25289#issuecomment-518918889 **[Test build #108742 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test URL: https://github.com/apache/spark/pull/25366#issuecomment-518918462 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test URL: https://github.com/apache/spark/pull/25366#issuecomment-518918460 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test

2019-08-06 Thread GitBox
AmplabJenkins removed a comment on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test URL: https://github.com/apache/spark/pull/25366#issuecomment-518918460 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test

2019-08-06 Thread GitBox
AmplabJenkins commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test URL: https://github.com/apache/spark/pull/25366#issuecomment-518918462 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test

2019-08-06 Thread GitBox
SparkQA commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test URL: https://github.com/apache/spark/pull/25366#issuecomment-518917430 **[Test build #108741 has

[GitHub] [spark] srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-06 Thread GitBox
srowen commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-518917299 I did not benchmark this as I think it's a correctness issue that would be worth a perf hit. I also

[GitHub] [spark] beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-08-06 Thread GitBox
beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-518917065 @dongjoon-hyun Could you check this PR? This is an automated

[GitHub] [spark] beliefer commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test

2019-08-06 Thread GitBox
beliefer commented on issue #25366: [SPARK-27924][SQL][TEST][FOLLOW-UP] Open comment about boolean test URL: https://github.com/apache/spark/pull/25366#issuecomment-518916476 > I made a PR to you, @beliefer . Please review and merge. > > *

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25229: [SPARK-27900][K8s] Add jvm oom flag

2019-08-06 Thread GitBox
dongjoon-hyun edited a comment on issue #25229: [SPARK-27900][K8s] Add jvm oom flag URL: https://github.com/apache/spark/pull/25229#issuecomment-518916061 @skonto . My name is `Dongjoon Hyun` with GitHub id `@dongjoon-hyun`. :) I knew the history of #24796 and Spark uses

[GitHub] [spark] dongjoon-hyun commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag

2019-08-06 Thread GitBox
dongjoon-hyun commented on issue #25229: [SPARK-27900][K8s] Add jvm oom flag URL: https://github.com/apache/spark/pull/25229#issuecomment-518916061 @skonto . My name is `Dongjoon Hyun` with GitHub id `@dongjoon-hyun`. :) I knew the history of #24792 and Spark uses

[GitHub] [spark] gatorsmile commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence

2019-08-06 Thread GitBox
gatorsmile commented on issue #25279: [SPARK-28519][SQL] Use StrictMath log, pow functions for platform independence URL: https://github.com/apache/spark/pull/25279#issuecomment-518915141 @srowen Could you show the perf benchmark? The performance regression is expected, right?

  1   2   3   4   5   6   7   8   9   >