[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526432709 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-08-29 Thread GitBox
HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319338191 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-08-29 Thread GitBox
HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319338191 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#issuecomment-526432496 Can one of the admins verify this patch? This is an

[GitHub] [spark] dongjoon-hyun commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test for Github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25624: [SPARK-28919][INFRA] Add more profiles for JDK8/11 build test for Github workflow URL: https://github.com/apache/spark/pull/25624#issuecomment-526432088 Thank you for review and updating PR title, @HyukjinKwon .

[GitHub] [spark] AmplabJenkins removed a comment on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#issuecomment-526431023 Can one of the admins verify this patch? This is

[GitHub] [spark] SparkQA removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
SparkQA removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526428401 **[Test build #109932 has

[GitHub] [spark] AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526431428 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA commented on issue #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold

2019-08-29 Thread GitBox
SparkQA commented on issue #25623: [SPARK-28786][DOC][SQL][FOLLOW-UP] Change "Related Statements" to bold URL: https://github.com/apache/spark/pull/25623#issuecomment-526431535 **[Test build #109934 has

[GitHub] [spark] AmplabJenkins commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#issuecomment-526431477 Can one of the admins verify this patch? This is an

[GitHub] [spark] SparkQA commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-29 Thread GitBox
SparkQA commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-526431556 **[Test build #109935 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526431433 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526431428 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526431433 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-526431121 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-526431118 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
SparkQA commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526431335 **[Test build #109932 has

[GitHub] [spark] AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-526431121 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-526431118 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#issuecomment-526431023 Can one of the admins verify this patch? This is an

[GitHub] [spark] xianyinxin opened a new pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-08-29 Thread GitBox
xianyinxin opened a new pull request #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626 ### What changes were proposed in this pull request? This PR adds UPDATE support for DataSource V2, which is a simple following

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-08-29 Thread GitBox
HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319336862 ## File path:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-08-29 Thread GitBox
HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319336862 ## File path:

[GitHub] [spark] younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
younggyuchun commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526430106 > Thank you for review, @cloud-fan ,

[GitHub] [spark] SparkQA commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
SparkQA commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526429921 **[Test build #109933 has

[GitHub] [spark] dongjoon-hyun commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526429760 Thank you for review, @cloud-fan ,

[GitHub] [spark] AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data typ

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526429512 Test PASSed. Refer to this

[GitHub] [spark] AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526429512 Test PASSed. Refer to this link for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data typ

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526429509 Merged build finished. Test

[GitHub] [spark] AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526429509 Merged build finished. Test PASSed.

[GitHub] [spark] younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolea

2019-08-29 Thread GitBox
younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r319335936 ## File path:

[GitHub] [spark] dongjoon-hyun closed pull request #25621: [SPARK-28922][SS] Safe Kafka parameter redaction

2019-08-29 Thread GitBox
dongjoon-hyun closed pull request #25621: [SPARK-28922][SS] Safe Kafka parameter redaction URL: https://github.com/apache/spark/pull/25621 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
SparkQA commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526428401 **[Test build #109932 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526427979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526427974 Merged build finished. Test PASSed. This is

[GitHub] [spark] huaxingao removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
huaxingao removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-523607371 Here is the screen shot

[GitHub] [spark] AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526427974 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25522: [SPARK-28787][DOC][SQL]Document LOAD DATA statement in SQL Reference URL: https://github.com/apache/spark/pull/25522#issuecomment-526427979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] viirya commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
viirya commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526427393 @dongjoon-hyun thanks! This is an automated message from

[GitHub] [spark] wenxuanguan edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
wenxuanguan edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526422493 > Before reviewing the design, I may need to say, you are encouraged to at least mention it if you borrow

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
HeartSaVioR commented on a change in pull request #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#discussion_r319334410 ## File path:

[GitHub] [spark] dongjoon-hyun commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526426911 I'll rebase and merge this after mine, @viirya .

[GitHub] [spark] wenxuanguan edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
wenxuanguan edited a comment on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526422493 > Before reviewing the design, I may need to say, you are encouraged to at least mention it if you borrow

[GitHub] [spark] dongjoon-hyun commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526425818 BTW, I love this PR, @viirya . Thanks. :) This is

[GitHub] [spark] viirya commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
viirya commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r31910 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run: |

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r319333070 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run:

[GitHub] [spark] SparkQA commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
SparkQA commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526425369 **[Test build #109931 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r319332970 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run:

[GitHub] [spark] younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolea

2019-08-29 Thread GitBox
younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r319332973 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data typ

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526424938 Test PASSed. Refer to this

[GitHub] [spark] wenxuanguan commented on a change in pull request #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
wenxuanguan commented on a change in pull request #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#discussion_r319332869 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data typ

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526424935 Merged build finished. Test

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r319332774 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run:

[GitHub] [spark] AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526424935 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type.

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#issuecomment-526424938 Test PASSed. Refer to this link for

[GitHub] [spark] younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolea

2019-08-29 Thread GitBox
younggyuchun commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r319332626 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r319332588 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run:

[GitHub] [spark] viirya commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
viirya commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r319332491 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run: |

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
dongjoon-hyun commented on a change in pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#discussion_r319332072 ## File path: .github/workflows/master.yml ## @@ -24,4 +24,4 @@ jobs: run:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526423372 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526423377 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526423377 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526423372 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] SparkQA removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
SparkQA removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526382995 **[Test build #109919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109919/testReport)** for PR

[GitHub] [spark] SparkQA commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-29 Thread GitBox
SparkQA commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-526422997 **[Test build #109919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109919/testReport)** for PR 25600

[GitHub] [spark] wenxuanguan commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
wenxuanguan commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526422493 > Before reviewing the design, I may need to say, you are encouraged to at least mention it if you borrow the

[GitHub] [spark] wenxuanguan commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming

2019-08-29 Thread GitBox
wenxuanguan commented on issue #25618: [SPARK-28908][SS]Implement Kafka EOS sink for Structured Streaming URL: https://github.com/apache/spark/pull/25618#issuecomment-526421834 > By reading the doc without super deep understanding I've found this in the caveats section: > > ```

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean

2019-08-29 Thread GitBox
HyukjinKwon commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r319329713 ## File path:

[GitHub] [spark] HyukjinKwon closed pull request #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python if not set

2019-08-29 Thread GitBox
HyukjinKwon closed pull request #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python if not set URL: https://github.com/apache/spark/pull/25545 This is an automated message from the Apache Git

[GitHub] [spark] HyukjinKwon commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python if not set

2019-08-29 Thread GitBox
HyukjinKwon commented on issue #25545: [SPARK-28843][PYTHON] Set OMP_NUM_THREADS to executor cores for python if not set URL: https://github.com/apache/spark/pull/25545#issuecomment-526419608 Thanks. Merged to master.

[GitHub] [spark] SparkQA commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
SparkQA commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526417252 **[Test build #109930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109930/testReport)**

[GitHub] [spark] AmplabJenkins removed a comment on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526416777 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526416773 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#issuecomment-526416820 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#issuecomment-526416813 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#issuecomment-526416813 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526416773 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#issuecomment-526416820 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526416777 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] viirya commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
viirya commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526416654 IIUC, we may need this parameter. If I understand it wrongly, please let me know, I will close this. Thanks.

[GitHub] [spark] viirya opened a new pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
viirya opened a new pull request #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625 ### What changes were proposed in this pull request? This patch adds java version parameter to GitHub workflow conf for

[GitHub] [spark] viirya commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow

2019-08-29 Thread GitBox
viirya commented on issue #25625: [SPARK-28920][INFRA] Set up java version for github workflow URL: https://github.com/apache/spark/pull/25625#issuecomment-526416464 cc @dongjoon-hyun @dbtsai This is an automated message

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-08-29 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r319326530 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415688 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-08-29 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r319326530 ## File path:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-08-29 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r319326530 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415684 Merged build finished. Test FAILed. This

[GitHub] [spark] dongjoon-hyun commented on issue #25608: [WIP][SPARK-28894][SQL][TESTS] Report test results of SQLQueryTestSuite correctly in Jenkins

2019-08-29 Thread GitBox
dongjoon-hyun commented on issue #25608: [WIP][SPARK-28894][SQL][TESTS] Report test results of SQLQueryTestSuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25608#issuecomment-526415902 Thanks for investigation. Yes. We really need to handle that properly!

[GitHub] [spark] SparkQA removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
SparkQA removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526400101 **[Test build #109923 has

[GitHub] [spark] SparkQA commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
SparkQA commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415595 **[Test build #109929 has

[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415688 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-08-29 Thread GitBox
HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319326296 ## File path:

[GitHub] [spark] SparkQA commented on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-08-29 Thread GitBox
SparkQA commented on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#issuecomment-526415600 **[Test build #109928 has

[GitHub] [spark] SparkQA commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
SparkQA commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415596 **[Test build #109923 has

[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415684 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration()

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #25616: [SPARK-28907][CORE] Review invalid usage of new Configuration() URL: https://github.com/apache/spark/pull/25616#issuecomment-526067097 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415176 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415179 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415179 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-29 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-526415176 Merged build finished. Test PASSed. This

<    1   2   3   4   5   6   7   8   >