[GitHub] [spark] turboFei commented on a change in pull request #25701: [SPARK-29000][SQL] Decimal precision overflow when don't allow precision loss

2019-09-06 Thread GitBox
turboFei commented on a change in pull request #25701: [SPARK-29000][SQL] Decimal precision overflow when don't allow precision loss URL: https://github.com/apache/spark/pull/25701#discussion_r321946764 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529054300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529054297 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529054297 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529054300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.b

[GitHub] [spark] SparkQA commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
SparkQA commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529054150 **[Test build #110268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110268/testRepo

[GitHub] [spark] SparkQA removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529042381 **[Test build #110268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110268/t

[GitHub] [spark] huaxingao commented on a change in pull request #20442: [SPARK-23265][ML]Update multi-column error handling logic in QuantileDiscretizer

2019-09-06 Thread GitBox
huaxingao commented on a change in pull request #20442: [SPARK-23265][ML]Update multi-column error handling logic in QuantileDiscretizer URL: https://github.com/apache/spark/pull/20442#discussion_r321946449 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDisc

[GitHub] [spark] AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529052152 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529052152 Test PASSed. Refer to this link for build results (access rights to CI server needed): ht

[GitHub] [spark] AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529052148 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529052148 Merged build finished. Test PASSed. Thi

[GitHub] [spark] SparkQA commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
SparkQA commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529051436 **[Test build #110270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110270/t

[GitHub] [spark] viirya commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
viirya commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529051448 cc @cloud-fan @maropu @mgaido91 @rednaxelafx

[GitHub] [spark] AngersZhuuuu commented on issue #25694: [SPARK-28982][SQL] Implementation Spark's own GetTypeInfoOperation

2019-09-06 Thread GitBox
AngersZh commented on issue #25694: [SPARK-28982][SQL] Implementation Spark's own GetTypeInfoOperation URL: https://github.com/apache/spark/pull/25694#issuecomment-529051363 > LGTM. > I think it's good now. > It can be thought between "NULL" and "VOID", but I think it's fine as is

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25694: [SPARK-28982][SQL] Implementation Spark's own GetTypeInfoOperation

2019-09-06 Thread GitBox
AngersZh commented on a change in pull request #25694: [SPARK-28982][SQL] Implementation Spark's own GetTypeInfoOperation URL: https://github.com/apache/spark/pull/25694#discussion_r321944431 ## File path: sql/hive-thriftserver/v2.3.5/src/main/scala/org/apache/spark/sql/hive/th

[GitHub] [spark] HeartSaVioR commented on issue #25709: [SPARK-29007][STREAMING][MLLIB] Enforce not leaking SparkContext in tests which creates new StreamingContext with new SparkContext

2019-09-06 Thread GitBox
HeartSaVioR commented on issue #25709: [SPARK-29007][STREAMING][MLLIB] Enforce not leaking SparkContext in tests which creates new StreamingContext with new SparkContext URL: https://github.com/apache/spark/pull/25709#issuecomment-529048642 Thanks both of you for the valuable feedbacks! I

[GitHub] [spark] SparkQA commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
SparkQA commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529047955 **[Test build #110269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110269/t

[GitHub] [spark] AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529047487 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529047481 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529047481 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529047487 Test PASSed. Refer to this link for build results (access rights to CI server needed): ht

[GitHub] [spark] HeartSaVioR commented on issue #25702: [WIP][SPARK-29001][CORE] Print event thread stack trace when EventQueue starts to drop events

2019-09-06 Thread GitBox
HeartSaVioR commented on issue #25702: [WIP][SPARK-29001][CORE] Print event thread stack trace when EventQueue starts to drop events URL: https://github.com/apache/spark/pull/25702#issuecomment-529047449 It might help if listener thread is stuck on processing specific event, but it could b

[GitHub] [spark] dilipbiswal commented on a change in pull request #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-09-06 Thread GitBox
dilipbiswal commented on a change in pull request #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#discussion_r321940743 ## File path: docs/sql-ref-syntax-aux-cache-clear-cache.md ## @@ -19,4 +19

[GitHub] [spark] maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-06 Thread GitBox
maropu commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529045841 Yea, I think so, too. If its possible for a split function to return two variables (`va

[GitHub] [spark] mgaido91 commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-06 Thread GitBox
mgaido91 commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529044608 I agree with @rednaxelafx . Introducing many class fields shouldn't probably cause is

[GitHub] [spark] AmplabJenkins commented on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-529043882 Merged build finished. Test PASSed. This is an automated message f

[GitHub] [spark] AmplabJenkins removed a comment on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-529043884 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu

[GitHub] [spark] AmplabJenkins removed a comment on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-529043882 Merged build finished. Test PASSed. This is an automated m

[GitHub] [spark] AmplabJenkins commented on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-529043884 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins

[GitHub] [spark] SparkQA commented on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-06 Thread GitBox
SparkQA commented on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-529043543 **[Test build #110258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110258/testReport)** for PR 25708

[GitHub] [spark] SparkQA removed a comment on issue #25708: [SPARK-28141][SQL] Support special date values

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25708: [SPARK-28141][SQL] Support special date values URL: https://github.com/apache/spark/pull/25708#issuecomment-528988337 **[Test build #110258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110258/testReport)** for P

[GitHub] [spark] AmplabJenkins removed a comment on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final.

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final. URL: https://github.com/apache/spark/pull/25712#issuecomment-529042663 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final.

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final. URL: https://github.com/apache/spark/pull/25712#issuecomment-529042668 Test PASSed. Refer to this link for build results (access rights to CI server needed): http

[GitHub] [spark] AmplabJenkins commented on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final.

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final. URL: https://github.com/apache/spark/pull/25712#issuecomment-529042663 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final.

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final. URL: https://github.com/apache/spark/pull/25712#issuecomment-529042668 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] SparkQA commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
SparkQA commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529042381 **[Test build #110268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110268/testRepor

[GitHub] [spark] rednaxelafx commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-06 Thread GitBox
rednaxelafx commented on issue #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#issuecomment-529042370 I haven't reviewed this PR in detail yet, just some first thoughts: At a gla

[GitHub] [spark] SparkQA commented on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final.

2019-09-06 Thread GitBox
SparkQA commented on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final. URL: https://github.com/apache/spark/pull/25712#issuecomment-529042309 **[Test build #110260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110260/t

[GitHub] [spark] SparkQA removed a comment on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final.

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25712: [SPARK-29011][BUILD] Update netty-all from 4.1.30-Final to 4.1.39-Final. URL: https://github.com/apache/spark/pull/25712#issuecomment-529005898 **[Test build #110260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] [spark] AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529042042 Merged build finished. Test PASSed. Thi

[GitHub] [spark] AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529042044 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529042044 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] [spark] AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25654: [SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles() URL: https://github.com/apache/spark/pull/25654#issuecomment-529042042 Merged build finished. Test PASSed. This is an

[GitHub] [spark] HeartSaVioR edited a comment on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR edited a comment on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#issuecomment-529039146 ![Screen Shot 2019-09-07 at 7 44 15 AM](https://user-image

[GitHub] [spark] HeartSaVioR edited a comment on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR edited a comment on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#issuecomment-529039146 ![Screen Shot 2019-09-07 at 7 44 15 AM](https://user-image

[GitHub] [spark] jiangxb1987 commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
jiangxb1987 commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#discussion_r321935470 ## File path: core/src/test/scala/org/a

[GitHub] [spark] gatorsmile commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
gatorsmile commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529040200 Thanks! Merged to master. This is an automa

[GitHub] [spark] gatorsmile closed pull request #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
gatorsmile closed pull request #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658 This is an automated message from the Apache Git Service. To res

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529039723 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/je

[GitHub] [spark] AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529039719 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] SparkQA commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
SparkQA commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529039705 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529039719 Merged build finished. Test PASSed. This is an automated messa

[GitHub] [spark] AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529039723 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//j

[GitHub] [spark] AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529039259 Test FAILed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] SparkQA removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529017747 **[Test build #110261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/

[GitHub] [spark] AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529039259 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amp

[GitHub] [spark] AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529039256 Merged build finished. Test FAILed.

[GitHub] [spark] HeartSaVioR commented on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR commented on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#issuecomment-529039146 ![Screen Shot 2019-09-07 at 7 44 15 AM](https://user-images.githu

[GitHub] [spark] AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529039256 Merged build finished. Test FAILed. Thi

[GitHub] [spark] SparkQA commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination

2019-09-06 Thread GitBox
SparkQA commented on issue #25717: [WIP][SPARK-29013][SQL] Structurally equivalent subexpression elimination URL: https://github.com/apache/spark/pull/25717#issuecomment-529039167 **[Test build #110261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110261/

[GitHub] [spark] dongjoon-hyun commented on issue #25511: [SPARK-22955][DSTREAMS] - graceful shutdown shouldn't lead to job gen…

2019-09-06 Thread GitBox
dongjoon-hyun commented on issue #25511: [SPARK-22955][DSTREAMS] - graceful shutdown shouldn't lead to job gen… URL: https://github.com/apache/spark/pull/25511#issuecomment-529037927 Yes. @srowen . The current merge script has two issues. 1. It doesn't work on the merged PR. 2. It doe

[GitHub] [spark] SparkQA commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
SparkQA commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529036751 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/15262/

[GitHub] [spark] SparkQA commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection

2019-09-06 Thread GitBox
SparkQA commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection URL: https://github.com/apache/spark/pull/25642#issuecomment-529036801 **[Test build #110267 has started](https://amplab.cs.berkeley.edu/jenkins/job/S

[GitHub] [spark] rdblue commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2

2019-09-06 Thread GitBox
rdblue commented on issue #25626: [SPARK-28892][SQL] Add UPDATE support for DataSource V2 URL: https://github.com/apache/spark/pull/25626#issuecomment-529036736 @xianyinxin, can you describe the use case you have for adding this to Spark? We discussed this PR in the last DSv2 sync; s

[GitHub] [spark] SparkQA commented on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
SparkQA commented on issue #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#issuecomment-529036785 **[Test build #110266 has started](https://amplab.cs.berkeley.edu/jenk

[GitHub] [spark] AmplabJenkins removed a comment on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection URL: https://github.com/apache/spark/pull/25642#issuecomment-529036364 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection URL: https://github.com/apache/spark/pull/25642#issuecomment-529036369 Test PASSed. Refer to this link for build results (access right

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#discussion_r321932126 ## File path: core/src/test/scala/org/a

[GitHub] [spark] AmplabJenkins commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection URL: https://github.com/apache/spark/pull/25642#issuecomment-529036369 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection URL: https://github.com/apache/spark/pull/25642#issuecomment-529036364 Merged build finished. Test PASSed. -

[GitHub] [spark] maropu commented on a change in pull request #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-06 Thread GitBox
maropu commented on a change in pull request #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#discussion_r321931750 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sq

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529036141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jen

[GitHub] [spark] AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529036137 Merged build finished. Test PASSed. This is an automated messa

[GitHub] [spark] jinxingwang commented on a change in pull request #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
jinxingwang commented on a change in pull request #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#discussion_r321931812 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorP

[GitHub] [spark] maropu commented on a change in pull request #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec

2019-09-06 Thread GitBox
maropu commented on a change in pull request #25710: [SPARK-29008][SQL] Define an individual method for each common subexpression in HashAggregateExec URL: https://github.com/apache/spark/pull/25710#discussion_r321931750 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sq

[GitHub] [spark] AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529036137 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] SparkQA commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
SparkQA commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529036076 **[Test build #110265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110265/testReport)** for PR 25614 at c

[GitHub] [spark] AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529036141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//jo

[GitHub] [spark] SparkQA removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#issuecomment-529033649 **[Test build #110265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110265/testReport)** for PR 25

[GitHub] [spark] AmplabJenkins removed a comment on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/25718#issuecomment-529035890 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/25718#issuecomment-529033651 **[Test build #110264 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110264/testReport)** for

[GitHub] [spark] AmplabJenkins removed a comment on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/25718#issuecomment-529035893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.ed

[GitHub] [spark] AmplabJenkins commented on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/25718#issuecomment-529035893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkin

[GitHub] [spark] SparkQA commented on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab

2019-09-06 Thread GitBox
SparkQA commented on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/25718#issuecomment-529035837 **[Test build #110264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110264/testReport)** for PR 2571

[GitHub] [spark] AmplabJenkins commented on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25718: [SPARK-28373][DOCS][WebUI] JDBC/ODBC Server Tab URL: https://github.com/apache/spark/pull/25718#issuecomment-529035890 Merged build finished. Test PASSed. This is an automated message

[GitHub] [spark] maropu commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection

2019-09-06 Thread GitBox
maropu commented on issue #25642: [SPARK-28916][SQL] Split subexpression elimination functions code for Generate[Mutable|Unsafe]Projection URL: https://github.com/apache/spark/pull/25642#issuecomment-529035738 retest this please -

[GitHub] [spark] maropu commented on issue #25714: [SPARK-21870][SQL][FOLLOW-UP] Clean up string template formats for generated code in HashAggregateExec

2019-09-06 Thread GitBox
maropu commented on issue #25714: [SPARK-21870][SQL][FOLLOW-UP] Clean up string template formats for generated code in HashAggregateExec URL: https://github.com/apache/spark/pull/25714#issuecomment-529035588 Thanks for the double-check, @dongjoon-hyun ;) ---

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
dongjoon-hyun commented on a change in pull request #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#discussion_r321931184 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/Executo

[GitHub] [spark] jinxingwang commented on a change in pull request #25614: [SPARK-28887][K8S] Executor pod status fix

2019-09-06 Thread GitBox
jinxingwang commented on a change in pull request #25614: [SPARK-28887][K8S] Executor pod status fix URL: https://github.com/apache/spark/pull/25614#discussion_r321930798 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorP

[GitHub] [spark] dongjoon-hyun commented on issue #25714: [SPARK-21870][SQL][FOLLOW-UP] Clean up string template formats for generated code in HashAggregateExec

2019-09-06 Thread GitBox
dongjoon-hyun commented on issue #25714: [SPARK-21870][SQL][FOLLOW-UP] Clean up string template formats for generated code in HashAggregateExec URL: https://github.com/apache/spark/pull/25714#issuecomment-529034928 Ur, @maropu . Although this is a follow-up, we need +1 from the Apache Spark

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#discussion_r321930059 ## File path: core/src/test/scala/org/a

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#discussion_r321930059 ## File path: core/src/test/scala/org/a

[GitHub] [spark] AmplabJenkins commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529034239 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA removed a comment on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
SparkQA removed a comment on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529031856 **[Test build #110263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values

2019-09-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25706: [SPARK-26989][CORE][TEST] DAGSchedulerSuite: ensure listeners are fully processed before checking recorded values URL: https://github.com/apache/spark/pull/25706#discussion_r321930059 ## File path: core/src/test/scala/org/a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529034239 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
AmplabJenkins removed a comment on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529034244 Test PASSed. Refer to this link for build results (access rights to CI server needed): http

[GitHub] [spark] AmplabJenkins commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
AmplabJenkins commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529034244 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] SparkQA commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan

2019-09-06 Thread GitBox
SparkQA commented on issue #25658: [SPARK-28935][SQL][DOCS] Document SQL metrics for Details for Query Plan URL: https://github.com/apache/spark/pull/25658#issuecomment-529034179 **[Test build #110263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110263/t

<    1   2   3   4   5   6   7   8   9   >