[GitHub] [spark] wangyum commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
wangyum commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534866631 @srowen @HyukjinKwon @dongjoon-hyun The test failure fixed by

[GitHub] [spark] wangyum commented on issue #25775: [SPARK-29015][SQL][test-hadoop3.2] fix bug for jdk11, can't use 'add jar' jar's class as create table serde

2019-09-24 Thread GitBox
wangyum commented on issue #25775: [SPARK-29015][SQL][test-hadoop3.2] fix bug for jdk11, can't use 'add jar' jar's class as create table serde URL: https://github.com/apache/spark/pull/25775#issuecomment-534866015 @AngersZh Could you add these to **How was this patch tested?**:

[GitHub] [spark] turboFei commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
turboFei commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534863001 The failed `SQLQueryTestSuite` in sql module passed locally.

[GitHub] [spark] ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-09-24 Thread GitBox
ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#discussion_r327938382 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861440 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861440 Test PASSed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861438 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861438 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534817882 **[Test build #111317 has

[GitHub] [spark] SparkQA commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog

2019-09-24 Thread GitBox
SparkQA commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861087 **[Test build #111317 has

[GitHub] [spark] ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-09-24 Thread GitBox
ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#discussion_r327938382 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859916 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859916 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859914 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534838545 **[Test build #111325 has

[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859914 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859719 **[Test build #111325 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#discussion_r327935435 ## File path:

[GitHub] [spark] ConeyLiu commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
ConeyLiu commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#discussion_r327933288 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853811 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853802 Merged build finished. Test PASSed.

[GitHub] [spark] dongjoon-hyun closed pull request #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
dongjoon-hyun closed pull request #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912 This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853802 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853811 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534822573 **[Test build #111320 has

[GitHub] [spark] dongjoon-hyun commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
dongjoon-hyun commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853560 Merged to master. This is an

[GitHub] [spark] SparkQA commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.

2019-09-24 Thread GitBox
SparkQA commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853402 **[Test build #111320 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25883#discussion_r327929067 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION URL: https://github.com/apache/spark/pull/25883#discussion_r327928927 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847695 Test FAILed. Refer to this link for build results

[GitHub] [spark] AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847688 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847695 Test FAILed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847688 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534787764 **[Test build #111314 has

[GitHub] [spark] SparkQA commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file

2019-09-24 Thread GitBox
SparkQA commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847502 **[Test build #111314 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#discussion_r327928252 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#discussion_r327928039 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846721 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846727 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846721 Merged build finished. Test PASSed.

[GitHub] [spark] ueshin commented on issue #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions

2019-09-24 Thread GitBox
ueshin commented on issue #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions URL: https://github.com/apache/spark/pull/25666#issuecomment-534846779 @nvander1 I'm not sure whether we also need the index argument in `exists`, `forall` and `aggregate`, but we should

[GitHub] [spark] AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846727 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
SparkQA commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846522 **[Test build #111328 has

[GitHub] [spark] AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846174 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534819526 Can one of the admins verify this patch?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846174 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846178 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846178 Test PASSed. Refer to this link for build results (access rights

[GitHub] [spark] dongjoon-hyun commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock

2019-09-24 Thread GitBox
dongjoon-hyun commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846156 ok to test This

[GitHub] [spark] ueshin commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-09-24 Thread GitBox
ueshin commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-534846005 @nvander1 We don't need to wait for #25666. It won't affect the current behavior but just add a new usage. We can do it in

[GitHub] [spark] SparkQA commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows

2019-09-24 Thread GitBox
SparkQA commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534845875 **[Test build #111315 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25723: [SPARK-29019][WebUI] Improve tooltip JDBC/ODBC Server tab

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25723: [SPARK-29019][WebUI] Improve tooltip JDBC/ODBC Server tab URL: https://github.com/apache/spark/pull/25723#discussion_r327927121 ## File path: core/src/main/scala/org/apache/spark/ui/ToolTips.scala ## @@ -99,4

[GitHub] [spark] SparkQA removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534804363 **[Test build #111315 has

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r327926554 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r327926835 ## File path:

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r327926141 ## File path:

[GitHub] [spark] HeartSaVioR commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
HeartSaVioR commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534844432 FYI, we know about https://github.com/sbt/sbt/issues/2949 which failed to get attention,

[GitHub] [spark] HeartSaVioR edited a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
HeartSaVioR edited a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534844432 FYI, we know about https://github.com/sbt/sbt/issues/2949 which failed to get

[GitHub] [spark] turboFei edited a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
turboFei edited a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534679302 > I will try to set our own commitJob method to FileOutputCommitter by using

[GitHub] [spark] turboFei edited a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
turboFei edited a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534679302 > I will try to set our own commitJob method to FileOutputCommitter by using

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r327924629 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534831906 Can one of the admins verify this patch?

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#discussion_r327924070 ## File path:

[GitHub] [spark] SparkQA commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
SparkQA commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534842431 **[Test build #111327 has

[GitHub] [spark] wangshuo128 edited a comment on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec

2019-09-24 Thread GitBox
wangshuo128 edited a comment on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec URL: https://github.com/apache/spark/pull/25902#issuecomment-534840976 @cloud-fan > I have a slightly different proposal: when codegen

[GitHub] [spark] wangshuo128 commented on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec

2019-09-24 Thread GitBox
wangshuo128 commented on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec URL: https://github.com/apache/spark/pull/25902#issuecomment-534840976 @cloud-fan > I have a slightly different proposal: when codegen

[GitHub] [spark] AmplabJenkins removed a comment on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534840043 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534840035 Merged build finished. Test FAILed. This

[GitHub] [spark] nvander1 commented on issue #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions

2019-09-24 Thread GitBox
nvander1 commented on issue #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions URL: https://github.com/apache/spark/pull/25666#issuecomment-534840273 Should we also provide similar overloads with index arguments in `exists`,`forall`, and `aggregate`? Seems

[GitHub] [spark] AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534840014 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534840043 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534805881 **[Test build #111316 has

[GitHub] [spark] AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534840014 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534840035 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter

2019-09-24 Thread GitBox
SparkQA commented on issue #25876: [SPARK-29197][SQL] Remove saveModeForDSV2 from DataFrameWriter URL: https://github.com/apache/spark/pull/25876#issuecomment-534839911 **[Test build #111316 has

[GitHub] [spark] AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534840011 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534840011 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
SparkQA commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534839751 **[Test build #111326 has

[GitHub] [spark] xuanyuanking closed pull request #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API

2019-09-24 Thread GitBox
xuanyuanking closed pull request #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API URL: https://github.com/apache/spark/pull/25361 This is an automated message from the Apache Git Service. To

[GitHub] [spark] xuanyuanking commented on issue #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API

2019-09-24 Thread GitBox
xuanyuanking commented on issue #25361: [SPARK-28625][Core] Indeterminate shuffle support in Shuffle Writer API URL: https://github.com/apache/spark/pull/25361#issuecomment-534839813 Close this preview PR, the API changed in #25620, which uses map task attempt Id as the map id during

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#discussion_r327921439 ## File path:

[GitHub] [spark] nvander1 commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API

2019-09-24 Thread GitBox
nvander1 commented on issue #24232: [SPARK-27297] [SQL] Add higher order functions to scala API URL: https://github.com/apache/spark/pull/24232#issuecomment-534839430 @ueshin Do you want to wait for #25666 to get sorted before moving forward with this? Or get this moving, then add the

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#discussion_r327921439 ## File path:

[GitHub] [spark] gengliangwang commented on a change in pull request #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`

2019-09-24 Thread GitBox
gengliangwang commented on a change in pull request #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#discussion_r327921147 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PostgreSQLDialect.scala

[GitHub] [spark] sarutak commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
sarutak commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534838872 retest this please.

[GitHub] [spark] SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534838545 **[Test build #111325 has

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#discussion_r327920415 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins

2019-09-24 Thread GitBox
HeartSaVioR commented on a change in pull request #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#discussion_r327920415 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534837685 Test FAILed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534837530 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534837685 Test FAILed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534837537 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534837680 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534837680 Merged build finished. Test FAILed.

[GitHub] [spark] SparkQA removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
SparkQA removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534817874 **[Test build #111318 has

[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534837537 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.

2019-09-24 Thread GitBox
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534837530 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view

2019-09-24 Thread GitBox
SparkQA commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534837521 **[Test build #111318 has

[GitHub] [spark] SparkQA commented on issue #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable

2019-09-24 Thread GitBox
SparkQA commented on issue #25849: [SPARK-29175][SQL] Make additional remote maven repository in IsolatedClientLoader configurable URL: https://github.com/apache/spark/pull/25849#issuecomment-534837228 **[Test build #111324 has

[GitHub] [spark] viirya commented on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec

2019-09-24 Thread GitBox
viirya commented on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec URL: https://github.com/apache/spark/pull/25902#issuecomment-534837111 Ah, I see. You are correct. Your proposal sounds good.

  1   2   3   4   5   6   7   8   9   10   >