[GitHub] [spark] SparkQA commented on issue #25895: [SPARK-28816][DOC][SQL] Document ADD JAR statement in SQL Reference

2019-10-06 Thread GitBox
SparkQA commented on issue #25895: [SPARK-28816][DOC][SQL] Document ADD JAR statement in SQL Reference URL: https://github.com/apache/spark/pull/25895#issuecomment-538850680 **[Test build #111832 has

[GitHub] [spark] xuanyuanking commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
xuanyuanking commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538849642 cc @yucai @cloud-fan @jiangxb1987 This is

[GitHub] [spark] xuanyuanking commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
xuanyuanking commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538849477 The difference between this PR and the original one is mainly caused by the following proposals from my

[GitHub] [spark] AmplabJenkins removed a comment on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538846628 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538846619 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538846619 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538846628 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
SparkQA commented on issue #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040#issuecomment-538846299 **[Test build #111831 has

[GitHub] [spark] xuanyuanking opened a new pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs

2019-10-06 Thread GitBox
xuanyuanking opened a new pull request #26040: [SPARK-9853][Core] Optimize shuffle fetch of continuous partition IDs URL: https://github.com/apache/spark/pull/26040 This PR takes over #19788. After we split the shuffle fetch protocol from `OpenBlock` in #24565, this optimization can be

[GitHub] [spark] AngersZhuuuu commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2

2019-10-06 Thread GitBox
AngersZh commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-538844100 > Is it possible to build the Hadoop 3.2 release and spot check whether the changes are correct --

[GitHub] [spark] HeartSaVioR edited a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
HeartSaVioR edited a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538839655 Just leaving a general comment, as I'm not familiar with this change: > The

[GitHub] [spark] HeartSaVioR commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
HeartSaVioR commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538839655 Just leaving general comments, as I'm not familiar with this change: > The subquery

[GitHub] [spark] HeartSaVioR edited a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
HeartSaVioR edited a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538839655 Just leaving a general comment, as I'm not familiar with this change: > The

[GitHub] [spark] HeartSaVioR commented on issue #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on issue #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#issuecomment-538838751 @Ngone51 I've reviewed only a small part yet, but feel that supporting

[GitHub] [spark] AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538838305 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538838310 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538838305 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538838310 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #26001: [SPARK-29331][SQL] create DS v2 Write at physical plan

2019-10-06 Thread GitBox
cloud-fan commented on a change in pull request #26001: [SPARK-29331][SQL] create DS v2 Write at physical plan URL: https://github.com/apache/spark/pull/26001#discussion_r331843957 ## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala

[GitHub] [spark] SparkQA removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
SparkQA removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538809621 **[Test build #111829 has

[GitHub] [spark] dilipbiswal commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
dilipbiswal commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538838141 cc @cloud-fan @gatorsmile This

[GitHub] [spark] SparkQA commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
SparkQA commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538838019 **[Test build #111829 has

[GitHub] [spark] dilipbiswal commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
dilipbiswal commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538836990 LGTM cc @srowen @gatorsmile This is an

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331843003 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-53883 Merged build finished. Test PASSed. This

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331842874 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538836670 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
SparkQA removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538835049 **[Test build #111830 has

[GitHub] [spark] AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-53883 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538836670 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331842861 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] SparkQA commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
SparkQA commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538836617 **[Test build #111830 has

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331842134 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538835281 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538835287 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331841963 ## File path:

[GitHub] [spark] shivusondur commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
shivusondur commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#discussion_r331841959 ## File path: docs/sql-ref-syntax-aux-show-tables.md ## @@ -18,5 +18,86 @@

[GitHub] [spark] AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538835287 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] shivusondur commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
shivusondur commented on a change in pull request #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#discussion_r331841928 ## File path: docs/sql-ref-syntax-aux-show-tables.md ## @@ -18,5 +18,86 @@

[GitHub] [spark] AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538835281 Merged build finished. Test PASSed. This is an

[GitHub] [spark] SparkQA commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference.

2019-10-06 Thread GitBox
SparkQA commented on issue #25561: [SPARK-28810][DOC][SQL] Document SHOW TABLES in SQL Reference. URL: https://github.com/apache/spark/pull/25561#issuecomment-538835049 **[Test build #111830 has

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331841760 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331841692 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] imback82 commented on a change in pull request #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path

2019-10-06 Thread GitBox
imback82 commented on a change in pull request #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path URL: https://github.com/apache/spark/pull/26006#discussion_r331841565 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331840527 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-538832433 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-538832439 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-538832439 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-538832433 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
SparkQA removed a comment on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-538804836 **[Test build #111828 has

[GitHub] [spark] SparkQA commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
SparkQA commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-53883 **[Test build #111828 has

[GitHub] [spark] cloud-fan commented on a change in pull request #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path

2019-10-06 Thread GitBox
cloud-fan commented on a change in pull request #26006: [SPARK-29279][SQL] Merge SHOW NAMESPACES and SHOW DATABASES code path URL: https://github.com/apache/spark/pull/26006#discussion_r331839869 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331839713 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331839522 ## File path: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331838152 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala

[GitHub] [spark] imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs

2019-10-06 Thread GitBox
imatiach-msft commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#discussion_r331838218 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331834249 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331834249 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331835120 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26031: [SPARK-29362][SQL] Move timestamp expressions and tests to separate files

2019-10-06 Thread GitBox
cloud-fan commented on issue #26031: [SPARK-29362][SQL] Move timestamp expressions and tests to separate files URL: https://github.com/apache/spark/pull/26031#issuecomment-538825362 This is a tradeoff that we need to evaluate. We should not blindly reject any cross-file code movement

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331834249 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331831520 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331831082 ## File path:

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener

2019-10-06 Thread GitBox
HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331831332 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26025: [SPARK-28892][SQL][followup] add resolved logical plan for UPDATE TABLE

2019-10-06 Thread GitBox
cloud-fan commented on a change in pull request #26025: [SPARK-28892][SQL][followup] add resolved logical plan for UPDATE TABLE URL: https://github.com/apache/spark/pull/26025#discussion_r331831130 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #26025: [SPARK-28892][SQL][followup] add resolved logical plan for UPDATE TABLE

2019-10-06 Thread GitBox
cloud-fan commented on a change in pull request #26025: [SPARK-28892][SQL][followup] add resolved logical plan for UPDATE TABLE URL: https://github.com/apache/spark/pull/26025#discussion_r331830967 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538809837 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538809828 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538809837 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538809828 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
SparkQA commented on issue #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039#issuecomment-538809621 **[Test build #111829 has

[GitHub] [spark] dilipbiswal opened a new pull request #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED

2019-10-06 Thread GitBox
dilipbiswal opened a new pull request #26039: [SPARK-29366][SQL] Subqueries created for DPP are not printed in EXPLAIN FORMATTED URL: https://github.com/apache/spark/pull/26039 ### What changes were proposed in this pull request? The subquery expressions introduced by DPP are not

[GitHub] [spark] SparkQA commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation

2019-10-06 Thread GitBox
SparkQA commented on issue #26011: [SPARK-29343][SQL] Eliminate sorts without limit in the subquery of Join/Aggregation URL: https://github.com/apache/spark/pull/26011#issuecomment-538804836 **[Test build #111828 has

[GitHub] [spark] HeartSaVioR commented on issue #24208: [SPARK-27272][CORE] Enable blacklisting of node/executor on fetch failures by default

2019-10-06 Thread GitBox
HeartSaVioR commented on issue #24208: [SPARK-27272][CORE] Enable blacklisting of node/executor on fetch failures by default URL: https://github.com/apache/spark/pull/24208#issuecomment-538800434 Looks like this got two +1s but stuck with -1. Origin concern seemed to be resolved but the

[GitHub] [spark] AmplabJenkins removed a comment on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538792188 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538792187 Merged build finished. Test PASSed. This is

[GitHub] [spark] MaxGekk commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
MaxGekk commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538792235 @dongjoon-hyun @srowen @cloud-fan Could you review this PR.

[GitHub] [spark] AmplabJenkins commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538792187 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538792188 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
SparkQA removed a comment on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538773126 **[Test build #111822 has

[GitHub] [spark] SparkQA commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction

2019-10-06 Thread GitBox
SparkQA commented on issue #26036: [SPARK-29365][SQL] Support dates and timestamps subtraction URL: https://github.com/apache/spark/pull/26036#issuecomment-538792066 **[Test build #111822 has

[GitHub] [spark] AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538790656 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538790654 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538790656 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
SparkQA removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538789196 **[Test build #111827 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538790654 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
SparkQA commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538790603 **[Test build #111827 has

[GitHub] [spark] viirya edited a comment on issue #26037: [SPARK-28938][K8S] Move to supported OpenJDK docker image for Kubernetes

2019-10-06 Thread GitBox
viirya edited a comment on issue #26037: [SPARK-28938][K8S] Move to supported OpenJDK docker image for Kubernetes URL: https://github.com/apache/spark/pull/26037#issuecomment-538789852 And yes, ensurepip is a problem. Let me update and test locally.

[GitHub] [spark] viirya commented on issue #26037: [SPARK-28938][K8S] Move to supported OpenJDK docker image for Kubernetes

2019-10-06 Thread GitBox
viirya commented on issue #26037: [SPARK-28938][K8S] Move to supported OpenJDK docker image for Kubernetes URL: https://github.com/apache/spark/pull/26037#issuecomment-538789852 And yes, ensurepip is a problem. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538789605 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538789607 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538789607 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538789605 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
SparkQA commented on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538789437 **[Test build #111821 has

[GitHub] [spark] SparkQA removed a comment on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite

2019-10-06 Thread GitBox
SparkQA removed a comment on issue #26028: [SPARK-29359][SQL][TESTS] Better exception handling in (SQL|ThriftServer)QueryTestSuite URL: https://github.com/apache/spark/pull/26028#issuecomment-538771086 **[Test build #111821 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538789308 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538789310 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins removed a comment on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538789310 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
AmplabJenkins commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538789308 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel

2019-10-06 Thread GitBox
SparkQA commented on issue #26038: [SPARK-29235][ML][Pyspark]Support avgMetrics in read/write of CrossValidatorModel URL: https://github.com/apache/spark/pull/26038#issuecomment-538789196 **[Test build #111827 has

  1   2   3   >