[GitHub] [spark] SparkQA removed a comment on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558424377 **[Test build #114435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114435/testReport)** for PR 26671 at

[GitHub] [spark] cloud-fan commented on issue #26595: [SPARK-29956][SQL] A literal number with an exponent should be parsed to Double

2019-11-25 Thread GitBox
cloud-fan commented on issue #26595: [SPARK-29956][SQL] A literal number with an exponent should be parsed to Double URL: https://github.com/apache/spark/pull/26595#issuecomment-558467874 also cc @viirya @maropu This is an

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AngersZh commented on a change in pull request #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#discussion_r350549930 ## File path: pom.xml ## @@ -1024,7 +1025,7 @@ org.apache.hadoop

[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558467369 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang URL: https://github.com/apache/spark/pull/26673#issuecomment-558467299 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558467373 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang URL: https://github.com/apache/spark/pull/26673#issuecomment-558467304 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558467369 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang URL: https://github.com/apache/spark/pull/26673#issuecomment-558467304 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558467373 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang URL: https://github.com/apache/spark/pull/26673#issuecomment-558467299 Merged build finished. Test PASSed. This is

[GitHub] [spark] SparkQA commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
SparkQA commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558466959 **[Test build #114443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114443/testReport)** for PR 26594 at

[GitHub] [spark] SparkQA commented on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang

2019-11-25 Thread GitBox
SparkQA commented on issue #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang URL: https://github.com/apache/spark/pull/26673#issuecomment-558466953 **[Test build #114442 has

[GitHub] [spark] cloud-fan commented on a change in pull request #26466: [SPARK-29839][SQL] Supporting STORED AS in CREATE TABLE LIKE

2019-11-25 Thread GitBox
cloud-fan commented on a change in pull request #26466: [SPARK-29839][SQL] Supporting STORED AS in CREATE TABLE LIKE URL: https://github.com/apache/spark/pull/26466#discussion_r350549362 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala

[GitHub] [spark] dongjoon-hyun opened a new pull request #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang

2019-11-25 Thread GitBox
dongjoon-hyun opened a new pull request #26673: [SPARK-30030][BUILD][FOLLOWUP] Remove unused org.apache.commons.lang URL: https://github.com/apache/spark/pull/26673 ### What changes were proposed in this pull request? This PR aims to remove the unused test dependency

[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558465609 Build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558465616 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558465616 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#issuecomment-558465609 Build finished. Test PASSed. This is an automated message from the

[GitHub] [spark] cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558465360 For top-level limit, we use a special physical plan `CollectLimitExec`, which doesn't have a shuffle. The

[GitHub] [spark] AngersZhuuuu commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AngersZh commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558463297 > @AngersZh after some more thoughts, I think we can still reuse non-correlated scalar subquery.

[GitHub] [spark] cloud-fan commented on a change in pull request #26595: [SPARK-29956][SQL] A literal number with an exponent should be parsed to Double

2019-11-25 Thread GitBox
cloud-fan commented on a change in pull request #26595: [SPARK-29956][SQL] A literal number with an exponent should be parsed to Double URL: https://github.com/apache/spark/pull/26595#discussion_r350544159 ## File path:

[GitHub] [spark] cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
cloud-fan commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558460184 @AngersZh after some more thoughts, I think we can still reuse non-correlated scalar subquery. We can

[GitHub] [spark] cloud-fan closed pull request #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
cloud-fan closed pull request #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665 This is an automated message from the

[GitHub] [spark] cloud-fan commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
cloud-fan commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558459625 thanks, merging to master!

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558458791 @HeartSaVioR the file `CsvOutputWriter.scala` was moved in another PR, and this PR is **not directly reverting** from the original commit.

[GitHub] [spark] gengliangwang edited a comment on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
gengliangwang edited a comment on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558458791 @HeartSaVioR the file `CsvOutputWriter.scala` was moved in another PR, and this PR is **not directly reverting** from the original

[GitHub] [spark] cloud-fan commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
cloud-fan commented on issue #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659#issuecomment-558458598 thanks, merging to master! This is an automated message from

[GitHub] [spark] cloud-fan closed pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description

2019-11-25 Thread GitBox
cloud-fan closed pull request #26659: [MINOR][DOC] Fix the CalendarIntervalType description URL: https://github.com/apache/spark/pull/26659 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-558457176 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on issue #26617: [SPARK-29979][SQL]Add basic/reserved property key constants in TableCatalog and SupportsNamespaces

2019-11-25 Thread GitBox
cloud-fan commented on issue #26617: [SPARK-29979][SQL]Add basic/reserved property key constants in TableCatalog and SupportsNamespaces URL: https://github.com/apache/spark/pull/26617#issuecomment-558457227 @rdblue It's a little weird to have only a `TableCatalog` and others are

[GitHub] [spark] AmplabJenkins removed a comment on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9 URL: https://github.com/apache/spark/pull/26672#issuecomment-558457185 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-558457181 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9 URL: https://github.com/apache/spark/pull/26672#issuecomment-558457188 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9 URL: https://github.com/apache/spark/pull/26672#issuecomment-558457185 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9 URL: https://github.com/apache/spark/pull/26672#issuecomment-558457188 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-558457181 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-558457176 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9

2019-11-25 Thread GitBox
SparkQA commented on issue #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9 URL: https://github.com/apache/spark/pull/26672#issuecomment-558456896 **[Test build #114440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114440/testReport)** for

[GitHub] [spark] SparkQA commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
SparkQA commented on issue #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#issuecomment-558456900 **[Test build #114441 has

[GitHub] [spark] dongjoon-hyun opened a new pull request #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9

2019-11-25 Thread GitBox
dongjoon-hyun opened a new pull request #26672: [SPARK-30035][BUILD] Upgrade to Apache Commons Lang 3.9 URL: https://github.com/apache/spark/pull/26672 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this

[GitHub] [spark] HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558455533 For now I restored the UT and move the UT to the place where it will be checked with both DSv1 and DSv2, and modified the description of PR. I

[GitHub] [spark] AmplabJenkins removed a comment on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558424608 Can one of the admins verify this patch? This is an automated

[GitHub] [spark] SparkQA commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
SparkQA commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558455326 **[Test build #114439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114439/testReport)** for PR 26671 at commit

[GitHub] [spark] AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558454794 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558454791 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558454791 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558454794 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] SparkQA removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558424392 **[Test build #114436 has

[GitHub] [spark] SparkQA commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
SparkQA commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558454457 **[Test build #114436 has

[GitHub] [spark] dongjoon-hyun commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
dongjoon-hyun commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558452803 It's surprising to me that the PR Builder ignores `lint-java`, but we have `GitHub Action` for that.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
dongjoon-hyun commented on a change in pull request #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#discussion_r350537380 ## File path:

[GitHub] [spark] HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558452333 Sorry I'm not clear on understanding the suggestion. Looks like you don't suggest to "do clean revert on both issues", but suggest to "do

[GitHub] [spark] dongjoon-hyun closed pull request #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
dongjoon-hyun closed pull request #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] dongjoon-hyun commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
dongjoon-hyun commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558450445 Thank you, @HyukjinKwon , @viirya , @gengliangwang . Merged to master.

[GitHub] [spark] dongjoon-hyun commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
dongjoon-hyun commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558450299 Yes. I also expect only a revert of SPARK-26081 (including the SPARK-2 body part).

[GitHub] [spark] gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
gengliangwang commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558448838 Well I was expecting this PR comes with UTs... @dongjoon-hyun @gatorsmile @zsxwing WDYT?

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350527629 ## File path:

[GitHub] [spark] wangyum commented on a change in pull request #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
wangyum commented on a change in pull request #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#discussion_r350525419 ## File path: pom.xml ## @@ -1024,7 +1025,7 @@ org.apache.hadoop hadoop-minikdc

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350523160 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-by-filter.sql

[GitHub] [spark] SparkQA commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
SparkQA commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558436654 **[Test build #114438 has

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350523022 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-by-filter.sql

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350522962 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350522785 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350522693 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350522662 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558435227 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558435219 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558435227 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350521717 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558435219 Merged build finished. Test PASSed.

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350521699 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] wangyum commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries

2019-11-25 Thread GitBox
wangyum commented on issue #26437: [SPARK-29800][SQL] Plan non-correlated Exists 's subquery in PlanSubqueries URL: https://github.com/apache/spark/pull/26437#issuecomment-558434852 retest this please This is an automated

[GitHub] [spark] beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression

2019-11-25 Thread GitBox
beliefer commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350521572 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558434470 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558434474 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558434470 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558434474 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558404911 **[Test build #114434 has

[GitHub] [spark] wangyum commented on a change in pull request #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0

2019-11-25 Thread GitBox
wangyum commented on a change in pull request #26594: [SPARK-29957][TEST] Bump MiniKdc to 3.2.0 URL: https://github.com/apache/spark/pull/26594#discussion_r350520924 ## File path: pom.xml ## @@ -1024,7 +1025,7 @@ org.apache.hadoop hadoop-minikdc

[GitHub] [spark] SparkQA commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system.

2019-11-25 Thread GitBox
SparkQA commented on issue #26670: [SPARK-30033][core] Manage shuffle IO plugins using Spark's plugin system. URL: https://github.com/apache/spark/pull/26670#issuecomment-558434088 **[Test build #114434 has

[GitHub] [spark] HeartSaVioR commented on issue #24128: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #24128: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files URL: https://github.com/apache/spark/pull/24128#issuecomment-558433816 Maybe we can differentiate two major cases: 1) downstream query to read the output

[GitHub] [spark] AmplabJenkins removed a comment on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#issuecomment-558433479 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#issuecomment-558433475 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#issuecomment-558433479 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#issuecomment-558433475 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA commented on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
SparkQA commented on issue #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#issuecomment-558433178 **[Test build #114437 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558432933 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558432925 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558432925 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558432933 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] mdianjun commented on a change in pull request #26650: [CORE] Fix a bug in getBlockHosts

2019-11-25 Thread GitBox
mdianjun commented on a change in pull request #26650: [CORE] Fix a bug in getBlockHosts URL: https://github.com/apache/spark/pull/26650#discussion_r350519493 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/PartitionedFileUtil.scala ## @@ -69,8 +69,8

[GitHub] [spark] SparkQA removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
SparkQA removed a comment on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558400885 **[Test build #114433 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114433/testReport)** for PR

[GitHub] [spark] SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8

2019-11-25 Thread GitBox
SparkQA commented on issue #26669: [SPARK-30032][BUILD] Upgrade to ORC 1.5.8 URL: https://github.com/apache/spark/pull/26669#issuecomment-558432547 **[Test build #114433 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114433/testReport)** for PR 26669 at

[GitHub] [spark] Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
Ngone51 commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350514186 ## File path:

[GitHub] [spark] HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558425298 I skipped copying full title on each PR as we're reverting two issues which would make very long title.

[GitHub] [spark] AmplabJenkins commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
AmplabJenkins commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558424608 Can one of the admins verify this patch? This is an automated message from

[GitHub] [spark] viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions

2019-11-25 Thread GitBox
viirya commented on a change in pull request #26629: [SPARK-29768][SQL] Column pruning through nondeterministic expressions URL: https://github.com/apache/spark/pull/26629#discussion_r350512011 ## File path:

[GitHub] [spark] SparkQA commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext

2019-11-25 Thread GitBox
SparkQA commented on issue #26665: [MINOR][CORE] Make EventLogger codec be consistent between EventLogFileWriter and SparkContext URL: https://github.com/apache/spark/pull/26665#issuecomment-558424392 **[Test build #114436 has

[GitHub] [spark] SparkQA commented on issue #26671: Revert "[SPARK-26081][SPARK-29999]"

2019-11-25 Thread GitBox
SparkQA commented on issue #26671: Revert "[SPARK-26081][SPARK-2]" URL: https://github.com/apache/spark/pull/26671#issuecomment-558424377 **[Test build #114435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/114435/testReport)** for PR 26671 at commit

<    1   2   3   4   5   6   7   8   9   10   >