[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620894431 **[Test build #122005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122005/testReport)** for PR 28370 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620892563 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620892563 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620760923 **[Test build #122012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122012/testReport)** for PR 28330 at commit

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620891896 **[Test build #122012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122012/testReport)** for PR 28330 at commit

[GitHub] [spark] redsanket commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
redsanket commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620883306 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620876695 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620876695 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620773904 **[Test build #122015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122015/testReport)** for PR 28358 at commit

[GitHub] [spark] SparkQA commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
SparkQA commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620875606 **[Test build #122015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122015/testReport)** for PR 28358 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620871829 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620871829 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] gatorsmile commented on pull request #28224: [SPARK-31429][SQL][DOC] Automatically generates a SQL document for built-in functions

2020-04-28 Thread GitBox
gatorsmile commented on pull request #28224: URL: https://github.com/apache/spark/pull/28224#issuecomment-620871453 Thank you, this looks great! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA removed a comment on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620720359 **[Test build #122007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122007/testReport)** for PR 28392 at commit

[GitHub] [spark] SparkQA commented on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
SparkQA commented on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620870935 **[Test build #122007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122007/testReport)** for PR 28392 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620868247 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620868245 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620868245 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620773952 **[Test build #122014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122014/testReport)** for PR 28379 at commit

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620867591 **[Test build #122014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122014/testReport)** for PR 28379 at commit

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
dongjoon-hyun edited a comment on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620804122 Introducing `AggregateWithHaving` is elegant and nice, but the meaning of this PR seems to be different in `branch-2.4` from `branch-3.0`. It would be great if we

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620864651 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28397: URL: https://github.com/apache/spark/pull/28397#discussion_r416934315 ## File path: sql/core/src/test/resources/sql-tests/inputs/having.sql ## @@ -16,3 +16,6 @@ SELECT MIN(t.v) FROM (SELECT * FROM hav WHERE v > 0) t

[GitHub] [spark] AmplabJenkins commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620864651 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620710970 **[Test build #122006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122006/testReport)** for PR 28194 at commit

[GitHub] [spark] SparkQA commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
SparkQA commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620863618 **[Test build #122006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122006/testReport)** for PR 28194 at commit

[GitHub] [spark] SparkQA commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
SparkQA commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620861549 **[Test build #122018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122018/testReport)** for PR 28378 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620858496 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620858496 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620333535 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] gengliangwang commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
gengliangwang commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620857662 ok to test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] baohe-zhang commented on pull request #28378: [SPARK-31584][WebUI] Fix NullPointerException when parsing event log with InMemoryStore

2020-04-28 Thread GitBox
baohe-zhang commented on pull request #28378: URL: https://github.com/apache/spark/pull/28378#issuecomment-620857128 @HeartSaVioR @gengliangwang The UT is added. InMemoryStoreSuite.java :249 would throw a NullPointerException if we don't have this fix.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620837437 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620837437 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620673509 **[Test build #122004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122004/testReport)** for PR 28369 at commit

[GitHub] [spark] SparkQA commented on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
SparkQA commented on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620836377 **[Test build #122004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122004/testReport)** for PR 28369 at commit

[GitHub] [spark] mengxr commented on a change in pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-28 Thread GitBox
mengxr commented on a change in pull request #28395: URL: https://github.com/apache/spark/pull/28395#discussion_r416885587 ## File path: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala ## @@ -168,6 +168,23 @@ private[spark] object PythonRDD extends Logging {

[GitHub] [spark] AmplabJenkins commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620818999 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620818999 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
SparkQA commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620818497 **[Test build #122017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122017/testReport)** for PR 28375 at commit

[GitHub] [spark] imback82 commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
imback82 commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620817959 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maryannxue commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2020-04-28 Thread GitBox
maryannxue commented on a change in pull request #23531: URL: https://github.com/apache/spark/pull/23531#discussion_r416874322 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala ## @@ -253,6 +257,143 @@ case class

[GitHub] [spark] maryannxue commented on a change in pull request #23531: [SPARK-24497][SQL] Support recursive SQL query

2020-04-28 Thread GitBox
maryannxue commented on a change in pull request #23531: URL: https://github.com/apache/spark/pull/23531#discussion_r416872953 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala ## @@ -253,6 +257,143 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620811602 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620811593 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620811593 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620633288 **[Test build #122003 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122003/testReport)** for PR 28394 at commit

[GitHub] [spark] SparkQA commented on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
SparkQA commented on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620810121 **[Test build #122003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122003/testReport)** for PR 28394 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620809442 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620809442 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620605847 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620605135 **[Test build #121996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121996/testReport)** for PR 27803 at commit

[GitHub] [spark] SparkQA commented on pull request #27803: [SPARK-31049][SQL] Support nested adjacent generators, e.g., explode(explode(v))

2020-04-28 Thread GitBox
SparkQA commented on pull request #27803: URL: https://github.com/apache/spark/pull/27803#issuecomment-620808344 **[Test build #121996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121996/testReport)** for PR 27803 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
dongjoon-hyun commented on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620804122 Introducing `AggregateWithHaving` is elegant and nice, but the meaning of this PR seems to be different in `branch-2.4`. It would be great if we have a proper PR title

[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
MichaelChirico commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620800199 I would leave the JVM stuff to the developers working more closely with that code base. Translations only have to be updated at release time & the marginal cost from

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620798194 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620798186 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620798186 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620728738 **[Test build #122008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122008/testReport)** for PR 28375 at commit

[GitHub] [spark] SparkQA commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
SparkQA commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620797991 **[Test build #122008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122008/testReport)** for PR 28375 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620769689 **[Test build #122013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122013/testReport)** for PR 28387 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620795417 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620795417 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
SparkQA commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620795128 **[Test build #122013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122013/testReport)** for PR 28387 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28396: [SPARK-31597][SQL] extracting day from intervals should be interval.days + days in interval.microsecond

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28396: URL: https://github.com/apache/spark/pull/28396#issuecomment-620792038 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28396: [SPARK-31597][SQL] extracting day from intervals should be interval.days + days in interval.microsecond

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28396: URL: https://github.com/apache/spark/pull/28396#issuecomment-620792029 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28396: [SPARK-31597][SQL] extracting day from intervals should be interval.days + days in interval.microsecond

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28396: URL: https://github.com/apache/spark/pull/28396#issuecomment-620792029 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28396: [SPARK-31597][SQL] extracting day from intervals should be interval.days + days in interval.microsecond

2020-04-28 Thread GitBox
SparkQA commented on pull request #28396: URL: https://github.com/apache/spark/pull/28396#issuecomment-620790929 **[Test build #122002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122002/testReport)** for PR 28396 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28396: [SPARK-31597][SQL] extracting day from intervals should be interval.days + days in interval.microsecond

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28396: URL: https://github.com/apache/spark/pull/28396#issuecomment-620628659 **[Test build #122002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122002/testReport)** for PR 28396 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620782676 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620782676 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620760984 **[Test build #122011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122011/testReport)** for PR 28386 at commit

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620782470 **[Test build #122011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122011/testReport)** for PR 28386 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28399: [SPARK-31563][SQL][FOLLOWUP] Create literals directly from Catalyst's internal value in InSet.sql

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28399: URL: https://github.com/apache/spark/pull/28399#issuecomment-620778771 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28399: [SPARK-31563][SQL][FOLLOWUP] Create literals directly from Catalyst's internal value in InSet.sql

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28399: URL: https://github.com/apache/spark/pull/28399#issuecomment-620778771 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28399: [SPARK-31563][SQL][FOLLOWUP] Create literals directly from Catalyst's internal value in InSet.sql

2020-04-28 Thread GitBox
SparkQA commented on pull request #28399: URL: https://github.com/apache/spark/pull/28399#issuecomment-620778034 **[Test build #122016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122016/testReport)** for PR 28399 at commit

[GitHub] [spark] MaxGekk commented on pull request #28399: [SPARK-31563][SQL][FOLLOWUP] Create literals directly from Catalyst's internal value in InSet.sql

2020-04-28 Thread GitBox
MaxGekk commented on pull request #28399: URL: https://github.com/apache/spark/pull/28399#issuecomment-620777186 @cloud-fan Please, take a look at it. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] MaxGekk opened a new pull request #28399: [SPARK-31563][SQL][FOLLOWUP] Create literals directly from Catalyst's internal value in InSet.sql

2020-04-28 Thread GitBox
MaxGekk opened a new pull request #28399: URL: https://github.com/apache/spark/pull/28399 ### What changes were proposed in this pull request? In the PR, I propose to simplify the code of `InSet.sql` and create `Literal` instances directly from Catalyst's internal values by using the

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28385: URL: https://github.com/apache/spark/pull/28385#discussion_r416826778 ## File path: core/src/main/scala/org/apache/spark/util/Utils.scala ## @@ -304,7 +304,8 @@ private[spark] object Utils extends Logging {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28385: [SPARK-31591][CORE] Fix null name prefix when create directory

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28385: URL: https://github.com/apache/spark/pull/28385#discussion_r416827038 ## File path: core/src/main/scala/org/apache/spark/util/Utils.scala ## @@ -304,7 +304,8 @@ private[spark] object Utils extends Logging {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620774597 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620774597 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620773952 **[Test build #122014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122014/testReport)** for PR 28379 at commit

[GitHub] [spark] SparkQA commented on pull request #28358: [WIP][SPARK-31567][R][TESTS] Update AppVeyor R version to 4.0.0

2020-04-28 Thread GitBox
SparkQA commented on pull request #28358: URL: https://github.com/apache/spark/pull/28358#issuecomment-620773904 **[Test build #122015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122015/testReport)** for PR 28358 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620772185 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620772185 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620610184 **[Test build #121998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121998/testReport)** for PR 28394 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620770541 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28394: [SPARK-31596][SQL][DOCS] Generate SQL Configurations from hive module to configuration doc

2020-04-28 Thread GitBox
SparkQA commented on pull request #28394: URL: https://github.com/apache/spark/pull/28394#issuecomment-620770898 **[Test build #121998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121998/testReport)** for PR 28394 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620770393 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620770541 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620770393 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
SparkQA commented on pull request #28387: URL: https://github.com/apache/spark/pull/28387#issuecomment-620769689 **[Test build #122013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122013/testReport)** for PR 28387 at commit

[GitHub] [spark] srowen commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
srowen commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620769739 Sure, but, what about the 1000s in the JVM code this calls too? a little translation isn't going to help anyway. Think about maintaining translations for new messages. I don't

[GitHub] [spark] MichaelChirico commented on a change in pull request #28387: [SPARK-29339][R][FOLLOW-UP] Remove requireNamespace1 workaround for arrow

2020-04-28 Thread GitBox
MichaelChirico commented on a change in pull request #28387: URL: https://github.com/apache/spark/pull/28387#discussion_r416819050 ## File path: R/pkg/R/types.R ## @@ -88,11 +88,6 @@ specialtypeshandle <- function(type) { checkSchemaInArrow <- function(schema) {

[GitHub] [spark] MichaelChirico commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
MichaelChirico commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620765673 > I doubt we will ever have translations. my two cents is, it's mainly a matter of volition. As of now, `SparkR` has only 200 messages to translate (my guess

[GitHub] [spark] AmplabJenkins commented on pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28368: URL: https://github.com/apache/spark/pull/28368#issuecomment-620763913 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28368: URL: https://github.com/apache/spark/pull/28368#issuecomment-620763913 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28368: URL: https://github.com/apache/spark/pull/28368#issuecomment-620595120 **[Test build #121995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121995/testReport)** for PR 28368 at commit

[GitHub] [spark] SparkQA commented on pull request #28368: [SPARK-31575][SQL] Synchronise global JVM security configuration modification

2020-04-28 Thread GitBox
SparkQA commented on pull request #28368: URL: https://github.com/apache/spark/pull/28368#issuecomment-620762825 **[Test build #121995 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121995/testReport)** for PR 28368 at commit

<    1   2   3   4   5   6   7   8   9   >