[GitHub] [spark] viirya commented on a change in pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-02 Thread GitBox
viirya commented on a change in pull request #28331: URL: https://github.com/apache/spark/pull/28331#discussion_r419052580 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -650,6 +656,19 @@ private[spark] class BlockManager( blockId:

[GitHub] [spark] holdenk commented on a change in pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-02 Thread GitBox
holdenk commented on a change in pull request #28331: URL: https://github.com/apache/spark/pull/28331#discussion_r419050598 ## File path: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ## @@ -148,6 +170,86 @@ private[spark] class

[GitHub] [spark] holdenk commented on a change in pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-02 Thread GitBox
holdenk commented on a change in pull request #28331: URL: https://github.com/apache/spark/pull/28331#discussion_r419050439 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -650,6 +656,19 @@ private[spark] class BlockManager( blockId:

[GitHub] [spark] huaxingao commented on pull request #28428: [SPARK-31612][SQL][DOCS][FOLLOW-UP] SQL Reference clean up

2020-05-02 Thread GitBox
huaxingao commented on pull request #28428: URL: https://github.com/apache/spark/pull/28428#issuecomment-623056870 I will close this PR. I am changing every sql ref file to remove the html syntax. I will make these changes there.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623056669 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623056669 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28420: [SPARK-31615][SQL] Pretty string output for sql method of RuntimeReplaceable expressions

2020-05-02 Thread GitBox
SparkQA commented on pull request #28420: URL: https://github.com/apache/spark/pull/28420#issuecomment-623056539 **[Test build #14 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14/testReport)** for PR 28420 at commit

[GitHub] [spark] viirya commented on a change in pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-02 Thread GitBox
viirya commented on a change in pull request #28331: URL: https://github.com/apache/spark/pull/28331#discussion_r419049624 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -650,6 +656,19 @@ private[spark] class BlockManager( blockId:

[GitHub] [spark] viirya commented on a change in pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-02 Thread GitBox
viirya commented on a change in pull request #28331: URL: https://github.com/apache/spark/pull/28331#discussion_r419049049 ## File path: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ## @@ -148,6 +170,86 @@ private[spark] class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623049466 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623049466 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support - WIDTH_BUCKET

2020-05-02 Thread GitBox
SparkQA commented on pull request #18323: URL: https://github.com/apache/spark/pull/18323#issuecomment-623049387 **[Test build #13 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13/testReport)** for PR 18323 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more canonical

2020-05-02 Thread GitBox
HyukjinKwon commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-623049263 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] HyukjinKwon commented on pull request #28413: [SPARK-31610][ML] Expose hashFunc property in HashingTF

2020-05-02 Thread GitBox
HyukjinKwon commented on pull request #28413: URL: https://github.com/apache/spark/pull/28413#issuecomment-623048922 Yeah, I think I agree with @srowen's https://github.com/apache/spark/pull/28413#pullrequestreview-404538663.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific co

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623047508 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623047508 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-02 Thread GitBox
SparkQA commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623047407 **[Test build #12 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12/testReport)** for PR 28438 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific co

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623033296 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623047271 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-02 Thread GitBox
HyukjinKwon commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623047229 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AmplabJenkins commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623047271 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623026011 **[Test build #11 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11/testReport)** for PR 28208 at commit

[GitHub] [spark] SparkQA commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
SparkQA commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623047143 **[Test build #11 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11/testReport)** for PR 28208 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
HyukjinKwon commented on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623047009 cc @gengliangwang FYI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28383: [SPARK-31590][SQL] Metadata-only queries should not include subquery in partition filters

2020-05-02 Thread GitBox
HyukjinKwon commented on a change in pull request #28383: URL: https://github.com/apache/spark/pull/28383#discussion_r419036306 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuerySuite.scala ## @@ -103,6 +103,21 @@ class

[GitHub] [spark] HyukjinKwon commented on pull request #28383: [SPARK-31590][SQL] Metadata-only queries should not include subquery in partition filters

2020-05-02 Thread GitBox
HyukjinKwon commented on pull request #28383: URL: https://github.com/apache/spark/pull/28383#issuecomment-623044277 @cxzl25, I think https://github.com/apache/spark/pull/28383#discussion_r418767134 isn't fully addressed. Can you fix the PR description to explain fully what this PR

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific co

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623033213 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623033296 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28438: URL: https://github.com/apache/spark/pull/28438#issuecomment-623033213 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] tianshizz opened a new pull request #28438: [SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant

2020-05-02 Thread GitBox
tianshizz opened a new pull request #28438: URL: https://github.com/apache/spark/pull/28438 ### What changes were proposed in this pull request? Allow customized timeouts for `runSparkSubmit`, which will make flaky tests more likely to pass when using a larger timeout value.

[GitHub] [spark] github-actions[bot] commented on pull request #27257: [SPARK-30540][WEBUI] HistoryServer application link is incorrect when one application having multiple attempts

2020-05-02 Thread GitBox
github-actions[bot] commented on pull request #27257: URL: https://github.com/apache/spark/pull/27257#issuecomment-623032460 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #27309: [SPARK-30598][SQL] Detect equijoins better

2020-05-02 Thread GitBox
github-actions[bot] commented on pull request #27309: URL: https://github.com/apache/spark/pull/27309#issuecomment-623032456 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] maropu commented on a change in pull request #28424: [SPARK-31618][SQL] Distinct pushdown in Intersect Distinct based on stats

2020-05-02 Thread GitBox
maropu commented on a change in pull request #28424: URL: https://github.com/apache/spark/pull/28424#discussion_r419018496 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1682,6 +1682,22 @@ object SQLConf { .doubleConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623026100 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623026100 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
SparkQA commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623026011 **[Test build #11 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11/testReport)** for PR 28208 at commit

[GitHub] [spark] erenavsarogullari commented on pull request #28208: [SPARK-31440][SQL] Improve SQL Rest API

2020-05-02 Thread GitBox
erenavsarogullari commented on pull request #28208: URL: https://github.com/apache/spark/pull/28208#issuecomment-623025795 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623024321 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623023267 **[Test build #10 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10/testReport)** for PR 28433 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623024321 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
SparkQA commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623024287 **[Test build #10 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10/testReport)** for PR 28433 at commit

[GitHub] [spark] dilipbiswal commented on a change in pull request #28424: [SPARK-31618][SQL] Distinct pushdown in Intersect Distinct based on stats

2020-05-02 Thread GitBox
dilipbiswal commented on a change in pull request #28424: URL: https://github.com/apache/spark/pull/28424#discussion_r419016053 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1682,6 +1682,22 @@ object SQLConf { .doubleConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623023416 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623023416 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
SparkQA commented on pull request #28433: URL: https://github.com/apache/spark/pull/28433#issuecomment-623023267 **[Test build #10 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10/testReport)** for PR 28433 at commit

[GitHub] [spark] dilipbiswal commented on a change in pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
dilipbiswal commented on a change in pull request #28433: URL: https://github.com/apache/spark/pull/28433#discussion_r419015360 ## File path: docs/sql-ref-ansi-compliance.md ## @@ -27,35 +27,10 @@ The casting behaviours are defined as store assignment rules in the standard.

[GitHub] [spark] dilipbiswal commented on a change in pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
dilipbiswal commented on a change in pull request #28433: URL: https://github.com/apache/spark/pull/28433#discussion_r419015360 ## File path: docs/sql-ref-ansi-compliance.md ## @@ -27,35 +27,10 @@ The casting behaviours are defined as store assignment rules in the standard.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623022644 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623022644 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623003200 **[Test build #122219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122219/testReport)** for PR 28437 at commit

[GitHub] [spark] SparkQA commented on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
SparkQA commented on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623022476 **[Test build #122219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122219/testReport)** for PR 28437 at commit

[GitHub] [spark] imback82 commented on a change in pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
imback82 commented on a change in pull request #28435: URL: https://github.com/apache/spark/pull/28435#discussion_r419005627 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -727,6 +729,10 @@ private[spark] class

[GitHub] [spark] imback82 commented on a change in pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
imback82 commented on a change in pull request #28435: URL: https://github.com/apache/spark/pull/28435#discussion_r419005627 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -727,6 +729,10 @@ private[spark] class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623003339 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623003339 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
SparkQA commented on pull request #28437: URL: https://github.com/apache/spark/pull/28437#issuecomment-623003200 **[Test build #122219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122219/testReport)** for PR 28437 at commit

[GitHub] [spark] sarutak opened a new pull request #28437: [SPARK-30385][WEBUI] WebUI occasionally throw IOException on stop()

2020-05-02 Thread GitBox
sarutak opened a new pull request #28437: URL: https://github.com/apache/spark/pull/28437 ### What changes were proposed in this pull request? This PR added a workaround for the issue which occasionally happens when SparkContext#stop() is called. I think this issue can occurs on

[GitHub] [spark] imback82 commented on pull request #28435: [SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
imback82 commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-623002663 @tgravescs @dbtsai @srowen Can you help with the review? Thanks in advance! This is an automated message from

[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-02 Thread GitBox
akshatb1 commented on a change in pull request #28258: URL: https://github.com/apache/spark/pull/28258#discussion_r418993885 ## File path: core/src/main/scala/org/apache/spark/deploy/Client.scala ## @@ -124,38 +128,58 @@ private class ClientEndpoint( } } - /* Find

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622995216 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622992844 **[Test build #122218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122218/testReport)** for PR 28435 at commit

[GitHub] [spark] SparkQA commented on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
SparkQA commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622995174 **[Test build #122218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122218/testReport)** for PR 28435 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622995216 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] prakharjain09 commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-02 Thread GitBox
prakharjain09 commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-622993583 retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622992964 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622992964 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28435: [WIP][SPARK-31625][YARN] Unregister application from YARN RM outside the shutdown hook if it succeeds

2020-05-02 Thread GitBox
SparkQA commented on pull request #28435: URL: https://github.com/apache/spark/pull/28435#issuecomment-622992844 **[Test build #122218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122218/testReport)** for PR 28435 at commit

[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-02 Thread GitBox
akshatb1 commented on a change in pull request #28258: URL: https://github.com/apache/spark/pull/28258#discussion_r418986974 ## File path: docs/spark-standalone.md ## @@ -374,6 +374,24 @@ To run an interactive Spark shell against the cluster, run the following command You

[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-02 Thread GitBox
akshatb1 commented on a change in pull request #28258: URL: https://github.com/apache/spark/pull/28258#discussion_r418986898 ## File path: docs/spark-standalone.md ## @@ -374,6 +374,24 @@ To run an interactive Spark shell against the cluster, run the following command You

[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-02 Thread GitBox
akshatb1 commented on a change in pull request #28258: URL: https://github.com/apache/spark/pull/28258#discussion_r418986928 ## File path: docs/spark-standalone.md ## @@ -374,6 +374,24 @@ To run an interactive Spark shell against the cluster, run the following command You

[GitHub] [spark] igreenfield commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

2020-05-02 Thread GitBox
igreenfield commented on a change in pull request #26624: URL: https://github.com/apache/spark/pull/26624#discussion_r418985664 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ## @@ -674,6 +677,18 @@ private[spark] class Executor( } } +

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622983155 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622979072 **[Test build #122217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122217/testReport)** for PR 28436 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622983155 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
SparkQA commented on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622983097 **[Test build #122217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122217/testReport)** for PR 28436 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28036: [SPARK-26341][CORE]Expose executor memory metrics at the stage level, in the Stages tab

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28036: URL: https://github.com/apache/spark/pull/28036#issuecomment-622979980 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28036: [SPARK-26341][CORE]Expose executor memory metrics at the stage level, in the Stages tab

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28036: URL: https://github.com/apache/spark/pull/28036#issuecomment-622979980 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28036: [SPARK-26341][CORE]Expose executor memory metrics at the stage level, in the Stages tab

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28036: URL: https://github.com/apache/spark/pull/28036#issuecomment-622957622 **[Test build #122216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122216/testReport)** for PR 28036 at commit

[GitHub] [spark] SparkQA commented on pull request #28036: [SPARK-26341][CORE]Expose executor memory metrics at the stage level, in the Stages tab

2020-05-02 Thread GitBox
SparkQA commented on pull request #28036: URL: https://github.com/apache/spark/pull/28036#issuecomment-622979677 **[Test build #122216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122216/testReport)** for PR 28036 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-622979197 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-622979303 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-622979300 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-622979300 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-622979193 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-622927473 **[Test build #122214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122214/testReport)** for PR 27983 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622978301 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-622979193 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-02 Thread GitBox
SparkQA removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-622927474 **[Test build #122213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122213/testReport)** for PR 28370 at commit

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-02 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-622979041 **[Test build #122213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122213/testReport)** for PR 28370 at commit

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-02 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-622979037 **[Test build #122214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122214/testReport)** for PR 27983 at commit

[GitHub] [spark] SparkQA commented on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
SparkQA commented on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622979072 **[Test build #122217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122217/testReport)** for PR 28436 at commit

[GitHub] [spark] akshatb1 commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-02 Thread GitBox
akshatb1 commented on a change in pull request #28258: URL: https://github.com/apache/spark/pull/28258#discussion_r418977842 ## File path: core/src/main/scala/org/apache/spark/deploy/Client.scala ## @@ -61,6 +61,10 @@ private class ClientEndpoint( private val lostMasters

[GitHub] [spark] AmplabJenkins commented on pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #28436: URL: https://github.com/apache/spark/pull/28436#issuecomment-622978301 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] wangyum opened a new pull request #28436: [SPARK-31626][SQL] Port HIVE-10415: hive.start.cleanup.scratchdir configuration is not taking effect

2020-05-02 Thread GitBox
wangyum opened a new pull request #28436: URL: https://github.com/apache/spark/pull/28436 ### What changes were proposed in this pull request? This pr port [HIVE-10415](https://issues.apache.org/jira/browse/HIVE-10415): `hive.start.cleanup.scratchdir` configuration is not taking effect.

[GitHub] [spark] srowen commented on a change in pull request #28433: [SPARK-31030] [DOCS] [FOLLOWUP] Replace HTML Table by Markdown Table

2020-05-02 Thread GitBox
srowen commented on a change in pull request #28433: URL: https://github.com/apache/spark/pull/28433#discussion_r418974993 ## File path: docs/sql-ref-syntax-qry-select-tvf.md ## @@ -50,31 +50,12 @@ function_name ( expression [ , ... ] ) [ table_alias ] ### Supported

[GitHub] [spark] srowen commented on a change in pull request #28258: [SPARK-31486] [CORE] spark.submit.waitAppCompletion flag to control spark-submit exit in Standalone Cluster Mode

2020-05-02 Thread GitBox
srowen commented on a change in pull request #28258: URL: https://github.com/apache/spark/pull/28258#discussion_r418974650 ## File path: docs/spark-standalone.md ## @@ -374,6 +374,24 @@ To run an interactive Spark shell against the cluster, run the following command You

[GitHub] [spark] srowen commented on a change in pull request #28404: [SPARK-31603][ML]AFT uses common functions in RDDLossFunction

2020-05-02 Thread GitBox
srowen commented on a change in pull request #28404: URL: https://github.com/apache/spark/pull/28404#discussion_r418974371 ## File path: mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/AFTAggregator.scala ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] srowen commented on a change in pull request #28413: [SPARK-31610][ML] Expose hashFunc property in HashingTF

2020-05-02 Thread GitBox
srowen commented on a change in pull request #28413: URL: https://github.com/apache/spark/pull/28413#discussion_r418974144 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala ## @@ -42,14 +42,23 @@ import

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27620: [SPARK-30866][SS] FileStreamSource: Cache fetched list of files beyond maxFilesPerTrigger as unread files

2020-05-02 Thread GitBox
AmplabJenkins removed a comment on pull request #27620: URL: https://github.com/apache/spark/pull/27620#issuecomment-622972578 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27620: [SPARK-30866][SS] FileStreamSource: Cache fetched list of files beyond maxFilesPerTrigger as unread files

2020-05-02 Thread GitBox
AmplabJenkins commented on pull request #27620: URL: https://github.com/apache/spark/pull/27620#issuecomment-622972578 This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   3   >