[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-635621840 **[Test build #123247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/testReport)** for PR 28627 at commit

[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-28 Thread GitBox
SparkQA commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-635776114 **[Test build #123247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/testReport)** for PR 28627 at commit

[GitHub] [spark] maropu commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-05-28 Thread GitBox
maropu commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-635774892 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] huaxingao commented on pull request #28657: [SPARK-31840][ML] Add instance weight support in LogisticRegressionSummary

2020-05-28 Thread GitBox
huaxingao commented on pull request #28657: URL: https://github.com/apache/spark/pull/28657#issuecomment-635770681 cc @srowen @zhengruifeng This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635769889 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635766059 **[Test build #123263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123263/testReport)** for PR 28672 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635769889 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
SparkQA commented on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635769798 **[Test build #123263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123263/testReport)** for PR 28672 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635767099 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635767099 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635720332 **[Test build #123259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123259/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635764256 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635766357 **[Test build #123259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123259/testReport)** for PR 28331 at commit

[GitHub] [spark] SparkQA commented on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
SparkQA commented on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635766059 **[Test build #123263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123263/testReport)** for PR 28672 at commit

[GitHub] [spark] cloud-fan closed pull request #28664: [SPARK-31855][SQL][TESTS] Check reading date/timestamp from Avro files w/ and w/o Spark version

2020-05-28 Thread GitBox
cloud-fan closed pull request #28664: URL: https://github.com/apache/spark/pull/28664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #28664: [SPARK-31855][SQL][TESTS] Check reading date/timestamp from Avro files w/ and w/o Spark version

2020-05-28 Thread GitBox
cloud-fan commented on pull request #28664: URL: https://github.com/apache/spark/pull/28664#issuecomment-635765240 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] huaxingao commented on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
huaxingao commented on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635764888 Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference per @gatorsmile request. cc @maropu @dilipbiswal @ulysses-you @jzhuge @xuanyuanking

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-635764290 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-635764290 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28672: URL: https://github.com/apache/spark/pull/28672#issuecomment-635764256 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-28 Thread GitBox
SparkQA commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-635763920 **[Test build #123262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123262/testReport)** for PR 28619 at commit

[GitHub] [spark] huaxingao opened a new pull request #28672: [SPARK-31333][SQL][DOCS][FOLLOW-UP] Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference

2020-05-28 Thread GitBox
huaxingao opened a new pull request #28672: URL: https://github.com/apache/spark/pull/28672 ### What changes were proposed in this pull request? Add Coalesce/Repartition/Repartition_By_Range Hints to SQL Reference ### Why are the changes needed? To make SQL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635758324 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635757584 **[Test build #123261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123261/testReport)** for PR 28593 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635758317 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635757936 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635758309 **[Test build #123261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123261/testReport)** for PR 28593 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635758317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635757936 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635757584 **[Test build #123261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123261/testReport)** for PR 28593 at commit

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-28 Thread GitBox
cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-635757370 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
cloud-fan commented on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635751861 This makes sense to me. e.g. for partitions [1, 1, 1, ..., 1, 10], which are coalesced to `[9, 10]`, I don't think there are skewed partitions. @JkSelf what do you

[GitHub] [spark] cloud-fan closed pull request #28668: [SPARK-31862][SQL] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
cloud-fan closed pull request #28668: URL: https://github.com/apache/spark/pull/28668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635749462 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on pull request #28668: [SPARK-31862][SQL] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
cloud-fan commented on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635749895 yea, it's better to make the error behavior consistent between AQE and non-AQE. Thanks, merging to master/3.0!

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635749458 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635749458 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635704603 **[Test build #123257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123257/testReport)** for PR 28647 at commit

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635749256 **[Test build #123257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123257/testReport)** for PR 28647 at commit

[GitHub] [spark] cloud-fan closed pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
cloud-fan closed pull request #28670: URL: https://github.com/apache/spark/pull/28670 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
cloud-fan commented on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635749108 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan closed pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
cloud-fan closed pull request #28651: URL: https://github.com/apache/spark/pull/28651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins commented on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635747350 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635747350 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
cloud-fan commented on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635747382 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA removed a comment on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635646684 **[Test build #123251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123251/testReport)** for PR 28670 at commit

[GitHub] [spark] SparkQA commented on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
SparkQA commented on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635746931 **[Test build #123251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123251/testReport)** for PR 28670 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635746316 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635746311 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635746311 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635746196 **[Test build #123256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123256/testReport)** for PR 28647 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635698603 **[Test build #123256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123256/testReport)** for PR 28647 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
cloud-fan commented on a change in pull request #28671: URL: https://github.com/apache/spark/pull/28671#discussion_r432244219 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ## @@ -811,6 +811,63 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
cloud-fan commented on a change in pull request #28671: URL: https://github.com/apache/spark/pull/28671#discussion_r432243974 ## File path: sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/ColumnValue.java ## @@ -178,9 +178,9 @@ public static TColumnValue

[GitHub] [spark] yaooqinn commented on pull request #27805: [SPARK-31056][SQL] Add CalendarIntervals division

2020-05-28 Thread GitBox
yaooqinn commented on pull request #27805: URL: https://github.com/apache/spark/pull/27805#issuecomment-635741463 thanks for pinging me @maropu Using extract/date_part functions instead may be a good choice here for end-users. Supporting `/` for intervals goes against a contract

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28668: [SPARK-31862][SQL] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635739504 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28668: [SPARK-31862][SQL] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635739504 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
cloud-fan commented on a change in pull request #28671: URL: https://github.com/apache/spark/pull/28671#discussion_r432237754 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperationUtils.scala ## @@ -0,0 +1,78 @@ +/* + *

[GitHub] [spark] SparkQA commented on pull request #28668: [SPARK-31862][SQL] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
SparkQA commented on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635738977 **[Test build #123249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123249/testReport)** for PR 28668 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28668: [SPARK-31862][SQL] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635630594 **[Test build #123249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123249/testReport)** for PR 28668 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
cloud-fan commented on a change in pull request #28671: URL: https://github.com/apache/spark/pull/28671#discussion_r432237754 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperationUtils.scala ## @@ -0,0 +1,78 @@ +/* + *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635736416 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635736416 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635639292 **[Test build #123250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123250/testReport)** for PR 28669 at commit

[GitHub] [spark] SparkQA commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
SparkQA commented on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635735795 **[Test build #123250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123250/testReport)** for PR 28669 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-635732936 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-635732936 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-28 Thread GitBox
SparkQA commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-635732632 **[Test build #123260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123260/testReport)** for PR 27627 at commit

[GitHub] [spark] siknezevic commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-05-28 Thread GitBox
siknezevic commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-635732643 Could you please reopen this PR and remove the Stale tag? This PR brings significant performance improvements when spilling is enabled. Thank you

[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-28 Thread GitBox
skambha commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-635730700 I wanted to summarize where we are at. The changes up to this point took care of whole stage enabled, disabled and ansi enabled/disabled scenarios etc consistently. But based

[GitHub] [spark] SparkQA removed a comment on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635718288 **[Test build #123258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123258/testReport)** for PR 28651 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635728948 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635728948 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
SparkQA commented on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635728749 **[Test build #123258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123258/testReport)** for PR 28651 at commit

[GitHub] [spark] maropu commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-05-28 Thread GitBox
maropu commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-635724871 Could you update the PR description, too, based on the current PR approach? e.g., `Join is the equi-join.` -> `Join is the sort merge one with equality conditions`

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-635723792 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r432206204 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,111 @@ +/* + * Licensed

[GitHub] [spark] AmplabJenkins commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-635723792 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-635615292 **[Test build #123246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123246/testReport)** for PR 27066 at commit

[GitHub] [spark] SparkQA commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-05-28 Thread GitBox
SparkQA commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-635723180 **[Test build #123246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123246/testReport)** for PR 27066 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635720616 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635720611 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635720332 **[Test build #123259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123259/testReport)** for PR 28331 at commit

[GitHub] [spark] SparkQA commented on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
SparkQA commented on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635718288 **[Test build #123258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123258/testReport)** for PR 28651 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635716619 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28651: URL: https://github.com/apache/spark/pull/28651#issuecomment-635716619 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635715162 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635715157 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635715157 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635686780 **[Test build #123255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123255/testReport)** for PR 28647 at commit

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635715025 **[Test build #123255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123255/testReport)** for PR 28647 at commit

[GitHub] [spark] yaooqinn commented on a change in pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
yaooqinn commented on a change in pull request #28651: URL: https://github.com/apache/spark/pull/28651#discussion_r432217803 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala ## @@ -73,11 +68,19 @@ trait

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635712678 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635712675 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635712675 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635712336 **[Test build #123254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123254/testReport)** for PR 28331 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635673683 **[Test build #123254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123254/testReport)** for PR 28331 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

2020-05-28 Thread GitBox
HyukjinKwon commented on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635710262 > if this is only removing "unhelpful" stack traces from the console, I can see it. I am pretty certain on this. Actually, this is why I am hiding JVM strackstrace

[GitHub] [spark] HyukjinKwon commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-28 Thread GitBox
HyukjinKwon commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-635705454 I guess we agree that the vote based clearly on misunderstanding should not stand in practice. Well, I agree with you all of it. What I would like to discuss about further

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635704865 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   6   >