[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635704865 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635704603 **[Test build #123257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123257/testReport)** for PR 28647 at commit

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432208610 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432208324 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2708,23 @@ class HiveDDLSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635699830 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635699821 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635699821 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635646655 **[Test build #123252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123252/testReport)** for PR 28331 at commit

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635699528 **[Test build #123252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123252/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635698883 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635698883 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635698603 **[Test build #123256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123256/testReport)** for PR 28647 at commit

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432203235 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2720,4 +2708,23 @@ class HiveDDLSuite

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-28 Thread GitBox
HeartSaVioR edited a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-635693470 I think the meaning of "binding" should be consistent - committers can give +1 and merge the code change, because they have "binding vote" for "code change". -1

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432202932 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ## @@ -839,6 +839,19 @@ case class AlterTableSetLocationCommand(

[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r432201354 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -115,6 +116,8 @@ case class CreateTableLikeCommand(

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-28 Thread GitBox
HeartSaVioR edited a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-635693470 I think the meaning of "binding" should be consistent - committers can give +1 and merge the code change, because they have "binding vote" for "code change". -1

[GitHub] [spark] srowen commented on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

2020-05-28 Thread GitBox
srowen commented on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635693433 Well, I'd say it differently. A Python person may not know what a JVM stack trace means. Taking it away doesn't itself do much except shorten a big dump of output, which doesn't

[GitHub] [spark] HeartSaVioR commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-28 Thread GitBox
HeartSaVioR commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-635693470 I think the meaning of "binding" should be consistent - committers can give +1 and merge the code change, because they have "binding vote" for "code change". -1 applies

[GitHub] [spark] maropu commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
maropu commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635691563 Could you update the SQL doc for the behaivour, too? https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-ddl-create-table-like.md

[GitHub] [spark] maropu commented on a change in pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28651: URL: https://github.com/apache/spark/pull/28651#discussion_r432195988 ## File path: sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java ## @@ -76,6 +76,10 @@ public void

[GitHub] [spark] maropu commented on a change in pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28651: URL: https://github.com/apache/spark/pull/28651#discussion_r432193307 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala ## @@ -73,11 +68,19 @@ trait

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635686780 **[Test build #123255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123255/testReport)** for PR 28647 at commit

[GitHub] [spark] maropu commented on a change in pull request #28651: [SPARK-31833][SQL][test-hive1.2] Set HiveThriftServer2 with actual port while configured 0

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28651: URL: https://github.com/apache/spark/pull/28651#discussion_r432193307 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala ## @@ -73,11 +68,19 @@ trait

[GitHub] [spark] github-actions[bot] commented on pull request #27129: [SPARK-30427][SQL] Add config item for limiting partition number when calculating statistics through File System

2020-05-28 Thread GitBox
github-actions[bot] commented on pull request #27129: URL: https://github.com/apache/spark/pull/27129#issuecomment-635685643 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] closed pull request #26082: [SPARK-29431][WebUI] Improve Web UI / Sql tab visualization with cached dataframes.

2020-05-28 Thread GitBox
github-actions[bot] closed pull request #26082: URL: https://github.com/apache/spark/pull/26082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] github-actions[bot] commented on pull request #27246: [SPARK-30536][CORE][SQL] Sort-merge join operator spilling performance improvements

2020-05-28 Thread GitBox
github-actions[bot] commented on pull request #27246: URL: https://github.com/apache/spark/pull/27246#issuecomment-635685630 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #27234: [SPARK-23626][CORE] DAGScheduler blocked due to JobSubmitted event

2020-05-28 Thread GitBox
github-actions[bot] commented on pull request #27234: URL: https://github.com/apache/spark/pull/27234#issuecomment-635685638 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635684815 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gatorsmile edited a comment on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

2020-05-28 Thread GitBox
gatorsmile edited a comment on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635684318 https://youtu.be/X4YHGKj3V5M?t=124 is another example. The JVM stacktrace for Python people is not very friendly, especially for data scientists who have very limited

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-635684815 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] gatorsmile commented on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark exceptions more Pythonic

2020-05-28 Thread GitBox
gatorsmile commented on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-635684318 https://youtu.be/X4YHGKj3V5M?t=124 is another example. The JVM stacktrace for Python people is not very friendly, especially for data scientists who have very limited

[GitHub] [spark] HyukjinKwon commented on pull request #28666: [BUILD][INFRA] bump the timeout to match the jenkins PRB

2020-05-28 Thread GitBox
HyukjinKwon commented on pull request #28666: URL: https://github.com/apache/spark/pull/28666#issuecomment-635683737 +1 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success

2020-05-28 Thread GitBox
dongjoon-hyun commented on pull request #28667: URL: https://github.com/apache/spark/pull/28667#issuecomment-635683604 cc @dbtsai , too This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] rdblue commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-28 Thread GitBox
rdblue commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-635683658 I agree that if it is a misunderstanding, then a veto isn't binding. And the way to handle that situation is to discuss why the justification was based on a misunderstanding and

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635676599 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635676599 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635676037 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635590890 **[Test build #123244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123244/testReport)** for PR 28331 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635651945 **[Test build #123253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123253/testReport)** for PR 28671 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635676037 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
SparkQA commented on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635675849 **[Test build #123253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123253/testReport)** for PR 28671 at commit

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635675981 **[Test build #123244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123244/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28667: URL: https://github.com/apache/spark/pull/28667#issuecomment-635674156 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28667: URL: https://github.com/apache/spark/pull/28667#issuecomment-635674156 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28667: URL: https://github.com/apache/spark/pull/28667#issuecomment-635605135 **[Test build #123245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123245/testReport)** for PR 28667 at commit

[GitHub] [spark] SparkQA commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success

2020-05-28 Thread GitBox
SparkQA commented on pull request #28667: URL: https://github.com/apache/spark/pull/28667#issuecomment-635673782 **[Test build #123245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123245/testReport)** for PR 28667 at commit

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635673683 **[Test build #123254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123254/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635671841 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635671841 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] jiangxb1987 closed pull request #28658: [SPARK-31730][CORE][TEST][3.0] Fix flaky tests in BarrierTaskContextSuite

2020-05-28 Thread GitBox
jiangxb1987 closed pull request #28658: URL: https://github.com/apache/spark/pull/28658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] jiangxb1987 commented on pull request #28658: [SPARK-31730][CORE][TEST][3.0] Fix flaky tests in BarrierTaskContextSuite

2020-05-28 Thread GitBox
jiangxb1987 commented on pull request #28658: URL: https://github.com/apache/spark/pull/28658#issuecomment-635670296 Merged to 3.0! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on a change in pull request #28654: [SPARK-31834][SQL]Improve error message for incompatible data types

2020-05-28 Thread GitBox
maropu commented on a change in pull request #28654: URL: https://github.com/apache/spark/pull/28654#discussion_r432178411 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala ## @@ -80,7 +80,7 @@ class

[GitHub] [spark] maropu commented on pull request #27805: [SPARK-31056][SQL] Add CalendarIntervals division

2020-05-28 Thread GitBox
maropu commented on pull request #27805: URL: https://github.com/apache/spark/pull/27805#issuecomment-635668958 cc: @yaooqinn This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] tgravescs commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

2020-05-28 Thread GitBox
tgravescs commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635654676 I filed a followup jira https://issues.apache.org/jira/browse/SPARK-31856?filter=-2 to look at handling the executor added better, this fix works for now.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635653136 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] juliuszsompolski commented on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
juliuszsompolski commented on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635652574 cc @MaxGekk @cloud-fan @wangyum @gatorsmile This is an automated message from the Apache Git Service.

[GitHub] [spark] bmarcott edited a comment on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

2020-05-28 Thread GitBox
bmarcott edited a comment on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635651858 @Ngone51 Thanks for looking into this. Let's make a few corrections to the description: - This happened with previous delay scheduling as well (although

[GitHub] [spark] AmplabJenkins commented on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635653136 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
SparkQA commented on pull request #28671: URL: https://github.com/apache/spark/pull/28671#issuecomment-635651945 **[Test build #123253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123253/testReport)** for PR 28671 at commit

[GitHub] [spark] bmarcott commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

2020-05-28 Thread GitBox
bmarcott commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635651858 @Ngone51 Thanks for looking into this. Let's make a few corrections to the description: This happened with previous delay scheduling as well (although likely

[GitHub] [spark] okimcoder removed a comment on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

2020-05-28 Thread GitBox
okimcoder removed a comment on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635650972 @Ngone51 Thanks for looking into this. Let's make a few corrections to the description: 1. This happened with previous delay scheduling as well (although

[GitHub] [spark] okimcoder commented on pull request #28656: [SPARK-31837][CORE] Shift to the new highest locality level if there is when recomputeLocality

2020-05-28 Thread GitBox
okimcoder commented on pull request #28656: URL: https://github.com/apache/spark/pull/28656#issuecomment-635650972 @Ngone51 Thanks for looking into this. Let's make a few corrections to the description: 1. This happened with previous delay scheduling as well (although likely

[GitHub] [spark] juliuszsompolski opened a new pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox
juliuszsompolski opened a new pull request #28671: URL: https://github.com/apache/spark/pull/28671 ### What changes were proposed in this pull request? Timestamp literals in Spark are interpreted as timestamps in local timezone spark.sql.session.timeZone. If JDBC client is

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635647157 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635647026 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635647157 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] holdenk commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
holdenk commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635647447 I've verified the updated unit test fails when I manually set migrate shuffle blocks to false, thanks @attilapiros :)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635647016 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635647016 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
SparkQA commented on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635646684 **[Test build #123251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123251/testReport)** for PR 28670 at commit

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635646655 **[Test build #123252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123252/testReport)** for PR 28331 at commit

[GitHub] [spark] maryannxue commented on pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
maryannxue commented on pull request #28670: URL: https://github.com/apache/spark/pull/28670#issuecomment-635646271 cc @cloud-fan @Ngone51 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maryannxue opened a new pull request #28670: [SPARK-31865][SQL] Fix complex AQE query stage not reused

2020-05-28 Thread GitBox
maryannxue opened a new pull request #28670: URL: https://github.com/apache/spark/pull/28670 ### What changes were proposed in this pull request? This PR fixes the issue of complex query stages that contain sub stages not being reused at times due to dynamic plan changes.

[GitHub] [spark] AmplabJenkins commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635639710 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635639710 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maryannxue commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
maryannxue commented on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635639218 cc @cloud-fan @Ngone51 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
SparkQA commented on pull request #28669: URL: https://github.com/apache/spark/pull/28669#issuecomment-635639292 **[Test build #123250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123250/testReport)** for PR 28669 at commit

[GitHub] [spark] maryannxue opened a new pull request #28669: [SPARK-31864][SQL] Adjust AQE skew join trigger condition

2020-05-28 Thread GitBox
maryannxue opened a new pull request #28669: URL: https://github.com/apache/spark/pull/28669 ### What changes were proposed in this pull request? This PR makes a minor change in deciding whether a partition is skewed by comparing the partition size to the median size of

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28668: [SPARK-31862] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635631119 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28668: [SPARK-31862] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635631119 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28668: [SPARK-31862] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
SparkQA commented on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635630594 **[Test build #123249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123249/testReport)** for PR 28668 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635628412 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maryannxue commented on pull request #28668: [SPARK-31862] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
maryannxue commented on pull request #28668: URL: https://github.com/apache/spark/pull/28668#issuecomment-635628548 cc @cloud-fan @Ngone51 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635624756 **[Test build #123248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123248/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635628404 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635628388 **[Test build #123248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123248/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635628404 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maryannxue opened a new pull request #28668: [SPARK-31862] Remove exception wrapping in AQE

2020-05-28 Thread GitBox
maryannxue opened a new pull request #28668: URL: https://github.com/apache/spark/pull/28668 ### What changes were proposed in this pull request? This PR removes the excessive exception wrapping in AQE so that error messages are less verbose and mostly consistent with

[GitHub] [spark] dongjoon-hyun commented on pull request #28666: [BUILD][INFRA] bump the timeout to match the jenkins PRB

2020-05-28 Thread GitBox
dongjoon-hyun commented on pull request #28666: URL: https://github.com/apache/spark/pull/28666#issuecomment-635627152 +1, late LGTM. Thank you, @shaneknapp . This is an automated message from the Apache Git Service. To

[GitHub] [spark] holdenk commented on pull request #28667: [WIP][SPARK-31860][BUILD] only push release tags on success

2020-05-28 Thread GitBox
holdenk commented on pull request #28667: URL: https://github.com/apache/spark/pull/28667#issuecomment-635625346 cc @shaneknapp This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] SparkQA commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
SparkQA commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635624756 **[Test build #123248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123248/testReport)** for PR 28331 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-635622188 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635622316 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-05-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-635622316 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-28 Thread GitBox
AmplabJenkins commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-635622188 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test

2020-05-28 Thread GitBox
SparkQA commented on pull request #28627: URL: https://github.com/apache/spark/pull/28627#issuecomment-635621840 **[Test build #123247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/testReport)** for PR 28627 at commit

[GitHub] [spark] sarutak commented on pull request #28666: [BUILD][INFRA] bump the timeout to match the jenkins PRB

2020-05-28 Thread GitBox
sarutak commented on pull request #28666: URL: https://github.com/apache/spark/pull/28666#issuecomment-635619264 @shaneknapp Thanks! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] shaneknapp commented on pull request #28666: [BUILD][INFRA] bump the timeout to match the jenkins PRB

2020-05-28 Thread GitBox
shaneknapp commented on pull request #28666: URL: https://github.com/apache/spark/pull/28666#issuecomment-635618458 done! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] shaneknapp commented on pull request #28666: [BUILD][INFRA] bump the timeout to match the jenkins PRB

2020-05-28 Thread GitBox
shaneknapp commented on pull request #28666: URL: https://github.com/apache/spark/pull/28666#issuecomment-635617050 also going to backport this to 3.0 and 2.4 This is an automated message from the Apache Git Service. To

<    1   2   3   4   5   6   >