[GitHub] [spark] yaooqinn commented on pull request #28692: [SPARK-31879][SQL] Using GB as default Locale for datetime formatters

2020-06-03 Thread GitBox
yaooqinn commented on pull request #28692: URL: https://github.com/apache/spark/pull/28692#issuecomment-638617420 > > Thanks for taking care of this. It looks like the culture in GB has been changed a lot during JDK8 to 11, lol... > > Since we have banned 'u'(localized day-of-week) for

[GitHub] [spark] AmplabJenkins commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638617236 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
SparkQA commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638617103 **[Test build #123519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123519/testReport)** for PR 28723 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638617236 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638608499 **[Test build #123519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123519/testReport)** for PR 28723 at commit

[GitHub] [spark] MaxGekk commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
MaxGekk commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638614573 @HyukjinKwon I guess this PR fixes the issue mainly: https://github.com/apache/spark/pull/28582 This is

[GitHub] [spark] imback82 commented on a change in pull request #28676: [WIP][SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-06-03 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r435003013 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +60,26 @@ case class

[GitHub] [spark] maryannxue commented on a change in pull request #28676: [WIP][SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-06-03 Thread GitBox
maryannxue commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r434999296 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +60,26 @@ case class

[GitHub] [spark] maryannxue commented on a change in pull request #28676: [WIP][SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-06-03 Thread GitBox
maryannxue commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r434999159 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +60,26 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638608832 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638608832 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
HyukjinKwon commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638608705 Looks good if the tests pass. WDYT can you point out which change fixed this if you already know? This is

[GitHub] [spark] SparkQA commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
SparkQA commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638608499 **[Test build #123519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123519/testReport)** for PR 28723 at commit

[GitHub] [spark] MaxGekk commented on pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
MaxGekk commented on pull request #28723: URL: https://github.com/apache/spark/pull/28723#issuecomment-638608339 @HyukjinKwon Please, review this PR. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] MaxGekk opened a new pull request #28723: [SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
MaxGekk opened a new pull request #28723: URL: https://github.com/apache/spark/pull/28723 ### What changes were proposed in this pull request? Enable `date.sql` and run it via Thrift Server in `ThriftServerQueryTestSuite`. ### Why are the changes needed? To improve test

[GitHub] [spark] maryannxue commented on a change in pull request #28676: [WIP][SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-06-03 Thread GitBox
maryannxue commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r434997427 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -554,7 +554,7 @@ class

[GitHub] [spark] cloud-fan commented on pull request #28674: [SPARK-31868][SQL] Restore the parsing behaviour week-based-year for 2.4

2020-06-03 Thread GitBox
cloud-fan commented on pull request #28674: URL: https://github.com/apache/spark/pull/28674#issuecomment-638596561 yea, let me close it. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638595741 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638595741 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-03 Thread GitBox
SparkQA commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638595499 **[Test build #123518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123518/testReport)** for PR 28585 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638594386 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sarutak commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-03 Thread GitBox
sarutak commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638594427 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638594386 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638593857 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638593857 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638593225 **[Test build #123515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123515/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638537610 **[Test build #123515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123515/testReport)** for PR 28708 at commit

[GitHub] [spark] cloud-fan commented on pull request #28717: [SPARK-29947][SQL][followup] ResolveRelations should return relations with fresh attribute IDs

2020-06-03 Thread GitBox
cloud-fan commented on pull request #28717: URL: https://github.com/apache/spark/pull/28717#issuecomment-638591182 ``` sql("select * from (select t1.a, t1.b from t t1 join t t2 on t1.a = t2.a group by t1.a, t1.b) j join t t3 where j.b = t3.b").show ``` This also works. Please let

[GitHub] [spark] HyukjinKwon commented on pull request #28674: [SPARK-31868][SQL] Restore the parsing behaviour week-based-year for 2.4

2020-06-03 Thread GitBox
HyukjinKwon commented on pull request #28674: URL: https://github.com/apache/spark/pull/28674#issuecomment-638590600 Okay, understood now .. let's be diligent on updating related JIRAs btw in particular the blockers. So SPARK-31868 is won't fix?

[GitHub] [spark] cloud-fan commented on pull request #28674: [SPARK-31868][SQL] Restore the parsing behaviour week-based-year for 2.4

2020-06-03 Thread GitBox
cloud-fan commented on pull request #28674: URL: https://github.com/apache/spark/pull/28674#issuecomment-638589781 @HyukjinKwon this PR is closed by https://github.com/apache/spark/commit/afe95bd9ad7a07c49deecf05f0a1000bb8f80caa It's not merged...

[GitHub] [spark] yaooqinn edited a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-03 Thread GitBox
yaooqinn edited a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638585185 Hmm... Bad news, I am afraid I just the concept of `THE FIRST DAY OF WEEK` is not only about the letter 'u' itself!!! It affects all week-based patterns.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-638587250 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-638587250 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-06-03 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-638586972 **[Test build #123517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123517/testReport)** for PR 27983 at commit

[GitHub] [spark] yaooqinn edited a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-03 Thread GitBox
yaooqinn edited a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638585185 Hmm... Bad news, I am afraid I just the concept of `THE FIRST DAY OF WEEK` is not only about the letter 'u' itself!!! It affects all week-based patterns.

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-06-03 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-638585620 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] yaooqinn commented on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-03 Thread GitBox
yaooqinn commented on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638585185 Hmm... Bad news, I am afraid I just the concept of `THE FIRST DAY OF WEEK` is not about the letter 'u' itself!!! It affects all week-based patterns. i.e., For the

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r434975787 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -506,31 +506,55 @@ class Analyzer(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638582575 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638582569 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638582569 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638475249 **[Test build #123507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123507/testReport)** for PR 28618 at commit

[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
SparkQA commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638582172 **[Test build #123507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123507/testReport)** for PR 28618 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r434971770 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3495,6 +3495,59 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638578913 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638578913 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638528573 **[Test build #123514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123514/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638578285 **[Test build #123514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123514/testReport)** for PR 28708 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638577007 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638577007 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638576239 **[Test build #123511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123511/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638501022 **[Test build #123511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123511/testReport)** for PR 28708 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28709: [SPARK-31901][SQL] Use the session time zone in legacy date formatters

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28709: URL: https://github.com/apache/spark/pull/28709#issuecomment-638571863 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28709: [SPARK-31901][SQL] Use the session time zone in legacy date formatters

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28709: URL: https://github.com/apache/spark/pull/28709#issuecomment-638571863 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28722: [WIP][SPARK-31902][K8S][TEST] Fix the K8s integration test Jenkins mockito errors

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28722: URL: https://github.com/apache/spark/pull/28722#issuecomment-638571326 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28722: [WIP][SPARK-31902][K8S][TEST] Fix the K8s integration test Jenkins mockito errors

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28722: URL: https://github.com/apache/spark/pull/28722#issuecomment-638571326 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28709: [SPARK-31901][SQL] Use the session time zone in legacy date formatters

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28709: URL: https://github.com/apache/spark/pull/28709#issuecomment-638462497 **[Test build #123506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123506/testReport)** for PR 28709 at commit

[GitHub] [spark] SparkQA commented on pull request #28709: [SPARK-31901][SQL] Use the session time zone in legacy date formatters

2020-06-03 Thread GitBox
SparkQA commented on pull request #28709: URL: https://github.com/apache/spark/pull/28709#issuecomment-638571314 **[Test build #123506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123506/testReport)** for PR 28709 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28722: [WIP][SPARK-31902][K8S][TEST] Fix the K8s integration test Jenkins mockito errors

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28722: URL: https://github.com/apache/spark/pull/28722#issuecomment-638518638 **[Test build #123513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123513/testReport)** for PR 28722 at commit

[GitHub] [spark] wangyum commented on a change in pull request #28575: [SPARK-31705][SQL] Push predicate through join by rewriting join condition to conjunctive normal form

2020-06-03 Thread GitBox
wangyum commented on a change in pull request #28575: URL: https://github.com/apache/spark/pull/28575#discussion_r434962858 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1372,6 +1376,108 @@ object

[GitHub] [spark] SparkQA commented on pull request #28722: [WIP][SPARK-31902][K8S][TEST] Fix the K8s integration test Jenkins mockito errors

2020-06-03 Thread GitBox
SparkQA commented on pull request #28722: URL: https://github.com/apache/spark/pull/28722#issuecomment-638570738 **[Test build #123513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123513/testReport)** for PR 28722 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r434961465 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -506,31 +506,55 @@ class Analyzer(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638567432 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638567424 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638567424 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
SparkQA commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638566575 **[Test build #123504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123504/testReport)** for PR 28618 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638455954 **[Test build #123504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123504/testReport)** for PR 28618 at commit

[GitHub] [spark] viirya commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
viirya commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r434958555 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -506,31 +506,55 @@ class Analyzer(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638561866 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638561860 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638561860 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r434955113 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -506,31 +506,55 @@ class Analyzer(

[GitHub] [spark] SparkQA removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638449390 **[Test build #123502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123502/testReport)** for PR 28618 at commit

[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-06-03 Thread GitBox
SparkQA commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-638561296 **[Test build #123502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123502/testReport)** for PR 28618 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28722: [WIP][SPARK-31902][K8S][TEST] Fix the K8s integration test Jenkins mockito errors

2020-06-03 Thread GitBox
HyukjinKwon commented on pull request #28722: URL: https://github.com/apache/spark/pull/28722#issuecomment-638560058 Ah, okay. I wasn't sure if it's same thing :-) This is an automated message from the Apache Git Service. To

[GitHub] [spark] viirya commented on a change in pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
viirya commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r434952757 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -506,31 +506,55 @@ class Analyzer(

[GitHub] [spark] yaooqinn edited a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-03 Thread GitBox
yaooqinn edited a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638558054 After all, we are trying our best. This seems to be the best choice left. Notice that only `e` and `ee` is localized, and `e*3`and `e*4` are not. And we should

[GitHub] [spark] yaooqinn edited a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-03 Thread GitBox
yaooqinn edited a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638558054 After all, we are trying our best. This seems to be the best choice left. Notice that only `e` and `ee` are localized, and `e*3`and `e*4` are not. And we should

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638558200 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638558187 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28138/

[GitHub] [spark] yaooqinn commented on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-03 Thread GitBox
yaooqinn commented on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638558054 After all, we are trying our best. This seems to be the best choice left. Notice that only `e` and `ee` is localized, and `e*3`and `e*4` are not, and we should disable

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638558200 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #28676: [WIP][SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-06-03 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r434949608 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -554,7 +554,7 @@ class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28705: [SPARK-30808][SQL] Enable Java 8 time API in in Thriftserver SQL CLI

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28705: URL: https://github.com/apache/spark/pull/28705#issuecomment-638554388 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638554177 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28705: [SPARK-30808][SQL] Enable Java 8 time API in in Thriftserver SQL CLI

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28705: URL: https://github.com/apache/spark/pull/28705#issuecomment-638554388 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638554174 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AmplabJenkins removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638553797 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638554174 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638553517 **[Test build #123516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123516/testReport)** for PR 28490 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28674: [SPARK-31868][SQL] Restore the parsing behaviour week-based-year for 2.4

2020-06-03 Thread GitBox
HyukjinKwon commented on pull request #28674: URL: https://github.com/apache/spark/pull/28674#issuecomment-638554187 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
SparkQA commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638554169 **[Test build #123516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123516/testReport)** for PR 28490 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
AmplabJenkins commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638553797 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28705: [SPARK-30808][SQL] Enable Java 8 time API in in Thriftserver SQL CLI

2020-06-03 Thread GitBox
SparkQA removed a comment on pull request #28705: URL: https://github.com/apache/spark/pull/28705#issuecomment-638420519 **[Test build #123500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123500/testReport)** for PR 28705 at commit

[GitHub] [spark] SparkQA commented on pull request #28490: [SPARK-31670][SQL]Struct Field in groupByExpr with CUBE

2020-06-03 Thread GitBox
SparkQA commented on pull request #28490: URL: https://github.com/apache/spark/pull/28490#issuecomment-638553517 **[Test build #123516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123516/testReport)** for PR 28490 at commit

[GitHub] [spark] SparkQA commented on pull request #28705: [SPARK-30808][SQL] Enable Java 8 time API in in Thriftserver SQL CLI

2020-06-03 Thread GitBox
SparkQA commented on pull request #28705: URL: https://github.com/apache/spark/pull/28705#issuecomment-638553604 **[Test build #123500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123500/testReport)** for PR 28705 at commit

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-03 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638552212 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28138/

[GitHub] [spark] HyukjinKwon closed pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
HyukjinKwon closed pull request #28721: URL: https://github.com/apache/spark/pull/28721 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
HyukjinKwon commented on pull request #28721: URL: https://github.com/apache/spark/pull/28721#issuecomment-638551511 Let me merge it to master first. From reading the JIRA, seems it's fixed only in the master. This is an

[GitHub] [spark] HyukjinKwon commented on pull request #28721: [SPARK-28624][SQL][TESTS] Run date.sql via Thrift Server

2020-06-03 Thread GitBox
HyukjinKwon commented on pull request #28721: URL: https://github.com/apache/spark/pull/28721#issuecomment-638551553 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

  1   2   3   4   5   6   7   >