[GitHub] [spark] HyukjinKwon commented on pull request #28996: [SPARK-29358][SQL] Make unionByName optionally fill missing columns with nulls

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28996: URL: https://github.com/apache/spark/pull/28996#issuecomment-654756926 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654756521 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654756243 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654756243 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654754327 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654754317 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654754317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654664656 **[Test build #125191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125191/testReport)** for PR 29019 at commit

[GitHub] [spark] SparkQA commented on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
SparkQA commented on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-654753694 **[Test build #125191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125191/testReport)** for PR 29019 at commit

[GitHub] [spark] maropu commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
maropu commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654749847 Oh, I see. Looks okay to add this. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654739521 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654739521 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
HeartSaVioR commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450745960 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] SparkQA commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
SparkQA commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654738586 **[Test build #125205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125205/testReport)** for PR 28989 at commit

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
HeartSaVioR commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450745960 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654733821 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654733807 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
SparkQA commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654733951 **[Test build #125204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125204/testReport)** for PR 28969 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654697663 **[Test build #125203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125203/testReport)** for PR 28961 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654733807 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
SparkQA commented on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654733486 **[Test build #125203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125203/testReport)** for PR 28961 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654730125 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] attilapiros commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
attilapiros commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450738375 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654730125 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654729239 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654729042 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] attilapiros commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
attilapiros commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450727255 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #27428: URL: https://github.com/apache/spark/pull/27428#discussion_r450729347 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -118,7 +118,78 @@ import

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29023: URL: https://github.com/apache/spark/pull/29023#issuecomment-654720236 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29023: URL: https://github.com/apache/spark/pull/29023#issuecomment-654720869 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29023: URL: https://github.com/apache/spark/pull/29023#issuecomment-654720236 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] attilapiros commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
attilapiros commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450727255 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] Matzz opened a new pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
Matzz opened a new pull request #29023: URL: https://github.com/apache/spark/pull/29023 When I use `toPandas` on RDD created from Postgresql query I get following error: ``` pyspark/sql/dataframe.py:2138: UserWarning: toPandas attempted Arrow optimization because

[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654710558 Note that this PR only changes the docstrings in the SQL API, AFAIK SQL doesn't support named arguments

[GitHub] [spark] bart-samwel commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
bart-samwel commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654708664 Thinking about this some more, there may actually be something more important, which is compatibility with [named

[GitHub] [spark] cloud-fan commented on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
cloud-fan commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-654706001 Can you reference some hive doc? IIRC we use a global lock because the hive client is not thread-safe. I'm not convinced that the hive client is thread-safe when operating on

[GitHub] [spark] bart-samwel commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
bart-samwel commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654704508 SGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654702101 `fmt` could very clearly not mean any of those things in this context  Further, spelled-out `format` is written in the plain-English usage section of every one

[GitHub] [spark] cloud-fan commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654700928 I don't know why it's not supported before, and looks fine to me. cc @maropu @viirya @bart-samwel This is

[GitHub] [spark] yaooqinn commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
yaooqinn commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654700116 cc @cloud-fan @maropu @HyukjinKwon thanks for reviewing this in advance. This is an automated message from the

[GitHub] [spark] LantaoJin edited a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin edited a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654698752 To simply the UT. I introduced this pattern. And I have recognized there is problem for agg. It can coalesce but split. I will refactor code and description. Emm. Make

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654698694 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
HeartSaVioR commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450707447 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654698752 To simply the UT. I introduced this pattern. And I have recognized there is problem for agg. I will refactor code and description. Emm. Make it WIP.

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654698694 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654697631 Yes. You are correct. I have recognized this case. I will should skip aggregation :( This is an automated

[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654697634 **[Test build #125202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125202/testReport)** for PR 29022 at commit

[GitHub] [spark] SparkQA commented on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
SparkQA commented on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654697663 **[Test build #125203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125203/testReport)** for PR 28961 at commit

[GitHub] [spark] bart-samwel commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions

2020-07-07 Thread GitBox
bart-samwel commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654695394 May I suggest going the other way, i.e., avoiding abbreviation? I don't think there's any value in abbreviating, other than that it makes the argument's meaning less

[GitHub] [spark] yaooqinn opened a new pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
yaooqinn opened a new pull request #29022: URL: https://github.com/apache/spark/pull/29022 ### What changes were proposed in this pull request? In this PR, I supposed we support 'f'-suffixed float literal, e.g. `select 1.1f` ### Why are the changes needed?

[GitHub] [spark] cloud-fan edited a comment on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
cloud-fan edited a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654694004 ``` SMJ Sort Shuffle Sort HashAggregate Shuffle ``` This is an interesting use case. We must be careful when

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654694024 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654694061 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654694024 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654694061 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654694004 ``` SMJ Sort Shuffle Sort HashAggregate Shuffle ``` This is an interesting use case. We must be careful when

[GitHub] [spark] LantaoJin commented on pull request #28938: [SPARK-32118][SQL] Use fine-grained read write lock for each database in HiveExternalCatalog

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28938: URL: https://github.com/apache/spark/pull/28938#issuecomment-654693688 Gentle ping @dongjoon-hyun @cloud-fan @wangyum @rxin @maropu This is an automated message from the Apache

[GitHub] [spark] LantaoJin commented on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-654693092 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
SparkQA commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-654693321 **[Test build #125201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125201/testReport)** for PR 28683 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29012: [SPARK-31710][SQL][FOLLOWUP] Allow cast numeric to timestamp by default

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29012: URL: https://github.com/apache/spark/pull/29012#issuecomment-654689795 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29012: [SPARK-31710][SQL][FOLLOWUP] Allow cast numeric to timestamp by default

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29012: URL: https://github.com/apache/spark/pull/29012#issuecomment-654689795 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29012: [SPARK-31710][SQL][FOLLOWUP] Allow cast numeric to timestamp by default

2020-07-07 Thread GitBox
SparkQA commented on pull request #29012: URL: https://github.com/apache/spark/pull/29012#issuecomment-654688957 **[Test build #125199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125199/testReport)** for PR 29012 at commit

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-654688912 **[Test build #125200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125200/testReport)** for PR 28833 at commit

[GitHub] [spark] attilapiros commented on a change in pull request #28967: [SPARK-32149][SHUFFLE] Improve file path name normalisation at block resolution within the external shuffle service

2020-07-07 Thread GitBox
attilapiros commented on a change in pull request #28967: URL: https://github.com/apache/spark/pull/28967#discussion_r450696105 ## File path: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java ## @@ -145,29 +143,4 @@

[GitHub] [spark] cloud-fan commented on pull request #29012: [SPARK-31710][SQL][FOLLOWUP] Allow cast numeric to timestamp by default

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29012: URL: https://github.com/apache/spark/pull/29012#issuecomment-654686610 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654685275 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-654685313 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-654685313 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654685275 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-07 Thread GitBox
SparkQA commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654684720 **[Test build #125198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125198/testReport)** for PR 27066 at commit

[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-654684533 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654681267 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-654681215 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-654681215 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654681267 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-07 Thread GitBox
cloud-fan commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654680984 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-07-07 Thread GitBox
cloud-fan commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-654681140 jenkins is very unstable recently... This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dilipbiswal commented on a change in pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
dilipbiswal commented on a change in pull request #28683: URL: https://github.com/apache/spark/pull/28683#discussion_r450687662 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2106,6 +2106,15 @@ object SQLConf { .booleanConf

[GitHub] [spark] SparkQA commented on pull request #28989: [WIP][SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
SparkQA commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-654680358 **[Test build #125196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125196/testReport)** for PR 28989 at commit

[GitHub] [spark] SparkQA commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-07 Thread GitBox
SparkQA commented on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-654680330 **[Test build #125197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125197/testReport)** for PR 27428 at commit

[GitHub] [spark] beliefer commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-07 Thread GitBox
beliefer commented on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-654679577 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654677094 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654677094 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654676289 **[Test build #125195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125195/testReport)** for PR 28901 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654644380 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] LantaoJin commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-654673849 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28988: [SPARK-32163][SQL] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28988: URL: https://github.com/apache/spark/pull/28988#issuecomment-654669416 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29012: [SPARK-31710][SQL][FOLLOWUP] Allow cast numeric to timestamp by default

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29012: URL: https://github.com/apache/spark/pull/29012#issuecomment-654669570 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654669468 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29012: [SPARK-31710][SQL][FOLLOWUP] Allow cast numeric to timestamp by default

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29012: URL: https://github.com/apache/spark/pull/29012#issuecomment-654669570 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28969: [SPARK-32150][BUILD] Upgrade to ZStd 1.4.5-4

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28969: URL: https://github.com/apache/spark/pull/28969#issuecomment-654669468 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28993: [SPARK-32168][SQL] Fix hidden partitioning correctness bug in SQL overwrite

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28993: URL: https://github.com/apache/spark/pull/28993#issuecomment-654669288 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28993: [SPARK-32168][SQL] Fix hidden partitioning correctness bug in SQL overwrite

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28993: URL: https://github.com/apache/spark/pull/28993#issuecomment-654669288 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28999: URL: https://github.com/apache/spark/pull/28999#issuecomment-654669317 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28999: URL: https://github.com/apache/spark/pull/28999#issuecomment-654669317 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28988: [SPARK-32163][SQL] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28988: URL: https://github.com/apache/spark/pull/28988#issuecomment-654669416 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

2020-07-07 Thread GitBox
SparkQA commented on pull request #28999: URL: https://github.com/apache/spark/pull/28999#issuecomment-654668593 **[Test build #125192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125192/testReport)** for PR 28999 at commit

[GitHub] [spark] SparkQA commented on pull request #28988: [SPARK-32163][SQL] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
SparkQA commented on pull request #28988: URL: https://github.com/apache/spark/pull/28988#issuecomment-654668685 **[Test build #125194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125194/testReport)** for PR 28988 at commit

[GitHub] [spark] SparkQA commented on pull request #28993: [SPARK-32168][SQL] Fix hidden partitioning correctness bug in SQL overwrite

2020-07-07 Thread GitBox
SparkQA commented on pull request #28993: URL: https://github.com/apache/spark/pull/28993#issuecomment-654668595 **[Test build #125193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125193/testReport)** for PR 28993 at commit

[GitHub] [spark] cloud-fan commented on pull request #28993: [SPARK-32168][SQL] Fix hidden partitioning correctness bug in SQL overwrite

2020-07-07 Thread GitBox
cloud-fan commented on pull request #28993: URL: https://github.com/apache/spark/pull/28993#issuecomment-654667294 retest this please This is an automated message from the Apache Git Service. To respond to the message,

<    7   8   9   10   11   12   13   14   >