[GitHub] [spark] SparkQA commented on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
SparkQA commented on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-655227046 **[Test build #125276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125276/testReport)** for PR 28971 at commit [`89d19c6`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28989: [SPARK-27194][SPARK-29302][SQL] Define a spark staging committer to resolve FileAlreadyExistingException

2020-07-07 Thread GitBox
SparkQA commented on pull request #28989: URL: https://github.com/apache/spark/pull/28989#issuecomment-655226976 **[Test build #125275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125275/testReport)** for PR 28989 at commit [`0d722a9`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-07-07 Thread GitBox
SparkQA commented on pull request #28683: URL: https://github.com/apache/spark/pull/28683#issuecomment-655227027 **[Test build #125277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125277/testReport)** for PR 28683 at commit [`dbdab2d`](https://github.com

[GitHub] [spark] srowen commented on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
srowen commented on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-655226094 Weird. I've seen the same test failure twice here, but it does not fail the normal 2.12 build for me locally. The order of test suite output seems ... intermingled? Kind of confu

[GitHub] [spark] srowen commented on pull request #28971: [WIP][SPARK-29292][SPARK-30010][CORE] Let core compile for Scala 2.13

2020-07-07 Thread GitBox
srowen commented on pull request #28971: URL: https://github.com/apache/spark/pull/28971#issuecomment-655226128 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] StefanXiepj commented on a change in pull request #29010: [SPARK-32192][SQL] Print column name when throws ClassCastException

2020-07-07 Thread GitBox
StefanXiepj commented on a change in pull request #29010: URL: https://github.com/apache/spark/pull/29010#discussion_r451229987 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala ## @@ -20,6 +20,7 @@ package org.apache.spark.sql.hive import java.

[GitHub] [spark] zhengruifeng commented on pull request #28990: [SPARK-32164][ML] GeneralizedLinearRegressionSummary optimization

2020-07-07 Thread GitBox
zhengruifeng commented on pull request #28990: URL: https://github.com/apache/spark/pull/28990#issuecomment-655224401 thanks all! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] ulysses-you commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-07-07 Thread GitBox
ulysses-you commented on a change in pull request #28647: URL: https://github.com/apache/spark/pull/28647#discussion_r451227746 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -1230,16 +1230,10 @@ private[hive] object HiveClien

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-655221228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655220794 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655221184 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-655221228 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] leoluan2009 commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver

2020-07-07 Thread GitBox
leoluan2009 commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-655221201 @wangyum @maropu should we support the global config for timeout? This is an automated message from the Apa

[GitHub] [spark] AmplabJenkins commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655221184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655220786 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655214574 **[Test build #125272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125272/testReport)** for PR 26935 at commit [`9a066c1`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-07-07 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-655220909 **[Test build #125274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125274/testReport)** for PR 28647 at commit [`19f398b`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
SparkQA commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655220755 **[Test build #125272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125272/testReport)** for PR 26935 at commit [`9a066c1`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
SparkQA commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655220852 **[Test build #125273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125273/testReport)** for PR 28898 at commit [`eeffca0`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655220786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] frankyin-factual commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r451224944 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -493,6 +491,156 @@ class

[GitHub] [spark] frankyin-factual commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r451223742 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -493,6 +491,156 @@ class

[GitHub] [spark] frankyin-factual commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
frankyin-factual commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r451223323 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -493,6 +491,156 @@ class

[GitHub] [spark] HyukjinKwon commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655216499 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] HyukjinKwon removed a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
HyukjinKwon removed a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655216499 +1 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28975: URL: https://github.com/apache/spark/pull/28975#issuecomment-655214843 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655214894 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655214894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28975: URL: https://github.com/apache/spark/pull/28975#issuecomment-655214843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
SparkQA commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655214574 **[Test build #125272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125272/testReport)** for PR 26935 at commit [`9a066c1`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-07 Thread GitBox
SparkQA commented on pull request #28975: URL: https://github.com/apache/spark/pull/28975#issuecomment-655214539 **[Test build #125271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125271/testReport)** for PR 28975 at commit [`e2201ef`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-655214483 The very first commit merged by @HeartSaVioR! This is an automated message from the Apache Git Service. To r

[GitHub] [spark] HeartSaVioR commented on pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-07-07 Thread GitBox
HeartSaVioR commented on pull request #26935: URL: https://github.com/apache/spark/pull/26935#issuecomment-655214166 retest this, please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
HyukjinKwon commented on a change in pull request #29023: URL: https://github.com/apache/spark/pull/29023#discussion_r451220383 ## File path: python/pyspark/rdd.py ## @@ -141,7 +141,9 @@ def _parse_memory(s): def _load_from_socket(sock_info, serializer): -(sockfile, so

[GitHub] [spark] HeartSaVioR commented on pull request #28975: [SPARK-32148][SS] Fix stream-stream join issue on missing to copy reused unsafe row

2020-07-07 Thread GitBox
HeartSaVioR commented on pull request #28975: URL: https://github.com/apache/spark/pull/28975#issuecomment-655213867 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] HeartSaVioR commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-07-07 Thread GitBox
HeartSaVioR commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-655213773 Thanks for the update. There's a case it goes up closer to 10x but not really 10x, which seems that 10x is safe one to apply. --

[GitHub] [spark] HyukjinKwon commented on pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #29023: URL: https://github.com/apache/spark/pull/29023#issuecomment-655213664 Thanks @dongjoon-hyun for cc'ing me. @Matzz can you show how you tested it? This is an automated message fro

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28926: URL: https://github.com/apache/spark/pull/28926#issuecomment-655211390 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-655211583 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HeartSaVioR commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
HeartSaVioR commented on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-655211739 Thanks! Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respon

[GitHub] [spark] AmplabJenkins commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-655211583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28926: URL: https://github.com/apache/spark/pull/28926#issuecomment-655211383 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] HeartSaVioR closed pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
HeartSaVioR closed pull request #28965: URL: https://github.com/apache/spark/pull/28965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28926: URL: https://github.com/apache/spark/pull/28926#issuecomment-655211383 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655211012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655211012 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark versio

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-655089638 **[Test build #125248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125248/testReport)** for PR 28965 at commit [`9dfa5c0`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655210553 **[Test build #125270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125270/testReport)** for PR 28833 at commit [`9ad57d1`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28926: URL: https://github.com/apache/spark/pull/28926#issuecomment-655026521 **[Test build #125242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125242/testReport)** for PR 28926 at commit [`8c4ffaa`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28926: [SPARK-32133][SQL] Forbid time field steps for date start/end in Sequence

2020-07-07 Thread GitBox
SparkQA commented on pull request #28926: URL: https://github.com/apache/spark/pull/28926#issuecomment-655210448 **[Test build #125242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125242/testReport)** for PR 28926 at commit [`8c4ffaa`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28965: [SPARK-32124][CORE][FOLLOW-UP] Use the invalid value Int.MinValue to fill the map index when the event logs from the old Spark version

2020-07-07 Thread GitBox
SparkQA commented on pull request #28965: URL: https://github.com/apache/spark/pull/28965#issuecomment-655210512 **[Test build #125248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125248/testReport)** for PR 28965 at commit [`9dfa5c0`](https://github.co

[GitHub] [spark] maropu commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
maropu commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451215944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,9 @@ object MapObjects {

[GitHub] [spark] github-actions[bot] commented on pull request #27248: [WIP][SPARK-30538][SQL] Control spark sql output small file by merge small partition

2020-07-07 Thread GitBox
github-actions[bot] commented on pull request #27248: URL: https://github.com/apache/spark/pull/27248#issuecomment-655209651 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue ma

[GitHub] [spark] maropu commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
maropu commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451215944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,9 @@ object MapObjects {

[GitHub] [spark] HyukjinKwon closed pull request #28912: [SPARK-32057][SQL][test-hive1.2][test-hadoop2.7] ExecuteStatement: cancel and close should not transiently ERROR

2020-07-07 Thread GitBox
HyukjinKwon closed pull request #28912: URL: https://github.com/apache/spark/pull/28912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] maropu commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
maropu commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451215944 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,9 @@ object MapObjects {

[GitHub] [spark] HyukjinKwon commented on pull request #28912: [SPARK-32057][SQL][test-hive1.2][test-hadoop2.7] ExecuteStatement: cancel and close should not transiently ERROR

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28912: URL: https://github.com/apache/spark/pull/28912#issuecomment-655209291 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
SparkQA commented on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655208601 **[Test build #125269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125269/testReport)** for PR 28983 at commit [`ee96cc0`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655208860 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28983: URL: https://github.com/apache/spark/pull/28983#issuecomment-655208860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [WIP] Plumb whether a worker would also be decommissioned along with executor

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-655206610 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [WIP] Plumb whether a worker would also be decommissioned along with executor

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-655208442 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28979: URL: https://github.com/apache/spark/pull/28979#issuecomment-655206965 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28979: URL: https://github.com/apache/spark/pull/28979#issuecomment-655206965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655206381 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] agrawaldevesh opened a new pull request #29032: [WIP] Plumb whether a worker would also be decommissioned along with executor

2020-07-07 Thread GitBox
agrawaldevesh opened a new pull request #29032: URL: https://github.com/apache/spark/pull/29032 ### What changes were proposed in this pull request? This PR is a giant plumbing PR that plumbs a DecommissionInfo along with the DecommissionExecutor message. ### Why are the cha

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [WIP] Plumb whether a worker would also be decommissioned along with executor

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-655206610 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655206381 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
SparkQA commented on pull request #28979: URL: https://github.com/apache/spark/pull/28979#issuecomment-655205717 **[Test build #125237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125237/testReport)** for PR 28979 at commit [`b642c97`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28979: [SPARK-32154][SQL] Use ExpressionEncoder for the return type of ScalaUDF to convert to catalyst type

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28979: URL: https://github.com/apache/spark/pull/28979#issuecomment-654986241 **[Test build #125237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125237/testReport)** for PR 28979 at commit [`b642c97`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-654986192 **[Test build #125236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125236/testReport)** for PR 29022 at commit [`90bb546`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655204951 **[Test build #125236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125236/testReport)** for PR 29022 at commit [`90bb546`](https://github.co

[GitHub] [spark] viirya commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
viirya commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r451209981 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -493,6 +491,156 @@ class NestedCol

[GitHub] [spark] viirya commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
viirya commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r451209212 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -493,6 +491,156 @@ class NestedCol

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655200336 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
maropu commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451208355 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedColumnAl

[GitHub] [spark] AmplabJenkins commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655200336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451207610 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedC

[GitHub] [spark] viirya commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451207755 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedColumnAl

[GitHub] [spark] SparkQA commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
SparkQA commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655200055 **[Test build #125268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125268/testReport)** for PR 28898 at commit [`a0998ae`](https://github.com

[GitHub] [spark] ulysses-you commented on pull request #28808: [SPARK-31975][SQL] Show AnalysisException when WindowFunction is used without WindowExpression

2020-07-07 Thread GitBox
ulysses-you commented on pull request #28808: URL: https://github.com/apache/spark/pull/28808#issuecomment-655200059 thanks for merging! thanks all! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] maropu commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
maropu commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-65529 Looks okay. cc: @viirya @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to t

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451207610 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedC

[GitHub] [spark] maropu commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
maropu commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451206786 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedColumnAl

[GitHub] [spark] erikerlandson commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
erikerlandson commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451206954 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,9 @@ object MapObjects

[GitHub] [spark] frankyin-factual commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
frankyin-factual commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-655199003 @viirya @maropu Rebased with the current master. This is an automated message from the Apache Git Serv

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-655197943 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] erikerlandson commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
erikerlandson commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451205658 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,9 @@ object MapObjects

[GitHub] [spark] AmplabJenkins commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-655198271 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] maryannxue commented on a change in pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
maryannxue commented on a change in pull request #29031: URL: https://github.com/apache/spark/pull/29031#discussion_r451205755 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/RemoveRedundantProjects.scala ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

[GitHub] [spark] maryannxue commented on a change in pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
maryannxue commented on a change in pull request #29031: URL: https://github.com/apache/spark/pull/29031#discussion_r451205382 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2935,6 +2944,8 @@ class SQLConf extends Serializable with

[GitHub] [spark] AmplabJenkins commented on pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29031: URL: https://github.com/apache/spark/pull/29031#issuecomment-655197943 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] viirya commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451204846 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedColumnAl

[GitHub] [spark] allisonwang-db opened a new pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
allisonwang-db opened a new pull request #29031: URL: https://github.com/apache/spark/pull/29031 ### What changes were proposed in this pull request? This PR added a physical rule to remove redundant project nodes. A `ProjectExec` is redundant when 1. It has the same output attributes

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451203379 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedC

[GitHub] [spark] viirya commented on a change in pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29027: URL: https://github.com/apache/spark/pull/29027#discussion_r451202576 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -132,9 +134,12 @@ object NestedColumnAl

[GitHub] [spark] maropu commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
maropu commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451202429 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala ## @@ -415,6 +417,192 @@ abstract class BroadcastJoinS

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29030: SPARK-32093. Add hadoop-ozone-filesystem jar to ozone profile.

2020-07-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #29030: URL: https://github.com/apache/spark/pull/29030#discussion_r451202038 ## File path: pom.xml ## @@ -3059,13 +3062,28 @@ 2.7.1 2.4 + + + org.apache.hadoop + hadoop

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29030: SPARK-32093. Add hadoop-ozone-filesystem jar to ozone profile.

2020-07-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #29030: URL: https://github.com/apache/spark/pull/29030#discussion_r451201726 ## File path: pom.xml ## @@ -202,6 +202,9 @@ 0.15.1 org.fusesource.leveldbjni + + +0.5.0-beta Review comment: Th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655194334 This is an automated message from the Apache Git Service. To respond to the message, please log on

<    1   2   3   4   5   6   7   8   9   10   >