viirya commented on pull request #29404:
URL: https://github.com/apache/spark/pull/29404#issuecomment-672622923
> However, the aggregation buffer is written in steaming checkpoints. Thus,
we can't change to aggregation buffer to resolve the issue.
Is this saying the `isEmpty` in
cloud-fan commented on pull request #29404:
URL: https://github.com/apache/spark/pull/29404#issuecomment-672601482
This adds perf overhead as we need to check overflow after each Add
operation, while the master branch only checks overflow at the end because we
have an extra agg buffer
AmplabJenkins removed a comment on pull request #29403:
URL: https://github.com/apache/spark/pull/29403#issuecomment-672600993
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on a change in pull request #29412:
URL: https://github.com/apache/spark/pull/29412#discussion_r469015649
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala
##
@@ -67,18 +65,12 @@ trait OrcFiltersBase {
AmplabJenkins commented on pull request #29403:
URL: https://github.com/apache/spark/pull/29403#issuecomment-672600993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhouyejoe commented on pull request #29392:
URL: https://github.com/apache/spark/pull/29392#issuecomment-672598759
Hi, @yanxiaole. I double checked the codes in checkForLogs(). I think
SPARK-29043 does actually handles the race condition by filtering out the
stale.filterNot(isProcessing),
SparkQA commented on pull request #29403:
URL: https://github.com/apache/spark/pull/29403#issuecomment-672596737
**[Test build #127352 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127352/testReport)**
for PR 29403 at commit
SparkQA removed a comment on pull request #29403:
URL: https://github.com/apache/spark/pull/29403#issuecomment-672414635
**[Test build #127352 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127352/testReport)**
for PR 29403 at commit
mridulm commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672589797
pip issues, jira update ended up failing ...
This is an automated message from the Apache Git Service.
To
asfgit closed pull request #29411:
URL: https://github.com/apache/spark/pull/29411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
HyukjinKwon edited a comment on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672579570
@mridulm, I remember you have to manually be added to have that Jenkins
permission IIRC. The same thing happened to me too before. I will send an email
offline to
mridulm commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672581541
Thx @venkata91, merging to master
This is an automated message from the Apache Git Service.
To respond to the
HyukjinKwon commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672579570
@mridulm, I remember you have to manually be added to the Jenkins admin. The
same thing happened to me too before. I will send an email offline to you to
invite.
AmplabJenkins removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672576899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
mridulm commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672578174
@HyukjinKwon Any idea why jenkins does not want to listen to me ? :-)
https://github.com/apache/spark/pull/29411#issuecomment-672367418
AmplabJenkins removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672576869
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672567923
**[Test build #127366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127366/testReport)**
for PR 29410 at commit
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672576953
@srowen After
[5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc),
I think that there are no more similar problems that
AmplabJenkins commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672576869
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672575936
**[Test build #127366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127366/testReport)**
for PR 29410 at commit
AmplabJenkins removed a comment on pull request #29322:
URL: https://github.com/apache/spark/pull/29322#issuecomment-672570802
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29322:
URL: https://github.com/apache/spark/pull/29322#issuecomment-672570802
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
venkata91 commented on a change in pull request #29411:
URL: https://github.com/apache/spark/pull/29411#discussion_r469002807
##
File path:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
##
@@ -79,7 +79,7 @@ class SparkSubmitUtilsSuite extends
SparkQA removed a comment on pull request #29322:
URL: https://github.com/apache/spark/pull/29322#issuecomment-672393733
**[Test build #127351 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127351/testReport)**
for PR 29322 at commit
SparkQA commented on pull request #29322:
URL: https://github.com/apache/spark/pull/29322#issuecomment-672570103
**[Test build #127351 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127351/testReport)**
for PR 29322 at commit
HyukjinKwon commented on pull request #29333:
URL: https://github.com/apache/spark/pull/29333#issuecomment-672569879
Okay, GitHub team suggested a scenario that it could work out of the box.
It's a bit complicated then I thought but I will try. Yes, it is a nice-to-have
but I think it is
HyukjinKwon commented on a change in pull request #29410:
URL: https://github.com/apache/spark/pull/29410#discussion_r468999216
##
File path: python/docs/source/getting_started/index.rst
##
@@ -20,3 +20,13 @@
Getting Started
===
+**PySpark** is the Python API
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672568214
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672568232
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672568232
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672568214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rohitmishr1484 edited a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672391444
Hi @HyukjinKwon,
I was not sure how to add you as a Reviewer for this Pull request, thus
adding this comment. I would like to mention a few points:
SparkQA commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672567923
**[Test build #127366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127366/testReport)**
for PR 29410 at commit
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672567955
**[Test build #127367 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127367/testReport)**
for PR 29370 at commit
rohitmishr1484 edited a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672391444
Hi @HyukjinKwon,
I was not sure how to add you as a Reviewer for this Pull request, thus
adding this comment. I would like to mention a few points:
AmplabJenkins removed a comment on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672278185
Can one of the admins verify this patch?
This is an automated message from the Apache Git
LuciferYang edited a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672566297
The main change of Address
[5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc)
is add a sort
- Add a
HyukjinKwon commented on pull request #29410:
URL: https://github.com/apache/spark/pull/29410#issuecomment-672566533
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
HyukjinKwon closed pull request #29409:
URL: https://github.com/apache/spark/pull/29409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672566390
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HyukjinKwon commented on pull request #29409:
URL: https://github.com/apache/spark/pull/29409#issuecomment-672566456
Merged to master and branch-3.0.
This is an automated message from the Apache Git Service.
To respond to
AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672566390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672566297
The main change of Address
[5328d33](https://github.com/apache/spark/pull/29370/commits/5328d33cc0fe138a5d1de9c73285ef262209e6dc)
is add a sort
- Add a `sorted` to
cchighman commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672566232
@maropu
Everything should be updated as requested. I appreciate your thorough
review and believe we arrived at a better result in the process.
SparkQA commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672566066
**[Test build #127365 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127365/testReport)**
for PR 28841 at commit
AmplabJenkins removed a comment on pull request #29406:
URL: https://github.com/apache/spark/pull/29406#issuecomment-672564475
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29406:
URL: https://github.com/apache/spark/pull/29406#issuecomment-672564475
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672564201
**[Test build #127364 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127364/testReport)**
for PR 29370 at commit
SparkQA commented on pull request #29406:
URL: https://github.com/apache/spark/pull/29406#issuecomment-672564174
**[Test build #127363 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127363/testReport)**
for PR 29406 at commit
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672562750
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29406:
URL: https://github.com/apache/spark/pull/29406#issuecomment-672562761
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672562791
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HyukjinKwon closed pull request #29405:
URL: https://github.com/apache/spark/pull/29405
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins commented on pull request #29406:
URL: https://github.com/apache/spark/pull/29406#issuecomment-672562761
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672562791
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672562750
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #29405:
URL: https://github.com/apache/spark/pull/29405#issuecomment-672562701
Merged to master and branch-3.0.
This is an automated message from the Apache Git Service.
To respond to
SparkQA commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672562400
**[Test build #127362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127362/testReport)**
for PR 28841 at commit
AmplabJenkins removed a comment on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-672561572
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-672561566
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-672475149
**[Test build #127354 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127354/testReport)**
for PR 29270 at commit
AmplabJenkins commented on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-672561566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29270:
URL: https://github.com/apache/spark/pull/29270#issuecomment-672561496
**[Test build #127354 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127354/testReport)**
for PR 29270 at commit
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560937
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560937
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672561005
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672561005
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r468993324
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/pathFilters.scala
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
SparkQA commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672560714
**[Test build #127361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127361/testReport)**
for PR 28841 at commit
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560495
The main change of Address
[fca4fa7](https://github.com/apache/spark/pull/29370/commits/fca4fa788c9f9bef0a465daca0bb4c1b62036b63)
as follow:
- Add a `LongType` match
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672560679
**[Test build #127360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127360/testReport)**
for PR 29370 at commit
cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r468992874
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/pathFilters.scala
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
HyukjinKwon commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672559552
Looks good
This is an automated message from the Apache Git Service.
To respond to the message, please log
HyukjinKwon commented on a change in pull request #29411:
URL: https://github.com/apache/spark/pull/29411#discussion_r468992068
##
File path:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
##
@@ -79,7 +79,7 @@ class SparkSubmitUtilsSuite extends
AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672559298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672559298
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672558960
**[Test build #127359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127359/testReport)**
for PR 28841 at commit
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672557789
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672558251
The main change of Address
[db90b1a](https://github.com/apache/spark/pull/29370/commits/db90b1acc87d709ca7643a258eccc31a2ff219ca)
as follow:
- Call `toSeq` in
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672557783
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672557271
**[Test build #127358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127358/testReport)**
for PR 28841 at commit
AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672557783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672557555
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672557773
**[Test build #127358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127358/testReport)**
for PR 28841 at commit
AmplabJenkins commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672557555
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672557271
**[Test build #127358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127358/testReport)**
for PR 28841 at commit
SparkQA commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672557252
**[Test build #127357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127357/testReport)**
for PR 29411 at commit
LuciferYang commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672556899
@srowen There are still some fixes left to commit and will be done today
This is an automated message from
HyukjinKwon commented on pull request #29411:
URL: https://github.com/apache/spark/pull/29411#issuecomment-672556759
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
HyukjinKwon commented on a change in pull request #29412:
URL: https://github.com/apache/spark/pull/29412#discussion_r468989223
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFiltersBase.scala
##
@@ -67,18 +65,12 @@ trait
cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r468988635
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala
##
@@ -0,0 +1,557 @@
+/*
+ * Licensed to the
cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r468988356
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala
##
@@ -0,0 +1,557 @@
+/*
+ * Licensed to the
cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r468988180
##
File path: docs/sql-data-sources-generic-options.md
##
@@ -119,3 +119,47 @@ To load all files recursively, you can use:
{% include_example
cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r468988409
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/PathFilterSuite.scala
##
@@ -0,0 +1,557 @@
+/*
+ * Licensed to the
AmplabJenkins commented on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672555893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28841:
URL: https://github.com/apache/spark/pull/28841#issuecomment-672555893
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672554028
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672554028
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #29370:
URL: https://github.com/apache/spark/pull/29370#issuecomment-672553768
**[Test build #127356 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127356/testReport)**
for PR 29370 at commit
AmplabJenkins removed a comment on pull request #29328:
URL: https://github.com/apache/spark/pull/29328#issuecomment-672543101
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1 - 100 of 607 matches
Mail list logo
