[GitHub] [spark] LuciferYang opened a new pull request, #38525: [SPARK-40950][BUILD][FOLLOWUP] Fix Scala 2.13 Mima check

2022-11-06 Thread GitBox
LuciferYang opened a new pull request, #38525: URL: https://github.com/apache/spark/pull/38525 ### What changes were proposed in this pull request? This pr aims to fix Scala 2.13 Mima check after https://github.com/apache/spark/pull/38427: - https://github.com/apache/spark/actions/

[GitHub] [spark] panbingkun commented on a diff in pull request #38522: [SPARK-41022][SQL][TESTS] Test the error class: DEFAULT_DATABASE_NOT_EXISTS, INDEX_ALREADY_EXISTS, INDEX_NOT_FOUND, ROUTINE_NOT_

2022-11-06 Thread GitBox
panbingkun commented on code in PR #38522: URL: https://github.com/apache/spark/pull/38522#discussion_r1014791978 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala: ## @@ -1578,13 +1578,29 @@ abstract class SessionCatalogSuite extends

[GitHub] [spark] panbingkun commented on a diff in pull request #38520: [SPARK-41021][SQL][TESTS] Test some subclasses of error class DATATYPE_MISMATCH

2022-11-06 Thread GitBox
panbingkun commented on code in PR #38520: URL: https://github.com/apache/spark/pull/38520#discussion_r1014795221 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ## @@ -745,4 +745,52 @@ class ExpressionTypeCheckingSuite ex

[GitHub] [spark] panbingkun commented on a diff in pull request #38520: [SPARK-41021][SQL][TESTS] Test some subclasses of error class DATATYPE_MISMATCH

2022-11-06 Thread GitBox
panbingkun commented on code in PR #38520: URL: https://github.com/apache/spark/pull/38520#discussion_r1014794905 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala: ## @@ -99,6 +100,17 @@ class CollectionExpressionsSuite ex

[GitHub] [spark] panbingkun commented on a diff in pull request #38520: [SPARK-41021][SQL][TESTS] Test some subclasses of error class DATATYPE_MISMATCH

2022-11-06 Thread GitBox
panbingkun commented on code in PR #38520: URL: https://github.com/apache/spark/pull/38520#discussion_r1014794699 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ## @@ -745,4 +745,52 @@ class ExpressionTypeCheckingSuite ex

[GitHub] [spark] LuciferYang commented on a diff in pull request #38507: [SPARK-40372][SQL] Migrate failures of array type checks onto error classes

2022-11-06 Thread GitBox
LuciferYang commented on code in PR #38507: URL: https://github.com/apache/spark/pull/38507#discussion_r1014786778 ## sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala: ## @@ -1603,25 +1681,35 @@ class DataFrameFunctionsSuite extends QueryTest with Shar

[GitHub] [spark] panbingkun commented on a diff in pull request #38520: [SPARK-41021][SQL][TESTS] Test some subclasses of error class DATATYPE_MISMATCH

2022-11-06 Thread GitBox
panbingkun commented on code in PR #38520: URL: https://github.com/apache/spark/pull/38520#discussion_r1014794332 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ## @@ -745,4 +745,52 @@ class ExpressionTypeCheckingSuite ex

[GitHub] [spark] LuciferYang commented on pull request #38427: [SPARK-40950][CORE] Fix isRemoteAddressMaxedOut performance overhead on scala 2.13

2022-11-06 Thread GitBox
LuciferYang commented on PR #38427: URL: https://github.com/apache/spark/pull/38427#issuecomment-1304753660 https://github.com/apache/spark/actions/runs/3401306708/jobs/5656324784 ``` [error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.13:3.3

[GitHub] [spark] panbingkun commented on a diff in pull request #38520: [SPARK-41021][SQL][TESTS] Test some subclasses of error class DATATYPE_MISMATCH

2022-11-06 Thread GitBox
panbingkun commented on code in PR #38520: URL: https://github.com/apache/spark/pull/38520#discussion_r1014793728 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ## @@ -745,4 +745,52 @@ class ExpressionTypeCheckingSuite ex

[GitHub] [spark] LuciferYang commented on a diff in pull request #38507: [SPARK-40372][SQL] Migrate failures of array type checks onto error classes

2022-11-06 Thread GitBox
LuciferYang commented on code in PR #38507: URL: https://github.com/apache/spark/pull/38507#discussion_r1014785958 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala: ## @@ -2810,15 +2879,15 @@ case class Sequence( if (typesC

[GitHub] [spark] AmplabJenkins commented on pull request #38520: [SPARK-41021][SQL][TESTS] Test some subclasses of error class DATATYPE_MISMATCH

2022-11-06 Thread GitBox
AmplabJenkins commented on PR #38520: URL: https://github.com/apache/spark/pull/38520#issuecomment-1304741713 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] LuciferYang commented on a diff in pull request #38507: [SPARK-40372][SQL] Migrate failures of array type checks onto error classes

2022-11-06 Thread GitBox
LuciferYang commented on code in PR #38507: URL: https://github.com/apache/spark/pull/38507#discussion_r1014784646 ## core/src/main/resources/error/error-classes.json: ## @@ -225,14 +230,14 @@ "The should all be of type map, but it's ." ] }, - "M

<    1   2