Re: [PR] [SPARK-46913][SS] Add support for processing/event time based timers with transformWithState operator [spark]

2024-03-09 Thread via GitHub
neilramaswamy commented on code in PR #45051: URL: https://github.com/apache/spark/pull/45051#discussion_r1518738187 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46913][SS] Add support for processing/event time based timers with transformWithState operator [spark]

2024-03-09 Thread via GitHub
anishshri-db commented on code in PR #45051: URL: https://github.com/apache/spark/pull/45051#discussion_r1518723182 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46913][SS] Add support for processing/event time based timers with transformWithState operator [spark]

2024-03-09 Thread via GitHub
HeartSaVioR commented on code in PR #45051: URL: https://github.com/apache/spark/pull/45051#discussion_r1518698125 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46913][SS] Add support for processing/event time based timers with transformWithState operator [spark]

2024-03-09 Thread via GitHub
neilramaswamy commented on code in PR #45051: URL: https://github.com/apache/spark/pull/45051#discussion_r1518669207 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46106]If the hive table is a table, the outsourcing information will be displayed during ShowCreateTableCommand. #44018 [spark]

2024-03-09 Thread via GitHub
github-actions[bot] closed pull request #44019: [SPARK-46106]If the hive table is a table, the outsourcing information will be displayed during ShowCreateTableCommand. #44018 URL: https://github.com/apache/spark/pull/44019 -- This is an automated message from the Apache Git Service. To

Re: [PR] [SPARK-47328][SQL] Rename UCS_BASIC collation to UTF8_BINARY [spark]

2024-03-09 Thread via GitHub
srielau commented on PR #45442: URL: https://github.com/apache/spark/pull/45442#issuecomment-1987003846 A concern was raised that UCS_BASIC which is the order imposed by the Unicode codepoints is not an exact match to the sort order of UTF8 once you get beyond 32k. -- This is an

Re: [PR] [SPARK-46913][SS] Add support for processing/event time based timers with transformWithState operator [spark]

2024-03-09 Thread via GitHub
neilramaswamy commented on code in PR #45051: URL: https://github.com/apache/spark/pull/45051#discussion_r1518669207 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TimerStateImpl.scala: ## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SQL] Bind JDBC dialect to JDBCRDD at construction [spark]

2024-03-09 Thread via GitHub
utkarshwealthy commented on code in PR #45410: URL: https://github.com/apache/spark/pull/45410#discussion_r1518645531 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala: ## @@ -153,12 +153,12 @@ object JDBCRDD extends Logging { */ class

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-09 Thread via GitHub
stevomitric commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1518576388 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,19 @@ public boolean endsWith(final UTF8String suffix, int

[PR] [SPARK-47334][SQL] Make `withColumnRenamed` reuse the implementation of `withColumnsRenamed` [spark]

2024-03-09 Thread via GitHub
zhengruifeng opened a new pull request, #45450: URL: https://github.com/apache/spark/pull/45450 ### What changes were proposed in this pull request? Make `withColumnRenamed` reuse the implementation of `withColumnsRenamed` ### Why are the changes needed? to avoid any

Re: [PR] [WIP] Use checkInputDataTypes to check the parameter types of the function `to_xml` & remove _LEGACY_ERROR_TEMP_3234 [spark]

2024-03-09 Thread via GitHub
panbingkun commented on PR #45167: URL: https://github.com/apache/spark/pull/45167#issuecomment-1986789521 > @panbingkun Could fill in PR description, please. You changes are pretty useful, I believe. @MaxGekk Okay, let me update it. But this PR actually did `two` aims,