Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20408
@ajbozarth Ok. For tomorrow I can update both the label and the screenshots.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20408#discussion_r164594314
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -254,6 +255,7 @@ private class LiveExecutor(val executorId: String
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20408#discussion_r164368745
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage.js ---
@@ -25,9 +25,13 @@ function getThreadDumpEnabled() {
return
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20408
@ajbozarth What about `Active except for Stages: [...]`?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20408#discussion_r164292079
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -594,12 +606,24 @@ private[spark] class AppStatusListener
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20408
cc @squito @tgravescs
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user attilapiros opened a pull request:
https://github.com/apache/spark/pull/20408
[SPARK-23189][Core][UI] Reflect stage level blacklisting on executor tab
## What changes were proposed in this pull request?
The purpose of this PR to reflect the stage level
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20046
cc @gatorsmile @hvanhovell @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
Test failure seems to be unrelated as it it is in
org.apache.spark.sql.hive.client.HiveClientSuites.
@squito, @tgravescs could you please restart testing
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20046
PySpark failure must be unrelated as only unit tests are added.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20046
I have already extended
sql/core/src/test/resources/sql-tests/inputs/window.sql with the missing window
aggregate functions but if you would like I can move it to a different PR too
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20046#discussion_r162894686
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -86,6 +93,429 @@ class DataFrameWindowFunctionsSuite
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
One more reason to run tests in sbt / maven. In intelliJ somehow the
complete suite was successful. But the current failure seems to me unrelated,
as org.apache.spark.deploy.history has 0
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20203#discussion_r162716271
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetBlacklistSuite.scala ---
@@ -59,31 +60,55 @@ class TaskSetBlacklistSuite extends
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
The node blacklisting is tested by unit tests:
- HistoryServerSuite
- TaskSetBlacklistSuite
- AppStatusListenerSuite
And manually with a 2 node cluster:
https
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
@tgravescs @squito: But what about doing it in a separate PR as this is
already quite big?
So node backlisting would be still within the scope but executor page
changes would be done for a
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
Of course I can update the executors page too.
@tgravescs I think via handling the onStageCompleted I can do what you
would like to see here
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20203#discussion_r162041751
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala ---
@@ -128,13 +130,17 @@ private[scheduler] class TaskSetBlacklist(val
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161854693
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,3 +361,78 @@ class JacksonParser
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161807543
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,3 +361,78 @@ class JacksonParser
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161704328
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -143,28 +139,20 @@ object
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161744616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonUtils.scala
---
@@ -39,7 +38,7 @@ object JsonUtils
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161742050
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -178,21 +166,15 @@ object
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161733393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,3 +361,78 @@ class JacksonParser
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161566402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -143,28 +139,20 @@ object
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161567546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,3 +361,78 @@ class JacksonParser
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161745397
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1853,7 +1853,7 @@ class JsonSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161487862
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161491069
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -751,6 +751,25 @@ class HiveDDLSuite
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161488850
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161477649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -800,6 +802,15 @@ case class AlterTableSetLocationCommand
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161480210
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161488605
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20249#discussion_r161488179
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1869,6 +1869,65 @@ abstract class DDLSuite extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20203#discussion_r161070422
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -211,6 +211,11 @@ private[spark] class AppStatusListener
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
@tgravescs: You are welcome.
Running Spark as (with lower application.maxFailedTasksPerExecutor than
stage.maxFailedTasksPerExecutor):
```
$ bin/spark-shell --master "
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20235#discussion_r160979218
--- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala
---
@@ -34,86 +35,122 @@ class FPGrowthSuite extends SparkFunSuite with
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20203
cc @tgravescs
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
GitHub user attilapiros opened a pull request:
https://github.com/apache/spark/pull/20203
[SPARK-22577] [core] executor page blacklist status should update with
TaskSet level blacklisting
## What changes were proposed in this pull request?
In this PR stage blacklisting is
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20046
cc @gatorsmile @hvanhovell @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20069#discussion_r158885112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -47,6 +48,15 @@ trait Predicate extends
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20045#discussion_r158300159
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -32,6 +32,209 @@ import
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20046#discussion_r158456767
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -154,6 +154,217 @@ class
GitHub user attilapiros opened a pull request:
https://github.com/apache/spark/pull/20046
Adding unit tests for missing aggregate functions
## What changes were proposed in this pull request?
Improving the test coverage of window functions focusing on missing test
for
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19599#discussion_r156913602
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -435,6 +435,43 @@ class BooleanParam(parent: String, name: String, doc
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/19599
As I see inside the StringParam the options even can be mapped to enum
values. This way ignoring cases at the matching part would be no problem at all
(and it would be very efficient). Going
201 - 246 of 246 matches
Mail list logo
