Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/5915#issuecomment-108594833
Anything I should try to do to fix this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/5915#issuecomment-108632111
Yay!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/5915#issuecomment-108092203
Ok, think I fixed the merge and cleaned up the pull request so it is just
my files.
---
If your project is set up for it, you can reply to this email and have your
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/5915#issuecomment-108078500
l will try to resolve and update the pull request.
On Tue, Jun 2, 2015 at 10:49 AM, jkbradley notificati...@github.com wrote:
Uh oh, those tests
GitHub user leahmcguire opened a pull request:
https://github.com/apache/spark/pull/6073
[SPARK-7545][mllib] Added check in Bernoulli Naive Bayes to make sure that
both training and predict feature have values of 0 or 1
You can merge this pull request into a Git repository
GitHub user leahmcguire reopened a pull request:
https://github.com/apache/spark/pull/5915
[SPARK-6164] [ML] CrossValidatorModel should keep stats from fitting
Added stats from cross validation as a val in the cross validation model to
save them for user access.
You can merge
Github user leahmcguire closed the pull request at:
https://github.com/apache/spark/pull/5915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/5915#issuecomment-100051023
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user leahmcguire opened a pull request:
https://github.com/apache/spark/pull/5911
[SPARK-6164 [ML] CrossValidatorModel should keep stats from fitting
Added stats from cross validation as a val in the cross validation model to
save them for user access.
You can merge
Github user leahmcguire closed the pull request at:
https://github.com/apache/spark/pull/5911
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user leahmcguire opened a pull request:
https://github.com/apache/spark/pull/5915
[SPARK-6164] [ML] CrossValidatorModel should keep stats from fitting
Added stats from cross validation as a val in the cross validation model to
save them for user access.
You can merge
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-86292839
Either version is fine. If you have time to make the change on tomorrow go
ahead and send the PR. Otherwise I'll have time to make the change on
Friday
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26542594
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends Loader
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26543828
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26347821
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -156,9 +181,14 @@ object NaiveBayesModel extends Loader
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26256579
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -35,26 +39,30 @@ import org.apache.spark.sql.{DataFrame
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r26258688
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala ---
@@ -262,4 +303,58 @@ object NaiveBayes {
def train(input
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-78381145
@jkbradley thanks for the comments! I have implemented everything except
the two inline comments that I replied to directly.
I'm not clear about how you want
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-77435497
I made all the inline fixes and integrated the model type fix. If you can
provide me with a bit more guidance on the save/load I am happy to do it.
---
If your
Github user leahmcguire commented on a diff in the pull request:
https://github.com/apache/spark/pull/4087#discussion_r25443491
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/classification/NaiveBayesSuite.scala
---
@@ -71,23 +86,67 @@ class NaiveBayesSuite extends
Github user leahmcguire commented on the pull request:
https://github.com/apache/spark/pull/4087#issuecomment-70597399
Thanks for the comments!
The JIRA for the python API is:
https://issues.apache.org/jira/browse/SPARK-5328
I will get the rest fixed tonight
GitHub user leahmcguire opened a pull request:
https://github.com/apache/spark/pull/4087
[SPARK-4894][mllib] Added Bernoulli option to NaiveBayes model in mllib
Added optional model type parameter for NaiveBayes training. Can be either
Multinomial or Bernoulli.
When
22 matches
Mail list logo
