Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13363#discussion_r64970602
--- Diff: core/src/main/scala/org/apache/spark/storage/StorageLevel.scala
---
@@ -120,8 +120,14 @@ class StorageLevel private(
private def
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13269#issuecomment-52647
As we discussed offline, this PR also enables case insensitive encoder
resolution. Would be nice to add a test case for it. Basically something like
this
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13362#issuecomment-42407
@cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13362
[SPARK-15112][SQL] Disables EmbedDeserializerInFilter for plan fragments
that change schema
## What changes were proposed in this pull request?
`EmbedDeserializerInFilter` implicitly
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13280#discussion_r64947036
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala
---
@@ -1415,6 +1425,18 @@ class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13280#discussion_r64946259
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -194,7 +196,24
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13280#discussion_r64945499
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala
---
@@ -1415,6 +1425,18 @@ class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13280#discussion_r64943553
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala
---
@@ -1066,19 +1066,29 @@ class
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13280#issuecomment-222025448
@rdblue LGTM pending rebasing and Jenkins. Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12972#issuecomment-222025019
Sorry for the late review, this LGTM except for one minor comment on the
test case. Thanks for fixing it!
---
If your project is set up for it, you can reply to
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12972#discussion_r64838540
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -451,4 +451,17 @@ class OrcQuerySuite extends QueryTest with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12972#discussion_r64838469
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -451,4 +451,17 @@ class OrcQuerySuite extends QueryTest with
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13330#issuecomment-222023638
LGTM pending Jenkins. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13330#issuecomment-222023617
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13331#issuecomment-222022474
Merging to master and branch-2.0. Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13331#discussion_r64816282
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -436,20 +435,6 @@ class DatasetSuite extends QueryTest with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13331#discussion_r64815745
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -440,14 +439,16 @@ class DatasetSuite extends QueryTest with
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13280#issuecomment-221982103
I think we should upgrade Parquet to 1.8.1 in Spark 2.0 due to the
following reasons:
1. Get PARQUET-251 fixed so that we no longer write corrupted
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13331
[SPARK-15550][SQL][WIP] Dataset.show() should show contents nested products
as rows
## What changes were proposed in this pull request?
This PR addresses two related issues:
1
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13216#discussion_r64697298
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TypedFilterOptimizationSuite.scala
---
@@ -34,40 +35,47 @@ class
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221756444
cc @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64674180
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -28,11 +28,11 @@ class ShowCreateTableSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r64673144
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -354,7 +356,27 @@ object
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221739839
@xwu0226 For your [last comment][1] in your PR, I also realized that we are
not really using `CatalogTable.storage.locationUri` for data source tables
while doing
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221736990
@xwu0226 No we shouldn't have problem with Hive compatible tables now since
we only add the placeholder location URI when `table.storage.locationUri` is
empty
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221737110
@xwu0226 I should probably add a comment to explain the
`locationUri.isEmpty` thing since it's not quite intuitive.
---
If your project is set up for it, yo
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221715803
@xwu0226 Thanks. Handled Hive compatible tables [here][1]. `CatalogTable`
should be implementation agnostic, so it's infeasible to add a Hive specific
fl
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64645557
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -68,7 +69,8 @@ private[spark] class HiveExternalCatalog
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13273#issuecomment-221469762
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13280#issuecomment-221457588
I had once tried to upgrade Parquet to 1.8.1, and one more change needs to
be done for the upgrade:
https://github.com/apache/spark/pull/9225/files#diff
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64503026
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -385,7 +385,10 @@ object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64500677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64500584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -385,7 +385,10 @@ object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64500603
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64482317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13270#discussion_r64327851
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -216,7 +216,25 @@ class SessionCatalog
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13270#issuecomment-221137189
@xwu0226 Would you please help review this one? It's based on our
discussion in your PR (#13120). The benefit of this version is that it avoids
the bad
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13270
[SPARK-15269][SQL] Removes unexpected empty table directories created while
creating external Spark SQL data sourcet tables.
This PR is an alternative to #13120 authored by @xwu0226
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13212#issuecomment-221135020
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13212#issuecomment-221102993
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64293071
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
---
@@ -295,9 +294,7 @@ private[hive] class
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13212#issuecomment-221082584
In general looks good except for a few minor comments. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64279884
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -774,13 +774,42 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64278795
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -46,3 +51,52 @@ case class AddFileCommand(path: String
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64278535
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -46,3 +51,52 @@ case class AddFileCommand(path: String
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13229#issuecomment-221043731
LGTM, merging to master and branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64257331
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -46,3 +51,52 @@ case class AddFileCommand(path: String
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64256691
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -46,3 +51,52 @@ case class AddFileCommand(path: String
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64256050
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -46,3 +51,52 @@ case class AddFileCommand(path: String
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64255403
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -46,3 +51,52 @@ case class AddFileCommand(path: String
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64255488
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -774,13 +774,42 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64253549
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -774,13 +774,42 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64253417
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -774,13 +774,42 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64253346
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -774,13 +774,42 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64252871
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -117,7 +117,7 @@ statement
tableIdentifier
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64252495
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -156,6 +156,18 @@ class SparkContextSuite extends SparkFunSuite with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64252462
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -156,6 +156,18 @@ class SparkContextSuite extends SparkFunSuite with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13212#discussion_r64252524
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -156,6 +156,18 @@ class SparkContextSuite extends SparkFunSuite with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r64100525
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -354,7 +356,27 @@ object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13227#discussion_r64100013
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala
---
@@ -341,11 +341,11 @@ private[sql] object
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13227#issuecomment-220706484
LGTM except for one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12313#discussion_r63912066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -498,6 +499,117 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12313#discussion_r63912028
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -498,6 +499,117 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/12313#discussion_r63912009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -498,6 +499,117 @@ class Analyzer
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r63869408
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -354,7 +356,27 @@ object
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13173#issuecomment-220231882
Doesn't seem to be a valid MiMA check failure. Actually the tool crashed.
---
If your project is set up for it, you can reply to this email and have your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13173#issuecomment-220231892
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13173#discussion_r63751785
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -633,16 +633,16 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12952#issuecomment-220104678
@marmbrus Sorry for the late reply. This issue is a little bit complicated.
I made the following (long) summary for explanation and future reference
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13173#issuecomment-220042157
cc @yhuai @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13173
[SPARK-14346][SQL] Lists unsupported Hive features in SHOW CREATE TABLE
output
## What changes were proposed in this pull request?
This PR is a follow-up of #13079. It replaces
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63710152
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,149 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r63687429
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -348,13 +349,23 @@ object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r63686818
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -348,13 +349,23 @@ object
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13120#discussion_r63686590
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
---
@@ -348,13 +349,23 @@ object
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13166#issuecomment-219992565
Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13094#issuecomment-219988054
LGTM. Thanks for fixing it! Merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63669445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,149 @@ case class ShowCreateTableCommand(table
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13166
[SPARK-15334][SQL][HOTFIX] Fixes compilation error for Scala 2.10
## What changes were proposed in this pull request?
This PR fixes a Scala 2.10 compilation failure introduced in PR
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13127#issuecomment-219948559
LGTM, merging to master and branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13098#issuecomment-219898461
Also merged to branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13098#issuecomment-219898286
Just merged this to master, but it conflicts with branch-2.0. Trying to
resolve manually.
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63543727
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -116,24 +116,143 @@ class ShowCreateTableSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63543604
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63489249
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63489049
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63488983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -95,7 +101,8 @@ case class CatalogTable
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63489023
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63488949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63356767
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -130,109 +124,343 @@ class VersionsSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63352676
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -130,109 +124,343 @@ class VersionsSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63352618
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -130,109 +124,343 @@ class VersionsSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63352549
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -130,109 +124,343 @@ class VersionsSuite extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13127#discussion_r63351076
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -130,109 +124,343 @@ class VersionsSuite extends
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13098#issuecomment-219422041
LGTM except for some minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13098#discussion_r63349989
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1975,9 +1978,9 @@ class SQLQuerySuite extends QueryTest with
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13098#discussion_r63349951
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1975,9 +1978,9 @@ class SQLQuerySuite extends QueryTest with
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13098#issuecomment-219421069
Please update the PR title since it also removes deprecated call from
examples and docs.
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13098#discussion_r63349555
--- Diff: docs/sql-programming-guide.md ---
@@ -1582,8 +1582,8 @@ people.printSchema()
# |-- age: long (nullable = true)
# |-- name: string
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13098#discussion_r63349544
--- Diff: docs/sql-programming-guide.md ---
@@ -1544,8 +1544,8 @@ people.printSchema();
// |-- age: long (nullable = true)
// |-- name: string
701 - 800 of 5243 matches
Mail list logo
