[GitHub] spark pull request #21175: [SPARK-24107][CORE] ChunkedByteBuffer.writeFully ...

2018-04-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21175#discussion_r184675304 --- Diff: core/src/test/scala/org/apache/spark/io/ChunkedByteBufferSuite.scala --- @@ -56,6 +56,15 @@ class ChunkedByteBufferSuite extends SparkFunSuite

[GitHub] spark pull request #21175: [SPARK-24107][CORE] ChunkedByteBuffer.writeFully ...

2018-04-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21175#discussion_r184645573 --- Diff: core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala --- @@ -63,10 +63,12 @@ private[spark] class ChunkedByteBuffer(var chunks

[GitHub] spark pull request #21175: [SPARK-24107][CORE] ChunkedByteBuffer.writeFully ...

2018-04-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21175#discussion_r184644678 --- Diff: core/src/test/scala/org/apache/spark/io/ChunkedByteBufferSuite.scala --- @@ -56,6 +56,13 @@ class ChunkedByteBufferSuite extends SparkFunSuite

[GitHub] spark pull request #21175: [SPARK-24107][CORE] ChunkedByteBuffer.writeFully ...

2018-04-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21175#discussion_r184644454 --- Diff: core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala --- @@ -63,10 +63,12 @@ private[spark] class ChunkedByteBuffer(var chunks

[GitHub] spark issue #21070: [SPARK-23972][BUILD][SQL] Update Parquet to 1.10.0.

2018-04-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21070 ok, I'll work on it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21177: [SPARK-24111][SQL] Add the TPCDS v2.7 (latest) queries i...

2018-04-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21177 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21177: [SPARK-24111][SQL] Add the TPCDS v2.7 (latest) qu...

2018-04-27 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21177 [SPARK-24111][SQL] Add the TPCDS v2.7 (latest) queries in TPCDSQueryBenchmark ## What changes were proposed in this pull request? This pr added the TPCDS v2.7 (latest) queries

[GitHub] spark issue #21174: [SPARK-24085][SQL] Query returns UnsupportedOperationExc...

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21174 One question; we have no risk to miss any partition pruning by this fix? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21175: [SPARK-24107] ChunkedByteBuffer.writeFully method has no...

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21175 Plz add `[CORE]` in the title. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21176: [SPARK-24109] Remove class SnappyOutputStreamWrapper

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21176 Have you checked the @srowen 's comment? https://github.com/apache/spark/pull/18949#issuecomment-323354674 --- - To unsubscribe

[GitHub] spark issue #21174: [SPARK-24085] Query returns UnsupportedOperationExceptio...

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21174 plz add `[SQL]` in the title. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21174: [SPARK-24085] Query returns UnsupportedOperationExceptio...

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21174 Ah, ok. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21173: [SPARK-23856][SQL] Add an option `queryTimeout` in JDBCO...

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21173 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21174: [SPARK-24085] Query returns UnsupportedOperationExceptio...

2018-04-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21174 Why the orc works fine? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21173: [SPARK-23856][SQL] Add an option `queryTimeout` i...

2018-04-26 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21173 [SPARK-23856][SQL] Add an option `queryTimeout` in JDBCOptions ## What changes were proposed in this pull request? This pr added an option `queryTimeout` for the number of seconds

[GitHub] spark issue #21070: [SPARK-23972][BUILD][SQL] Update Parquet to 1.10.0.

2018-04-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21070 I just run `TPCDSQueryBenchmark` in an ec2 instance (m4.2xlarge). The job to check performance regression is too heavy, so we just check if `tpcds`, `tpch`, and `ssb` can be correctly compiled

[GitHub] spark issue #21070: [SPARK-23972][BUILD][SQL] Update Parquet to 1.10.0.

2018-04-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21070 @gatorsmile @rdblue I checked the numbers and I found no regression at least in TPC-DS: to check the actual numbers, see https://issues.apache.org/jira/browse/SPARK-24070

[GitHub] spark issue #21149: [SPARK-24076][SQL] Use different seed in HashAggregate t...

2018-04-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21149 cc: @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21149: [SPARK-24076][SQL] Use different seed in HashAggr...

2018-04-25 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21149#discussion_r183968048 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -755,7 +755,7 @@ case class HashAggregateExec

[GitHub] spark issue #21149: [SPARK-24076][SQL] Use different seed in HashAggregate t...

2018-04-25 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21149 oh... good catch. I think you'd be better to put [the detailed info.](https://issues.apache.org/jira/browse/SPARK-24076?focusedCommentId=16451743=com.atlassian.jira.plugin.system.issuetabpanels

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21109 Can you put performance numbers w/ this pr? Also, you'd be better to add benchmark code in `JoinBenchmark`. --- - To unsubscribe

[GitHub] spark pull request #21148: [SPARK-24079][SQL] Update the nullability of Join...

2018-04-24 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21148 [SPARK-24079][SQL] Update the nullability of Join output based on inferred predicates ## What changes were proposed in this pull request? This pr added code to update the nullability

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21018 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21070: [SPARK-23972][BUILD][SQL] Update Parquet to 1.10.0.

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21070 I'll check performance changes w/ this pr in days and put the result in https://issues.apache.org/jira/browse/SPARK-24070

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21144: [SPARK-24043][SQL] Interpreted Predicate should initiali...

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21144 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21144: [SPARK-24043][SQL] Interpreted Predicate should i...

2018-04-24 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21144#discussion_r183908521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -36,6 +36,14 @@ object InterpretedPredicate

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-24 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183907321 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -794,4 +795,28 @@ class CachedTableSuite extends QueryTest

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20938 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21137: [SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow i...

2018-04-24 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21137#discussion_r183671345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1255,6 +1255,13 @@ case class

[GitHub] spark pull request #21137: [SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow i...

2018-04-24 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21137#discussion_r183671370 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1267,12 +1274,12 @@ case class

[GitHub] spark issue #21137: [SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow in Exter...

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21137 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20692: [SPARK-23531][SQL] Show attribute type in explain

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20692 @mgaido91 Can you update this? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-24 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20938 @ueshin Do you forget to merge this? ;) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-24 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183614108 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -55,56 +42,39 @@ object InMemoryRelation

[GitHub] spark issue #21137: [SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow in Exter...

2018-04-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21137 @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21137: [SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow i...

2018-04-23 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21137 [SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow in ExternalMapToCatalyst eval ## What changes were proposed in this pull request? This pr is a follow-up of #20980 and fixes code to reuse

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183395070 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -55,56 +42,39 @@ object InMemoryRelation

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20980 ok, Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183362225 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -155,31 +125,76 @@ case class InMemoryRelation

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183362208 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -55,56 +42,39 @@ object InMemoryRelation

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-23 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20980 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183288749 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala --- @@ -55,56 +42,38 @@ object InMemoryRelation

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r183288666 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21018 @cloud-fan @viirya could you check this? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 @cloud-fan @wzhfy ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21052#discussion_r183190383 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends

[GitHub] spark pull request #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21052#discussion_r183190432 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends

[GitHub] spark pull request #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21052#discussion_r183190234 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends

[GitHub] spark pull request #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21052#discussion_r183190221 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends

[GitHub] spark pull request #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21052#discussion_r183190136 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/StatisticsCollectionSuite.scala --- @@ -382,4 +382,34 @@ class StatisticsCollectionSuite extends

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r183185144 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec

[GitHub] spark pull request #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should s...

2018-04-20 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20980#discussion_r183070120 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala --- @@ -472,6 +474,61 @@ class

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20757 Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20980 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

2018-04-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21112 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder meth...

2018-04-20 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21112 @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21112: [SPARK-23588][SQL][FOLLOW-UP] Resolve a map build...

2018-04-20 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21112 [SPARK-23588][SQL][FOLLOW-UP] Resolve a map builder method per execution in CatalystToExternalMap ## What changes were proposed in this pull request? This pr is a follow-up pr of #20979

[GitHub] spark issue #20979: [SPARK-23588][SQL] CatalystToExternalMap should support ...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20979 ok, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should s...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20980#discussion_r182945511 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala --- @@ -415,6 +417,36 @@ class

[GitHub] spark pull request #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should s...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20980#discussion_r182933940 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1197,8 +1197,64 @@ case class

[GitHub] spark pull request #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should s...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20980#discussion_r182930489 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala --- @@ -415,6 +417,36 @@ class

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r182929830 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -119,26 +119,60 @@ class CacheManager extends Logging

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21018 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20757 Many thanks for your checks! I'll fix soon! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r182903518 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1615,13 +1616,50 @@ case class

[GitHub] spark issue #21052: [SPARK-23799][SQL] FilterEstimation.evaluateInSet produc...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21052 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20980 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20778 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20757 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21018 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r182677131 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r182673750 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -266,28 +342,53 @@ case class HashAggregateExec

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20965#discussion_r182653261 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -254,6 +256,80 @@ case class HashAggregateExec

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 @wzhfy ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r182626260 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -119,26 +119,60 @@ class CacheManager extends Logging

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r182612846 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -119,26 +119,60 @@ class CacheManager extends Logging

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r181122693 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -119,26 +119,60 @@ class CacheManager extends Logging

[GitHub] spark issue #21052: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-12 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21052 @wzhfy @gatorsmile could you trigger the tests? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20929: [SPARK-23772][SQL][WIP] Provide an option to ignore colu...

2018-04-12 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20929 Thanks for the review! ok, plz give me more time to reconsider the design based the comments. --- - To unsubscribe, e-mail

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-04-12 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20778 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20778: [SPARK-23584][SQL] NewInstance should support int...

2018-04-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20778#discussion_r180975252 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -392,8 +392,44 @@ case class NewInstance

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-11 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-11 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21018#discussion_r180777891 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala --- @@ -119,26 +119,60 @@ class CacheManager extends Logging

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-11 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-11 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-04-11 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20980: [SPARK-23589][SQL] ExternalMapToCatalyst should support ...

2018-04-10 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20980 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-10 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20757 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180616339 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -145,4 +161,55 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180616142 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -116,7 +127,12 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180615479 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -172,17 +174,20 @@ object ExtractFiltersAndInnerJoins

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180615326 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -59,12 +75,7 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180613972 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,50 @@ object ReorderJoin extends Rule

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-10 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20913 @mshtelma You shouldn't merge the changes and you need to rebase your pr. So, I think it's easy to close this pr and open a new pr as @jiangxb1987 suggested above

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-04-10 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20757 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-09 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21018 I'll fix the failure tonight (jst) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #21018: [SPARK-23880][SQL] Do not trigger any jobs for ca...

2018-04-09 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21018 [SPARK-23880][SQL] Do not trigger any jobs for caching data ## What changes were proposed in this pull request? This pr fixed code so that `cache` could prevent any jobs from being triggered

[GitHub] spark issue #21005: [SPARK-23898][SQL] Simplify add & subtract code generati...

2018-04-09 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21005 yea, I think so and I just suggested we'd better to file a new jira for that. Thanks! --- - To unsubscribe, e-mail: reviews

<    8   9   10   11   12   13   14   15   16   17   >