Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56881462
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -263,13 +263,33 @@ class BlockMatrix @Since("
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56881322
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -263,13 +263,33 @@ class BlockMatrix @Since("
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/10839#discussion_r56881327
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -263,13 +263,33 @@ class BlockMatrix @Since("
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11853#issuecomment-199416076
@yinxusen It doesn't seems feasible to me to find all duplicated examples
in all languages in a single PR. Shall we list possible merges first and then
group the tasks
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11780#issuecomment-199415065
@hhbyyh We moved Logging to `org.apache.spark.internal`. Could you update
this PR?
---
If your project is set up for it, you can reply to this email and have your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11578#issuecomment-199129930
@viirya Generating a random value could be more expensive than an iterator
call. With gap sampling and p=0.8, we probably need to generate more values
than the number
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56433888
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434392
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11610#issuecomment-197557069
@dbtsai There is a good chance of precision loss during the computation of
A^T A is A is ill-conditioned. A better approach is to factorize A directly. It
is similar
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56435017
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/HypothesisTestingExample.scala
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434972
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/HypothesisTestingExample.scala
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434617
--- Diff:
examples/src/main/python/mllib/hypothesis_testing_kolmogorov_smirnov_test_example.py
---
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434815
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/HypothesisTestingExample.scala
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434020
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56433851
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaKernelDensityEstimationExample.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56435169
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/StratifiedSamplingExample.scala
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56433947
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56433747
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaHypothesisTestingExample.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11578#issuecomment-197620041
What is the sampling probability in your benchmark?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434099
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11463#issuecomment-197552267
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434426
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaSummaryStatisticsExample.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434127
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197557655
@Fokko That PR was merged. Could you merge the current master and update
your implementation? Note that when you concat the vectors, it is useful to
check the sparsity
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434528
--- Diff: examples/src/main/python/mllib/hypothesis_testing_example.py ---
@@ -0,0 +1,63 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56435241
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/SummaryStatisticsExample.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434630
--- Diff: examples/src/main/python/mllib/hypothesis_testing_example.py ---
@@ -0,0 +1,63 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11108#issuecomment-197601829
I'm making a pass now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434078
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11108#issuecomment-197608555
@keypointt @yinxusen I made one pass and left some comments inline. One
issue is whether we want to print empty lines. It doesn't seem necessary to me
for example code
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56434589
--- Diff: examples/src/main/python/mllib/hypothesis_testing_example.py ---
@@ -0,0 +1,63 @@
+#
+# Licensed to the Apache Software Foundation (ASF
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11108#issuecomment-198004940
I agree. But we don't really need lines just to print empty lines. For
example:
~~~scala
println(goodnessOfFitTestResult)
println
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11781#issuecomment-197984243
@zhengruifeng Please do not start coding immediately after you created a
JIRA. As @srowen mentioned on the JIRA, we already have ALS with nonnegative LS
solver
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56433742
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaCorrelationsExample.java
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11108#discussion_r56435214
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/StratifiedSamplingExample.scala
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11379#issuecomment-197613831
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11379#issuecomment-197203735
+1. There was a bug in SQL internal type conversions, which might call
`serialize` twice. This is why `Any` was used. The bug was fixed but I forgot
to change the type
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11581#discussion_r56293008
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -273,7 +273,29 @@ private[ml] object DefaultParamsReader
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10242#issuecomment-197199809
@yanboliang Is this PR ready for merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11610#issuecomment-197199401
Locally, we are solving `A^T A x = A^T b`. In a rank deficient case, we can
compute the min-length least squares solution that also minimizes `\| x \|_2`,
which
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11463#issuecomment-197196419
LGTM except one minor issue on the output path, which should be in a
temporary folder. So it doesn't appear in git.
---
If your project is set up for it, you can reply
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11463#discussion_r56291297
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -65,12 +51,23 @@ class LogisticRegressionSuite
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11463#discussion_r56291308
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -44,6 +44,19 @@ class AFTSurvivalRegressionSuite
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11549#discussion_r56290850
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -17,15 +17,41 @@
package org.apache.spark.ml.api.r
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11549#discussion_r56290664
--- Diff: R/pkg/R/mllib.R ---
@@ -51,13 +45,12 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11549#discussion_r56290662
--- Diff: R/pkg/R/mllib.R ---
@@ -29,15 +29,9 @@ setClass("PipelineModel", representation(model = "jobj"))
#' @param formula A
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11549#discussion_r56290601
--- Diff: R/pkg/R/mllib.R ---
@@ -51,13 +45,12 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11549#issuecomment-197192755
@yanboliang @hhbyyh Let us do the summary statistics under another JIRA:
https://issues.apache.org/jira/browse/SPARK-13925
---
If your project is set up for it, you
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56290215
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,26 @@ test_that("kmeans", {
cluster <- summary.model$cluster
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11486#issuecomment-197191433
About labels, I think we should output the raw labels as predictions
instead of the encoded indices. It is hard to extract the feature metadata in
SparkR.
---
If your
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56289859
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -227,6 +236,25 @@ class NaiveBayesModel private[ml
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56289848
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,26 @@ test_that("kmeans", {
cluster <- summary.model$cluster
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56289853
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,26 @@ test_that("kmeans", {
cluster <- summary.model$cluster
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56289840
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,26 @@ test_that("kmeans", {
cluster <- summary.model$cluster
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56289845
--- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
@@ -141,3 +141,26 @@ test_that("kmeans", {
cluster <- summary.model$cluster
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/10839#issuecomment-197188227
@Fokko The implementation doesn't take care of sparsity yet. I created
https://github.com/apache/spark/pull/11757 to add row/column iterators to local
matrices. After
GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/11757
[SPARK-13927][MLLIB] add row/column iterator to local matrices
## What changes were proposed in this pull request?
Add row/column iterator to local matrices to simplify tasks like
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11694#issuecomment-197159610
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11486#discussion_r56258707
--- Diff: R/pkg/R/generics.R ---
@@ -1168,3 +1168,7 @@ setGeneric("kmeans")
#' @rdname fitted
#' @export
setGener
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-196945850
@avulanov I made one pass on the implementation. Besides inline comments:
* It is good to keep the size checks as safe guards.
* For methods that modify
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208098
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208163
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -164,11 +208,18 @@ class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208120
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208130
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208156
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -141,12 +178,19 @@ class
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208138
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208010
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208068
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208142
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208108
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208078
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208149
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207975
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -654,12 +513,19 @@ private[ann] object FeedForwardModel {
def apply(topology
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208042
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208020
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208087
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -22,7 +22,8 @@ import
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208034
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208014
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208093
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -65,7 +66,42 @@ private[ml] trait
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208058
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56208055
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/LossFunction.scala
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207978
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -774,8 +640,8 @@ private[ml] class FeedForwardTrainer(
val inputSize: Int
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207997
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -783,6 +649,22 @@ private[ml] class FeedForwardTrainer(
private var optimizer
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207992
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -783,6 +649,22 @@ private[ml] class FeedForwardTrainer(
private var optimizer
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207987
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -783,6 +649,22 @@ private[ml] class FeedForwardTrainer(
private var optimizer
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207864
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207952
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -294,89 +248,13 @@ private[ann] object ActivationFunction
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207931
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -150,72 +166,32 @@ private[ann] object AffineLayerModel
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207898
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207940
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -226,44 +236,21 @@ private[ann] trait ActivationFunction extends
Serializable
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207829
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -32,20 +32,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207880
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207844
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -32,20 +32,43 @@ import org.apache.spark.util.random.XORShiftRandom
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207877
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207904
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -96,50 +112,50 @@ private[ann] trait LayerModel extends Serializable
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207925
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -150,72 +166,32 @@ private[ann] object AffineLayerModel
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207888
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r56207892
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -54,39 +77,32 @@ private[ann] trait Layer extends Serializable {
* Can return
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11581#discussion_r56099459
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -273,7 +273,29 @@ private[ml] object DefaultParamsReader
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11707#issuecomment-196584946
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
901 - 1000 of 8762 matches
Mail list logo
