Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@HyukjinKwon Sorry for the delay. I'm busy looking for jobs these days.
I'll try my best to fix it in October. Thank you for reminding me
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@HyukjinKwon It's still active. I'll fix it when I'm available. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14158#discussion_r119022541
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala
---
@@ -65,13 +65,29 @@ abstract class AbstractSqlParser
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14158#discussion_r11899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala
---
@@ -50,13 +50,29 @@ abstract class AbstractSqlParser
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14158#discussion_r118998724
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -326,7 +336,16 @@ private[spark] object UIUtils extends Logging {
val
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
I have just rebased. @ajbozarth @HyukjinKwon @gatorsmile @srowen @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14461
@HyukjinKwon Thanks for reminding. I am finals this week. I will fix this
after 15th.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@HyukjinKwon Thanks for reminding. I am finals this week. I will fix this
after 15th.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14461
@HyukjinKwon Thanks for reminding. I will have a look asap. Too many things
to recently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nblintao closed the pull request at:
https://github.com/apache/spark/pull/14204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14204#discussion_r96568190
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage.js ---
@@ -408,12 +420,17 @@ $(document).ready(function
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14204#discussion_r94474216
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/executorspage.js ---
@@ -408,12 +420,17 @@ $(document).ready(function
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14461
@ajbozarth I finally have a chance to rebase it in the winter break. Could
you please have a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@ajbozarth I finally have a chance to rebase it in the winter break. Could
you please have a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
@ajbozarth I finally have a chance to rebase it in the winter break. Could
you please have a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14158#discussion_r83355296
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
---
@@ -146,11 +158,35 @@ private[ui] abstract class
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@markhamstra Queries longer than 1000 chars are truncated to 1000 chars
after the parsing. "+more" will only expand 140 chars to at most 1000 chars.
---
If your project is set up for i
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@markhamstra Thanks. Here is my related explanation at the top of this PR.
> If the query text is too long (i.e. longer than 1000 chars), it will be
truncated. This is to avoid down
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
Thanks, @ajbozarth. Sure, I'd love to rebase it and get it merged. But I am
really busy with my mid-terms and interviews recently. I'll take a look tonight
and fix it if it's easy to do
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
retest this, please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
Interesting, test again please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
test this, please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
@ajbozarth Great! Glad to see your PR merged. Thanks for providing this
patch, I'll fix it days later.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14461
Oh yes. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14461
retest it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14461
@ajbozarth Thanks for pointing out that. I have removed the link on the
application summary page and reverted related changes.
---
If your project is set up for it, you can reply to this email
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14382
It looks great from the code. I will try it tomorrow or later. Thanks for
fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user nblintao opened a pull request:
https://github.com/apache/spark/pull/14461
[SPARK-16856] [WEBUI] [CORE] Link application summary page and detail page
to the master page
## What changes were proposed in this pull request?
1. Added a "**Back to Master**&
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
@JoshRosen Thanks for pointing out the compatibility issue. I have fixed it
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
@yhuai I tried again today. I think the possible reason is your browser
caches some resources, especially, `/static/executorspage-template.html`.
---
If your project is set up for it, you can
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
Great! Thanks, @andrewor14 @ajbozarth @yhuai @zsxwing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
@yhuai Updated:
> The diff didn't keep track of some lines based on the original ones. The
function `makeRow`of the original `AllJobsPage.scala` is reused. They are
separa
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r72038829
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -210,64 +214,69 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
@yhuai Does the column exist? Are all of the cells in the column blank?
That's weird. It was OK when I committed. I'll check it out later.
---
If your project is set up for it, you can reply
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r71999178
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +375,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r71999045
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -210,64 +214,69 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14319
Doing more study to figure out the requirements on providing per-session
information to users. So, I decided to close the PR for now. The work will be
continued after figuring out how this page
Github user nblintao closed the pull request at:
https://github.com/apache/spark/pull/14319
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14319
Thanks, @ajbozarth.
Yes, I think the configuration alone is not enough for a new tab. @yhuai
and I actually plan to do more on this tab. As mentioned in
[JIRA](https://issues.apache.org/jira
GitHub user nblintao opened a pull request:
https://github.com/apache/spark/pull/14319
[SPARK-16635][WEBUI][SQL] Provide Session support in the Spark UI
## What changes were proposed in this pull request?
Add a Session Tab and the related Session Page in the Spark UI
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14204#discussion_r71830047
--- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
---
@@ -73,13 +73,15 @@ class JsonProtocolSuite extends SparkFunSuite
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
Thanks for your reminding, @ajbozarth. I committed without testing locally
this time because I thought it was a small fix and could pass the test.
Unlucky, it still needs to be updated.
I'll
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
I have fixed the conflicts with #13670.
Some unit tests for JSON protocol needs to be updated, but I cannot get
assess to the page of Jenkins server somehow. I'll fix it as soon as I could
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13670
Hi, @kishorvpatil. Cool improvement! I'm developing the Executors Page at
#14204 based on your changes. But I have a small question about your new
implementation of the tables
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
@ajbozarth Thanks for pointing out how to fix this. I'll try to fix it
tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
Updated by truncating long texts and adding a tooltip.
The detail description and the screenshot at
https://github.com/apache/spark/pull/14158#issue-165127460 is also updated.
---
If your
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
@ajbozarth @felixcheung Thanks for viewing and discussing! I plan to
implement the two updates I mentioned above. The idea of clipboard sounds
awesome, but I think we might need more discussion
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14204
It looks like this if we use the worker URL as the placeholder (instead of
"Worker") in the column Worker. Please note the text (the URL of the worker) is
different from its hre
GitHub user nblintao opened a pull request:
https://github.com/apache/spark/pull/14204
[SPARK-16520] [WEBUI] Link executors to corresponding worker pages
## What changes were proposed in this pull request?
Added a new column named "Worker" in the Executor Page of
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
**In the commit above, I made three adjustments:**
1. If the query has no related query text, show a blank in that field.
1. If there is no query in the table has a query text
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/14158
Thanks, @ajbozarth. That's a great point. When no execution in a table has
SQL text, this column shouldn't be shown. I'll fix this.
---
If your project is set up for it, you can reply
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14158#discussion_r70541399
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
---
@@ -103,6 +104,9 @@ private[ui] abstract class
GitHub user nblintao opened a pull request:
https://github.com/apache/spark/pull/14158
[SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQL Tab
## What changes were proposed in this pull request?
For the web UI, this PR adds the raw SQL query text for each execution
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
I believe this commit has resolved the bugs reported by @ajbozarth. It
looks well on history server pages now, and it could keep the status of other
tables while changing one.
Could you please
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13708
Thanks, @zsxwing . I have fixed them in the commit above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
This PR has known bugs about linking. I have fixed the related bugs in
#13708. In order to avoid conflicts, I will not update this PR until #13708 is
merged.
So, please do NOT review or test
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13708
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13708
@ajbozarth Thanks. That was implemented in the pageNavigation of the
PagedTable by @zsxwing from PR #7399. I didn't change it, and it seems useful
to me. It works like a pagination for the page
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13708
I have fixed some linking bugs in stage tables (including the history
server problem reported by @ajbozarth ). I have also prevented displaying empty
tables in pool pages.
I have tested
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13708
@ajbozarth Could you please try again to see whether or not have my new
commit fixed the problem you mentioned above?
Also, regarding the bug you mentioned in #13620, are the _stage_ tables
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
@ajbozarth Got it, that's a fatal bug. I will fix it in this PR. Thanks
again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13620
@ajbozarth Thanks for your checking and reporting. I didn't notice that the
UI for history servers are different and just changed the AllJobsPage.
I will try to check the page for history
Github user nblintao commented on the issue:
https://github.com/apache/spark/pull/13708
@ajbozarth Thanks for pointing it out. It is true for both the stages page
and the job page. It doesn't keep track of the status of other tables when one
table is changed.
I will try
GitHub user nblintao opened a pull request:
https://github.com/apache/spark/pull/13708
[SPARK-15591] [WEBUI] Paginate Stage Table in Stages tab
## What changes were proposed in this pull request?
This patch adds pagination support for the Stage Tables in the Stage tab
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r67087787
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r67087737
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r66896475
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r66896310
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r66895790
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
Github user nblintao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13620#discussion_r66894846
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -369,3 +361,246 @@ private[ui] class AllJobsPage(parent: JobsTab)
extends
GitHub user nblintao opened a pull request:
https://github.com/apache/spark/pull/13620
[SPARK-15590] [WEBUI] Paginate Job Table in Jobs tab
## What changes were proposed in this pull request?
This patch adds pagination support for the Job Tables in the Jobs tab.
Pagination
73 matches
Mail list logo
