Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17487
perfect! Can it be merged then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17487
FYI I can squash these commits to clean up the history once we agree on how
best to approach the testing
---
If your project is set up for it, you can reply to this email and have your
reply
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17487
Maybe @gatorsmile or @srowen have an idea. How can I test the case
insensitive unresolvedTableValuedFunction without using a var for the
functionName. I'm open to all ideas folks! introducing
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17487#discussion_r109307800
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -105,7 +105,7 @@ object
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17487
Ok I was planning on doing that but unfortunately all the tests don't go
through the resolveTableValuedFuntion but new up an UnTableValued. I totally
agree with you with regards to state. What we
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17487#discussion_r109307649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -105,7 +105,7 @@ object
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17487
based on comments from @hvanhovell I am depending on the case sensitivity
setting of the analyser. That said I had to make the functionName a var to
change the value to lower case which feels
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17487#discussion_r109286453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -105,7 +105,7 @@ object
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17487#discussion_r109123577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -105,7 +105,7 @@ object
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17487
I'm not sure to be honest. But even if it is, the inbuilt functions has a
key of "range"
So anything else won't be found which is causing the problem in the first
GitHub user samelamin opened a pull request:
https://github.com/apache/spark/pull/17487
[Spark-20145] Make range case insensitive
## What changes were proposed in this pull request?
Range in SQL should be case insensitive
## How was this patch tested?
unit
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
@gatorsmile @srowen how does it look now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108884506
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108881923
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108879329
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
Can someone guide me why the tests failed? is it another flakey test or?
because the below message doesnt make sense to me :(
> Traceback (most recent call last):
> File &quo
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108849902
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,18 +46,22 @@
private static final boolean unaligned
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
@gatorsmile moved the comment per your suggestion, but to be honest if the
comment is unclear surly the first thing someone will do is check that JIRA?
---
If your project is set up for it, you
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
ok @gatorsmile i set default indentation to 2, how does it look now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
@gatorsmile I think my Intellij has some annoying auto indenting changes.
Does spark have some project wide settings I can auto import?
---
If your project is set up for it, you can reply
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108789142
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -45,21 +45,27 @@
private static final boolean unaligned
Github user samelamin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17472#discussion_r108783754
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -46,16 +46,22 @@
private static final boolean unaligned
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/17472
@kiszk @srowen updated per your commets
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user samelamin opened a pull request:
https://github.com/apache/spark/pull/17472
[SPARK-1]: Fix for flakey tests due to java.nio.Bits.unaligned() â¦
â¦doesn't return true on ppc
## What changes were proposed in this pull request?
check architecture
Github user samelamin commented on the issue:
https://github.com/apache/spark/pull/14527
@cloud-fan by adding a new API do you mean move the logic into a new
method in the Dataset class?
---
If your project is set up for it, you can reply to this email and have your
reply appear
26 matches
Mail list logo
