[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-04-21 Thread tanwanirahul
Github user tanwanirahul closed the pull request at: https://github.com/apache/spark/pull/11219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-04-21 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11219#issuecomment-213249792 @jkbradley Make sense. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13309][SQL] Fix type inference issue wi...

2016-02-28 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11194#issuecomment-190074779 @rxin @HyukjinKwon thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13309][SQL] Fix type inference issue wi...

2016-02-25 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11194#issuecomment-188818395 Could we please merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13452][MLLIB] RegressionMetrics to supp...

2016-02-25 Thread tanwanirahul
Github user tanwanirahul closed the pull request at: https://github.com/apache/spark/pull/11322 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13452][MLLIB] RegressionMetrics to supp...

2016-02-25 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11322#issuecomment-188789973 @srowen Sure. thanks!. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13452][MLLIB] RegressionMetrics to supp...

2016-02-24 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11322#issuecomment-188179104 @srowen true. I have coded the same logic several times mostly for kaggle problems. Since it is supported in R, I felt a need for it in spark as well. However if

[GitHub] spark pull request: [MINOR][MAINTENANCE] Fix typo for the pull req...

2016-02-24 Thread tanwanirahul
GitHub user tanwanirahul opened a pull request: https://github.com/apache/spark/pull/11343 [MINOR][MAINTENANCE] Fix typo for the pull request template. ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was

[GitHub] spark pull request: [SPARK-13452][MLLIB] RegressionMetrics to supp...

2016-02-24 Thread tanwanirahul
Github user tanwanirahul commented on a diff in the pull request: https://github.com/apache/spark/pull/11322#discussion_r53905064 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala --- @@ -109,6 +111,14 @@ class RegressionMetrics @Since

[GitHub] spark pull request: [SPARK-13452][MLLIB] RegressionMetrics to supp...

2016-02-23 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11322#issuecomment-187725208 @srowen @mengxr Could you please review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-13452][MLLIB] RegressionMetrics to supp...

2016-02-23 Thread tanwanirahul
GitHub user tanwanirahul opened a pull request: https://github.com/apache/spark/pull/11322 [SPARK-13452][MLLIB] RegressionMetrics to support RootMeanSquareLogar… ## What changes were proposed in this pull request? [SPARK-13452][MLLIB] RegressionMetrics to support

[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-02-18 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11219#issuecomment-185604502 @mengxr - I see you have added this code. Could you please check if this change would be good to have. If not, I will happily close. --- If your project is set

[GitHub] spark pull request: [SPARK-13309][SQL] Fix type inference issue wi...

2016-02-18 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11194#issuecomment-185603039 @HyukjinKwon @rxin Is this waiting on me? Just want to confirm it I am expected to add anything more. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-02-16 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11219#issuecomment-184815144 @JoshRosen Sure. If someone confirms on this, I will add that. On if we need it: The pipeline apis work on the dataframes. If we don't have this inte

[GitHub] spark pull request: [MINOR][MLLIB] Public visibility for eval metr...

2016-02-16 Thread tanwanirahul
GitHub user tanwanirahul opened a pull request: https://github.com/apache/spark/pull/11219 [MINOR][MLLIB] Public visibility for eval metric's dataframe constructor You can merge this pull request into a Git repository by running: $ git pull https://github.com/tanwani

[GitHub] spark pull request: [SPARK-13309][SQL] Fix type inference issue wi...

2016-02-14 Thread tanwanirahul
Github user tanwanirahul commented on the pull request: https://github.com/apache/spark/pull/11194#issuecomment-183905612 Yes, could be done. I personally prefer to keep code and data separate. This way: - Changing the data does not require us to compile the code

[GitHub] spark pull request: [SPARK-13309][SQL] Fix type inference issue wi...

2016-02-13 Thread tanwanirahul
GitHub user tanwanirahul opened a pull request: https://github.com/apache/spark/pull/11194 [SPARK-13309][SQL] Fix type inference issue with CSV data You can merge this pull request into a Git repository by running: $ git pull https://github.com/tanwanirahul/spark master