Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22952
> @zsxwing Btw, how do you think about addressing background move/deletion
(I had thought and
Yeah, this can be done in a separate ticket.
I was play
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237319928
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -257,16 +289,65 @@ class FileStreamSource
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237314690
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -530,6 +530,12 @@ Here are the details of all the sources in Spark.
&qu
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237319903
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -257,16 +289,65 @@ class FileStreamSource
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237319176
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -257,16 +289,65 @@ class FileStreamSource
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237200636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamOptions.scala
---
@@ -74,6 +76,39 @@ class FileStreamOptions
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237315173
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -100,6 +101,36 @@ class FileStreamSource
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237315718
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -257,16 +289,65 @@ class FileStreamSource
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237320515
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -100,6 +101,36 @@ class FileStreamSource
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22952#discussion_r237314459
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -530,6 +530,12 @@ Here are the details of all the sources in Spark.
&qu
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23109
cc @squito
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/23109
[SPARK-26069][TESTS][FOLLOWUP]Add another possible error message
## What changes were proposed in this pull request?
`org.apache.spark.network.RpcIntegrationSuite.sendRpcWithStreamFailures
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23089
cc @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/23089
[SPARK-26120][TESTS][SS][SPARKR]Fix a streaming query leak in Structured
Streaming R tests
## What changes were proposed in this pull request?
Stop the streaming query in `Specify
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23060
Thanks! Merging to master and 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23034
LGTM. By the way, @HyukjinKwon I totally understand that this PR needs to
merge soon to avoid getting conflicts. But could you please at least get
someone to review and sign off before merging next
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/23060
[SPARK-26092][SS]Use CheckpointFileManager to write the streaming metadata
file
## What changes were proposed in this pull request?
Use CheckpointFileManager to write the streaming
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23041
Thanks. Merging to master and 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23041
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/23041#discussion_r233734198
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -371,23 +371,29 @@ private void assertErrorsContain
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23041
cc @squito
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/23041
[SPARK-26069][TESTS]Fix flaky test:
RpcIntegrationSuite.sendRpcWithStreamFailures
## What changes were proposed in this pull request?
The test failure is because `assertErrorAndClosed
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23023
Thanks! Merging to master and 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/23023
cc @jose-torres
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/23023
[SPARK-26042][SS][TESTS]Fix a potential hang in
KafkaContinuousSourceTopicDeletionSuite
## What changes were proposed in this pull request?
As initializing lazy vals shares the same lock
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22952
> Provide additional option: delete (two options - 'rename' / 'delete' -
are mutually exclusive)
>
> Actually the actions end users are expected to take are 1. moving to
archive
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22923
We need to always update user accumulators. Right now such task metrics
just cause some annoying error logs, seems not worth to fix
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22910
[SPARK-25899][TESTS]Fix flaky CoarseGrainedSchedulerBackendSuite
## What changes were proposed in this pull request?
I saw CoarseGrainedSchedulerBackendSuite failed in my PR and finally
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
Thanks! Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
@markhamstra any further comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22771#discussion_r228409787
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1364,6 +1385,21 @@ private[spark] class DAGScheduler
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22771#discussion_r228355772
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1364,6 +1385,21 @@ private[spark] class DAGScheduler
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22816
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22816#discussion_r228262084
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -114,7 +114,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22816
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22816
[SPARK-25822][PySpark]Fix a race condition when releasing a Python worker
## What changes were proposed in this pull request?
There is a race condition when releasing a Python worker
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
I agreed that the task reaper is a big change to the story and we should
reconsider SPARK-17064. Could we move the discussion to SPARK-17064?
By the way, regarding this PR itself
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
@tgravescs Yeah, looks like that
https://issues.apache.org/jira/browse/SPARK-24622 is better but it may take
more time than this one, since this PR is smaller and less risky
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22771#discussion_r227060028
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -672,6 +674,55 @@ class SparkContextSuite extends SparkFunSuite
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22770#discussion_r227056168
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -31,15 +32,15 @@ import
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22770
Thanks for reviewing this. Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22771
cc @squito @tgravescs @jiangxb1987 @kayousterhout
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22771
[SPARK-25773][Core]Cancel zombie tasks in a result stage when the job
finishes
## What changes were proposed in this pull request?
When a job finishes, there may be some zombie tasks
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22770#discussion_r226459546
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -278,7 +289,7 @@ private[spark] class PythonWorkerFactory
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22770#discussion_r226459609
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -163,7 +172,9 @@ private[spark] class PythonWorkerFactory
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22770
[SPARK-25771][PYSPARK]Fix improper synchronization in PythonWorkerFactory
## What changes were proposed in this pull request?
Fix the following issues in PythonWorkerFactory
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22692
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22173#discussion_r223513440
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
---
@@ -77,17 +82,54 @@
private static final
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22628
Is it supposed to the flaky ChunkFetchIntegrationSuite?
http://spark-tests.appspot.com/test-details?suite_name=org.apache.spark.network.ChunkFetchIntegrationSuite_name=fetchFileChunk
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22627
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r223490770
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,214 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r223490811
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,214 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r223491087
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,214 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r223491101
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,214 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r223481016
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22649
> and this only becomes ambiguous in 2.12 (long story).
Yeah, I'm curious why it didn't fail in 2.12 before. I know there are
several Scala features not working with overload. This
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22649
Thanks for fixing this. I'm just curious why it didn't fail before my
change from `Long` to `java.lang.Long
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22647
LGTM pending tests
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22633
Thanks. Merging to master and 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22633
Looks like `lint-java` doesn't catch any style issues in my PR
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222813906
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815111
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815845
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222812874
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815770
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222812936
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815072
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222818441
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -2709,6 +2935,78 @@ write.stream(aggDF, "memory", outputMode =
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222817163
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222814573
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222812757
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222818615
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -2709,6 +2935,78 @@ write.stream(aggDF, "memory", outputMode =
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222818119
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -2709,6 +2935,78 @@ write.stream(aggDF, "memory", outputMode =
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815808
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815830
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22627#discussion_r222815089
--- Diff: docs/structured-streaming-programming-guide.md ---
@@ -1989,22 +2026,211 @@ head(sql("select * from aggre
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22633
[SPARK-25644][SS]Fix java foreachBatch in DataStreamWriter
## What changes were proposed in this pull request?
The java `foreachBatch` API in `DataStreamWriter` should accept
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22633
cc @tdas
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22586#discussion_r221438766
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -1880,6 +1880,26 @@ class DAGSchedulerSuite extends SparkFunSuite
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22473
Thanks! Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22586
[SPARK-25568][Core]Continue to update the remaining accumulators when
failing to update one accumulator
## What changes were proposed in this pull request?
Since we don't fail a job when
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22473
LGTM pending tests
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22473
Looks like `org.apache.spark.deploy.history.HistoryServerSuite.executor
list with executor metrics json` and
`org.apache.spark.util.JsonProtocolSuite.SparkListenerEvent` are broken by the
changes
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r221313411
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -609,13 +609,13 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r221022783
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -609,13 +609,13 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r221022651
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -609,13 +609,13 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22553#discussion_r220718383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala
---
@@ -42,7 +42,11 @@ class CaseInsensitiveMap[T
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22507
Thanks! Merging to master and 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22507#discussion_r220286600
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
---
@@ -874,6 +874,57 @@ abstract class
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/22429
@MaxGekk Make sense. Could you also try to remove the default value?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r219977185
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -196,7 +196,7 @@ case class RDDScanExec
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22429#discussion_r219969937
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -250,5 +265,22 @@ class QueryExecution(val sparkSession
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219940593
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -83,6 +83,17 @@ package object config {
private[spark] val
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219576996
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -83,6 +83,17 @@ package object config {
private[spark] val
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219575442
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -799,15 +799,21 @@ private[spark] class Executor
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219574228
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -160,7 +160,7 @@ private[spark] class Executor(
* times, it should
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219577386
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -252,18 +253,121 @@ class ExecutorSuite extends SparkFunSuite
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219575944
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -799,15 +799,21 @@ private[spark] class Executor
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r219576946
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -83,6 +83,17 @@ package object config {
private[spark] val
1 - 100 of 6049 matches
Mail list logo
