HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558913168
Thanks all for reviewing and merging!
This is an automated message from the Apac
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558846113
Just updated the description.
This is an automated message from the Apache Git S
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558843138
Looks like we are mixing up two different problems.
Let me define the problem properly; the root issue of SPARK-2 was due to
"empty pa
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558825886
@gengliangwang I added the reason to move the UT. If you meant others, would
you mind if I ask to be more specific in review comments?
-
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558673046
> now we at least write one file for each partition?
Yes, that has been the assumption of ManifestFileCommitProtocol, as it
provides the p
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558512558
retest this, please
This is an automated message from the Apache Git Service.
To
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558490228
@gengliangwang Thanks for understanding and bearing with me. :)
This is an autom
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558478147
Ah yes you're right that it cannot be reverted cleanly - so there's
physically no clean revert.
Maybe I overthought here; I thought about
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558455533
For now I restored the UT and move the UT to the place where it will be
checked with both DSv1 and DSv2, and modified the description of PR. I le
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558452333
Sorry I'm not clear on understanding the suggestion.
Looks like you don't suggest to "do clean revert on both issues", but
suggest to "do
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558425298
I skipped copying full title on each PR as we're reverting two issues which
would make very long title.
HeartSaVioR commented on issue #26671: Revert "[SPARK-26081][SPARK-2]"
URL: https://github.com/apache/spark/pull/26671#issuecomment-558424184
cc. @dongjoon-hyun @gatorsmile @gengliangwang @zsxwing - this is the PR to
revert both commits. Once this is merged I'll raise a separate PR for
12 matches
Mail list logo
