[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427127270 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala ## @@ -161,6 +161,10 @@ object

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427125934 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3071,15 +3071,28 @@ class Analyzer(

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427121973 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala ## @@ -161,6 +161,10 @@ object

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon commented on a change in pull request #28572: URL: https://github.com/apache/spark/pull/28572#discussion_r427107644 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -3071,15 +3071,31 @@ class Analyzer(