[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-11-07 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-551362077 See https://github.com/apache/spark/pull/26432

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-11-07 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-551350586 Let me create a PR. This is an

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-11-07 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-551348479 Oh, I was confused: ``` TypeError: not supported type: ``` It's not supported yet

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-11-07 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-551345447 Hm, actually if such changes happen, 3.0 might be right place to happen. WDYT @BryanCutler? It actually

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-10-23 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-545746713 This patch is a bit hard to say a bug fix (as pointed out at

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-10-16 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-542892074 Given the discussion above, seems we're not going to back port.

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-09-12 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-530691141 I don't think so. Yes so It might be better do document that. We can start to work on that after

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-09-11 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-530608802 Merged to master. This is an automated

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-09-11 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-530608742 Let me get this in. We should allow `bytes` anyway - looks Arrow converts into `bytes` too :D. Let me

[GitHub] [spark] HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type

2019-09-11 Thread GitBox
HyukjinKwon commented on issue #25749: [SPARK-29041][PYTHON] Allows createDataFrame to accept bytes as binary type URL: https://github.com/apache/spark/pull/25749#issuecomment-530607102 Yea. I agree with that bytes <> str was by design so I targeted only when explicitly the type is