[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-09 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133 The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-09 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-671155276 @srowen agree with u, we can make a 'checkpoint' if [4018b1f](https://github.com/apache/spark/pull/29370/commits/4018b1fb47e72f790609d4d2993e0ba90639fcc8) no problem,

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-07 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133 The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-670359133 The main change of Address [beb3928](https://github.com/apache/spark/pull/29370/commits/beb3928397a81b2dd65d885b4e40e6e3c65376a3) is call `toMap` method of `Metadata#

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-06 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669764681 details of remaining failed cases already updated to the [attachment](https://issues.apache.org/jira/secure/attachment/13009170/failed-and-aborted-20200806) and added

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503 I will update failure list to JIRA after this pr later This is an automated message from the Apache

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669716503 I will update failure list to JIRA later after this pr This is an automated message from the Apache G

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401 cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module, do we accept partial fixed and fix the remaining cases in other pr

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669714401 cc @srowen from the numbers alone, this pr fixed about 70% failed cases of `sql/catalyst` module, do we accept partial fixed? -

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240 > Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite b

[GitHub] [spark] LuciferYang edited a comment on pull request #29370: [SPARK-32526][SQL]Pass DataSourceV2AnalysisBaseSuite and TreeNodeSuite related test cases in scala 2.13

2020-08-05 Thread GitBox
LuciferYang edited a comment on pull request #29370: URL: https://github.com/apache/spark/pull/29370#issuecomment-669710240 > Thanks. You don't need to fix everything in one shot. Please group the failures and fix the one you think this is related to many others. You can proceed by suite b