[GitHub] [spark] MaxGekk commented on a diff in pull request #39239: [SPARK-41730][PYTHON] Set tz to UTC while converting of timestamps to python's datetime

2023-03-15 Thread via GitHub
MaxGekk commented on code in PR #39239: URL: https://github.com/apache/spark/pull/39239#discussion_r1137571293 ## python/pyspark/sql/types.py: ## @@ -276,7 +276,18 @@ def toInternal(self, dt: datetime.datetime) -> int: def fromInternal(self, ts: int) -> datetime.datetime:

[GitHub] [spark] MaxGekk commented on a diff in pull request #39239: [SPARK-41730][PYTHON] Set tz to UTC while converting of timestamps to python's datetime

2022-12-28 Thread GitBox
MaxGekk commented on code in PR #39239: URL: https://github.com/apache/spark/pull/39239#discussion_r1058794838 ## python/pyspark/pandas/tests/test_resample.py: ## @@ -263,7 +263,7 @@ def test_dataframe_resample(self): def test_series_resample(self):

[GitHub] [spark] MaxGekk commented on a diff in pull request #39239: [SPARK-41730][PYTHON] Set tz to UTC while converting of timestamps to python's datetime

2022-12-28 Thread GitBox
MaxGekk commented on code in PR #39239: URL: https://github.com/apache/spark/pull/39239#discussion_r1058520899 ## python/pyspark/sql/types.py: ## @@ -276,7 +276,15 @@ def toInternal(self, dt: datetime.datetime) -> int: def fromInternal(self, ts: int) -> datetime.datetime:

[GitHub] [spark] MaxGekk commented on a diff in pull request #39239: [SPARK-41730][PYTHON] Set tz to UTC while converting of timestamps to python's datetime

2022-12-28 Thread GitBox
MaxGekk commented on code in PR #39239: URL: https://github.com/apache/spark/pull/39239#discussion_r1058433158 ## python/pyspark/sql/types.py: ## @@ -276,7 +276,15 @@ def toInternal(self, dt: datetime.datetime) -> int: def fromInternal(self, ts: int) -> datetime.datetime:

[GitHub] [spark] MaxGekk commented on a diff in pull request #39239: [SPARK-41730][PYTHON] Set tz to UTC while converting of timestamps to python's datetime

2022-12-28 Thread GitBox
MaxGekk commented on code in PR #39239: URL: https://github.com/apache/spark/pull/39239#discussion_r1058176658 ## python/pyspark/sql/types.py: ## @@ -276,7 +276,15 @@ def toInternal(self, dt: datetime.datetime) -> int: def fromInternal(self, ts: int) -> datetime.datetime: