[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480847421 ## File path: core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala ## @@ -113,6 +113,21 @@ class NettyBlockRpcServer(

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480847229 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -212,7 +211,7 @@ private[spark] class BlockManager( private val

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480178710 ## File path: core/src/test/scala/org/apache/spark/shuffle/HostLocalShuffleFetchSuite.scala ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480177199 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1415,10 +1415,11 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480173840 ## File path: core/src/test/scala/org/apache/spark/shuffle/HostLocalShuffleFetchSuite.scala ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480157384 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1415,10 +1415,11 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480095723 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -61,4 +78,56 @@ public MetricSet

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480095860 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -18,15 +18,32 @@ package

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480095206 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -61,4 +78,56 @@ public MetricSet

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480094857 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -120,34 +120,33 @@ private[spark] class ByteBufferBlockData(

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480090760 ## File path: core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala ## @@ -113,6 +113,15 @@ class NettyBlockRpcServer(

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480089706 ## File path: core/src/test/scala/org/apache/spark/shuffle/HostLocalShuffleFetchSuite.scala ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r480086501 ## File path: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala ## @@ -66,16 +66,24 @@ class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r478179838 ## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ## @@ -463,54 +466,73 @@ final class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r478175273 ## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ## @@ -466,42 +464,51 @@ final class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459902032 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -61,4 +78,62 @@ public MetricSet

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459897266 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -492,20 +494,26 @@ private[spark] class BlockManager(

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459897035 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1415,10 +1415,16 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r459264839 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1415,10 +1415,16 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r458103470 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1391,10 +1391,12 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r458097873 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1391,10 +1391,12 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r457896569 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1391,10 +1391,12 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r457876717 ## File path: core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala ## @@ -194,6 +196,45 @@ private[spark] class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r457876162 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java ## @@ -61,4 +63,17 @@ public MetricSet

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r452705081 ## File path: core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala ## @@ -194,6 +196,45 @@ private[spark] class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r452704155 ## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ## @@ -478,30 +475,43 @@ final class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r452703876 ## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ## @@ -478,30 +475,43 @@ final class

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r448971785 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1391,10 +1391,11 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r448971785 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1391,10 +1391,11 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r447554793 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1391,10 +1391,11 @@ package object config { private[spark]

[GitHub] [spark] Ngone51 commented on a change in pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

Ngone51 commented on a change in pull request #28911: URL: https://github.com/apache/spark/pull/28911#discussion_r447553884 ## File path: core/src/test/scala/org/apache/spark/shuffle/HostLocalShuffleFetchSuite.scala ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software