[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-14 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1070469083 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java: ## @@ -17,6 +17,7 @@ package

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1070184068 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java: ## @@ -230,6 +245,71 @@ public void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1070170721 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java: ## @@ -230,6 +245,71 @@ public void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1070170721 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java: ## @@ -230,6 +245,71 @@ public void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1070072578 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java: ## @@ -230,6 +243,50 @@ public void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1070072578 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java: ## @@ -230,6 +243,50 @@ public void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1069860734 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java: ## @@ -84,6 +87,12 @@ void createAndStart(String[] blockIds,

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-13 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1069084937 ## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java: ## @@ -192,8 +197,12 @@ private synchronized void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-12 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1067824025 ## common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java: ## @@ -245,8 +269,9 @@ private static void

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-11 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1067498072 ## core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockPusher.scala: ## @@ -251,6 +251,10 @@ private[spark] class ShuffleBlockPusher(conf: SparkConf) extends

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-06 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1063830324 ## common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java: ## @@ -287,6 +288,9 @@ public void onFailure(Throwable e) { try

[GitHub] [spark] akpatnam25 commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries

2023-01-06 Thread GitBox
akpatnam25 commented on code in PR #38959: URL: https://github.com/apache/spark/pull/38959#discussion_r1063830324 ## common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java: ## @@ -287,6 +288,9 @@ public void onFailure(Throwable e) { try